Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89621 --- I just want to say thanks for keeping at this - I feel kinda

Re: Review Request 126185: Make the KAppTemplate CMake module global

On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote: > > You might want to generate the documentation and look at it (you need the > > Sphinx documentation tool installed, then you just build > > extra-cmake-modules, and look in docs/html in the build directory). In particular, you'll need to add

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89618 --- kde-modules/KDEPackageAppTemplates.cmake (line 10)

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 16, 2015, 5:40 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 710 > > > > > > Why is it reasonable if the platform guidelines speak against it? > > René J.V. Bertin wrote: >

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 16, 2015, 10:24 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 16, 2015, 5:40 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 710 > > > > > > Why is it reasonable if the platform guidelines speak against it? The platform guidelines apply to

Re: Review Request 126330: use generate_export_header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/ --- (Updated Dec. 16, 2015, 11:35 p.m.) Status -- This change has been

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

šumski wrote: >> Fixed, it was an oversight when converting the lib into a KF5 framework. > > But this is a BiC change... Yes, bug fixes can do that ;) R ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: about ki18n/locales: installing only a subset?

On Wednesday December 16 2015 14:18:33 Jaroslaw Staniek wrote: > How about bundling the files in qrc containers, one per language to address > the issue of many tiny files? Agreed (and a priori already raised in a previous message). > That reminds me similar case of icon files. Indeed. And the

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 16, 2015, 12:25 p.m.) Review request for Build System, KDE

Review Request 126384: better description of qmlmodule cmake module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126384/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Review Request 126385: PartManager: stop tracking a widget even if it is no longer a top level window

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126385/ --- Review request for KDE Frameworks. Bugs: 355711

Re: about ki18n/locales: installing only a subset?

On Wednesday December 16 2015 11:48:58 David Faure wrote: > They are copied into the frameworks at release time. So you can also grab > them from > svn://anonsvn.kde.org/home/kde/trunk/l10n-kf5 directly (warning, this is huge) Ah, good! Svn is a bit of a hog indeed, but IIRC it does make it

Re: about ki18n/locales: installing only a subset?

On Wednesday 16 of December 2015 14:44:54 René J.V. Bertin wrote: > On Wednesday December 16 2015 14:18:33 Jaroslaw Staniek wrote: > > How about bundling the files in qrc containers, one per language to > > address > > the issue of many tiny files? > > Agreed (and a priori already raised in a

Re: Review Request 126384: better description of qmlmodule cmake module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126384/ --- (Updated Dec. 16, 2015, 2:42 p.m.) Status -- This change has been

Re: Review Request 126384: better description of qmlmodule cmake module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126384/#review89600 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2015,

Draft split for qpt plugin from frameworkintegration

Hi all, following up on [1] I have prepared a split of frameworkintegration to move the QPT plugin into a dedicated repository. You can find it in [2]. Please have a look at the split repo to verify that it looks fine. If everything is OK, I'll request a new repo from sysadmins. Some general

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89603 --- Looks fine to me, but I'll let Martin decide, since he

Re: about ki18n/locales: installing only a subset?

> [: René J.V. Bertin :] > It seems that with KF5 we have gotten back in the situation where you get > every possible language installed. Now that may be nice for the occasional > office prank [...] something that has absolutely no use for the vast > majority of users. It has a use in every

Re: about ki18n/locales: installing only a subset?

On Wednesday 16 December 2015 11:20:38 René J.V. Bertin wrote: > On Wednesday December 16 2015 09:03:53 David Faure wrote: > > > Yep, remove them if you don't want them, but then your users are going to > > complain, unless you provide them separately. > > I think I implied in my original

Re: Review Request 126330: use generate_export_header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/#review89606 --- Ship it! Ship It! - Martin Klapetek On Dec. 16, 2015,

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89608 --- Can you please add a screenshot of how such menu looks like

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Wednesday 16 of December 2015 09:08:03 David Faure wrote: > Fixed, it was an oversight when converting the lib into a KF5 framework. But this is a BiC change... Cheers, Hrvoje ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126325/ --- (Updated Dec. 16, 2015, 8:27 a.m.) Status -- This change has been

Re: about ki18n/locales: installing only a subset?

On Tuesday 15 December 2015 11:19:29 René J.V. Bertin wrote: > Hi, > > The KDE4 approach to internationalisation (sic :)) had the huge advantage > that it was rather trivial to provide installer packages for individual > languages so users could install only those few languages they would

Re: Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126325/#review89583 --- Ship it! Ship It! - David Faure On Dec. 13, 2015, 10:38

Re: Review Request 126330: use Qt defines for portability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/#review89581 --- I vote for generate_export_header. - David Faure On Dec.

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

Fixed, it was an oversight when converting the lib into a KF5 framework. > On Tuesday December 15 2015 18:55:52 René J.V. Bertin wrote: > > for packaging purposes it would be preferable if all libraries (symlinks) > > that are recorded in dependents' dependency lists are of the form > >

Re: Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126326/#review89582 --- Ship it! Ship It! - David Faure On Dec. 12, 2015, 10:58

Re: Review Request 126330: use Qt defines for portability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/ --- (Updated Dez. 16, 2015, 8:17 vorm.) Review request for KDE Frameworks.

Re: Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/ --- (Updated Dec. 16, 2015, 8:06 a.m.) Status -- This change has been

Re: Review Request 126330: use generate_export_header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/ --- (Updated Dez. 16, 2015, 8:18 vorm.) Review request for KDE Frameworks.

Re: Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126326/ --- (Updated Dec. 16, 2015, 8:21 a.m.) Status -- This change has been

Re: about ki18n/locales: installing only a subset?

On Wednesday December 16 2015 09:03:53 David Faure wrote: > Yep, remove them if you don't want them, but then your users are going to > complain, unless you provide them separately. I think I implied in my original message that I consider providing them separately the ideal solution ;) Sadly

Re: about ki18n/locales: installing only a subset?

On Wed, Dec 16, 2015 at 11:20:38AM +0100, René J.V. Bertin wrote: > On Wednesday December 16 2015 09:03:53 David Faure wrote: > > > Yep, remove them if you don't want them, but then your users are going to > > complain, unless you provide them separately. > > I think I implied in my original

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Wednesday December 16 2015 09:08:03 David Faure wrote: > Fixed, it was an oversight when converting the lib into a KF5 framework. Hah, you're welcome O:-) I had already taken the liberty to apply it myself (setting SOVERSION to 5); good to know it'll be part of the next release. >