Re: about ki18n/locales: installing only a subset?

> [: René J.V. Bertin :] > [...] AFAIK it's always been a habit among distributions to package > languages separately. Which distributions? Not the ones I use, Debian and Suse. I know only of Ubuntu doing it. >> [: Chusslove Illich :] >> Furthermore, if one thinks of stripping the translation

Re: Draft split for qpt plugin from frameworkintegration

On Thursday, December 17, 2015 5:48:47 PM CET Martin Graesslin wrote: > On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > > On Wed, Dec 16, 2015 at 4:12 PM, Martin Graesslin > > wrote: > > > Hi all, > > > > > > following up on [1] I have prepared a split of

Re: about ki18n/locales: installing only a subset?

>> [: Chusslove Illich :] >> It has a use in every situation where multiple-language users work in a >> centrally administered network. Like in... an office. > > [: René J.V. Bertin :] > How many offices do you know that require all known languages to be > installed? The only organisations I can

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89700 --- src/lib/io/kdirwatch.cpp (line 1067)

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89697 --- +1 Looks good to me. Just checked and tests still pass. -

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > I still want to see other OSX devs comment on that this is really the > > wanted approach. Also I need to point out that the split out of QPT to > > plasma-integration is prepared. I suggest to introduce a comparable > > osx-integration

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I recall a relatively recent discussion on a

Re: about ki18n/locales: installing only a subset?

On Friday December 18 2015 10:53:35 Chusslove Illich wrote: >I'm not talking about offices requiring it. I'm talking about coming to a >random office in the world and finding my language already available, >without trifling anyone about it. Out of curiosity: do you expect to use your language

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I recall a relatively recent discussion on a

Review Request 126417: don't rely on char* to QString implicit conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 126417: don't rely on char* to QString implicit conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/#review89717 --- Ship it! Ship It! - Martin Gräßlin On Dec. 18, 2015, 3:20

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Дек. 18, 2015, 12:25 п.п., Emmanuel Pescosta wrote: > > src/lib/io/kdirwatch.cpp, line 1067 > > > > > > This is wrong (if I'm not wrong ;) > > > > De Morgan's law [1] says that A or B <=> not

Re: Review Request 126327: sonnet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126327/ --- (Updated Dec. 18, 2015, 1:32 p.m.) Status -- This change has been

Re: Review Request 126417: don't rely on char* to QString implicit conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/#review89713 --- i'm wondering whether those are still needed - Kai Uwe

Re: Review Request 126416: MetaFunction doesn't need to be exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126416/#review89711 --- Maybe it would be best to move the implementation to a .cpp

Re: Review Request 126417: don't rely on char* to QString implicit conversion

> On Dec. 18, 2015, 3:35 p.m., Kai Uwe Broulik wrote: > > i'm wondering whether those are still needed Well, it's still being called. +1 on the patch, it can be further fixed later. - Aleix --- This is an automatically generated

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 18, 2015, 5:53 p.m.) Review request for KDE Software on

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- (Updated Дек. 18, 2015, 4:57 п.п.) Review request for KDE Frameworks and

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89719 --- src/lib/io/kdirwatch_p.h (line 109)

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/#review89720 --- Looks good to me. - Martin Gräßlin On Dec. 18, 2015, 7:30

Review Request 126418: Add KWin/Decoration support to plasmapkg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/ --- Review request for KDE Frameworks and Plasma. Summary (updated)

Re: Review Request 126417: don't rely on char* to QString implicit conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/ --- (Updated Dec. 18, 2015, 11:29 p.m.) Status -- This change has been

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:27 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, lines 279-281 > > > > > > This has a strange indentation > > > > Also I think those bools are not entirely useful,

Review Request 126416: MetaFunction doesn't need to be exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126416/ --- Review request for KDE Frameworks. Repository: kross Description

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I recall a relatively recent discussion on a

Re: Review Request 126410: Fix FILE* leak in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126410/#review89723 --- Ship it! Ship It! - Martin Klapetek On Dec. 18, 2015,

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89725 --- src/kstatusnotifieritem.cpp (lines 279 - 281)

Re: Review Request 126410: Fix FILE* leak in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126410/ --- (Updated Dec. 18, 2015, 10:50 p.m.) Status -- This change has been

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89724 --- > is it to be expected (in kstatusnotifieritemtest.cpp) that