Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review93052 --- It's weird, I have a faint memory of this working during the

Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/ --- Review request for KDE Frameworks and Wolfgang Bauer. Bugs: 336016

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated März 2, 2016, 12:48 vorm.) Review request for KDE Frameworks

Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- Review request for KDE Frameworks and Vishesh Handa. Bugs: 345750

Re: Review Request 127205: Add stubs to allow compilation on Android.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review93050 --- Ship it! Nothing should change when we're not on Android.

Re: Review Request 127205: Add stubs to allow compilation on Android.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- (Updated März 1, 2016, 9:38 nachm.) Review request for KDE Frameworks,

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

> On March 1, 2016, 4:37 p.m., Aleix Pol Gonzalez wrote: > > Eh... I just realized it's not 100% correct. We have a test > > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday. > > > > The problem with this one is that we are not reacting when icons are > > introduced

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

> On March 1, 2016, 4:37 p.m., Aleix Pol Gonzalez wrote: > > Eh... I just realized it's not 100% correct. We have a test > > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday. > > > > The problem with this one is that we are not reacting when icons are > > introduced

Re: Review Request 127237: Fix crash in kmore tools when DBus is missing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/#review93034 --- Hi Kåre, thanks for fix. Two things: 1) What do you think

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

> On March 1, 2016, 5:37 p.m., Aleix Pol Gonzalez wrote: > > Eh... I just realized it's not 100% correct. We have a test > > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday. > > > > The problem with this one is that we are not reacting when icons are > > introduced

Re: Review Request 127240: [Applet] Don't crash on remove panel

> On March 1, 2016, 4:02 p.m., David Edmundson wrote: > > src/plasma/private/applet_p.cpp, line 327 > > > > > > Why is this change "the else" here? > > > > you've changed it > > > > if the

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

> On March 1, 2016, 4:37 p.m., Aleix Pol Gonzalez wrote: > > Eh... I just realized it's not 100% correct. We have a test > > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday. > > > > The problem with this one is that we are not reacting when icons are > > introduced

Review Request 127245: Fix Kdelibs4 config migration for Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127236/#review93023 --- Eh... I just realized it's not 100% correct. We have a test

Re: Review Request 127240: [Applet] Don't crash on remove panel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127240/#review93015 --- src/plasma/private/applet_p.cpp (line 326)

Re: Review Request 127240: [Applet] Don't crash on remove panel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127240/#review93001 --- right, but now with that change we don't need any of the

Review Request 127240: [Applet] Don't crash on remove panel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127240/ --- Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127236/#review92996 --- Ship it! But I like battleship :) Awesome work Aleix, I

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 4:12 a.m., Aleix Pol Gonzalez wrote: > > src/sycoca/ksycocadict.cpp, line 322 > > > > > > Maybe it's better to leave the * there, as it makes it more clear that > > it's an output argument.

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 8:14 a.m., David Faure wrote: > > src/sycoca/kbuildmimetypefactory.cpp, line 65 > > > > > > Can you keep the order of the operands? I find > > if (var == constant) > > more readable

Re: Review Request 127100: Remove unused dependencies in kactivities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127100/ --- (Updated March 1, 2016, 1:44 p.m.) Status -- This change has been

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 51 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 12:00:56 + Build duration: 1.3 sec CHANGE SET No changes

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 56 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 12:00:56 + Build duration: 1.2 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 288 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/288/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 01 Mar 2016 11:57:31 + Build duration: 7.9 sec CHANGE SET No changes

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

> On March 1, 2016, 10:19 a.m., Kai Uwe Broulik wrote: > > src/kicontheme.cpp, line 675 > > > > > > This looks like it causes a lot of transient allocations, creating a > > QList just to do a contains() on it.

Re: Review Request 127233: Skip looking up . and .. to find the translations for an application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127233/ --- (Updated March 1, 2016, 11:58 a.m.) Status -- This change has been

Re: Review Request 127233: Skip looking up . and .. to find the translations for an application

> On March 1, 2016, 9:55 a.m., Chusslove Illich wrote: > > 270 directories does seem a bit excessive to me... how do you count them, > > by strace or? Yes: https://paste.kde.org/pvajgxbet It's coming from KHelpMenuPrivate::createActions, to see if the SwitchApplicationLanguage action needs

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 12:31 p.m., Kai Uwe Broulik wrote: > > src/sycoca/kbuildsycoca.cpp, line 143 > > > > > > QVector maybe? > > Nick Shaforostoff wrote: > doesn't make a difference from performance

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 8:14 a.m., David Faure wrote: > > About the unittest failure, I'm available by email to debug that, tests > > shouldn't fail. > > (first thing to check will be: did a > > ~/.qttest/share/applications/faketextapplication.desktop get created?) > > Nick Shaforostoff wrote: >

Re: Review Request 127205: Add stubs to allow compilation on Android.

> On March 1, 2016, 12:26 a.m., Aleix Pol Gonzalez wrote: > > src/lib/CMakeLists.txt, line 116 > > > > > > Why does pthread make a difference? > > Andreas Cord-Landwehr wrote: > Bionic provides native

KWidgetsAddons License (included breeze icons)

Hi, I want to implement a similiar "Show Password" functionality as KPasswordDialog from KWidgetsAddons has in GnuPG's pinentry. I'd like to use the same Icons for this, but Pinentry is GPLv2 or Later while breeze is LGPLv3. As I want to include them directly in the Source (without need for

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127236/#review92976 --- src/kicontheme.cpp (line 675)

Re: Review Request 127233: Skip looking up . and .. to find the translations for an application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127233/#review92971 --- Ship it! 270 directories does seem a bit excessive to

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 294 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/294/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 01 Mar 2016 08:41:46 + Build duration: 3 min 29 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 294 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/294/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 01 Mar 2016 08:41:46 + Build duration: 18 sec CHANGE SET No

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

Am 01.03.2016 um 09:16 schrieb Nick Shaforostoff: > At the moment we're playing Battleship to see if an icon is present in > a subdirectory. This means that we are checking on every directory if > there's an icon that matches the size with a said name on every request. > > > This can be seen

Re: Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/#review92968 --- src/lib/io/kdirwatch.cpp (line 181)

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127236/#review92967 --- Ship it! great finding, thanks for you work! - Nick

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92966 --- so, any objections for submitting the patch? - Nick