date:20160319


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127398/
---

Review request for KDE Frameworks.


Repository: knotifications


Description
---

Adds basic set of unit tests including fake notifications server.

This helped uncover and fix these issues:

* Calling close() on KNotification that was not "sent" would not emit closed() 
and would not delete it
* Closing a notification can delete the KNotification object prematurely
* Invoking an action leads to unnecessary dbus roundtrip
* Invoking an action would fail to properly close and delete the KNotification 
object


Diffs
-

  CMakeLists.txt 6d09051 
  autotests/CMakeLists.txt PRE-CREATION 
  autotests/fake_notifications_server.h PRE-CREATION 
  autotests/fake_notifications_server.cpp PRE-CREATION 
  autotests/knotification_test.cpp PRE-CREATION 
  autotests/knotifications5/qttest.notifyrc PRE-CREATION 
  autotests/qtest_dbus.h PRE-CREATION 
  src/knotification.cpp 17b0be2 
  src/knotificationmanager.cpp e80d48c 
  src/knotificationplugin.cpp acf964c 
  src/notifybypopup.cpp b9489c1 

Diff: https://git.reviewboard.kde.org/r/127398/diff/


Testing
---

Unit tests all pass.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 321 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/321/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 17 Mar 2016 17:30:33 +
Build duration: 1 min 57 sec

CHANGE SET
Revision 2661cd701c18ee17021de8bac5d05ccbf2f509eb by Marco Martin: (reintroduce 
busy property in Applet)
  change: edit src/scriptengines/qml/plasmoid/appletinterface.cpp
  change: edit src/scriptengines/qml/plasmoid/appletinterface.h
  change: edit src/plasma/private/applet_p.cpp
  change: edit src/plasma/applet.h
  change: edit src/plasma/applet.cpp
  change: edit src/plasma/private/applet_p.h


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 48/86 (56%)CLASSES 48/86 (56%)LINE 2923/8686 
(34%)CONDITIONAL 1522/2419 (63%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 508/531 
(96%)CONDITIONAL 371/636 (58%)
src.declarativeimports.core
FILES 1/7 (14%)CLASSES 1/7 (14%)LINE 60/832 (7%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1526/3676 
(42%)CONDITIONAL 790/1244 (64%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 826/1672 
(49%)CONDITIONAL 342/513 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1680 (0%)CONDITIONAL 
2/4 (50%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93749
---




src/kcompletionbox.cpp (line 282)


After show, call activateWindow(), even you can call raise()


- Anthony Fieroni


On Март 19, 2016, 10:56 след обяд, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated Март 19, 2016, 10:56 след обяд)
> 
> 
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Qt 5.6/QtWebkit

Hi,

Is there a page/site somewhere that outlines the current status of Qt 5.6/KF5 
compatibility, notably as far as QtWebkit is concerned?

A quick search (KF5 qt5.6 qtwebkit) didn't turn up any particularly useful hits 
in the first page or so, other than that one can apparently still build 
QtWebkit 5.5.1 . And that the component has apparently been replaced by 
QtWebEngine, which I presume means KF5 will soon migrate to that component?

Thanks,
René
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

Kevin Funk wrote:


> I think qt-developm...@qt-project.org is a better fit for this question.

Good call. From Jani Heikkinen:

> Webkit packages can be found from here:
> http://download.qt.io/community_releases/5.6/5.6.0/ 

R.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/#review93660
---



The only real difference to the original version is that the line

int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, solidDevNum);

is removed. This somehow implies that this check is too restrictive. If this 
indeed is the case, then this might very well be a bug in libmtp.

I haved tried to find something in the net, especially since other mtp-clients 
(from other DEs) are said to work, but couldn't really find something useful 
for now...

- Dominik Haumann


On March 16, 2016, 4:41 p.m., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127386/
> ---
> 
> (Updated March 16, 2016, 4:41 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
> 
> 
> Bugs: 325335
> https://bugs.kde.org/show_bug.cgi?id=325335
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp.
> 
> It seems the device is listed but dropped for some reason. This issues exists 
> for quite a long time (also in KDE 4.x), and some people provided this patch 
> (from bug #325335).
> 
> I personally cannot test this patch, as I don't own a Windows Phone.
> 
> However, given this patch works successfully for at least some users (see 
> also 
> https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/),
>  I think we at least should give it a try.
> 
> Adding group 'kdeframeworks' to reach a broader audience.
> 
> Would be cool to get a proper review for this patch, or even someone who owns 
> such a device!
> 
> 
> Diffs
> -
> 
>   mtp/devicecache.cpp 8c5c7cf 
> 
> Diff: https://git.reviewboard.kde.org/r/127386/diff/
> 
> 
> Testing
> ---
> 
> Compiles...
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 320 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/320/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 17 Mar 2016 12:40:31 +
Build duration: 3 min 13 sec

CHANGE SET
Revision c23f2415bb5726297e49785f18644dd17d1b38d7 by aleixpol: (Make it 
possible for an applet to offer a test object)
  change: edit src/plasma/private/packages.cpp
  change: edit src/plasmaquick/private/appletquickitem_p.h
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/appletquickitem.cpp
Revision 309c64f5e90453c5253baf19e6c01759e8aa6f83 by aleixpol: (Dont 
import an nonexistent layout)
  change: edit src/plasma/corona.cpp
Revision 0e9976afb1c4442819c9ca2cea9d2c50f4a53b3c by aleixpol: (Make sure 
PlasmaQuick export file is properly found)
  change: edit src/plasmaquick/configview.h
  change: edit src/plasmaquick/packageurlinterceptor.h
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/dialog.h
  change: edit src/plasmaquick/shellpluginloader.h
  change: edit src/plasmaquick/view.h
  change: edit src/plasmaquick/configmodel.h


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.dialognativetestFailed: 
TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 57/90 (63%)CLASSES 57/90 (63%)LINE 3830/8924 
(43%)CONDITIONAL 1994/3145 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 554/578 
(96%)CONDITIONAL 385/664 (58%)
src.declarativeimports.core
FILES 4/7 (57%)CLASSES 4/7 (57%)LINE 315/832 (38%)CONDITIONAL 
150/232 (65%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1650/3669 
(45%)CONDITIONAL 866/1308 (66%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 877/1746 
(50%)CONDITIONAL 368/549 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 434/1804 
(24%)CONDITIONAL 225/392 (57%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125965: Add declarative plugin to KHolidays



> On Nov. 6, 2015, 3:29 p.m., Nick Shaforostoff wrote:
> > src/declarative/holidayregionsmodel.cpp, line 81
> > 
> >
> > i suggest enclosing strings into QByteArrayLiteral.
> > 
> > see http://woboq.com/blog/qstringliteral.html for explanation and 
> > https://gitlab.com/pteam/pteam-qtbase/commit/05663e29d047851adb9a1ef440fb78b38ff3cc9b
> >  for the case when QBAL are not suitable

Is QByteArrayLiteral available in Qt 5.4? I can't find any info about it 
anywhere.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/#review88099
---


On Nov. 5, 2015, 8:57 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125965/
> ---
> 
> (Updated Nov. 5, 2015, 8:57 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> ---
> 
> For now it contains just the model of holiday regions
> which will be used in the Plasma calendar events
> configuration.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e8b7970 
>   src/CMakeLists.txt c067b6c 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/holidayregionsmodel.h PRE-CREATION 
>   src/declarative/holidayregionsmodel.cpp PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125965/diff/
> 
> 
> Testing
> ---
> 
> Applet configuration contains proper list of available
> holiday regions.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

Aleix Pol wrote:

> WebKit integration was done through forking then integrating. It was
> awkward because merging upstream changes meant rebasing our work on
> theirs.
> That's why it's Chromium is better in this regard, you get to interact
> the upstream component without forking it, AFAIU.

You mean Chromium is used as a sort of external library with a more or less 
thin 
wrapper on top/around it?

If so it seems it should have been possible to reimplement QtWebKit using a 
similar approach with probably far fewer API changes.

Not that that matters now ... for those of us who are on (readily) supported 
platforms.

R.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

oxygen icon name clasheroo

2016-03-19 Thread Harald Sitter

Hola!

Our most awesome icon maintainers wanted to carry over icon symlinking
from breeze to oxygen, alas that turned up a whole slew of
compatibility problems.

examples:
https://bugs.kde.org/show_bug.cgi?id=360605
https://bugs.kde.org/show_bug.cgi?id=360510

# Problem
In kde4 software people used oxygen as the standard icon set and
installed their own icons there. Since breeze covers all icons ever,
replicating its coverage into oxygen means we have a million conflicts
with (older?) tarballs of existing software that also install icons
into oxygen under the same name.

# Proposal
We could get rid of this and all future conflicts if we shift the
default oxygen icons into a subdirectory.

So, we install the default icons to

$prefix/share/icons/oxygen/base/22x22
$prefix/share/icons/oxygen/base/32x32
$prefix/share/icons/oxygen/base/...

applications can thus continue to install to

$prefix/share/icons/oxygen/22x22
$prefix/share/icons/oxygen/32x32
$prefix/share/icons/oxygen/...

without conflicting with our base files what so ever.

Downside of this is that the index.theme basically needs to list
everything twice (once for base and once for main directory), which
unfortunately incurs a bit of a runtime overhead. This is a bit of a
crap situation we are in and I can't think of another solution to
this.

Input welcome

HS
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-19 Thread Marco Martin



> On March 19, 2016, 1:22 p.m., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.
> 
> Dominik Haumann wrote:
> ...I'm not sure what you are suggesting: Fact is, right now, we don't 
> have another fix than reverting to the original code.
> It would also work to add a #ifdef, but given that temporary workarounds 
> tend to become pernanent ones, this is probably the worst solution.
> 
> So what is the proper fix / approach we can take here?
> 
> Anthony Fieroni wrote:
> http://doc.qt.io/qt-5/qt.html#WindowType-enum
> q->setWindowFlags(Qt::ToolTip | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> or 
> q->activateWindow();
> *(i.e., no keyboard input unless you call QWidget::activateWindow() 
> manually).*
> 
> Anthony Fieroni wrote:
> I mean Window :)
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Dominik Haumann wrote:
> Just tested
> 
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Does not work either: We get no window decoration, which is good, but 
> KLineEdit looses focus (no blinking cursor, no new typed text), and it is 
> hard to make the popup disappear again.
> 
> Maybe this is a bug in the implementation of KCompletionBox and/or 
> KLineEditor. Fact is, though, that it at least worked for applications before.
> 
> I could not find a call of activateWindow()...
> 
> Kai Uwe Broulik wrote:
> Does Qt::WindowDoesNotAcceptFocus help?
> 
> Dominik Haumann wrote:
> Unfortunately, no, no matter what combinations I try ;) (Qt::Window, 
> Qt::Popup, and the other flags arbitrarily combined)
> 
> Thomas Lübking wrote:
> Qt::WindowDoesNotAcceptFocus only handles what happens if the window 
> receives an ::ActivateWindow event, not how the window should be created.
> 
> You can try setting ("_q_showWithoutActivating", false) like 
> "_q_xcb_wm_window_type", but actually™ when this is tested on the windows 
> platform plugin, so is Qt::Popup, Qt::ToolTip and Qt::Tool.
> Qt::ToolTip is btw. Qt::Popup|Qt::Sheet and ::Sheet doesn't exist 
> anywhere but on OSX.
> 
> As ultimate resolution branch #ifdef Q_OS_WIN to tag a combobox drawer a 
> tooltip. And better start looking for another toolkit.

it suggests that in this case the bug is in the windows qpa..
even if it's horrible, the least broken solution is an ifdef that sets the 
window as tooltip only on windows
(and in the meantime taking a look what's wrong in that qpa and if is fixable 
at all)
having that window as a tooltip is wrong and breaks things on x11 (tooltips are 
now animated and that window would be animated too), so i would really rather 
not having it as a tooltip on x11, fine if it's that on Windows


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On March 19, 2016, 8:56 p.m., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated March 19, 2016, 8:56 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
>

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-19 Thread Thomas Lübking



> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.
> 
> Dominik Haumann wrote:
> ...I'm not sure what you are suggesting: Fact is, right now, we don't 
> have another fix than reverting to the original code.
> It would also work to add a #ifdef, but given that temporary workarounds 
> tend to become pernanent ones, this is probably the worst solution.
> 
> So what is the proper fix / approach we can take here?
> 
> Anthony Fieroni wrote:
> http://doc.qt.io/qt-5/qt.html#WindowType-enum
> q->setWindowFlags(Qt::ToolTip | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> or 
> q->activateWindow();
> *(i.e., no keyboard input unless you call QWidget::activateWindow() 
> manually).*
> 
> Anthony Fieroni wrote:
> I mean Window :)
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Dominik Haumann wrote:
> Just tested
> 
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Does not work either: We get no window decoration, which is good, but 
> KLineEdit looses focus (no blinking cursor, no new typed text), and it is 
> hard to make the popup disappear again.
> 
> Maybe this is a bug in the implementation of KCompletionBox and/or 
> KLineEditor. Fact is, though, that it at least worked for applications before.
> 
> I could not find a call of activateWindow()...
> 
> Kai Uwe Broulik wrote:
> Does Qt::WindowDoesNotAcceptFocus help?
> 
> Dominik Haumann wrote:
> Unfortunately, no, no matter what combinations I try ;) (Qt::Window, 
> Qt::Popup, and the other flags arbitrarily combined)

Qt::WindowDoesNotAcceptFocus only handles what happens if the window receives 
an ::ActivateWindow event, not how the window should be created.

You can try setting ("_q_showWithoutActivating", false) like 
"_q_xcb_wm_window_type", but actually™ when this is tested on the windows 
platform plugin, so is Qt::Popup, Qt::ToolTip and Qt::Tool.
Qt::ToolTip is btw. Qt::Popup|Qt::Sheet and ::Sheet doesn't exist anywhere but 
on OSX.

As ultimate resolution branch #ifdef Q_OS_WIN to tag a combobox drawer a 
tooltip. And better start looking for another toolkit.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On März 19, 2016, 8:56 nachm., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, 8:56 nachm.)
> 
> 
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org

Re: Review Request 127380: More conservative approach to saving some disk accesses

2016-03-19 Thread Kevin Funk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127380/#review93636
---



Since you asked for review: I don't know the code enough to judge. Generally 
I'd say "yes".

Does `iconPath(..., KIconLoader::MatchBest)` return results you'd have received 
with `iconPath(..., KIconLoader::MatchExact)`?

- Kevin Funk


On March 15, 2016, 1:52 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127380/
> ---
> 
> (Updated March 15, 2016, 1:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> My previous approach to KIconThemes felt like a dead end, I decided I'll take 
> a more conservative approach. Here's a first step.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 61e81f6 
>   autotests/kiconloader_benchmark.cpp PRE-CREATION 
>   src/kiconloader.cpp 75ab482 
>   src/kicontheme.cpp 0996054 
> 
> Diff: https://git.reviewboard.kde.org/r/127380/diff/
> 
> 
> Testing
> ---
> 
> Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 
> before= 17% less QFile::exists
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins and XDG_DATA_DIRS

It appears that something regressed in the jenkins setup.

Almost all of the current failures in the "Frameworks kf5-qt5" group come from 
XDG_DATA_DIRS
not being set up correctly anymore, I think.
E.g. in 
https://build.kde.org/view/Frameworks%20kf5-qt5/job/kio%20master%20kf5-qt5/269/PLATFORM=Linux,compiler=gcc/console
* KUriFilterTest and others fail to see the servicetype "KUriFilter/Plugin" 
which kio installs itself

The kio job says

export 
XDG_DATA_DIRS="/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kwidgetsaddons/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kauth/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/sonnet/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/knotifications/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kdesupport/extra-cmake-modules/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kdoctools/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/ktextwidgets/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kconfigwidgets/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kjobwidgets/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kcoreaddons/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/breeze-icons/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kglobalaccel/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kservice/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kwallet/inst/usr/share:/srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kdesupport/phonon/phonon/inst/usr/share:$XDG_DATA_DIRS:/usr/share:/usr/share"

This is missing the dir for kio itself.

Same kind of problem in kemoticonstest (which loads its own plugin), 
frameworkintegration (same).

Is this a voluntary change, as in, we should fix the tests to work without the 
need to make install first?

=

Also, kservice and kdelibs4support fail because XDG_CONFIG_DIRS doesn't contain
the kservice install prefix (+/etc/xdg).
For some strange reason XDG_CONFIG_DIRS, during the kdelibs4support tests, 
contains
the kio prefix but no other.
That one surely can't be intentional.

Can you have a look?

Thanks.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.

2016-03-19 Thread Allen Winter


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127428/#review93738
---


Ship it!




Ship It!

- Allen Winter


On March 19, 2016, 8:31 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127428/
> ---
> 
> (Updated March 19, 2016, 8:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> Noticed in the CI which says: Invalid plugin factory for 
> "kf5/emoticonsthemes/kde"
> 
> 
> Diffs
> -
> 
>   src/core/kemoticons.cpp 87e4a1116b634fdae33f42112b870c5eb1c204d0 
> 
> Diff: https://git.reviewboard.kde.org/r/127428/diff/
> 
> 
> Testing
> ---
> 
> Removing lib64/plugins/kf5/emoticonsthemes/kde.so locally, I got the crash 
> too, this fixes it.
> 
> Of course the unittest fails then, as expected, it just doesn't crash anymore.
> 
> I think some env vars are missing in Jenkins
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127428/#review93737
---


Ship it!




Looks good to me (can definitely not hurt to check the pointer for obvious 
reasons).

- Dominik Haumann


On März 19, 2016, 8:31 nachm., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127428/
> ---
> 
> (Updated März 19, 2016, 8:31 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> Noticed in the CI which says: Invalid plugin factory for 
> "kf5/emoticonsthemes/kde"
> 
> 
> Diffs
> -
> 
>   src/core/kemoticons.cpp 87e4a1116b634fdae33f42112b870c5eb1c204d0 
> 
> Diff: https://git.reviewboard.kde.org/r/127428/diff/
> 
> 
> Testing
> ---
> 
> Removing lib64/plugins/kf5/emoticonsthemes/kde.so locally, I got the crash 
> too, this fixes it.
> 
> Of course the unittest fails then, as expected, it just doesn't crash anymore.
> 
> I think some env vars are missing in Jenkins
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

On Friday March 18 2016 17:39:18 Milian Wolff wrote:

> > If so it seems it should have been possible to reimplement QtWebKit using a
> > similar approach with probably far fewer API changes.
> 
> Which WebKit implementation would you have chosen? The GTK one?

Huh??
Upstream WebKit is probably just as GUI-agnostic as the Chromium library, 
right? What I meant was that in that case, it could have been an alternative to 
write a similar "more or less thin wrapper" on top/around WebKit, rather than 
move to a completely different API.

> > Not that that matters now ... for those of us who are on (readily) supported
> > platforms.
> 
> Yes, this is a waste of time.

At this point that is probably true, regardless of the comparative merits of 
WebKit vs. Chromium.

R.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows



> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.
> 
> Dominik Haumann wrote:
> ...I'm not sure what you are suggesting: Fact is, right now, we don't 
> have another fix than reverting to the original code.
> It would also work to add a #ifdef, but given that temporary workarounds 
> tend to become pernanent ones, this is probably the worst solution.
> 
> So what is the proper fix / approach we can take here?
> 
> Anthony Fieroni wrote:
> http://doc.qt.io/qt-5/qt.html#WindowType-enum
> q->setWindowFlags(Qt::ToolTip | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> or 
> q->activateWindow();
> *(i.e., no keyboard input unless you call QWidget::activateWindow() 
> manually).*
> 
> Anthony Fieroni wrote:
> I mean Window :)
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Dominik Haumann wrote:
> Just tested
> 
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Does not work either: We get no window decoration, which is good, but 
> KLineEdit looses focus (no blinking cursor, no new typed text), and it is 
> hard to make the popup disappear again.
> 
> Maybe this is a bug in the implementation of KCompletionBox and/or 
> KLineEditor. Fact is, though, that it at least worked for applications before.
> 
> I could not find a call of activateWindow()...
> 
> Kai Uwe Broulik wrote:
> Does Qt::WindowDoesNotAcceptFocus help?

Unfortunately, no, no matter what combinations I try ;) (Qt::Window, Qt::Popup, 
and the other flags arbitrarily combined)


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On März 19, 2016, 8:56 nachm., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, 8:56 nachm.)
> 
> 
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-19 Thread Kai Uwe Broulik



> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.
> 
> Dominik Haumann wrote:
> ...I'm not sure what you are suggesting: Fact is, right now, we don't 
> have another fix than reverting to the original code.
> It would also work to add a #ifdef, but given that temporary workarounds 
> tend to become pernanent ones, this is probably the worst solution.
> 
> So what is the proper fix / approach we can take here?
> 
> Anthony Fieroni wrote:
> http://doc.qt.io/qt-5/qt.html#WindowType-enum
> q->setWindowFlags(Qt::ToolTip | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> or 
> q->activateWindow();
> *(i.e., no keyboard input unless you call QWidget::activateWindow() 
> manually).*
> 
> Anthony Fieroni wrote:
> I mean Window :)
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Dominik Haumann wrote:
> Just tested
> 
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> 
> Does not work either: We get no window decoration, which is good, but 
> KLineEdit looses focus (no blinking cursor, no new typed text), and it is 
> hard to make the popup disappear again.
> 
> Maybe this is a bug in the implementation of KCompletionBox and/or 
> KLineEditor. Fact is, though, that it at least worked for applications before.
> 
> I could not find a call of activateWindow()...

Does Qt::WindowDoesNotAcceptFocus help?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On März 19, 2016, 8:56 nachm., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, 8:56 nachm.)
> 
> 
> Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows



> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.
> 
> Dominik Haumann wrote:
> ...I'm not sure what you are suggesting: Fact is, right now, we don't 
> have another fix than reverting to the original code.
> It would also work to add a #ifdef, but given that temporary workarounds 
> tend to become pernanent ones, this is probably the worst solution.
> 
> So what is the proper fix / approach we can take here?
> 
> Anthony Fieroni wrote:
> http://doc.qt.io/qt-5/qt.html#WindowType-enum
> q->setWindowFlags(Qt::ToolTip | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> or 
> q->activateWindow();
> *(i.e., no keyboard input unless you call QWidget::activateWindow() 
> manually).*
> 
> Anthony Fieroni wrote:
> I mean Window :)
> q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);

Just tested

q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
Qt::FramelessWindowHint);

Does not work either: We get no window decoration, which is good, but KLineEdit 
looses focus (no blinking cursor, no new typed text), and it is hard to make 
the popup disappear again.

Maybe this is a bug in the implementation of KCompletionBox and/or KLineEditor. 
Fact is, though, that it at least worked for applications before.

I could not find a call of activateWindow()...


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On März 19, 2016, Mittag, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, Mittag)
> 
> 
> Review request for KDE Frameworks, kwin and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127414: Don't enable acl permissions widget if we don't own the file


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127414/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

The man page for setfacl says only the file owner or root can change the
permissions, so it would always fail. Better to disable it in the UI.

Patch effectily written by Thomas Pfeiffer.

BUG: 245580


Diffs
-

  src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 

Diff: https://git.reviewboard.kde.org/r/127414/diff/


Testing
---

ran kpropertiesdialogtest on a file owned by me, and a file owned by root.

One had the setting Permissions->Advanced->Add Entry enabled, the other did not.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127428/
---

Review request for KDE Frameworks.


Repository: kemoticons


Description
---

Noticed in the CI which says: Invalid plugin factory for 
"kf5/emoticonsthemes/kde"


Diffs
-

  src/core/kemoticons.cpp 87e4a1116b634fdae33f42112b870c5eb1c204d0 

Diff: https://git.reviewboard.kde.org/r/127428/diff/


Testing
---

Removing lib64/plugins/kf5/emoticonsthemes/kde.so locally, I got the crash too, 
this fixes it.

Of course the unittest fails then, as expected, it just doesn't crash anymore.

I think some env vars are missing in Jenkins


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127406: Fix encoding for gap.xml (use UTF-8)

2016-03-19 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127406/
---

Review request for Kate, KDE Frameworks and Daniel Vrátil.


Repository: ktexteditor


Description
---

The file is really ASCII-only (7 bit), so both ISO-8859-15 and UTF-8 works but 
no need to use a deprecated encoding.
(this could help systems were support for those encodings has been removed).

See also: https://mail.kde.org/pipermail/release-team/2016-March/009327.html


Diffs
-

  src/syntax/data/gap.xml 1af543d 

Diff: https://git.reviewboard.kde.org/r/127406/diff/


Testing
---


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones



> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote:
> > The only real difference to the original version is that the line
> > 
> > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, 
> > solidDevNum);
> > 
> > is removed. This somehow implies that this check is too restrictive. If 
> > this indeed is the case, then this might very well be a bug in libmtp.
> > 
> > I haved tried to find something in the net, especially since other 
> > mtp-clients (from other DEs) are said to work, but couldn't really find 
> > something useful for now...

Found something dating back to 2011: 
https://sourceforge.net/p/libmtp/mailman/libmtp-discuss/?viewmonth=201101=21=flat
Here it says:

One more thing. the mtp-probe did not work on older ubuntu's than 10.10.
Further investigating showed that it fails at 
LIBMTP_Check_Specific_Device () only because libusb does not populate 
the correct dev->devnum (i.e. usb device number.

However if I manually run mtp-probe, later after a few seconds of device 
plugged in, it works properly.

Looks like libusb takes a while to get the correct device number. Is 
this a known libusb issue or something else?

Might it be that we are hit by this issue? According to the link, newer 
versions of libusb should probably not have this issue.

Anyone familiar with this?


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/#review93660
---


On March 16, 2016, 4:41 p.m., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127386/
> ---
> 
> (Updated March 16, 2016, 4:41 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
> 
> 
> Bugs: 325335
> https://bugs.kde.org/show_bug.cgi?id=325335
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp.
> 
> It seems the device is listed but dropped for some reason. This issues exists 
> for quite a long time (also in KDE 4.x), and some people provided this patch 
> (from bug #325335).
> 
> I personally cannot test this patch, as I don't own a Windows Phone.
> 
> However, given this patch works successfully for at least some users (see 
> also 
> https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/),
>  I think we at least should give it a try.
> 
> Adding group 'kdeframeworks' to reach a broader audience.
> 
> Would be cool to get a proper review for this patch, or even someone who owns 
> such a device!
> 
> 
> Diffs
> -
> 
>   mtp/devicecache.cpp 8c5c7cf 
> 
> Diff: https://git.reviewboard.kde.org/r/127386/diff/
> 
> 
> Testing
> ---
> 
> Compiles...
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows



> On Март 19, 2016, 3:22 след обяд, Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.
> 
> Dominik Haumann wrote:
> ...I'm not sure what you are suggesting: Fact is, right now, we don't 
> have another fix than reverting to the original code.
> It would also work to add a #ifdef, but given that temporary workarounds 
> tend to become pernanent ones, this is probably the worst solution.
> 
> So what is the proper fix / approach we can take here?
> 
> Anthony Fieroni wrote:
> http://doc.qt.io/qt-5/qt.html#WindowType-enum
> q->setWindowFlags(Qt::ToolTip | Qt::BypassWindowManagerHint | 
> Qt::FramelessWindowHint);
> or 
> q->activateWindow();
> *(i.e., no keyboard input unless you call QWidget::activateWindow() 
> manually).*

I mean Window :)
q->setWindowFlags(Qt::Window | Qt::BypassWindowManagerHint | 
Qt::FramelessWindowHint);


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On Март 19, 2016, 2 след обяд, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated Март 19, 2016, 2 след обяд)
> 
> 
> Review request for KDE Frameworks, kwin and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows



> On Март 19, 2016, 3:22 след обяд, Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.
> 
> Dominik Haumann wrote:
> ...I'm not sure what you are suggesting: Fact is, right now, we don't 
> have another fix than reverting to the original code.
> It would also work to add a #ifdef, but given that temporary workarounds 
> tend to become pernanent ones, this is probably the worst solution.
> 
> So what is the proper fix / approach we can take here?

http://doc.qt.io/qt-5/qt.html#WindowType-enum
q->setWindowFlags(Qt::ToolTip | Qt::BypassWindowManagerHint | 
Qt::FramelessWindowHint);
or 
q->activateWindow();
*(i.e., no keyboard input unless you call QWidget::activateWindow() manually).*


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On Март 19, 2016, 2 след обяд, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated Март 19, 2016, 2 след обяд)
> 
> 
> Review request for KDE Frameworks, kwin and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones



> On März 17, 2016, 5:26 nachm., Dominik Haumann wrote:
> > The only real difference to the original version is that the line
> > 
> > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, 
> > solidDevNum);
> > 
> > is removed. This somehow implies that this check is too restrictive. If 
> > this indeed is the case, then this might very well be a bug in libmtp.
> > 
> > I haved tried to find something in the net, especially since other 
> > mtp-clients (from other DEs) are said to work, but couldn't really find 
> > something useful for now...
> 
> Dominik Haumann wrote:
> Found something dating back to 2011: 
> https://sourceforge.net/p/libmtp/mailman/libmtp-discuss/?viewmonth=201101=21=flat
> Here it says:
> 
> One more thing. the mtp-probe did not work on older ubuntu's than 
> 10.10.
> Further investigating showed that it fails at 
> LIBMTP_Check_Specific_Device () only because libusb does not populate 
> the correct dev->devnum (i.e. usb device number.
> 
> However if I manually run mtp-probe, later after a few seconds of 
> device 
> plugged in, it works properly.
> 
> Looks like libusb takes a while to get the correct device number. Is 
> this a known libusb issue or something else?
> 
> Might it be that we are hit by this issue? According to the link, newer 
> versions of libusb should probably not have this issue.
> 
> Anyone familiar with this?
> 
> Dominik Haumann wrote:
> More on this, grepping the entire git repo of gvfs 
> (https://github.com/GNOME/gvfs.git) shows that gvfs does not use 
> LIBMTP_Check_Specific_Device() at all.
> Similarly, grepping through simple-mtp-fs 
> (https://github.com/phatina/simple-mtpfs) also shows no usage of 
> LIBMTP_Check_Specific_Device().
> However, both solutions use the other LIBMTP calls similarly to how 
> kio-mtp does.
> 
> What if we really just omit this check. The worst thing that can happen 
> is that we iterate over all device numbers and get no hit, which just takes a 
> bit longer.
> 
> Question would be: Do we get too many devices, as Kai was saying? No 
> idea, but this really solves the issue for many users, then this might well 
> be worth a try.
> 
> Opinions?

I asked ok libmtp-discuss 
(https://sourceforge.net/p/libmtp/mailman/message/34948820/) and the answer is 
as follows:

This function probes an USB device for MTP specific properties, in some form
of MTP property auto detection. This auto-detection does not necessarily 
work for all MTP devices,
as it is was never well defined or documemted.

It also does not check against our existing USB ID database.

If you have a device that is in our USB ID database already,
LIBMTP_Detect_Raw_Devices will do the by-id detection (and you do that 
later in the code).

Only as fallback you should try LIBMTP_Check_Specific_Device().

In other words, following this reasoning, we should not use 
LIBMTP_Check_Specific_Device() at all as an initial check/filter, meaning that 
he patch is correct.

I don't think I will find more info about this issue without much more 
investigation. But given the infos we have, I would like to commit - thoungs?

@Kai: You were talking about 3 devices that are listed, only one of these 
working. Can you test or comment on this again?


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/#review93660
---


On März 16, 2016, 4:41 nachm., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127386/
> ---
> 
> (Updated März 16, 2016, 4:41 nachm.)
> 
> 
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
> 
> 
> Bugs: 325335
> https://bugs.kde.org/show_bug.cgi?id=325335
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp.
> 
> It seems the device is listed but dropped for some reason. This issues exists 
> for quite a long time (also in KDE 4.x), and some people provided this patch 
> (from bug #325335).
> 
> I personally cannot test this patch, as I don't own a Windows Phone.
> 
> However, given this patch works successfully for at least some users (see 
> also 
> https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/),
>  I think we at least should give it a try.
> 
> Adding group 'kdeframeworks' to reach a broader audience.
> 
> Would be cool to get a proper review for this patch, or even someone who owns 
> such a device!
> 
> 
> Diffs
> -
> 
>   mtp/devicecache.cpp 8c5c7cf 
> 
> Diff:

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows



> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).
> 
> Thomas Lübking wrote:
> i did not mean "alongside Qt::Popup" - if you need to hint this as 
> tooltip for somewhat useful behavior, either the class or QWidget/5 is 
> seriously fucked up.

...I'm not sure what you are suggesting: Fact is, right now, we don't have 
another fix than reverting to the original code.
It would also work to add a #ifdef, but given that temporary workarounds tend 
to become pernanent ones, this is probably the worst solution.

So what is the proper fix / approach we can take here?


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On März 19, 2016, Mittag, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, Mittag)
> 
> 
> Review request for KDE Frameworks, kwin and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

2016-03-19 Thread Sebastian Kügler


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/#review93652
---


Ship it!




Ship It!

- Sebastian Kügler


On March 17, 2016, 12:37 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127405/
> ---
> 
> (Updated March 17, 2016, 12:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Uses `"quotes"` rather than `` to include a neigbour header file.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 99fcf1b 
>   src/plasmaquick/configmodel.h ed2df2e 
>   src/plasmaquick/configview.h 5ac9c26 
>   src/plasmaquick/dialog.h 63efa04 
>   src/plasmaquick/packageurlinterceptor.h 343e311 
>   src/plasmaquick/shellpluginloader.h bdc13be 
>   src/plasmaquick/view.h b59271d 
> 
> Diff: https://git.reviewboard.kde.org/r/127405/diff/
> 
> 
> Testing
> ---
> 
> Aparently it was a problem on some systems. It was eventually fixed for me, 
> so I thought I was crazy. This should be the fix nevertheless (assuming 
> include directories are being exported properly).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

2016-03-19 Thread Kevin Funk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127406/#review93635
---


Ship it!




Ship It!

- Kevin Funk


On March 17, 2016, 12:36 a.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127406/
> ---
> 
> (Updated March 17, 2016, 12:36 a.m.)
> 
> 
> Review request for Kate, KDE Frameworks and Daniel Vrátil.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> The file is really ASCII-only (7 bit), so both ISO-8859-15 and UTF-8 works 
> but no need to use a deprecated encoding.
> (this could help systems were support for those encodings has been removed).
> 
> See also: https://mail.kde.org/pipermail/release-team/2016-March/009327.html
> 
> 
> Diffs
> -
> 
>   src/syntax/data/gap.xml 1af543d 
> 
> Diff: https://git.reviewboard.kde.org/r/127406/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Raising Qt requirement to Qt 5.4

2016-03-19 Thread Martin Graesslin

Hi all,

with todays release of Qt 5.6 I suggest that we raise the minimum Qt version 
requirement to 5.4. This would mean the latest three releases are supported.

The important new features in Qt 5.4 in my opinion for frameworks development 
are:
* QSignalSpy(const QObject *object, PointerToMemberFunction signal)
* Q_LOGGING_CATEGORY(name, string, msgType)

Which are already used in many frameworks and currently ifdefed.

Opinions?

Best Regards
Martin

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones



> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote:
> > The only real difference to the original version is that the line
> > 
> > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, 
> > solidDevNum);
> > 
> > is removed. This somehow implies that this check is too restrictive. If 
> > this indeed is the case, then this might very well be a bug in libmtp.
> > 
> > I haved tried to find something in the net, especially since other 
> > mtp-clients (from other DEs) are said to work, but couldn't really find 
> > something useful for now...
> 
> Dominik Haumann wrote:
> Found something dating back to 2011: 
> https://sourceforge.net/p/libmtp/mailman/libmtp-discuss/?viewmonth=201101=21=flat
> Here it says:
> 
> One more thing. the mtp-probe did not work on older ubuntu's than 
> 10.10.
> Further investigating showed that it fails at 
> LIBMTP_Check_Specific_Device () only because libusb does not populate 
> the correct dev->devnum (i.e. usb device number.
> 
> However if I manually run mtp-probe, later after a few seconds of 
> device 
> plugged in, it works properly.
> 
> Looks like libusb takes a while to get the correct device number. Is 
> this a known libusb issue or something else?
> 
> Might it be that we are hit by this issue? According to the link, newer 
> versions of libusb should probably not have this issue.
> 
> Anyone familiar with this?

More on this, grepping the entire git repo of gvfs 
(https://github.com/GNOME/gvfs.git) shows that gvfs does not use 
LIBMTP_Check_Specific_Device() at all.
Similarly, grepping through simple-mtp-fs 
(https://github.com/phatina/simple-mtpfs) also shows no usage of 
LIBMTP_Check_Specific_Device().
However, both solutions use the other LIBMTP calls similarly to how kio-mtp 
does.

What if we really just omit this check. The worst thing that can happen is that 
we iterate over all device numbers and get no hit, which just takes a bit 
longer.

Question would be: Do we get too many devices, as Kai was saying? No idea, but 
this really solves the issue for many users, then this might well be worth a 
try.

Opinions?


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/#review93660
---


On March 16, 2016, 4:41 p.m., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127386/
> ---
> 
> (Updated March 16, 2016, 4:41 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
> 
> 
> Bugs: 325335
> https://bugs.kde.org/show_bug.cgi?id=325335
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp.
> 
> It seems the device is listed but dropped for some reason. This issues exists 
> for quite a long time (also in KDE 4.x), and some people provided this patch 
> (from bug #325335).
> 
> I personally cannot test this patch, as I don't own a Windows Phone.
> 
> However, given this patch works successfully for at least some users (see 
> also 
> https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/),
>  I think we at least should give it a try.
> 
> Adding group 'kdeframeworks' to reach a broader audience.
> 
> Would be cool to get a proper review for this patch, or even someone who owns 
> such a device!
> 
> 
> Diffs
> -
> 
>   mtp/devicecache.cpp 8c5c7cf 
> 
> Diff: https://git.reviewboard.kde.org/r/127386/diff/
> 
> 
> Testing
> ---
> 
> Compiles...
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/
---

(Updated March 16, 2016, 4:41 p.m.)

Review request for KDE Frameworks, David Faure and Philipp Schmidt.

Changes
---

Next version, which uses again only the
Solid::Device::listFromType(Solid::DeviceInterface::PortableMediaPlayer,
QString()).

Following the comments on
https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/
this still works compared to the unpatched version.

Bugs: 325335
https://bugs.kde.org/show_bug.cgi?id=325335

Repository: kio-extras

Description
---

Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp.

It seems the device is listed but dropped for some reason. This issues exists
for quite a long time (also in KDE 4.x), and some people provided this patch
(from bug #325335).

I personally cannot test this patch, as I don't own a Windows Phone.

However, given this patch works successfully for at least some users (see also
https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/),
I think we at least should give it a try.

Adding group 'kdeframeworks' to reach a broader audience.

Would be cool to get a proper review for this patch, or even someone who owns
such a device!

Diffs (updated)
-

mtp/devicecache.cpp 8c5c7cf

Diff: https://git.reviewboard.kde.org/r/127386/diff/

Testing
---

Compiles...

Thanks,

Dominik Haumann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 16, 2016, 11:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 309c64f5e90453c5253baf19e6c01759e8aa6f83 by Aleix Pol to 
branch master.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 18 Mar 2016 13:10:48 +
Build duration: 6 min 8 sec

CHANGE SET
Revision 4c9c4524f0f7f5ff564a4764eda414b598e0f38b by mail: (Add syntax 
highlighting for gcode)
  change: add src/syntax/data/gcode.xml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29940/46699 
(64%)CONDITIONAL 15500/21289 (73%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3941/4250 
(93%)CONDITIONAL 1882/3546 (53%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3154/3169 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1666/1803 
(92%)CONDITIONAL 1255/1560 (80%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1794/3179 
(56%)CONDITIONAL 1204/1614 (75%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 190/474 (40%)CONDITIONAL 
77/132 (58%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/925 (0%)CONDITIONAL 0/0 
(100%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1854/3271 
(57%)CONDITIONAL 1438/1982 (73%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 111/128 (87%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 190/229 
(83%)CONDITIONAL 144/178 (81%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 
55/73 (75%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/440 (38%)CONDITIONAL 
97/115 (84%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 
(100%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 933/1247 
(75%)CONDITIONAL 603/766 (79%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1537 (1%)CONDITIONAL 
7/8 (88%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 712/1072 
(66%)CONDITIONAL 292/408 (72%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 900/1389 
(65%)CONDITIONAL 519/675 (77%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 387/1332 (29%)CONDITIONAL 
205/328 (63%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 120/361 (33%)CONDITIONAL 
57/74 (77%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1672/2165 
(77%)CONDITIONAL 1034/1238 (84%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 54/72 (75%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 684/783 (87%)CONDITIONAL 
321/400 (80%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2544/3845 
(66%)CONDITIONAL 1244/1685 (74%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/664 (0%)CONDITIONAL 0/0 
(100%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3087/6128 
(50%)CONDITIONAL 1364/1835 (74%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2327/3135 
(74%)CONDITIONAL 1298/1651 (79%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/138 (0%)CONDITIONAL 0/0 
(100%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3254/3750 
(87%)CONDITIONAL 1851/2145 (86%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

2016-03-19 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/#review93633
---

Did you also check that on Wayland? There it is important to have certain 
things happen before the window is shown, e.g. the role should be set before 
the window is shown, but the platform window needs to be set already.

Best way might be to completely integrate with the PlatformSurface QEvent and 
track whether there is a native window. That way we would not need to rely on 
visible and force creation through winId.

- Martin Gräßlin

On March 17, 2016, 3:13 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127409/
> ---
> 
> (Updated March 17, 2016, 3:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Only update the properties that require a winId when visible, otherwise let 
> updateVisibility() take care about them.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp 7bb63c5 
> 
> Diff: https://git.reviewboard.kde.org/r/127409/diff/
> 
> 
> Testing
> ---
> 
> I don't get platform creations being forced on gdb.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 321 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/321/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 17 Mar 2016 17:30:33 +
Build duration: 2 min 16 sec

CHANGE SET
Revision 2661cd701c18ee17021de8bac5d05ccbf2f509eb by Marco Martin: (reintroduce 
busy property in Applet)
  change: edit src/scriptengines/qml/plasmoid/appletinterface.h
  change: edit src/plasma/private/applet_p.h
  change: edit src/plasma/applet.h
  change: edit src/plasma/applet.cpp
  change: edit src/scriptengines/qml/plasmoid/appletinterface.cpp
  change: edit src/plasma/private/applet_p.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.dialognativetestFailed: 
TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 57/90 (63%)CLASSES 57/90 (63%)LINE 3828/8931 
(43%)CONDITIONAL 1993/3145 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 552/578 
(96%)CONDITIONAL 385/664 (58%)
src.declarativeimports.core
FILES 4/7 (57%)CLASSES 4/7 (57%)LINE 315/832 (38%)CONDITIONAL 
150/232 (65%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1650/3676 
(45%)CONDITIONAL 866/1308 (66%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 877/1746 
(50%)CONDITIONAL 367/549 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 434/1804 
(24%)CONDITIONAL 225/392 (57%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

2016-03-19 Thread Andreas Sturmlechner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93640
---



works for me, thanks!

- Andreas Sturmlechner


On March 17, 2016, 9:37 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> ---
> 
> (Updated March 17, 2016, 9:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
> 
> 
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix crash in rename dialog
> 
> ResizePanels must only be called in case of overwrite, all other cases 
> violate the preconditions.
> 
> @Andreas: Can you please try the patch?
> 
> 
> Diffs
> -
> 
>   src/widgets/renamedialog.cpp 2d456c7 
> 
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
> 
> 
> Testing
> ---
> 
> Yes, I tried it by overwriting a file with the same file and with a different 
> file -> no crash :)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-19 Thread Thomas Lübking



> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.
> 
> Dominik Haumann wrote:
> Unfortunatey, also does not work... The popup stays, does not close, and 
> typing does not insert text into the KLineEdit anymore (we don't see any 
> blinking cursor).

i did not mean "alongside Qt::Popup" - if you need to hint this as tooltip for 
somewhat useful behavior, either the class or QWidget/5 is seriously fucked up.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On März 19, 2016, Mittag, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, Mittag)
> 
> 
> Review request for KDE Frameworks, kwin and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows



> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote:
> > "Loose focus" is the complete wrong concept anyway.
> > It makes kickoff and various other plasmashell elements barely usable w/ 
> > any but the click-to-focus policy (implicit hide)
> > 
> > Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should 
> > be Qt::BypassWindowManagerHint anyway)
> > 
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
> > QComboBox dropdown. May point an implementation weakeness/bug in this class.

Unfortunatey, also does not work... The popup stays, does not close, and typing 
does not insert text into the KLineEdit anymore (we don't see any blinking 
cursor).


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---


On März 19, 2016, Mittag, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, Mittag)
> 
> 
> Review request for KDE Frameworks, kwin and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125965: Add declarative plugin to KHolidays


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/
---

(Updated March 16, 2016, 9:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and John Layt.


Changes
---

Submitted with commit e311a7a845a35a4e82e786cdd4d07592624f6741 by Martin 
Klapetek to branch master.


Repository: kholidays


Description
---

For now it contains just the model of holiday regions
which will be used in the Plasma calendar events
configuration.


Diffs
-

  CMakeLists.txt e8b7970 
  src/CMakeLists.txt c067b6c 
  src/declarative/CMakeLists.txt PRE-CREATION 
  src/declarative/holidayregionsmodel.h PRE-CREATION 
  src/declarative/holidayregionsmodel.cpp PRE-CREATION 
  src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION 
  src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION 
  src/declarative/qmldir PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125965/diff/


Testing
---

Applet configuration contains proper list of available
holiday regions.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127380: More conservative approach to saving some disk accesses



> On March 17, 2016, 8:57 a.m., Kevin Funk wrote:
> > Since you asked for review: I don't know the code enough to judge. 
> > Generally I'd say "yes".
> > 
> > Does `iconPath(..., KIconLoader::MatchBest)` return results you'd have 
> > received with `iconPath(..., KIconLoader::MatchExact)`?

I haven't seen differences, tests still pass. `MatchExact` is a more restricted 
version of `MatchBest`.

I'd say that if there's a case that currently doesn't return the best match 
when passing `KIconLoader::MatchBest`, then we need to fix the algorithm. My 
impression is that `MatchExact` pass was introduced as an optimization, 
although in practice it doesn't act as such.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127380/#review93636
---


On March 15, 2016, 2:52 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127380/
> ---
> 
> (Updated March 15, 2016, 2:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> My previous approach to KIconThemes felt like a dead end, I decided I'll take 
> a more conservative approach. Here's a first step.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 61e81f6 
>   autotests/kiconloader_benchmark.cpp PRE-CREATION 
>   src/kiconloader.cpp 75ab482 
>   src/kicontheme.cpp 0996054 
> 
> Diff: https://git.reviewboard.kde.org/r/127380/diff/
> 
> 
> Testing
> ---
> 
> Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 
> before= 17% less QFile::exists
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 16, 2016, 11:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 309c64f5e90453c5253baf19e6c01759e8aa6f83 by Aleix Pol to 
branch master.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

2016-03-19 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/#review93629
---



Thanks, this fixes building of plasma-workspace on my system.

- Christoph Feck


On March 17, 2016, 12:16 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127405/
> ---
> 
> (Updated March 17, 2016, 12:16 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Uses `"quotes"` rather than `` to include a neigbour header file.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 99fcf1b 
>   src/plasmaquick/configmodel.h ed2df2e 
>   src/plasmaquick/configview.h 5ac9c26 
>   src/plasmaquick/containmentview.h 4bdc1de 
>   src/plasmaquick/dialog.h 63efa04 
>   src/plasmaquick/packageurlinterceptor.h 343e311 
>   src/plasmaquick/shellpluginloader.h bdc13be 
>   src/plasmaquick/view.h b59271d 
> 
> Diff: https://git.reviewboard.kde.org/r/127405/diff/
> 
> 
> Testing
> ---
> 
> Aparently it was a problem on some systems. It was eventually fixed for me, 
> so I thought I was crazy. This should be the fix nevertheless (assuming 
> include directories are being exported properly).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127415: Set the appropriate feature test macro definitions to enable building on musl libc

2016-03-19 Thread Wiktor W Brodlo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127415/
---

Review request for KDE Frameworks.


Repository: kdesu


Description
---

The file kdesu_stub.c calls the following functions: putenv, unsetenv, 
initgroups, mkstemp, popen, pclose. Looking at the man pages, this set requires 
the _XOPEN_SOURCE and _BSD_SOURCE feature test macros to be defined. This patch 
passes these definitions to the compiler. This enables kdesu to be built 
against the musl libc, which is very strict about these things.


Diffs
-

  src/CMakeLists.txt 73ff883 

Diff: https://git.reviewboard.kde.org/r/127415/diff/


Testing
---

Without the patch, the build fails as follows:

```
src/kdesu_stub.c: In function ‘xsetenv’:
src/kdesu_stub.c:136:5: error: implicit declaration of function ‘putenv’ 
[-Werror=implicit-function-declaration]
 return putenv(s); /* yes: no free()! */
 ^
src/kdesu_stub.c: In function ‘main’:
src/kdesu_stub.c:258:9: error: implicit declaration of function ‘unsetenv’ 
[-Werror=implicit-function-declaration]
 unsetenv("LC_ALL");
 ^
src/kdesu_stub.c:301:9: error: implicit declaration of function ‘initgroups’ 
[-Werror=implicit-function-declaration]
 if (initgroups(pw->pw_name, pw->pw_gid) == -1) {
 ^
src/kdesu_stub.c:331:13: error: implicit declaration of function ‘mkstemp’ 
[-Werror=implicit-function-declaration]
 fd2 = mkstemp(xauthority);
 ^
src/kdesu_stub.c:342:13: error: implicit declaration of function ‘popen’ 
[-Werror=implicit-function-declaration]
 fout = popen("xauth >/dev/null 2>&1", "w");
 ^
src/kdesu_stub.c:342:18: warning: assignment makes pointer from integer without 
a cast
 fout = popen("xauth >/dev/null 2>&1", "w");
  ^
src/kdesu_stub.c:348:13: error: implicit declaration of function ‘pclose’ 
[-Werror=implicit-function-declaration]
 pclose(fout);
 ^
```

With the patch, the build passes and kdesu works.


Thanks,

Wiktor W Brodlo

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-19 Thread Thomas Lübking


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
---



"Loose focus" is the complete wrong concept anyway.
It makes kickoff and various other plasmashell elements barely usable w/ any 
but the click-to-focus policy (implicit hide)

Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should be 
Qt::BypassWindowManagerHint anyway)

PS: it's rather worrysome that Qt::Popup fails since it *is* set for the 
QComboBox dropdown. May point an implementation weakeness/bug in this class.

- Thomas Lübking


On März 19, 2016, Mittag, Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127424/
> ---
> 
> (Updated März 19, 2016, Mittag)
> 
> 
> Review request for KDE Frameworks, kwin and Marco Martin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
> were change from Qt::ToolTip to Qt::Window.
> 
> As consequence, the completion popup of the Kate command line gets a full 
> window decoration, which is obviously wrong, see attached screenshot.
> 
> Changing the type to Qt::Popup shows the proper popup, but key presses are 
> not forwarded, so typing is not possible, and additionally, on losing focus 
> the popup keeps staying open.
> Therefore, this patch reverts the type back to Qt::ToolTip.
> 
> Better fixes are of course welcome ;) Any ideas?
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.cpp 005aff8 
> 
> Diff: https://git.reviewboard.kde.org/r/127424/diff/
> 
> 
> Testing
> ---
> 
> Works on Windows as expected.
> 
> 
> File Attachments
> 
> 
> Completion Popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

2016-03-19 Thread Kevin Funk

On Wednesday, March 16, 2016 5:59:30 PM CET René J. V. Bertin wrote:
> Aleix Pol wrote:
> > https://code.qt.io/cgit/qt/qtwebkit.git/
> 
> Right, thanks, I'd seen that one too (there's also a clone on github but it
> isn't clear how recent/unmodified that one is).
> 
> What I didn't yet see is if there's a way to do tarball fetches from
> code.qt.io that correspond to a specific commit, tag or release (purely for
> convenience in a packaging script)?

I think qt-developm...@qt-project.org is a better fit for this question.

Cheers,
Kevin

> R.
> 
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93622
---


Ship it!




Ship It!

- David Faure


On March 11, 2016, 4:26 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> ---
> 
> (Updated March 11, 2016, 4:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> I notice a kwalletd5 with "-session ." in its command line started on my 
> desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let 
> session manager to restore it.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> ---
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 254 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/254/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 19 Mar 2016 11:23:52 +
Build duration: 4 min 55 sec

CHANGE SET
Revision bf37e9aa27a2321f4a6ce7188a0901fabd47c962 by emmanuelpescosta099: (Fix 
crash in rename dialog)
  change: edit src/widgets/renamedialog.cpp


JUNIT RESULTS

Name: (root) Failed: 4 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
49 test(s)Failed: TestSuite.kiocore-kfileitemtestFailed: 
TestSuite.kiofilewidgets-kurlnavigatortestFailed: 
TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 17/17 (100%)FILES 247/322 (77%)CLASSES 247/322 (77%)LINE 26104/49829 
(52%)CONDITIONAL 14049/21987 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7408/7742 
(96%)CONDITIONAL 4013/7390 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/117 (80%)CLASSES 94/117 (80%)LINE 7676/14146 
(54%)CONDITIONAL 4033/5596 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2274/7591 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/844 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1840/3852 
(48%)CONDITIONAL 1315/1948 (68%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 643/804 (80%)CONDITIONAL 
603/760 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1183 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 379/600 (63%)CONDITIONAL 
276/400 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.widgets
FILES 28/62 (45%)CLASSES 28/62 (45%)LINE 2564/10657 
(24%)CONDITIONAL 1234/1826 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 269 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/269/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 19 Mar 2016 11:23:52 +
Build duration: 4 min 33 sec

CHANGE SET
Revision bf37e9aa27a2321f4a6ce7188a0901fabd47c962 by emmanuelpescosta099: (Fix 
crash in rename dialog)
  change: edit src/widgets/renamedialog.cpp


JUNIT RESULTS

Name: (root) Failed: 4 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
49 test(s)Failed: TestSuite.kiocore-kfileitemtestFailed: 
TestSuite.kiofilewidgets-kurlnavigatortestFailed: 
TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 17/17 (100%)FILES 247/322 (77%)CLASSES 247/322 (77%)LINE 26102/49827 
(52%)CONDITIONAL 14045/21987 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7406/7740 
(96%)CONDITIONAL 4013/7390 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/117 (80%)CLASSES 94/117 (80%)LINE 7676/14146 
(54%)CONDITIONAL 4030/5596 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2274/7591 
(30%)CONDITIONAL 910/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/844 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1840/3852 
(48%)CONDITIONAL 1315/1948 (68%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 643/804 (80%)CONDITIONAL 
603/760 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1183 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 379/600 (63%)CONDITIONAL 
276/400 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.widgets
FILES 28/62 (45%)CLASSES 28/62 (45%)LINE 2564/10657 
(24%)CONDITIONAL 1234/1826 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Raising Qt requirement to Qt 5.4

2016-03-19 Thread Ivan Čukić

Hi all,

IIRC, the last time we talked about this we decided (I'll try to find
the e-mail thread when I get back home, IIRC the conclusion was by
dfaure) on KF5 always support the two last versions of Qt. This was
decided so that we do not need to have threads like these every time
we want to increase the Qt version.

Cheers,
Ivan
Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76


On 18 March 2016 at 19:39, Albert Astals Cid  wrote:
> El dimecres, 16 de març de 2016, a les 13:13:36 CET, Martin Graesslin va
> escriure:
>> Hi all,
>>
>> with todays release of Qt 5.6 I suggest that we raise the minimum Qt version
>> requirement to 5.4. This would mean the latest three releases are
>> supported.
>>
>> The important new features in Qt 5.4 in my opinion for frameworks
>> development are:
>> * QSignalSpy(const QObject *object, PointerToMemberFunction signal)
>> * Q_LOGGING_CATEGORY(name, string, msgType)
>>
>> Which are already used in many frameworks and currently ifdefed.
>>
>> Opinions?
>
> Is there anything else? These two seem "nice to have" but nothing that would
> hinder development of the frameworks.
>
> Cheers,
>   Albert
>
>>
>> Best Regards
>> Martin
>
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127424: KCompletionBox popup gets full window decoration on Windows


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/
---

Review request for KDE Frameworks, kwin and Marco Martin.


Repository: kcompletion


Description
---

In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags 
were change from Qt::ToolTip to Qt::Window.

As consequence, the completion popup of the Kate command line gets a full 
window decoration, which is obviously wrong, see attached screenshot.

Changing the type to Qt::Popup shows the proper popup, but key presses are not 
forwarded, so typing is not possible, and additionally, on losing focus the 
popup keeps staying open.
Therefore, this patch reverts the type back to Qt::ToolTip.

Better fixes are of course welcome ;) Any ideas?


Diffs
-

  src/kcompletionbox.cpp 005aff8 

Diff: https://git.reviewboard.kde.org/r/127424/diff/


Testing
---

Works on Windows as expected.


File Attachments


Completion Popup
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png


Thanks,

Dominik Haumann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125965: Add declarative plugin to KHolidays


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/#review93625
---



Ok so I shipped this because I realized KHolidays is still part
of KDE Applications and not Frameworks and KDE apps have dependency
freeze tonight, so I'm pushing this now in order to have the events
done in Plasma 5.7.

The QByteArrayLiterals can still be fixed once I get the answer
to the issue.

- Martin Klapetek


On March 16, 2016, 10:24 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125965/
> ---
> 
> (Updated March 16, 2016, 10:24 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> ---
> 
> For now it contains just the model of holiday regions
> which will be used in the Plasma calendar events
> configuration.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e8b7970 
>   src/CMakeLists.txt c067b6c 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/holidayregionsmodel.h PRE-CREATION 
>   src/declarative/holidayregionsmodel.cpp PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125965/diff/
> 
> 
> Testing
> ---
> 
> Applet configuration contains proper list of available
> holiday regions.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93651
---



Change looks good.

Would it be possible to get a test?

- Aleix Pol Gonzalez


On March 17, 2016, 10:37 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> ---
> 
> (Updated March 17, 2016, 10:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
> 
> 
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix crash in rename dialog
> 
> ResizePanels must only be called in case of overwrite, all other cases 
> violate the preconditions.
> 
> @Andreas: Can you please try the patch?
> 
> 
> Diffs
> -
> 
>   src/widgets/renamedialog.cpp 2d456c7 
> 
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
> 
> 
> Testing
> ---
> 
> Yes, I tried it by overwriting a file with the same file and with a different 
> file -> no crash :)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

On Wed, Mar 16, 2016 at 12:52 PM, René J.V.  wrote:

> Hi,
>
> Is there a page/site somewhere that outlines the current status of Qt
> 5.6/KF5 compatibility, notably as far as QtWebkit is concerned?
>
> A quick search (KF5 qt5.6 qtwebkit) didn't turn up any particularly useful
> hits in the first page or so, other than that one can apparently still
> build QtWebkit 5.5.1 . And that the component has apparently been> replaced
> by QtWebEngine, which I presume means KF5 will soon migrate to that
> component?
> >
>

There was a thread "Policy regarding QtWebKit and QtScript" on
kde-core-devel a while ago.
http://kde.6490.n7.nabble.com/Policy-regarding-QtWebKit-and-QtScript-td1619988.html
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves



> On Feb. 27, 2016, 11:11 a.m., David Faure wrote:
> > It seems weird to have a setting for FTP on one side, and a setting for 
> > "SMB and SFTP and any slave where this is implemented in the future".
> > I understand that it was the path of least code changes, but I fear this 
> > creates an inconsistency which will lead to more bug reports down the line.
> > Either we should just have the global option, or it should be per protocol.
> > 
> > Can you tell me more about your use case for this option, so we can 
> > understand better the reason for all this?
> > 
> > In general I find that .part is good, it 1) tells me that the file isn't 
> > ready to be used yet, 2) enables the resuming feature in case the 
> > connection drops.
> > 
> > I can very well imagine that some servers disable renaming and then the 
> > feature breaks the upload in the first place. Is this is the issue here?
> > But then it's not even per-protocol, it's per-protocol-and-host which 
> > might lead to an overblown configuration dialog. But the alternative is for 
> > the user to turn off some global setting (like the one you just added) and 
> > then (forget to) turn it back on. Right? :-)
> 
> Martin Kostolný wrote:
> Sorry for my late response. I agree with every word you said, David. :-) 
> Thanks for taking your time to discuss this.
> 
> My use-case is indeed the (one specific) remote SMB server has problems 
> with renaming and it breaks the upload. So I'd like to offer an option to 
> disable this otherwise very useful ".part" functionality.
> 
> I agree that global-mark-partial-option is not a good idea but I think we 
> should come up with something. So here is my first proposal: I'm up for the 
> overblown configuration dialog which would be hidden behind "Avanced upload 
> options..." button placed in Connection Preferences. Here is one wireframe 
> (warning - very unfinished! I had little time...): 
> https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options 
> would be moved to mentioned configuration dialog as well (to their dedicated 
> tab).
> 
> As I'm looking to the configuration dialog it is really overblown. Second 
> proposal: maybe we could use an entirelly different approach like a runtime 
> option to temporarily but globally disable MarkPartial. Something similar to 
> "Enable Power Management" button available in expanded battery plasmoid.
> 
> Martin Kostolný wrote:
> One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to 
> be used (in KIO::file_copy(..) etc.) in various file managers. That way we 
> can delegate this settings to be picked up by file managers like krusader, 
> dolphin or other tools using KIO.
> 
> David Faure wrote:
> We can't delegate the setting to the app. All KIO-based apps use this, 
> not just file managers. If you save a document in calligra onto an FTP 
> server, kio_ftp is used, and needs to know whether to use MarkPartial.
> 
> Not sure if I prefer the global option switched on/off temporarily, or 
> the precise per-host per-protocol setting. Maybe the VDG (visual design 
> group) has an opinion and/or other ideas...
> 
> Martin Kostolný wrote:
> Sorry about this rookie question - what is the right procedure to present 
> this problem to VDG? Is there such a group to add as reviewers or should I 
> ask the question on a forum?

https://vdesign.kde.org/how.html says forum.kde.org


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127154/#review92828
---


On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127154/
> ---
> 
> (Updated Feb. 24, 2016, 11:52 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson, David Faure, and Marco 
> Martin.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> We have an option called "Mark partially uploaded files" in System Settings 
> -> Network: Settings -> Connection Preferences -> FTP Options. This one 
> toggles adding ".part" extension to partially transferred files through FTP 
> protocol.
> 
> Other KIO slaves (such as SMB, SFTP) has already working code that supports 
> MarkPartial property read from kioslaverc. This patch is just exposing the 
> property from GUI, specifically I've created "Global Options" section (with 
> one checkbox) above existing "FTP Options" section.
> 
> Originally I've created a bug report for this: 
> https://bugs.kde.org/show_bug.cgi?id=359636
> 
> 
> Diffs
> -
> 
>   src/kcms/kio/kioslave.kcfg d34b691 
>   src/kcms/kio/netpref.h f7a0abc 
>   src/kcms/kio/netpref.cpp 24273a3 
> 
> Diff:

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127398/#review93674
---




src/knotification.cpp (line 396)


what if id == 0 ?


- David Edmundson


On March 16, 2016, 8:23 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127398/
> ---
> 
> (Updated March 16, 2016, 8:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Adds basic set of unit tests including fake notifications server.
> 
> This helped uncover and fix these issues:
> 
> * Calling close() on KNotification that was not "sent" would not emit 
> closed() and would not delete it
> * Closing a notification can delete the KNotification object prematurely
> * Invoking an action leads to unnecessary dbus roundtrip
> * Invoking an action would fail to properly close and delete the 
> KNotification object
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6d09051 
>   autotests/CMakeLists.txt PRE-CREATION 
>   autotests/fake_notifications_server.h PRE-CREATION 
>   autotests/fake_notifications_server.cpp PRE-CREATION 
>   autotests/knotification_test.cpp PRE-CREATION 
>   autotests/knotifications5/qttest.notifyrc PRE-CREATION 
>   autotests/qtest_dbus.h PRE-CREATION 
>   src/knotification.cpp 17b0be2 
>   src/knotificationmanager.cpp e80d48c 
>   src/knotificationplugin.cpp acf964c 
>   src/notifybypopup.cpp b9489c1 
> 
> Diff: https://git.reviewboard.kde.org/r/127398/diff/
> 
> 
> Testing
> ---
> 
> Unit tests all pass.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

2016-03-19 Thread Emmanuel Pescosta


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/
---

(Updated March 19, 2016, 11:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.


Changes
---

Submitted with commit bf37e9aa27a2321f4a6ce7188a0901fabd47c962 by Emmanuel 
Pescosta to branch master.


Bugs: 360488
https://bugs.kde.org/show_bug.cgi?id=360488


Repository: kio


Description
---

Fix crash in rename dialog

ResizePanels must only be called in case of overwrite, all other cases violate 
the preconditions.

@Andreas: Can you please try the patch?


Diffs
-

  src/widgets/renamedialog.cpp 2d456c7 

Diff: https://git.reviewboard.kde.org/r/127410/diff/


Testing
---

Yes, I tried it by overwriting a file with the same file and with a different 
file -> no crash :)


Thanks,

Emmanuel Pescosta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 323 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/323/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 17 Mar 2016 17:30:33 +
Build duration: 2 min 52 sec

CHANGE SET
Revision 2661cd701c18ee17021de8bac5d05ccbf2f509eb by Marco Martin: (reintroduce 
busy property in Applet)
  change: edit src/plasma/applet.cpp
  change: edit src/scriptengines/qml/plasmoid/appletinterface.h
  change: edit src/plasma/private/applet_p.h
  change: edit src/plasma/private/applet_p.cpp
  change: edit src/plasma/applet.h
  change: edit src/scriptengines/qml/plasmoid/appletinterface.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 48/86 (56%)CLASSES 48/86 (56%)LINE 2930/8723 
(34%)CONDITIONAL 1523/2419 (63%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 511/532 
(96%)CONDITIONAL 371/636 (58%)
src.declarativeimports.core
FILES 1/7 (14%)CLASSES 1/7 (14%)LINE 60/832 (7%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1529/3681 
(42%)CONDITIONAL 790/1244 (64%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 827/1679 
(49%)CONDITIONAL 343/513 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1694 (0%)CONDITIONAL 
2/4 (50%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)



> On March 17, 2016, 12:29 p.m., Aleix Pol Gonzalez wrote:
> > Change looks good.
> > 
> > Would it be possible to get a test?
> 
> Emmanuel Pescosta wrote:
> > Would it be possible to get a test?
> 
> autotest (is it allowed to show a dialog in KF autotests?) or more like 
> kpropertiesdialogtest?
> 
> David Faure wrote:
> Yes ideally this would be an autotest. We have autotests showing up 
> dialogs already, no problem there. What's a bit tricky is the introspection 
> to find the buttons and "click" them. Or just calling reject() would have 
> done the job for this particular crash (after some event processing).
> 
> Emmanuel Pescosta wrote:
> > We have autotests showing up dialogs already
> 
> Ok great :)
> 
> Is it ok for everyone when I push this fix now, so that downstream can 
> apply it to their KF 5.20 release, and provide the test next week? I need to 
> dive into the introspection stuff first, so this will need some time ;)

Yes (hence the Ship It). Thanks!


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93651
---


On March 17, 2016, 9:37 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> ---
> 
> (Updated March 17, 2016, 9:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
> 
> 
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix crash in rename dialog
> 
> ResizePanels must only be called in case of overwrite, all other cases 
> violate the preconditions.
> 
> @Andreas: Can you please try the patch?
> 
> 
> Diffs
> -
> 
>   src/widgets/renamedialog.cpp 2d456c7 
> 
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
> 
> 
> Testing
> ---
> 
> Yes, I tried it by overwriting a file with the same file and with a different 
> file -> no crash :)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Raising Qt requirement to Qt 5.4

2016-03-19 Thread Albert Astals Cid

El dimecres, 16 de març de 2016, a les 13:13:36 CET, Martin Graesslin va 
escriure:
> Hi all,
> 
> with todays release of Qt 5.6 I suggest that we raise the minimum Qt version
> requirement to 5.4. This would mean the latest three releases are
> supported.
> 
> The important new features in Qt 5.4 in my opinion for frameworks
> development are:
> * QSignalSpy(const QObject *object, PointerToMemberFunction signal)
> * Q_LOGGING_CATEGORY(name, string, msgType)
> 
> Which are already used in many frameworks and currently ifdefed.
> 
> Opinions?

Is there anything else? These two seem "nice to have" but nothing that would 
hinder development of the frameworks.

Cheers,
  Albert

> 
> Best Regards
> Martin


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

2016-03-19 Thread Emmanuel Pescosta



> On March 17, 2016, 1:29 p.m., Aleix Pol Gonzalez wrote:
> > Change looks good.
> > 
> > Would it be possible to get a test?
> 
> Emmanuel Pescosta wrote:
> > Would it be possible to get a test?
> 
> autotest (is it allowed to show a dialog in KF autotests?) or more like 
> kpropertiesdialogtest?
> 
> David Faure wrote:
> Yes ideally this would be an autotest. We have autotests showing up 
> dialogs already, no problem there. What's a bit tricky is the introspection 
> to find the buttons and "click" them. Or just calling reject() would have 
> done the job for this particular crash (after some event processing).

> We have autotests showing up dialogs already

Ok great :)

Is it ok for everyone when I push this fix now, so that downstream can apply it 
to their KF 5.20 release, and provide the test next week? I need to dive into 
the introspection stuff first, so this will need some time ;)


- Emmanuel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93651
---


On March 17, 2016, 10:37 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> ---
> 
> (Updated March 17, 2016, 10:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
> 
> 
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix crash in rename dialog
> 
> ResizePanels must only be called in case of overwrite, all other cases 
> violate the preconditions.
> 
> @Andreas: Can you please try the patch?
> 
> 
> Diffs
> -
> 
>   src/widgets/renamedialog.cpp 2d456c7 
> 
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
> 
> 
> Testing
> ---
> 
> Yes, I tried it by overwriting a file with the same file and with a different 
> file -> no crash :)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/
---

(Updated March 17, 2016, 1:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 0e9976afb1c4442819c9ca2cea9d2c50f4a53b3c by Aleix Pol to 
branch master.


Repository: plasma-framework


Description
---

Uses `"quotes"` rather than `` to include a neigbour header file.


Diffs
-

  src/plasmaquick/appletquickitem.h 99fcf1b 
  src/plasmaquick/configmodel.h ed2df2e 
  src/plasmaquick/configview.h 5ac9c26 
  src/plasmaquick/dialog.h 63efa04 
  src/plasmaquick/packageurlinterceptor.h 343e311 
  src/plasmaquick/shellpluginloader.h bdc13be 
  src/plasmaquick/view.h b59271d 

Diff: https://git.reviewboard.kde.org/r/127405/diff/


Testing
---

Aparently it was a problem on some systems. It was eventually fixed for me, so 
I thought I was crazy. This should be the fix nevertheless (assuming include 
directories are being exported properly).


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)



> On March 17, 2016, 12:29 p.m., Aleix Pol Gonzalez wrote:
> > Change looks good.
> > 
> > Would it be possible to get a test?
> 
> Emmanuel Pescosta wrote:
> > Would it be possible to get a test?
> 
> autotest (is it allowed to show a dialog in KF autotests?) or more like 
> kpropertiesdialogtest?

Yes ideally this would be an autotest. We have autotests showing up dialogs 
already, no problem there. What's a bit tricky is the introspection to find the 
buttons and "click" them. Or just calling reject() would have done the job for 
this particular crash (after some event processing).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93651
---


On March 17, 2016, 9:37 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> ---
> 
> (Updated March 17, 2016, 9:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
> 
> 
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix crash in rename dialog
> 
> ResizePanels must only be called in case of overwrite, all other cases 
> violate the preconditions.
> 
> @Andreas: Can you please try the patch?
> 
> 
> Diffs
> -
> 
>   src/widgets/renamedialog.cpp 2d456c7 
> 
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
> 
> 
> Testing
> ---
> 
> Yes, I tried it by overwriting a file with the same file and with a different 
> file -> no crash :)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93710
---


Ship it!




Oops, thanks for the fix.

- David Faure


On March 17, 2016, 9:37 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> ---
> 
> (Updated March 17, 2016, 9:37 a.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
> 
> 
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix crash in rename dialog
> 
> ResizePanels must only be called in case of overwrite, all other cases 
> violate the preconditions.
> 
> @Andreas: Can you please try the patch?
> 
> 
> Diffs
> -
> 
>   src/widgets/renamedialog.cpp 2d456c7 
> 
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
> 
> 
> Testing
> ---
> 
> Yes, I tried it by overwriting a file with the same file and with a different 
> file -> no crash :)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one



> On Март 12, 2016, 5:07 след обяд, Christoph Feck wrote:
> > Can someone confirm the issue is still present with Qt 5.6?
> > 
> > Unless it is, I suggest to not work around the Qt bug, because the release 
> > of Qt 5.6 is imminent and this fix does not reach our users earlier.
> 
> Luigi Toscano wrote:
> Don't we still support older version of Qt?

I can confirm this patch is *NOT* needed on Qt 5.6, it works correct.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127353/#review93449
---


On Март 12, 2016, 4:53 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127353/
> ---
> 
> (Updated Март 12, 2016, 4:53 след обяд)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 358977
> https://bugs.kde.org/show_bug.cgi?id=358977
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> QAction->setVisible(false) not work in init function, adding timer to trigger 
> visability
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.cpp 72748d6 
>   src/kpassworddialog.cpp 082929c 
> 
> Diff: https://git.reviewboard.kde.org/r/127353/diff/
> 
> 
> Testing
> ---
> 
> Or we can make action disabled, looks candy.
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/0eb3f420-553f-497e-806b-15a373bdbe32__Screenshot_20160312_110707.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/2feb37c4-143f-4560-8b97-963b2f4f1737__Screenshot_20160312_111731.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 322 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/322/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 19 Mar 2016 08:04:24 +
Build duration: 2 min 54 sec

CHANGE SET
Revision 28b4400da8481251084ac38b26b4347703a3ab54 by nowrep: (Dialog: Set 
SkipTaskbar/Pager states before showing window)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.dialognativetestFailed: 
TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 57/90 (63%)CLASSES 57/90 (63%)LINE 3833/8932 
(43%)CONDITIONAL 1995/3147 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 552/578 
(96%)CONDITIONAL 385/664 (58%)
src.declarativeimports.core
FILES 4/7 (57%)CLASSES 4/7 (57%)LINE 315/832 (38%)CONDITIONAL 
150/232 (65%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1650/3676 
(45%)CONDITIONAL 866/1308 (66%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 881/1746 
(50%)CONDITIONAL 369/551 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 435/1805 
(24%)CONDITIONAL 225/392 (57%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

2016-03-19 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/#review93649
---




src/plasmaquick/appletquickitem.h (line 31)


they're installed headers, so i think it should be
#include 


- Marco Martin


On March 17, 2016, 12:16 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127405/
> ---
> 
> (Updated March 17, 2016, 12:16 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Uses `"quotes"` rather than `` to include a neigbour header file.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 99fcf1b 
>   src/plasmaquick/configmodel.h ed2df2e 
>   src/plasmaquick/configview.h 5ac9c26 
>   src/plasmaquick/containmentview.h 4bdc1de 
>   src/plasmaquick/dialog.h 63efa04 
>   src/plasmaquick/packageurlinterceptor.h 343e311 
>   src/plasmaquick/shellpluginloader.h bdc13be 
>   src/plasmaquick/view.h b59271d 
> 
> Diff: https://git.reviewboard.kde.org/r/127405/diff/
> 
> 
> Testing
> ---
> 
> Aparently it was a problem on some systems. It was eventually fixed for me, 
> so I thought I was crazy. This should be the fix nevertheless (assuming 
> include directories are being exported properly).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127326/
---

(Updated Март 16, 2016, 11:33 след обяд)


Status
--

This change has been discarded.


Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and Martin 
Klapetek.


Repository: knotifications


Description
---

If KNotification is not notified, he don't ref() notification, if call close() 
on it cause a leak, emu closed() is not triggered.
https://git.reviewboard.kde.org/r/127318/


Diffs
-

  src/knotification.cpp 17b0be2 

Diff: https://git.reviewboard.kde.org/r/127326/diff/


Testing
---

No real test, just blame me if i'm not right.


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

Boudhayan Gupta wrote:

Sorry, I've been overlooking this thread completely (been going through a bit 
of 
a rough patch in life).

> 
> CC="gcc -DWHATEVER_DEFINE" cmake ...
> 
> It really should be as simple as that.

Yeah, except that this would very likely apply too:

> There's also an interaction with the build system I'm targeting; not really 
relevant on here but it does make it less trivial to rely on settings passed 
through the environment.

I've also done this kind of thing in the past when using CFLAGS or CXXFLAGS 
didn't have the intended effect. YMMV, and I cannot recall if I ever tried this 
with cmake, but I've learned to avoid this approach (or use a wrapper that adds 
the desired options) because I've seen a bit too many cases where something 
would fail during the initial compiler tests.

That build system I'm targeting (indeed, MacPorts) would apply the setting in 
one of its "header files" that provide the basic settings for any number of so-
called "ports" for packages that are to be built with those settings. I won't 
be 
the only one developing such ports, so I'm looking for something that's as 
robust as possible against operator oversight.

I realise this probably doesn't make much sense for most of you. Suffice it to 
say that things would have been really easier if cmake had a way to add 
elements 
to its variables via the command line.

R.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127405: Make sure PlasmaQuick export file is properly found


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Uses `"quotes"` rather than `` to include a neigbour header file.


Diffs
-

  src/plasmaquick/appletquickitem.h 99fcf1b 
  src/plasmaquick/configmodel.h ed2df2e 
  src/plasmaquick/configview.h 5ac9c26 
  src/plasmaquick/containmentview.h 4bdc1de 
  src/plasmaquick/dialog.h 63efa04 
  src/plasmaquick/packageurlinterceptor.h 343e311 
  src/plasmaquick/shellpluginloader.h bdc13be 
  src/plasmaquick/view.h b59271d 

Diff: https://git.reviewboard.kde.org/r/127405/diff/


Testing
---

Aparently it was a problem on some systems. It was eventually fixed for me, so 
I thought I was crazy. This should be the fix nevertheless (assuming include 
directories are being exported properly).


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 322 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/322/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 17 Mar 2016 12:40:31 +
Build duration: 2 min 43 sec

CHANGE SET
Revision c23f2415bb5726297e49785f18644dd17d1b38d7 by aleixpol: (Make it 
possible for an applet to offer a test object)
  change: edit src/plasmaquick/private/appletquickitem_p.h
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasma/private/packages.cpp
  change: edit src/plasmaquick/appletquickitem.h
Revision 309c64f5e90453c5253baf19e6c01759e8aa6f83 by aleixpol: (Dont 
import an nonexistent layout)
  change: edit src/plasma/corona.cpp
Revision 0e9976afb1c4442819c9ca2cea9d2c50f4a53b3c by aleixpol: (Make sure 
PlasmaQuick export file is properly found)
  change: edit src/plasmaquick/configview.h
  change: edit src/plasmaquick/packageurlinterceptor.h
  change: edit src/plasmaquick/shellpluginloader.h
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/view.h
  change: edit src/plasmaquick/dialog.h
  change: edit src/plasmaquick/configmodel.h


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 48/86 (56%)CLASSES 48/86 (56%)LINE 2932/8716 
(34%)CONDITIONAL 1524/2421 (63%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 509/532 
(96%)CONDITIONAL 371/636 (58%)
src.declarativeimports.core
FILES 1/7 (14%)CLASSES 1/7 (14%)LINE 60/832 (7%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1529/3674 
(42%)CONDITIONAL 790/1244 (64%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 831/1679 
(49%)CONDITIONAL 344/515 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1694 (0%)CONDITIONAL 
2/4 (50%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 320 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/320/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 17 Mar 2016 12:40:31 +
Build duration: 2 min 21 sec

CHANGE SET
Revision c23f2415bb5726297e49785f18644dd17d1b38d7 by aleixpol: (Make it 
possible for an applet to offer a test object)
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasmaquick/private/appletquickitem_p.h
  change: edit src/plasma/private/packages.cpp
Revision 309c64f5e90453c5253baf19e6c01759e8aa6f83 by aleixpol: (Dont 
import an nonexistent layout)
  change: edit src/plasma/corona.cpp
Revision 0e9976afb1c4442819c9ca2cea9d2c50f4a53b3c by aleixpol: (Make sure 
PlasmaQuick export file is properly found)
  change: edit src/plasmaquick/view.h
  change: edit src/plasmaquick/configview.h
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/dialog.h
  change: edit src/plasmaquick/configmodel.h
  change: edit src/plasmaquick/packageurlinterceptor.h
  change: edit src/plasmaquick/shellpluginloader.h


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 48/86 (56%)CLASSES 48/86 (56%)LINE 2923/8679 
(34%)CONDITIONAL 1522/2419 (63%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 508/531 
(96%)CONDITIONAL 371/636 (58%)
src.declarativeimports.core
FILES 1/7 (14%)CLASSES 1/7 (14%)LINE 60/832 (7%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1526/3669 
(42%)CONDITIONAL 790/1244 (64%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 826/1672 
(49%)CONDITIONAL 342/513 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1680 (0%)CONDITIONAL 
2/4 (50%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

2016-03-19 Thread Aleix Pol

On Thu, Mar 17, 2016 at 10:54 AM, René J. V.  wrote:
> David Edmundson wrote:
>
>> There was a thread "Policy regarding QtWebKit and QtScript" on
>> kde-core-devel a while ago.
>> http://kde.6490.n7.nabble.com/Policy-regarding-QtWebKit-and-QtScript-td1619988.html
>
> What I'm missing (as in not getting) in that discussion is the whole thing 
> about
> (Qt)WebKit upstream.
>
> IIUC, WebKit was developed by Apple based on KHtml, and AFAIK WebKit is still
> the basis for their Safari browser, and the sources are still available (e.g.
> http://opensource.apple.com/release/os-x-10112/).
>
> Do I have to deduce that QtWebKit isn't "just" a Qt interface to WebKit,
> maintained by the Qt Comp - because it is I don't see how security updates 
> could
> have stopped?

WebKit integration was done through forking then integrating. It was
awkward because merging upstream changes meant rebasing our work on
theirs.
That's why it's Chromium is better in this regard, you get to interact
the upstream component without forking it, AFAIU.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 324 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/324/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sat, 19 Mar 2016 08:04:24 +
Build duration: 2 min 13 sec

CHANGE SET
Revision 28b4400da8481251084ac38b26b4347703a3ab54 by nowrep: (Dialog: Set 
SkipTaskbar/Pager states before showing window)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 48/86 (56%)CLASSES 48/86 (56%)LINE 2930/8724 
(34%)CONDITIONAL 1523/2419 (63%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 511/532 
(96%)CONDITIONAL 371/636 (58%)
src.declarativeimports.core
FILES 1/7 (14%)CLASSES 1/7 (14%)LINE 60/832 (7%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1529/3681 
(42%)CONDITIONAL 790/1244 (64%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 827/1679 
(49%)CONDITIONAL 343/513 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1695 (0%)CONDITIONAL 
2/4 (50%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 324 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/324/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 19 Mar 2016 08:04:24 +
Build duration: 2 min 56 sec

CHANGE SET
Revision 28b4400da8481251084ac38b26b4347703a3ab54 by nowrep: (Dialog: Set 
SkipTaskbar/Pager states before showing window)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.dialognativetestFailed: 
TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 57/90 (63%)CLASSES 57/90 (63%)LINE 3835/8969 
(43%)CONDITIONAL 1993/3145 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 553/579 
(96%)CONDITIONAL 385/664 (58%)
src.declarativeimports.core
FILES 4/7 (57%)CLASSES 4/7 (57%)LINE 315/832 (38%)CONDITIONAL 
150/232 (65%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1653/3681 
(45%)CONDITIONAL 866/1308 (66%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 878/1753 
(50%)CONDITIONAL 367/549 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 436/1819 
(24%)CONDITIONAL 225/392 (57%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 322 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/322/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sat, 19 Mar 2016 08:04:24 +
Build duration: 2 min 10 sec

CHANGE SET
Revision 28b4400da8481251084ac38b26b4347703a3ab54 by nowrep: (Dialog: Set 
SkipTaskbar/Pager states before showing window)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 48/86 (56%)CLASSES 48/86 (56%)LINE 2925/8687 
(34%)CONDITIONAL 1523/2419 (63%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 510/531 
(96%)CONDITIONAL 371/636 (58%)
src.declarativeimports.core
FILES 1/7 (14%)CLASSES 1/7 (14%)LINE 60/832 (7%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1526/3676 
(42%)CONDITIONAL 790/1244 (64%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 826/1672 
(49%)CONDITIONAL 343/513 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1681 (0%)CONDITIONAL 
2/4 (50%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

2016-03-19 Thread Luigi Toscano



> On March 17, 2016, 8:46 a.m., Kevin Funk wrote:
> > Ship It!
> 
> Dominik Haumann wrote:
> sorry to be late here, but please increase the version number in the 
> language element. otherwise internal caches are not rebuilt...

Sure, done in 7c93a9032ad2296f1141a7c21e3779bf65f96e82 (in addition to the 
original e6b6e7c633882ef00c1bd0b301259286e5a123cd). Sorry for the inconvenience.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127406/#review93635
---


On March 17, 2016, 10:17 p.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127406/
> ---
> 
> (Updated March 17, 2016, 10:17 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks and Daniel Vrátil.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> The file is really ASCII-only (7 bit), so both ISO-8859-15 and UTF-8 works 
> but no need to use a deprecated encoding.
> (this could help systems were support for those encodings has been removed).
> 
> See also: https://mail.kde.org/pipermail/release-team/2016-March/009327.html
> 
> 
> Diffs
> -
> 
>   src/syntax/data/gap.xml 1af543d 
> 
> Diff: https://git.reviewboard.kde.org/r/127406/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 323 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/323/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 17 Mar 2016 17:30:33 +
Build duration: 2 min 26 sec

CHANGE SET
Revision 2661cd701c18ee17021de8bac5d05ccbf2f509eb by Marco Martin: (reintroduce 
busy property in Applet)
  change: edit src/scriptengines/qml/plasmoid/appletinterface.h
  change: edit src/plasma/private/applet_p.cpp
  change: edit src/plasma/private/applet_p.h
  change: edit src/plasma/applet.h
  change: edit src/plasma/applet.cpp
  change: edit src/scriptengines/qml/plasmoid/appletinterface.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.dialognativetestFailed: 
TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 57/90 (63%)CLASSES 57/90 (63%)LINE 3836/8968 
(43%)CONDITIONAL 1994/3145 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 555/579 
(96%)CONDITIONAL 385/664 (58%)
src.declarativeimports.core
FILES 4/7 (57%)CLASSES 4/7 (57%)LINE 315/832 (38%)CONDITIONAL 
150/232 (65%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1653/3681 
(45%)CONDITIONAL 866/1308 (66%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 878/1753 
(50%)CONDITIONAL 368/549 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 435/1818 
(24%)CONDITIONAL 225/392 (57%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127409: Make sure we're not forcing the window to be created prematurely


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Only update the properties that require a winId when visible, otherwise let 
updateVisibility() take care about them.


Diffs
-

  src/plasmaquick/dialog.cpp 7bb63c5 

Diff: https://git.reviewboard.kde.org/r/127409/diff/


Testing
---

I don't get platform creations being forced on gdb.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit (got it, now to build it)

René J. V. Bertin wrote:

>> Webkit packages can be found from here:
>> http://download.qt.io/community_releases/5.6/5.6.0/

I presume there must be at least one member on this list who managed to build 
QtWebKit 5.6.0 (and remembers how)?

Sorry about asking on here, but I'm not getting any answers on the Qt mailing 
list and I'd like to get this over with.

I've now tried several approaches that all led to either header file not found 
errors or symbol not found linker errors:

- shadow build vs. in-tree build (in-tree seems less problematic)
- unpacked the package as qtwebkit inside the main Qt source tree so it builds 
as part of Qt's configure/make/make install monolithic build
- used the installed qmake 5.6.0 inside the qtwebkit-opensource-src-5.6.0 tree, 
on WebKit.pro followed by make
- used the Tools/Scripts/build-webkit script

My latest attempt ended like this, after about 50 minutes :

%> Tools/Scripts/build-webkit --qmake=/opt/local/libexec/qt5/bin/qmake --qt --
release --prefix=/opt/local/libexec/qt5 --install-headers=/opt/local/include/qt5

...

Source/WebKit/qt/WidgetSupport/QtFallbackWebPopup.cpp:29:
Source/WebKit/qt/WidgetApi/qgraphicswebview.h:23:10: fatal error: 
  'QtWebKit/qwebkitglobal.h' file not found
#include 
 ^
1 error generated.
make[2]: *** [.obj/WebKit/qt/WidgetApi/qwebinspector.o] Error 1

That's the exact error (on a different file) I'd seen trying the monolithic 
build. It was suggested that was because the packagers forget to run syncqt on 
the source tree. I tried to figure out how to do that myself, but if I arrived 
at 
the correct invocation something else must be wrong (sync.profile not updated?) 
because it doesn't change the above error.

For now the only partly relevant info I found googling is 
http://comments.gmane.org/gmane.comp.lib.qt.devel/25236 which doesn't appear to 
be very helpful.

Thanks...
René

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127398/#review93676
---




src/knotification.cpp (line 63)


ref can't be UINT_MAX, but id can, no? Negative rage will brake all, it's 
this possible, maybe not. Counters it's not good idea to be signed.



src/knotificationmanager.cpp (line 168)


force = true, id not present how can take value? force is compromised


- Anthony Fieroni


On Март 16, 2016, 10:23 след обяд, Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127398/
> ---
> 
> (Updated Март 16, 2016, 10:23 след обяд)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Adds basic set of unit tests including fake notifications server.
> 
> This helped uncover and fix these issues:
> 
> * Calling close() on KNotification that was not "sent" would not emit 
> closed() and would not delete it
> * Closing a notification can delete the KNotification object prematurely
> * Invoking an action leads to unnecessary dbus roundtrip
> * Invoking an action would fail to properly close and delete the 
> KNotification object
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6d09051 
>   autotests/CMakeLists.txt PRE-CREATION 
>   autotests/fake_notifications_server.h PRE-CREATION 
>   autotests/fake_notifications_server.cpp PRE-CREATION 
>   autotests/knotification_test.cpp PRE-CREATION 
>   autotests/knotifications5/qttest.notifyrc PRE-CREATION 
>   autotests/qtest_dbus.h PRE-CREATION 
>   src/knotification.cpp 17b0be2 
>   src/knotificationmanager.cpp e80d48c 
>   src/knotificationplugin.cpp acf964c 
>   src/notifybypopup.cpp b9489c1 
> 
> Diff: https://git.reviewboard.kde.org/r/127398/diff/
> 
> 
> Testing
> ---
> 
> Unit tests all pass.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label

2016-03-19 Thread Sebastian Kügler


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127418/#review93685
---


Ship it!




Ship It!

- Sebastian Kügler


On March 18, 2016, 1:51 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127418/
> ---
> 
> (Updated March 18, 2016, 1:51 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 245580
> https://bugs.kde.org/show_bug.cgi?id=245580
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This fixes (amongst other focus bugs) the label having the right
> enabled effect if the permissions are not editable.
> 
> CCBUG: 245580
> 
> 
> Diffs
> -
> 
>   src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 
> 
> Diff: https://git.reviewboard.kde.org/r/127418/diff/
> 
> 
> Testing
> ---
> 
> Opened kpropertiesdialog on a folder and a file
> 
> Faked being a file system without ACL (by adding && false) into line 2128 so 
> that we see the full grid of options
> 
> Opened kpropertiesdialog on a folder and a file
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127418/
---

(Updated March 18, 2016, 2:51 a.m.)


Review request for KDE Frameworks.


Bugs: 245580
https://bugs.kde.org/show_bug.cgi?id=245580


Repository: kio


Description
---

This fixes (amongst other focus bugs) the label having the right
enabled effect if the permissions are not editable.

CCBUG: 245580


Diffs
-

  src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 

Diff: https://git.reviewboard.kde.org/r/127418/diff/


Testing
---

Opened kpropertiesdialog on a folder and a file

Faked being a file system without ACL (by adding && false) into line 2128 so 
that we see the full grid of options

Opened kpropertiesdialog on a folder and a file


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

2016-03-19 Thread Milian Wolff

On Donnerstag, 17. März 2016 14:52:15 CET René J. V. Bertin wrote:
> Aleix Pol wrote:
> > WebKit integration was done through forking then integrating. It was
> > awkward because merging upstream changes meant rebasing our work on
> > theirs.
> > That's why it's Chromium is better in this regard, you get to interact
> > the upstream component without forking it, AFAIU.
> 
> You mean Chromium is used as a sort of external library with a more or less
> thin wrapper on top/around it?

Yes, that is pretty much it. See also

https://www.youtube.com/watch?v=Pc5zKGmeYN0

and related videos if you want to educate yourself on the matter.

> If so it seems it should have been possible to reimplement QtWebKit using a
> similar approach with probably far fewer API changes.

Which WebKit implementation would you have chosen? The GTK one?

> Not that that matters now ... for those of us who are on (readily) supported
> platforms.

Yes, this is a waste of time.

-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit

2016-03-19 Thread Aleix Pol

On Wed, Mar 16, 2016 at 2:54 PM, René J. V.  wrote:
> David Edmundson wrote:
>
>
>> There was a thread "Policy regarding QtWebKit and QtScript" on
>> kde-core-devel a while ago.
>> http://kde.6490.n7.nabble.com/Policy-regarding-QtWebKit-and-QtScript-td1619988.html
>
> Indeed there was, a short while ago even. It mostly argues about the cost of
> building QtWebEngine (understandably ; in my experience it took about as long 
> to
> build as the rest of Qt 5.5).
>
> I also saw something about "it looks like there will be a source-only qtwebkit
> 5.6". Any pointers for that?

https://code.qt.io/cgit/qt/qtwebkit.git/

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

2016-03-19 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127406/
---

(Updated March 17, 2016, 9:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for Kate, KDE Frameworks and Daniel Vrátil.


Changes
---

Submitted with commit e6b6e7c633882ef00c1bd0b301259286e5a123cd by Luigi Toscano 
to branch master.


Repository: ktexteditor


Description
---

The file is really ASCII-only (7 bit), so both ISO-8859-15 and UTF-8 works but 
no need to use a deprecated encoding.
(this could help systems were support for those encodings has been removed).

See also: https://mail.kde.org/pipermail/release-team/2016-March/009327.html


Diffs
-

  src/syntax/data/gap.xml 1af543d 

Diff: https://git.reviewboard.kde.org/r/127406/diff/


Testing
---


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127410: Fix crash in rename dialog (KF 5.20)

2016-03-19 Thread Emmanuel Pescosta


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/
---

Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.


Bugs: 360488
https://bugs.kde.org/show_bug.cgi?id=360488


Repository: kio


Description
---

Fix crash in rename dialog

ResizePanels must only be called in case of overwrite, all other cases violate 
the preconditions.

@Andreas: Can you please try the patch?


Diffs
-

  src/widgets/renamedialog.cpp 2d456c7 

Diff: https://git.reviewboard.kde.org/r/127410/diff/


Testing
---

Yes, I tried it by overwriting a file with the same file and with a different 
file -> no crash :)


Thanks,

Emmanuel Pescosta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127418: Set text on QCheckbox widget rather than using a separate label


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127418/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

This fixes (amongst other focus bugs) the label having the right
enabled effect if the permissions are not editable.

CCBUG: 245580


Diffs
-

  src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 

Diff: https://git.reviewboard.kde.org/r/127418/diff/


Testing
---

Opened kpropertiesdialog on a folder and a file

Faked being a file system without ACL (by adding && false) into line 2128 so 
that we see the full grid of options

Opened kpropertiesdialog on a folder and a file


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.6/QtWebkit