Re: Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/#review94942 --- Ship it! Ship It! - David Faure On April 27, 2016, 8:44

Re: solving 'KSycoca database corruption!'

On Thu, Apr 28, 2016 at 10:01 AM, Jos van den Oever wrote: > Hi all, Hi Jos, > > A few days back dvratil reported errors in the KDE PIM unit tests. The tests > were writing > > QWARN : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca > database corruption! > > On my laptop, I w

Re: case in filenames

On Tue, April 26, 2016 20:11:15 René J.V. Bertin wrote: > Hi, > > Is there an official guideline concerning the use of case for distinguishing > between filenames? There are (or have been) a few ports that do this for > header files (or directories). In that case it's relatively easy to catch > on

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 01:34:22 + Build duration: 1 min 37 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 01:34:22 + Build duration: 1 min 37 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 22 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 01:14:37 + Build duration: 2 min 42 sec CHANGE SET No changes JUNIT RESULTS Nam

Re: Review Request 127778: Add test case for KRandom{,Sequence}

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127778/ --- (Updated April 27, 2016, 6:10 p.m.) Status -- This change has been m

Re: Review Request 127778: Add test case for KRandom{,Sequence}

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127778/#review94934 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 28, 201

Review Request 127778: Add test case for KRandom{,Sequence}

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127778/ --- Review request for KDE Frameworks. Bugs: 362161 https://bugs.kde.org/

Re: Review Request 127765: RFC: Cache global config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127765/#review94932 --- +1 on the concept. Making things faster for everyone for fre

Re: Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review94931 --- Ship it! I wouldn't add domain parameter to showXTip, unti

Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: kconf

Re: Review Request 127765: RFC: Cache global config files

> On April 27, 2016, 11:59 p.m., David Edmundson wrote: > > I think you've spotted a problem, but this patch is treating the symptom > > not the cause. > > > > According to my logs, the constant loading of kdeglobals comes from: > > - 50x loading .protocol files (which shouldn't be including

Re: Review Request 127774: Load protocol info as a simple config.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127774/#review94925 --- +1 - Aleix Pol Gonzalez On April 27, 2016, 11:53 p.m., Dav

Re: Review Request 127765: RFC: Cache global config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127765/#review94923 --- I think you've spotted a problem, but this patch is treating

Review Request 127774: Load protocol info as a simple config.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127774/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 127770: Increase maximum string length in KSycoca database

> On apr 27, 2016, 8:36 p.m., David Faure wrote: > > src/sycoca/ksycocautils.cpp, line 39 > > > > > > Variable-length arrays are invalid C++. > > > > gcc might accept it, but -pedantic won't, and other co

Re: Review Request 127765: RFC: Cache global config files

> On April 27, 2016, 9:03 p.m., Albert Astals Cid wrote: > > Question: Do we care if the contents of those files changes on runtime? > > I.e. do we want to get the updated values? I would think so, this is going to break style/palette changes being loaded in frameworks integration that uses th

Re: Review Request 127765: RFC: Cache global config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127765/#review94917 --- Question: Do we care if the contents of those files changes o

Re: Review Request 127770: Increase maximum string length in KSycoca database

> On April 27, 2016, 8:36 p.m., David Faure wrote: > > src/sycoca/ksycocautils.cpp, line 39 > > > > > > Variable-length arrays are invalid C++. > > > > gcc might accept it, but -pedantic won't, and other

Re: Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/ --- (Updated apr 27, 2016, 8:44 p.m.) Review request for KDE Frameworks and D

Re: Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/#review94914 --- Very good find, thanks! src/sycoca/ksycocautils.cpp (line 2

solving 'KSycoca database corruption!'

Hi all, A few days back dvratil reported errors in the KDE PIM unit tests. The tests were writing QWARN : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca database corruption! On my laptop, I was seeing the same error when starting KF5 applications. I've spent some time in t

Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 22 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 27 Apr 2016 16:38:48 + Build duration: 1 min 38 sec CHANGE SET Revision 932420b824e1c8e4a32960d24fdccf9a041014

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 22 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 27 Apr 2016 16:38:48 + Build duration: 1 min 38 sec CHANGE SET Revision 932420b824e1c8e4a32960d24fdccf9a041014

Re: Review Request 127757: Don't look-up kbuildsycoca5 on kservice tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127757/ --- (Updated April 27, 2016, 4:38 p.m.) Status -- This change has been m

Review Request 127765: RFC: Cache global config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127765/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 127763: Reduce memory usage footprint

> On April 27, 2016, 2:37 nachm., Kai Uwe Broulik wrote: > > src/kicontheme.cpp, line 697 > > > > > > While at it you could also cache end() and reserve() - Kai Uwe --

Re: Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94907 --- src/kicontheme.cpp (line 696)

Re: Review Request 127764: warn about need for production data, skip tests that depend on them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127764/ --- (Updated April 27, 2016, 1:29 p.m.) Status -- This change has been m

Re: Review Request 127764: warn about need for production data, skip tests that depend on them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127764/#review94906 --- Ship it! Ship It! - Marco Martin On April 27, 2016, 1:2

Review Request 127764: warn about need for production data, skip tests that depend on them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127764/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Re: Review Request 127757: Don't look-up kbuildsycoca5 on kservice tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127757/#review94905 --- Much more elegant than my approach. Only one comment. I misse

Re: Review Request 127754: Use kbuildsycoca5 executable that was just built, not the one from the system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127754/ --- (Updated apr 27, 2016, 12:47 p.m.) Status -- This change has been di

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 21 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 27 Apr 2016 12:17:16 + Build duration: 2 min 33 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Re: Review Request 127759: fix unresolvable types by adding relevant includes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127759/ --- (Updated April 27, 2016, 12:08 p.m.) Status -- This change has been

Re: Review Request 127759: fix unresolvable types by adding relevant includes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127759/#review94904 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 27, 201

Review Request 127759: fix unresolvable types by adding relevant includes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127759/ --- Review request for KDE Frameworks and David Edmundson. Repository: kcorea

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 29 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:44:40 + Build duration: 8 min 1 sec CHANGE SET R

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 29 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:44:40 + Build duration: 8 min 1 sec CHANGE SET R

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/30/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:40:57 + Build duration: 8 min 25 sec CHANGE SET Revision e8

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/30/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:40:57 + Build duration: 8 min 25 sec CHANGE SET Revision e8

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 29 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:44:40 + Build duration: 2 min 41 sec CHANGE SET Revi

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 29 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:44:40 + Build duration: 2 min 41 sec CHANGE SET Revi

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 28 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/28/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:37:29 + Build duration: 5 min 24 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/30/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:40:57 + Build duration: 2 min 42 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/30/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:40:57 + Build duration: 2 min 42 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 28 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/28/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:37:29 + Build duration: 2 min 1 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 29 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:35:12 + Build duration: 1 min 50 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 29 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:35:12 + Build duration: 5 min 0 sec CHANGE SET Revision 949

Re: Review Request 127754: Use kbuildsycoca5 executable that was just built, not the one from the system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127754/#review94903 --- Please see this approach: https://git.reviewboard.kde.org/r/1

Review Request 127757: Don't look-up kbuildsycoca5 on kservice tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127757/ --- Review request for KDE Frameworks and Jos van den Oever. Repository: kser

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 27 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/27/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:26:27 + Build duration: 8 min 24 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 27 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/27/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:26:27 + Build duration: 2 min 34 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 28 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/28/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 11:26:27 + Build duration: 2 min 23 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 28 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/28/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 11:26:27 + Build duration: 2 min 49 sec CHANGE SET Revision e

Re: Review Request 127756: Remove platformtheme plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127756/#review94902 --- +1 * having this here outdated creates ugly inconsistencies

Re: Review Request 127756: Remove platformtheme plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127756/#review94901 --- +1 - Aleix Pol Gonzalez On April 27, 2016, 1:16 p.m., Mart

Review Request 127756: Remove platformtheme plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127756/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Improving performance under breeze icons

HI 2016-04-27 2:26 GMT+02:00 Aleix Pol : > Hi, > As assessed lately, one penalty we have when starting an application > is the icons look-up. It's not really Breeze's fault, the intersection > of the standard we're using and how we're using it makes the situation > slightly complex, hence simplif

Re: Improving performance under breeze icons

2016-04-27 2:26 GMT+02:00 Aleix Pol : > Hi, > As assessed lately, one penalty we have when starting an application > is the icons look-up. It's not really Breeze's fault, the intersection > of the standard we're using and how we're using it makes the situation > slightly complex, hence simplifying

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 27 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/27/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 27 Apr 2016 09:51:03 + Build duration: 2 min 42 sec CHANGE SET No cha

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 27 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/27/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 27 Apr 2016 09:51:03 + Build duration: 2 min 10 sec CHANGE SET No changes

Review Request 127754: Use kbuildsycoca5 executable that was just built, not the one from the system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127754/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Improving performance under breeze icons

Thanks for looking into this Aleix! On Wednesday 27 April 2016 02:26:06 Aleix Pol wrote: > Hi, > As assessed lately, one penalty we have when starting an application > is the icons look-up. It's not really Breeze's fault, the intersection > of the standard we're using and how we're using it makes

Re: KF5 Tags tag tags, not objects

David Faure wrote: > versionfile=$here/versions/$repo > if [ ! -f $versionfile ]; then echo "$versionfile not found"; exit 1; fi > b=`sed '2q;d' $versionfile` > echo $b > checkout=$(findCheckout $repo) > cd $checkout || exit 2 > echo $PWD > $cmd git fetch --tags || exit 2 > $cmd git tag -a $tagnam