Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is

Re: Review Request 128250: Silence CMake policy CMP0063 warning also for tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128250/ --- (Updated June 28, 2016, 10:45 p.m.) Status -- This change has been

Re: Review Request 128252: Silence CMake policy CMP0063 warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128252/ --- (Updated June 28, 2016, 10:43 p.m.) Status -- This change has been

Re: Review Request 128251: Silence CMake policy CMP0063 warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128251/ --- (Updated June 29, 2016, 12:42 a.m.) Status -- This change has been

Review Request 128312: Fix notify by taskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128312/ --- Review request for KDE Frameworks and Martin Klapetek. Repository:

Re: Review Request 128309: add helper function to create "Details" button

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128309/#review96935 --- Can we perhaps make this API a bit more high-level by adding

Re: Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128307/#review96933 --- The reason doesn't make too much sense - with Qt 5.6 or

Review Request 128309: add helper function to create "Details" button

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128309/ --- Review request for KDE Frameworks. Repository: kwidgetsaddons

Review Request 128308: fix the mkspecs install directory when cross-compiling using Qt5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128308/ --- Review request for KDE Frameworks. Repository: qca Description ---

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

> On June 28, 2016, 1:47 p.m., David Edmundson wrote: > > src/declarativeimports/core/tooltipdialog.cpp, line 122 > > > > > > we already have setFlags(Qt::Tooltip) > > > > why is this not enough? > >

Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128307/ --- Review request for KDE Frameworks. Repository: kdeclarative

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

> On Юни 28, 2016, 2:47 след обяд, David Edmundson wrote: > > src/declarativeimports/core/tooltipdialog.cpp, line 122 > > > > > > we already have setFlags(Qt::Tooltip) > > > > why is this not enough? >

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 28, 2016, 2:40 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 26, 2016, 12:13 p.m., Luigi Toscano wrote: > > When the verify operation is executed, shouldn't the computed checksum be > > (immediately) shown in the corresponding text box? Makes sense, since it's then already calculated anyway. - Thomas

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote: > > Thank you for implementing the suggestion! > > There are still some issues with it: > > 1. HIG says "Avoid using color as a primary method of communication". A > > red-green blind person would have no tell success apart from failure

Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 19 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Jun 2016 12:58:21 + Build duration: 3 min 25 sec CHANGE SET Revision

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Jun 2016 12:58:21 + Build duration: 2 min 33 sec CHANGE SET Revision

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

> On June 28, 2016, 1:47 p.m., David Edmundson wrote: > > src/declarativeimports/core/tooltipdialog.cpp, line 122 > > > > > > we already have setFlags(Qt::Tooltip) > > > > why is this not enough? This

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128300/#review96911 --- src/declarativeimports/core/tooltipdialog.cpp (line 122)

Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128300/ --- Review request for KDE Frameworks and Plasma. Repository:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Jun 2016 10:43:57 + Build duration: 13 min CHANGE SET Revision 16d28d36a283106eb8e9a3dd608b5614f2ad1ebd by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Jun 2016 10:43:57 + Build duration: 4 min 39 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Jun 2016 10:27:33 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Jun 2016 10:27:23 + Build duration: 6 min 55 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote: > > Thank you for implementing the suggestion! > > There are still some issues with it: > > 1. HIG says "Avoid using color as a primary method of communication". A > > red-green blind person would have no tell success apart from failure

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/ --- (Updated June 28, 2016, 2:04 p.m.) Status -- This change has been

Is it able to make kservice's weightedOffers public access?

Hi KDE developers, It might needs to use static KServiceTypeTrader::weightedOffers(const QString ) to get KServiceOfferList offers, for example, https://github.com/isoft-linux/plasma-workspace/blob/Chinese-word-segmentation/runners/services/servicerunner.cpp#L93 KService::List services;