[Differential] [Closed] D4018: Fix mini map for HiDPI settings

This revision was automatically updated to reflect the committed changes. Closed by commit R39:030c37be3769: fix minimap rendering for HiDPI envs (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4018?vs=9854&id=9890#toc REPOSITORY R39 KTextEditor CHANGES SINCE LA

[Differential] [Commented On] D4018: Fix mini map for HiDPI settings

cullmann added inline comments. INLINE COMMENTS > dhaumann wrote in kateviewhelpers.cpp:479 > Do we maybe need a qCeil here? I think Qt internally doesn't round up either. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4018 EMAIL PREFERENCES https://phabricator.

Re: Review Request 129653: Fix KAuth helper error code reporting to match documentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129653/ --- (Updated Jan. 9, 2017, 2:05 a.m.) Status -- This change has been mar

[Differential] [Updated] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kossebau marked an inline comment as done. kossebau added a comment. Will commit in a few days, if noone objects. So it has some weeks for testing outside my system before the next KF release. REPOSITORY R241 KIO BRANCH fixKDynamicJobTracker REVISION DETAIL https://phabricator.kde.org

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 350 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/350/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 23:12:08 + Build duration: 1 min 17 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 350 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/350/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 23:12:08 + Build duration: 1 min 17 sec CHANGE SET No changes JUNIT RESULTS

Re: Qt 5.7+ and Command+Shift shortcuts on Mac

> On 8 Jan 2017, at 19:09, René J.V. Bertin wrote: > > So... > > It seems we are indeed looking at a Qt regression. > > https://github.com/RJVB/shortcut-test-qt5 > > > That's an adapted version of Qt's menus example which adds a shortcut test > action with a configurable shortcut string and

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

> On Jan. 7, 2017, 7:10 p.m., Albert Astals Cid wrote: > > I don't know what "Scroll is now smooth in the Authors tab of the about > > dialog." > > > > But if i compare Qt 5.7.1 with this patch and Qt 5.6.1, they are different > > reacting to the wheel. > > > > "Qt 5.7.1 with this patch" is m

Re: Review Request 129730: [WIP] : kbuildsyscoca should skip /Applications on Mac

> On Jan. 8, 2017, 9:04 p.m., David Faure wrote: > > Where do KDE apps on Mac get installed to? > > > > The reasoning "QStringList::removeAll() should remove only entries matching > > /Applications exactly", while true, *does* exclude /Applications from the > > recursive search for .desktop fi

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 349 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/349/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 21:59:13 + Build duration: 25 sec CHANGE SET No changes

Re: Review Request 129730: [WIP] : kbuildsyscoca should skip /Applications on Mac

> On Jan. 8, 2017, 8:04 p.m., David Faure wrote: > > Where do KDE apps on Mac get installed to? > > > > The reasoning "QStringList::removeAll() should remove only entries matching > > /Applications exactly", while true, *does* exclude /Applications from the > > recursive search for .desktop fi

Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/ --- Review request for Baloo and KDE Frameworks. Repository: kfilemetadata

Re: Review Request 129730: [WIP] : kbuildsyscoca should skip /Applications on Mac

> On Jan. 8, 2017, 9:04 p.m., David Faure wrote: > > Where do KDE apps on Mac get installed to? > > > > The reasoning "QStringList::removeAll() should remove only entries matching > > /Applications exactly", while true, *does* exclude /Applications from the > > recursive search for .desktop fi

Re: Review Request 129730: [WIP] : kbuildsyscoca should skip /Applications on Mac

> On Jan. 8, 2017, 8:04 p.m., David Faure wrote: > > Where do KDE apps on Mac get installed to? > > > > The reasoning "QStringList::removeAll() should remove only entries matching > > /Applications exactly", while true, *does* exclude /Applications from the > > recursive search for .desktop fi

Re: Review Request 129730: [WIP] : kbuildsyscoca should skip /Applications on Mac

> On Jan. 8, 2017, 9:04 p.m., David Faure wrote: > > Where do KDE apps on Mac get installed to? > > > > The reasoning "QStringList::removeAll() should remove only entries matching > > /Applications exactly", while true, *does* exclude /Applications from the > > recursive search for .desktop fi

[Differential] [Closed] D4010: Don't register ConfigModel twice

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dcd81c6be85f: Don't register ConfigModel twice (authored by davidedmundson). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4010?vs=9837&id=9876 REVISION

Re: Review Request 129729: [OS X] : don't risk deleting /Applications (!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129729/ --- (Updated Jan. 8, 2017, 9:12 p.m.) Status -- This change has been dis

Re: Review Request 129730: [WIP] : kbuildsyscoca should skip /Applications on Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129730/#review101896 --- Where do KDE apps on Mac get installed to? The reasoning "Q

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 353 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/353/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 18:43:33 + Build duration: 20 min CHANGE SET Revision 155c7993d7be823abf4f84fe0fee9da537aa8141 by Davi

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 353 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/353/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 18:43:33 + Build duration: 20 min CHANGE SET Revision 155c7993d7be823abf4f84fe0fee9da537aa8141 by Davi

[Differential] [Commented On] D4023: kformat: Make it possible to properly translate relative days of the week

aspotashev added inline comments. INLINE COMMENTS > kformatprivate.cpp:381 > { > -return tr("Last %1").arg(m_locale.dayName(date.dayOfWeek(), format)); > +switch(date.dayOfWeek()) { > +case 1: return tr("Last Monday","day in the previous week"); Needs a space

Re: including kde classes in qt

On Sunday, 8 January 2017 18:42:37 CET mayank bansiwal wrote: > hello mates. > i have just started to code with qt creator. I want to contribute to kde > open source organization which uses qt. Can anyone please tell me how to > include kde classes in qt ide. I added this syntax in my .pro file >

Re: Review Request 129729: [OS X] : don't risk deleting /Applications (!)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129729/#review101895 --- src/sycoca/kbuildsycoca.cpp (line 495)

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review101894 --- Ship it! Ah, OK :-) - David Faure On Dec. 29, 2016, 7:

Re: Review Request 129713: Only try to open the file if it's not empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129713/#review101893 --- Ship it! Ship It! - David Faure On Dec. 28, 2016, 3:02

Re: Review Request 129641: [GHNS Button] Hide when KIOSK restriction applies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129641/ --- (Updated Jan. 8, 2017, 6:58 p.m.) Status -- This change has been mar

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 358 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/358/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 18:42:24 + Build duration: 8 min 27 sec CHANGE SET Revision 155c7993d7be823abf4f84fe0fee9da537a

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 358 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/358/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 18:42:24 + Build duration: 8 min 27 sec CHANGE SET Revision 155c7993d7be823abf4f84fe0fee9da537a

Re: Review Request 129663: Don't break accelerators in KToolBar

> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be improv

Re: Review Request 129641: [GHNS Button] Hide when KIOSK restriction applies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129641/#review101891 --- Ship it! Ship It! - David Faure On Dec. 30, 2016, 9:24

Re: including kde classes in qt

On Sun, Jan 8, 2017 at 2:12 PM, mayank bansiwal wrote: > hello mates. > i have just started to code with qt creator. I want to contribute to kde > open source organization which uses qt. Can anyone please tell me how to > include kde classes in qt ide. I added this syntax in my .pro file > > LIBS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 188 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/188/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 17:33:33 + Build duration: 1 min 45 sec CHANGE SET Revision 98e1b3f985a36a15a16f2f7337d39d

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 188 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/188/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 17:33:33 + Build duration: 1 min 45 sec CHANGE SET Revision 98e1b3f985a36a15a16f2f7337d39d

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/191/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 17:33:33 + Build duration: 1 min 53 sec CHANGE SET Revision 98e1b3f985a36a15a16f2f7337d39d2e17c1a

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/191/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 17:33:33 + Build duration: 1 min 53 sec CHANGE SET Revision 98e1b3f985a36a15a16f2f7337d39d2e17c1a

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

> On Jan. 8, 2017, 4:09 p.m., David Faure wrote: > > pam_kwallet.c, line 422 > > > > > > trailing spaces > > Damjan Georgievski wrote: > > according to http://standards.freedesktop.org/basedir-spec/latest/,

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

So... It seems we are indeed looking at a Qt regression. https://github.com/RJVB/shortcut-test-qt5 That's an adapted version of Qt's menus example which adds a shortcut test action with a configurable shortcut string and commandline options to add it to the menubar and/or the context menu, pl

Re: Review Request 129795: Only use .xml and .theme files for highlighting and themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129795/ --- (Updated Jan. 8, 2017, 6:04 p.m.) Status -- This change has been mar

[Differential] [Commented On] D3702: kconfig_compiler: Use nullptr in generated code

dfaure added a comment. Hmm OK, it's green in CI now. I'm getting local failures around QFont but that seems like a change in Qt. FAIL! : KConfigTest::testComplex() Compared values are not the same Loc: [/home/dfaure/d/kde/src/5/frameworks/kconfig/autotests/kconfigguitest.cpp

Re: Review Request 129590: KAuth: Make D-Bus dependency optional.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129590/#review101885 --- Looks good, just one comment. autotests/CMakeLists.txt (li

Re: Review Request 129795: Only use .xml and .theme files for highlighting and themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129795/#review101886 --- Ship it! Ship It! - Volker Krause On Jan. 8, 2017, 5:3

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

> On Jan. 8, 2017, 4:09 p.m., David Faure wrote: > > pam_kwallet.c, line 422 > > > > > > trailing spaces > > Damjan Georgievski wrote: > > according to http://standards.freedesktop.org/basedir-spec/latest/,

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 130 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:24:06 + Build duration: 6 min 47 sec CHANGE SET Revision d3de5a2a79d2786207d0cfbbc9828e0

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 130 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:24:06 + Build duration: 6 min 47 sec CHANGE SET Revision d3de5a2a79d2786207d0cfbbc9828e0

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 187 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/187/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:35:09 + Build duration: 1 min 51 sec CHANGE SET No changes JUNIT RESULTS Na

Review Request 129795: Only use .xml and .theme files for highlighting and themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129795/ --- Review request for Kate, KDE Frameworks, Christoph Cullmann, and Volker Kra

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:24:06 + Build duration: 2 min 22 sec CHANGE SET Revision d3de5a2a79d2786207d0cfbbc9828e00dabd14

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:24:06 + Build duration: 2 min 22 sec CHANGE SET Revision d3de5a2a79d2786207d0cfbbc9828e00dabd14

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 190 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/190/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:19:48 + Build duration: 2 min 6 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

> On Jan. 8, 2017, 4:09 p.m., David Faure wrote: > > pam_kwallet.c, line 422 > > > > > > trailing spaces > > Damjan Georgievski wrote: > > according to http://standards.freedesktop.org/basedir-spec/latest/,

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 352 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:03:53 + Build duration: 14 min CHANGE SET Revision e1c91a8f5ad87a910634bbc8752ffbbf24a1ed08 by scr

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 357 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/357/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 16:05:30 + Build duration: 6 min 45 sec CHANGE SET Revision e1c91a8f5ad87a910634bbc8752ffbbf24

[Differential] [Closed] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0119858e400: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D401

[Differential] [Request, 35 lines] D4023: kformat: Make it possible to properly translate relative days of the week

mpyne created this revision. mpyne added reviewers: Frameworks, kde-i18n-doc, aspotashev. mpyne set the repository for this revision to R244 KCoreAddons. Restricted Application added a project: Frameworks. REVISION SUMMARY KFormat::formatRelativeDate

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129526/ --- (Updated Jan. 8, 2017, 4:59 p.m.) Review request for KDE Frameworks. Bu

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

> On Jan. 8, 2017, 4:09 p.m., David Faure wrote: > > pam_kwallet.c, line 422 > > > > > > trailing spaces > according to http://standards.freedesktop.org/basedir-spec/latest/, one is > supposed to check permissi

Re: including kde frameworks classes in qt

Hi, Am Sonntag, 8. Januar 2017, 18:42:37 CET schrieb mayank bansiwal: > hello mates. > i have just started to code with qt creator. I want to contribute to kde > open source organization which uses qt. Can anyone please tell me how to > include kde classes in qt ide. I added this syntax in my .pro

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 186 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/186/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 15:45:36 + Build duration: 5 min 10 sec CHANGE SET Revision 580b8fb90c9079c962191efa71485

[Differential] [Commented On] D3702: kconfig_compiler: Use nullptr in generated code

dfaure added a comment. Well, both ;) Martin's commit landed after the change to nullptr even though it was initially written before that change so it wasn't ready for it -> I just fixed it in https://commits.kde.org/kconfig/d3de5a2a79d2786207d0cfbbc9828e00dabd148d However I see mor

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 189 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/189/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 15:43:51 + Build duration: 2 min 1 sec CHANGE SET Revision 580b8fb90c9079c962191efa7148587d439bc

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129526/#review101873 --- I like the idea. However according to http://standards.free

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 294 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/294/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 08 Jan 2017 15:33:31 + Build duration: 2 min 58 sec CHANGE SET Revisi

Re: including kde classes in qt

El diumenge, 8 de gener de 2017, a les 18:42:37 CET, mayank bansiwal va escriure: > hello mates. > i have just started to code with qt creator. I want to contribute to kde > open source organization which uses qt. Can anyone please tell me how to > include kde classes in qt ide. I added this synta

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 294 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/294/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 08 Jan 2017 15:33:31 + Build duration: 2 min 58 sec CHANGE SET Revisi

[Differential] [Changed Subscribers] D3702: kconfig_compiler: Use nullptr in generated code

aacid added subscribers: graesslin, aacid. aacid added a comment. Are you sure about that? https://build.kde.org/job/kconfig%20master%20kf5-qt5/132/ says it's @graesslin that broke it. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES https:/

Re: Review Request 129517: don't ignore return value, verify it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129517/#review101872 --- Ship it! Ship It! - David Faure On Nov. 21, 2016, 10:0

including kde classes in qt

hello mates. i have just started to code with qt creator. I want to contribute to kde open source organization which uses qt. Can anyone please tell me how to include kde classes in qt ide. I added this syntax in my .pro file LIBS += -lkdeui but still it is showing error about kde header files i

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

On Sunday January 8 2017 11:48:08 Kevin Funk wrote: >Nope, sorry, never tried. Could you try with a current build when you have a moment, please? >I'm happy to receive any patches that improve shortcut handling in KDevelop on >Mac. Sure, but I think that in principle that should rather be patc

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 134 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/134/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 15:19:49 + Build duration: 6 min 8 sec CHANGE SET Revision 4c7ea7c4ec05d7c8af28ba19d6e02e22931752

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 129 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/129/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 15:19:49 + Build duration: 5 min 19 sec CHANGE SET Revision 4c7ea7c4ec05d7c8af28ba19d6e02e

[Differential] [Accepted] D4018: Fix mini map for HiDPI settings

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. In general ok - but sure whether we need qCeil() to round sizes up, but if it looks ok, it's probably fine to commit. INLINE COMMENTS > kateviewhelpers.cpp:479 > > -m_pixmap = QP

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 293 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/293/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 08 Jan 2017 15:15:19 + Build duration: 3 min 36 sec CHANGE SET Revis

[Differential] [Commented On] D3702: kconfig_compiler: Use nullptr in generated code

dfaure added a comment. This change broke unittests, says the CI. https://build.kde.org/view/Frameworks%20kf5-qt5/job/kconfig%20master%20kf5-qt5/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Closed] D4011: [Icon Item] Fix updating implicit size when icon sizes change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8875a04a1bbe: [Icon Item] Fix updating implicit size when icon sizes change (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4011?vs=

[Differential] [Closed] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b55493568b1: [Dialog] Use setPosition / setSize instead of setting everything individually (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.k

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 292 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/292/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 08 Jan 2017 15:10:19 + Build duration: 2 min 39 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 292 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/292/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 08 Jan 2017 15:10:19 + Build duration: 2 min 39 sec CHANGE SET Revisi

[Differential] [Closed] D4012: Introduce Units singleton

This revision was automatically updated to reflect the committed changes. Closed by commit R242:56773014e157: Introduce Units singleton (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9857&id=9859 REVISION DETAIL http

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 291 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/291/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 08 Jan 2017 15:02:00 + Build duration: 2 min 33 sec CHANGE SET Revision 5

[Differential] [Closed] D4013: [Units] Make iconSizes property constant

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4479fdab7fff: [Units] Make iconSizes property constant (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4013?vs=9842&id=9860#toc REPOSITORY R242 Plasma Frameworks CHANG

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 291 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/291/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 08 Jan 2017 15:02:00 + Build duration: 2 min 33 sec CHANGE SET Revision 5

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 291 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/291/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 08 Jan 2017 15:02:00 + Build duration: 3 min 2 sec CHANGE SET Revisi

[Differential] [Accepted] D4012: Introduce Units singleton

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks nice and clean to me now :) Nice job! REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Changed Subscribers] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

markg added inline comments. INLINE COMMENTS > tooltipdialog.cpp:116-118 > +if (KWindowSystem::isPlatformX11()) { > flags = flags | Qt::BypassWindowManagerHint; > } Isn't this redundant anyway? It's being set in the constructor as well. The constructor only deviates in initial

[Differential] [Updated] D4012: Introduce Units singleton

broulik marked an inline comment as done. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, markg, davidedmundson, #plasma Cc: markg, plasma-devel, #frameworks, le

[Differential] [Updated] D4012: Introduce Units singleton

broulik marked 3 inline comments as done. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, markg, davidedmundson, #plasma Cc: markg, plasma-devel, #frameworks, le

[Differential] [Accepted] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4019 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Updated, 33 lines] D4012: Introduce Units singleton

broulik updated this revision to Diff 9857. broulik added a comment. - Return reference instead of ptr - Rename to "instance" - Disable move and stuff REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9846&id=9857 REVISION DETAIL https

[Differential] [Commented On] D4012: Introduce Units singleton

broulik added a comment. I was actually thinking about using the "proper" singleton way but didn't want it to be inconsistent with everywhere else. But, yeah, I'll do that. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://ph

[Differential] [Request, 13 lines] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY I think it's wr

[Differential] [Requested Changes To] D4012: Introduce Units singleton

markg requested changes to this revision. markg added a reviewer: markg. markg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > units.cpp:61 > SharedAppFilter *Units::s_sharedAppFilter = nullptr; > +Units *Units::s_self = nullptr; > Remove this line if y

[Differential] [Request, 15 lines] D4018: Fix mini map for HiDPI settings

cullmann created this revision. cullmann added reviewers: Kate, dhaumann. cullmann set the repository for this revision to R39 KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Fix mini map for Hi

[Differential] [Request, 2 lines] D4017: Break from loop once we've found a Layout

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There's no poin

[Differential] [Accepted] D4010: Don't register ConfigModel twice

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DETAIL https://phabricator.kde.org/D4010 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4009 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Accepted] D4011: [Icon Item] Fix updating implicit size when icon sizes change

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4011 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Commented On] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

davidedmundson added a comment. The idea that it will change whether you see the tab bar resize isn't true. Setwidth and setHeight are done in sequence. There's no way you can get a repaint in between them. (Unless some code has an animation somewhere?) However this is still better.

[Differential] [Accepted] D4012: Introduce Units singleton

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Updated, 36 lines] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

kossebau updated this revision to Diff 9849. kossebau marked 3 inline comments as done. kossebau added a comment. rename modline var + backward compat code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4003?vs=9821&id=9849 BRANCH alignNamingOfBOFandU

[Differential] [Accepted] D4013: [Units] Make iconSizes property constant

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4013 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

  1   2   >