[Differential] [Closed] D3850: Pass -fno-operator-names when supported

2017-01-15 Thread Kevin Funk
This revision was automatically updated to reflect the committed changes. Closed by commit R240:a5f3a76e1479: Pass -fno-operator-names when supported (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3850?vs=9443=10205 REVISION

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 386 - Unstable!

2017-01-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/386/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 05:05:51 + Build duration: 26 min CHANGE SET Revision

[Differential] [Accepted] D4137: API dox: Add @class comment with CamelCase include, image title without KDE

2017-01-15 Thread Christoph Feck
cfeck accepted this revision. cfeck added a reviewer: cfeck. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH noteCamelCaseIncludeFixWidgetTitles REVISION DETAIL https://phabricator.kde.org/D4137 EMAIL PREFERENCES

[Differential] [Commented On] D4137: API dox: Add @class comment with CamelCase include, image title without KDE

2017-01-15 Thread Christoph Feck
cfeck added a comment. I would just add the missing forwarding headers without mentioning the version they first appeared in. Let's assume it is just a bug fix, and we do not mention bug fixes in the documentation. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 207 - Unstable!

2017-01-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/207/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 00:48:04 + Build duration: 1 min 51 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Commented On] D4130: Let KConfigDialogManager get a property's change signal from the metaObject

2017-01-15 Thread Elvis Angelaccio
elvisangelaccio added a comment. @kossebau That looks good, way more easier :) REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks Cc: elvisangelaccio

[Differential] [Accepted] D4023: kformat: Make it possible to properly translate relative days of the week

2017-01-15 Thread Alexander Potashev
aspotashev accepted this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4023 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mpyne, #frameworks, kde-i18n-doc, aacid, aspotashev Cc: aacid

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/ --- (Updated Jan. 15, 2017, 8:46 p.m.) Review request for KDE Frameworks,

Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

2017-01-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-15 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be

[Differential] [Accepted] D4023: kformat: Make it possible to properly translate relative days of the week

2017-01-15 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ok, then let's go with > Maybe something like "the most recent such day before today" and "the next such day after today"? i guess REPOSITORY R244 KCoreAddons REVISION DETAIL

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-15 Thread Albert Astals Cid
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be

[Differential] [Commented On] D4137: API dox: Add @class comment with CamelCase include, image title without KDE

2017-01-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. https://phabricator.kde.org/D4144 now would create the missing forward headers. Only issue might be that there is no @since note possible... so people might start using the forward header without knowing in which KF version this forward header was added...

[Differential] [Updated, 173 lines] D4137: API dox: Add @class comment with CamelCase include, image title without KDE

2017-01-15 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 10189. kossebau added a comment. add @class comments also for all classes in multi-class headers REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4137?vs=10171=10189 BRANCH noteCamelCaseIncludeFixWidgetTitles

[Differential] [Request, 8 lines] D4144: Install also CamelCase forward headers for classes from multi-class headers

2017-01-15 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REPOSITORY R236 KWidgetsAddons BRANCH installMoreCamelCaseForwardHeaders REVISION DETAIL https://phabricator.kde.org/D4144 AFFECTED FILES src/CMakeLists.txt EMAIL

[Differential] [Updated] D3826: Detect inotify.

2017-01-15 Thread Adriaan de Groot
adridg added a reviewer: ervin. adridg added a comment. Adding Kevin as reviewer -- I feel uncomfortable having so little feedback and I'm not sure who should be added if https://phabricator.kde.org/tag/buildsystem/ and https://phabricator.kde.org/tag/frameworks/ don't ACK. REPOSITORY

Review Request 129842: KAuth: update most of the examples, drop outdated ones

2017-01-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

[Differential] [Request, 57 lines] D4142: Support "default actions", as specified in [1].

2017-01-15 Thread Albert Vaca Cintora
albertvaka created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Default actions are the actions triggered when the notification is simply clicked, without adding any "action buttons". Until now, with

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-01-15 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/ --- (Updated Jan. 15, 2017, 4:03 p.m.) Review request for Baloo and KDE

Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-01-15 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/ --- Review request for Baloo and KDE Frameworks. Repository: kfilemetadata

[Differential] [Commented On] D4023: kformat: Make it possible to properly translate relative days of the week

2017-01-15 Thread Michael Pyne
mpyne added a comment. In https://phabricator.kde.org/D4023#77304, @aacid wrote: > Can you as a native speaker confirm this theory i've heard? > > If we are on "Monday 16", "Next Wednesday" means "Wednesday 25" if you want "Wednesday 18" you should say "This Wednesday" Yes,

[Differential] [Closed] D4141: Allow Tab as being modified by Shift

2017-01-15 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R278:4fe25b719065: Allow Tab as being modified by Shift (authored by subdiff). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4141?vs=10178=10180 REVISION DETAIL

Jenkins-kde-ci: kbookmarks master stable-kf5-qt5 » Linux,gcc - Build # 175 - Fixed!

2017-01-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/175/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 Jan 2017 14:07:54 + Build duration: 6 min 28 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 205 - Fixed!

2017-01-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/205/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 Jan 2017 13:06:50 + Build duration: 2 min 52 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Accepted] D4141: Allow Tab as being modified by Shift

2017-01-15 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D4141 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, graesslin Cc: #frameworks

[Differential] [Request, 1 line] D4141: Allow Tab as being modified by Shift

2017-01-15 Thread Roman Gilg
subdiff created this revision. subdiff added a reviewer: graesslin. subdiff set the repository for this revision to R278 KWindowSystem. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Backtab was in the list already,

Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-15 Thread Martin Tobias Holmedahl Sandsmark
> On Jan. 15, 2017, 12:46 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Ship It! tbh., I have no idea why it uses the explicit versions, pre-1.2 is ancient and I doubt anyone uses it so I don't think even a minimum version check is necessary. I see at least on arch it is symlinked to

Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-15 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129742/#review102038 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-15 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 204 - Still Unstable!

2017-01-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/204/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 Jan 2017 11:46:24 + Build duration: 1 min 56 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

2017-01-15 Thread Elvis Angelaccio
> On Jan. 15, 2017, 2:32 a.m., Christoph Feck wrote: > > From what I see, the content widget is not owned by the tool tip widget. > > What happens if I delete the tool tip widget first, then delete the content > > widget? Does deleting automatically break the connections to the now > >

Re: Review Request 129776: Allow multiline text for KIconDialog icon names

2017-01-15 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129776/#review102033 --- +1 - Anthony Fieroni On Ян. 4, 2017, 8:58 след обяд,