[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

[Eike Hein]

hein added a comment.


  Gnome-only spec? Why aren't they contributing to fd.o?

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4416

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 414 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/414/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 01:19:24 +
Build duration: 5 min 31 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 
(76%)CONDITIONAL 78/148 (53%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 
59/118 (50%)
src
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 
19/30 (63%)

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 414 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/414/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 01:19:24 +
Build duration: 5 min 31 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 
(76%)CONDITIONAL 78/148 (53%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 
59/118 (50%)
src
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 
19/30 (63%)

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 413 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/413/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 01:00:00 +
Build duration: 2 min 11 sec

CHANGE SET
Revision 5ce93f9d9e67ff60027a0c1a451ac5ded6ab57ab by scripty: (Upgrade Qt5 
version requirement to 5.6.0.)
  change: edit CMakeLists.txt

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 407 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/407/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 00:45:39 +
Build duration: 6 min 22 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29740/51606 
(58%)CONDITIONAL 16329/38743 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4428/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8079/14179 
(57%)CONDITIONAL 4428/9259 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3454/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1766/3780 
(47%)CONDITIONAL 1277/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3631/11016 
(33%)CONDITIONAL 1746/7096 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 407 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/407/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 00:45:39 +
Build duration: 6 min 22 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29740/51606 
(58%)CONDITIONAL 16329/38743 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4428/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8079/14179 
(57%)CONDITIONAL 4428/9259 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3454/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1766/3780 
(47%)CONDITIONAL 1277/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3631/11016 
(33%)CONDITIONAL 1746/7096 (25%)

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

[Kai Uwe Broulik]

> This is not ok, the web interface for reviewboard was as good as rb-tools (I 
> guess tbh i never used them) and "forcing" the use of a weird tool noone has 
> heard of is not a good way to attract new contributors

Agreed. Especially since arc is some mental php script that randomly amends 
wrong revisions and/or adds files deliberately left unstaged.

As for the context I usually end up uploading diffs with -U99 but that's not 
ideal and it had never been an issue with ReviewBoard.

‎I also find the way to access revision patchset diffs cumbersome. The fact 
that online comments aren't versioned and stick around even if the diff changed 
significantly in later iterations is quite annoying. They also don't provide 
code snippets in the list of comments, you always have to jump to the specific 
line to see what's up there.

The repository search when uploading a diff is also pretty dumb, always 
defaulting to the least sensible option: Querying for "plasma workspace" 
automatically chooses Plasma Workspace Wallpapers, "kio" ends up with KIO 
AudioCD or Gopher...

Nevertheless I got quite used to Phabricator, at least Differential, and don't 
really miss RB especially since it got painfully slow ever since a gazillion 
Frameworks repositories were created. In conjunction with Plasma 5.9's drag and 
drop notification feature and Spectacle creating illustrated revisions is a 
breeze.

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 228 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/228/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 23:56:49 +
Build duration: 1 min 53 sec

CHANGE SET
Revision a919d6e4c0164975d40a247fe34370c79f15ad58 by scripty: (Upgrade Qt5 
version requirement to 5.6.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5484/8008 
(68%)CONDITIONAL 2978/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1466/1554 
(94%)CONDITIONAL 903/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1228/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 233 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/233/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 23:56:49 +
Build duration: 1 min 57 sec

CHANGE SET
Revision a919d6e4c0164975d40a247fe34370c79f15ad58 by scripty: (Upgrade Qt5 
version requirement to 5.6.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5484/8008 
(68%)CONDITIONAL 2973/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 895/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1767/3045 
(58%)CONDITIONAL 766/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1227/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 406 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/406/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 23:45:50 +
Build duration: 9 min 18 sec

CHANGE SET
Revision 6a1b24676aa01f9aed272a612b5432402bf1a3a5 by scripty: (Upgrade Qt5 
version requirement to 5.6.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 30 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiocore-threadtestFailed: 
TestSuite.kiofilewidgets-kdiroperatortestFailed: 
TestSuite.kiofilewidgets-kfilecopytomenutestFailed: 
TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiofilewidgets-kfilewidgettestFailed: 
TestSuite.kiofilewidgets-knewfilemenutestFailed: 
TestSuite.kiofilewidgets-kurlcomboboxtestFailed: 
TestSuite.kiofilewidgets-kurlnavigatortestFailed: 
TestSuite.kiofilewidgets-kurlrequestertestFailed: 
TestSuite.kiogui-favicontestFailed: 
TestSuite.kioslave-httpauthenticationtestFailed: 
TestSuite.kioslave-httpheaderdispositiontestFailed: 
TestSuite.kioslave-httpheadertokenizetestFailed: 
TestSuite.kioslave-httpobjecttestFailed: 
TestSuite.kioslave-kcookiejartestFailed: 
TestSuite.kiowidgets-accessmanagertestFailed: 
TestSuite.kiowidgets-accessmanagertest-qnamFailed: 
TestSuite.kiowidgets-clipboardupdatertestFailed: 
TestSuite.kiowidgets-dropjobtestFailed: 
TestSuite.kiowidgets-fileundomanagertestFailed: 
TestSuite.kiowidgets-jobguitestFailed: 
TestSuite.kiowidgets-kdirlistertestFailed: 
TestSuite.kiowidgets-kdirmodeltestFailed: 
TestSuite.kiowidgets-kfileitemactionstestFailed: 
TestSuite.kiowidgets-krununittestFailed: 
TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: 
TestSuite.kiowidgets-kurifiltertestFailed: 
TestSuite.kiowidgets-kurlcompletiontestFailed: 
TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: 
TestSuite.kiowidgets-pastetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 12/13 (92%)FILES 157/248 (63%)CLASSES 157/248 (63%)LINE 15343/37848 
(41%)CONDITIONAL 8494/27962 (30%)

By packages
  
autotests
FILES 37/37 (100%)CLASSES 37/37 (100%)LINE 4394/4677 
(94%)CONDITIONAL 2284/4562 (50%)
autotests.http
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 65/65 (100%)CONDITIONAL 
41/80 (51%)
src.core
FILES 90/117 (77%)CLASSES 90/117 (77%)LINE 7098/14179 
(50%)CONDITIONAL 3813/9259 (41%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/849 (51%)CONDITIONAL 
317/749 (42%)
src.ioslaves.http
FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 1022/3775 (27%)CONDITIONAL 
637/3459 (18%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 694/1139 
(61%)CONDITIONAL 387/833 (46%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/385 (0%)CONDITIONAL 0/138 
(0%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.widgets
FILES 6/64 (9%)CLASSES 6/64 (9%)LINE 245/11015 (2%)CONDITIONAL 
136/7094 (2%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 412 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/412/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 23:45:50 +
Build duration: 7 min 12 sec

CHANGE SET
Revision 6a1b24676aa01f9aed272a612b5432402bf1a3a5 by scripty: (Upgrade Qt5 
version requirement to 5.6.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29726/51606 
(58%)CONDITIONAL 16319/38743 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4430/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8057/14179 
(57%)CONDITIONAL 4415/9259 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3454/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1766/3780 
(47%)CONDITIONAL 1277/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3639/11016 
(33%)CONDITIONAL 1747/7096 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 412 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/412/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 23:45:50 +
Build duration: 7 min 12 sec

CHANGE SET
Revision 6a1b24676aa01f9aed272a612b5432402bf1a3a5 by scripty: (Upgrade Qt5 
version requirement to 5.6.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29726/51606 
(58%)CONDITIONAL 16319/38743 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4430/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8057/14179 
(57%)CONDITIONAL 4415/9259 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3454/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1766/3780 
(47%)CONDITIONAL 1277/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3639/11016 
(33%)CONDITIONAL 1747/7096 (25%)

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On Sat, Feb 4, 2017 at 11:41 AM, Albert Astals Cid  wrote:
> El divendres, 3 de febrer de 2017, a les 21:06:08 CET, Ben Cooksley va
> escriure:
>> On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid  wrote:
>> > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va
> escriure:
>> >> Hi everyone,
>> >>
>> >> We've just completed the registration of all mainline repositories
>> >> (not including Websites or Sysadmin namespaced ones) on Phabricator.
>> >> Thanks go to Luigi Toscano for providing significant assistance with
>> >> this process.
>> >>
>> >> From this point forward, communities should be moving away from
>> >> Reviewboard to Phabricator for conducting code review.
>> >
>> > I just created first patch with the phabricator web interface.
>> >
>> > Found one minor and one major problem.
>> >
>> > Minor problem:
>> >  * You can't update the diff before creating a "Revision", so if you
>> >  realize
>> >
>> > your diff was wrong, back luck, you either leave the diff floating in the
>> > limbo or you create the Revision and the update the diff, showing the
>> > world
>> > your mistake for no reason
>> > https://phabricator.kde.org/D4422?vs=10881=10882
>>
>> Interesting. It might be worth asking upstream about that.
>>
>> > Major problem:
>> >  * It doesn't show context
>> >
>> > https://phabricator.kde.org/D4422
>> >
>> > "Context not available." is terrible, how is one supposed to review
>> > without
>> > being able to read the rest of the code?
>> >
>> > This is a deal breaker for me.
>>
>> Please see https://secure.phabricator.com/T5029
>
> As said on IRC, the fact that this has been open for almost 3 years is more a
> concern than a relief.

I've inquired with upstream, and they've indicated that at the moment
T5029 isn't on their roadmap for implementation (although T5000 and
T182 are).

Their target audience is primarily corporate development workflows,
for which requiring use of Arcanist isn't an issue.

>
>>
>> This only occurs when patches are uploaded from the web interface and
>> the patch in question has minimal context.
>> At this time Phabricator is not able to automatically resolve context
>> using markers in the patch (there are certain complexities involved
>> for some SCMs, particularly for SVN - which Phabricator supports)
>>
>> The fix for this is to either:
>> a) Use Arcanist, the recommended tool for working with Phabricator
>> (this is no different to rb-tools for Reviewboard)
>
> This is not ok, the web interface for reviewboard was as good as rb-tools (i
> guess tbh i never used them) and "forcing" the use of a weird tool noone has
> heard of is not a good way to attract new contributors

New contributors who aren't willing to install Arcanist can use diff
-U99 I would imagine?

>
> Cheers,
>   Albert

Regards,
Ben

Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On Fri, Feb 3, 2017 at 11:37 PM, René J.V. Bertin  wrote:
> On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote:
>
>>You missed the point. This "bit rot" is not about disk damage but
>>about software incompatibility. ZFS doesn't help with that...
>
> You mean diffs that no longer apply cleanly? In that case you missed our 
> point. Being able to consult intermediate versions of diffs, abandoned diffs 
> etc. is not to be able to apply them "as is". If there were no value in the 
> kind of code those diffs (can) contain we'd not be using git or git wouldn't 
> be preserving every single bit of history.

Rene, we aren't talking about diffs here. Not even close.

What we are talking about is things like silent data corruption caused
by upgrade edge cases, database encoding changes and data storage
format changes. Not to mention changes in the software stack itself,
and our long term ability to keep it running.

>
>
> Oh well. This is just another expression of FOSS's biggest weakness. Every 
> project has this centre-of-the-universe tendency that apparently justifies 
> breaking things for large parts of the user base whenever the project feels 
> it's justified.

I'm not even going to respond to that.

>
> R

Regards,
Ben

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

[Albert Astals Cid]

El divendres, 3 de febrer de 2017, a les 10:24:08 CET, Elvis Angelaccio va 
escriure:
> On Fri, Feb 3, 2017 at 9:06 AM, Ben Cooksley  wrote:
> > On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid  wrote:
> >> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va 
escriure:
> >>> Hi everyone,
> >>> 
> >>> We've just completed the registration of all mainline repositories
> >>> (not including Websites or Sysadmin namespaced ones) on Phabricator.
> >>> Thanks go to Luigi Toscano for providing significant assistance with
> >>> this process.
> >>> 
> >>> From this point forward, communities should be moving away from
> >>> Reviewboard to Phabricator for conducting code review.
> >> 
> >> I just created first patch with the phabricator web interface.
> >> 
> >> Found one minor and one major problem.
> >> 
> >> Minor problem:
> >>  * You can't update the diff before creating a "Revision", so if you
> >>  realize
> >> 
> >> your diff was wrong, back luck, you either leave the diff floating in the
> >> limbo or you create the Revision and the update the diff, showing the
> >> world
> >> your mistake for no reason
> >> https://phabricator.kde.org/D4422?vs=10881=10882
> > 
> > Interesting. It might be worth asking upstream about that.
> > 
> >> Major problem:
> >>  * It doesn't show context
> >> 
> >> https://phabricator.kde.org/D4422
> >> 
> >> "Context not available." is terrible, how is one supposed to review
> >> without
> >> being able to read the rest of the code?
> >> 
> >> This is a deal breaker for me.
> > 
> > Please see https://secure.phabricator.com/T5029
> > 
> > This only occurs when patches are uploaded from the web interface and
> > the patch in question has minimal context.
> > At this time Phabricator is not able to automatically resolve context
> > using markers in the patch (there are certain complexities involved
> > for some SCMs, particularly for SVN - which Phabricator supports)
> > 
> > The fix for this is to either:
> > a) Use Arcanist, the recommended tool for working with Phabricator
> > (this is no different to rb-tools for Reviewboard)
> > b) Use "diff -U99" when generating your diffs for uploading to Phabricator
> 
> Would it be possible to add this info in the patch upload form? e.g.
> near or in place of this sentence: "You can also paste a diff below,
> or upload a file containing a diff (for example, from svn diff, git
> diff or hg diff --git)."
> 
> It would not be a solution but at least more people would know that
> the -U switch can be used as workaround.

Or flat out reject the diff, that's annoying but at least gives you something 
you can use to move forward.

"I need a better diff, please use -U99"

Cheers,
  Albert

> 
> > In regards to improvements in Diffusion (Repository Hosting) and
> > Differential (Code Review) please see the upstream task at
> > https://secure.phabricator.com/T12010 for the work which is currently
> > in active progress (many of these
> > 
> >> Cheers,
> >> 
> >>   Albert
> > 
> > Regards,
> > Ben
> 
> Cheers,
> Elvis

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

[Albert Astals Cid]

El divendres, 3 de febrer de 2017, a les 21:06:08 CET, Ben Cooksley va 
escriure:
> On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid  wrote:
> > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va 
escriure:
> >> Hi everyone,
> >> 
> >> We've just completed the registration of all mainline repositories
> >> (not including Websites or Sysadmin namespaced ones) on Phabricator.
> >> Thanks go to Luigi Toscano for providing significant assistance with
> >> this process.
> >> 
> >> From this point forward, communities should be moving away from
> >> Reviewboard to Phabricator for conducting code review.
> > 
> > I just created first patch with the phabricator web interface.
> > 
> > Found one minor and one major problem.
> > 
> > Minor problem:
> >  * You can't update the diff before creating a "Revision", so if you
> >  realize
> > 
> > your diff was wrong, back luck, you either leave the diff floating in the
> > limbo or you create the Revision and the update the diff, showing the
> > world
> > your mistake for no reason
> > https://phabricator.kde.org/D4422?vs=10881=10882
> 
> Interesting. It might be worth asking upstream about that.
> 
> > Major problem:
> >  * It doesn't show context
> > 
> > https://phabricator.kde.org/D4422
> > 
> > "Context not available." is terrible, how is one supposed to review
> > without
> > being able to read the rest of the code?
> > 
> > This is a deal breaker for me.
> 
> Please see https://secure.phabricator.com/T5029

As said on IRC, the fact that this has been open for almost 3 years is more a 
concern than a relief.

> 
> This only occurs when patches are uploaded from the web interface and
> the patch in question has minimal context.
> At this time Phabricator is not able to automatically resolve context
> using markers in the patch (there are certain complexities involved
> for some SCMs, particularly for SVN - which Phabricator supports)
> 
> The fix for this is to either:
> a) Use Arcanist, the recommended tool for working with Phabricator
> (this is no different to rb-tools for Reviewboard)

This is not ok, the web interface for reviewboard was as good as rb-tools (i 
guess tbh i never used them) and "forcing" the use of a weird tool noone has 
heard of is not a good way to attract new contributors

Cheers,
  Albert

[Differential] [Accepted] D4421: Reverse meaning of :split, :vsplit to match vi and Kate actions.

[Michal Humpula]

michalhumpula accepted this revision.
michalhumpula added a reviewer: michalhumpula.
michalhumpula added a comment.
This revision is now accepted and ready to land.


  Hi Francis, it probably got switched during massive refactor few years back 
by me. Looks good. Thanks for the fix!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4421

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, #ktexteditor, michalhumpula
Cc: michalhumpula, cullmann, mwolff, kwrite-devel, #frameworks

Review Request 129911: Added property() method to TerminalInterface class

[Sven Fischer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129911/
---

Review request for KDE Frameworks.


Repository: kparts


Description
---

For konsole KPart consumers it may be necessary to access the properties
of the konsole profile, e.g. the "Start in current session dir" to be
able to control the working directory in new KPart instantiation.

A corresponding patch has been submitted to the konsole repository.


Diffs
-

  src/kde_terminal_interface.h f9603d120d5116db35ae60d65b2743a5aceaebac 

Diff: https://git.reviewboard.kde.org/r/129911/diff/


Testing
---

Locally compile konsole against this changed header, and running a yakuake 
instance against the patched konsole.


Thanks,

Sven Fischer

[Differential] [Commented On] D4421: Reverse meaning of :split, :vsplit to match vi and Kate actions.

[Christoph Cullmann]

cullmann added a comment.


  If that is more consistent with vi, I am ok with that ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4421

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, #ktexteditor
Cc: cullmann, mwolff, kwrite-devel, #frameworks

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D4422#82875, @anthonyfieroni wrote:
  
  > I understand code, it will work now, but to me it's a workaround.
  
  
  Why is it a workaround?
  
  > What about to call QIODevice::seek(0) in constructor, other unchanged to 
original code ?
  
  Please, test stuff before suggesting it, saying "No" to every random thing 
you think may work is not fun.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D4422

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aacid
Cc: anthonyfieroni, #frameworks

[Differential] [Closed] D4355: Add methods to hide the reveal password action

[Christoph Feck]

cfeck closed this revision.
cfeck added a comment.


  Submitted as 
https://commits.kde.org/kwidgetsaddons/307d54fcee3a41e1d8b3dafd16212b5b8d7c8a22

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D4355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, broulik, cfeck
Cc: #frameworks

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

[Anthony Fieroni]

anthonyfieroni added a comment.


  I understand code, it will work now, but to me it's a workaround. What about 
to call QIODevice::seek(0) in constructor, other unchanged to original code ?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D4422

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aacid
Cc: anthonyfieroni, #frameworks

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D4422#82848, @anthonyfieroni wrote:
  
  > > When subclassing QIODevice, you must call QIODevice::seek() at the start 
of your function to ensure integrity with QIODevice's built-in buffer.
  >
  > http://doc.qt.io/qt-5/qiodevice.html#seek
  >
  > For me, i'm not test it, it should be
  >
  >   if (!QIODevice::seek(pos)) {
  >   return false;
  >   }
  >   qint64 ioIndex = this->pos();
  >   .
  >   .
  >   .
  >
  
  
  No

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D4422

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aacid
Cc: anthonyfieroni, #frameworks

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

[Anthony Fieroni]

anthonyfieroni added a comment.


  > When subclassing QIODevice, you must call QIODevice::seek() at the start of 
your function to ensure integrity with QIODevice's built-in buffer.
  
  http://doc.qt.io/qt-5/qiodevice.html#seek
  
  For me, i'm not test it, it should be
  
if (!QIODevice::seek(pos)) {
return false;
}
qint64 ioIndex = this->pos();
.
.
.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D4422

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aacid
Cc: anthonyfieroni, #frameworks

Re: Phabricator: All repositories registered - upcoming workflow changes

[Luigi Toscano]

René J.V. Bertin ha scritto:
> On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote:
> 
>> You missed the point. This "bit rot" is not about disk damage but
>> about software incompatibility. ZFS doesn't help with that...
> 
> You mean diffs that no longer apply cleanly? In that case you missed our 
> point. Being able to consult intermediate versions of diffs, abandoned diffs 
> etc. is not to be able to apply them "as is". If there were no value in the 
> kind of code those diffs (can) contain we'd not be using git or git wouldn't 
> be preserving every single bit of history. 
> 
> 
> Oh well. This is just another expression of FOSS's biggest weakness. Every 
> project has this centre-of-the-universe tendency that apparently justifies 
> breaking things for large parts of the user base whenever the project feels 
> it's justified.

No one is breaking anything. We are working to try to collect the problems and
have them solved, and if you look around in the discussion it seems that a
simple mirroring is working. Also, someone else was checking on IRC how the
Reviewboard API works.

Please let's focus on the way to solve problems.

-- 
Luigi

Re: Phabricator: All repositories registered - upcoming workflow changes

[René J . V . Bertin]

On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote:

>You missed the point. This "bit rot" is not about disk damage but
>about software incompatibility. ZFS doesn't help with that...

You mean diffs that no longer apply cleanly? In that case you missed our point. 
Being able to consult intermediate versions of diffs, abandoned diffs etc. is 
not to be able to apply them "as is". If there were no value in the kind of 
code those diffs (can) contain we'd not be using git or git wouldn't be 
preserving every single bit of history. 


Oh well. This is just another expression of FOSS's biggest weakness. Every 
project has this centre-of-the-universe tendency that apparently justifies 
breaking things for large parts of the user base whenever the project feels 
it's justified.

R

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

[Elvis Angelaccio]

On Fri, Feb 3, 2017 at 9:06 AM, Ben Cooksley  wrote:
> On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid  wrote:
>> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va 
>> escriure:
>>> Hi everyone,
>>>
>>> We've just completed the registration of all mainline repositories
>>> (not including Websites or Sysadmin namespaced ones) on Phabricator.
>>> Thanks go to Luigi Toscano for providing significant assistance with
>>> this process.
>>>
>>> From this point forward, communities should be moving away from
>>> Reviewboard to Phabricator for conducting code review.
>>
>> I just created first patch with the phabricator web interface.
>>
>> Found one minor and one major problem.
>>
>> Minor problem:
>>  * You can't update the diff before creating a "Revision", so if you realize
>> your diff was wrong, back luck, you either leave the diff floating in the
>> limbo or you create the Revision and the update the diff, showing the world
>> your mistake for no reason
>> https://phabricator.kde.org/D4422?vs=10881=10882
>
> Interesting. It might be worth asking upstream about that.
>
>>
>>
>> Major problem:
>>  * It doesn't show context
>> https://phabricator.kde.org/D4422
>>
>> "Context not available." is terrible, how is one supposed to review without
>> being able to read the rest of the code?
>>
>> This is a deal breaker for me.
>
> Please see https://secure.phabricator.com/T5029
>
> This only occurs when patches are uploaded from the web interface and
> the patch in question has minimal context.
> At this time Phabricator is not able to automatically resolve context
> using markers in the patch (there are certain complexities involved
> for some SCMs, particularly for SVN - which Phabricator supports)
>
> The fix for this is to either:
> a) Use Arcanist, the recommended tool for working with Phabricator
> (this is no different to rb-tools for Reviewboard)
> b) Use "diff -U99" when generating your diffs for uploading to Phabricator

Would it be possible to add this info in the patch upload form? e.g.
near or in place of this sentence: "You can also paste a diff below,
or upload a file containing a diff (for example, from svn diff, git
diff or hg diff --git)."

It would not be a solution but at least more people would know that
the -U switch can be used as workaround.

>
> In regards to improvements in Diffusion (Repository Hosting) and
> Differential (Code Review) please see the upstream task at
> https://secure.phabricator.com/T12010 for the work which is currently
> in active progress (many of these
>
>>
>> Cheers,
>>   Albert
>
> Regards,
> Ben

Cheers,
Elvis

[Differential] [Updated] D4425: Add support for flatpak portals

[Jan Grulich]

jgrulich added a reviewer: mck182.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4425

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, mck182
Cc: #frameworks

[Differential] [Request, 393 lines] D4425: Add support for flatpak portals

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Creates a new flatpak notification plugin, which just forwards messages 
through
  DBus to xdg-desktop-portal service, otherwise there is no way for sandboxed 
applications
  to send notifications because of limited access. This plugin is used instead 
of
  notify by popup plugin if we detect we are in sandbox and the 
xdg-desktop-portal
  service is running

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4425

AFFECTED FILES
  src/CMakeLists.txt
  src/knotificationmanager.cpp
  src/notifybyflatpak.cpp
  src/notifybyflatpak.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich
Cc: #frameworks

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid  wrote:
> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure:
>> Hi everyone,
>>
>> We've just completed the registration of all mainline repositories
>> (not including Websites or Sysadmin namespaced ones) on Phabricator.
>> Thanks go to Luigi Toscano for providing significant assistance with
>> this process.
>>
>> From this point forward, communities should be moving away from
>> Reviewboard to Phabricator for conducting code review.
>
> I just created first patch with the phabricator web interface.
>
> Found one minor and one major problem.
>
> Minor problem:
>  * You can't update the diff before creating a "Revision", so if you realize
> your diff was wrong, back luck, you either leave the diff floating in the
> limbo or you create the Revision and the update the diff, showing the world
> your mistake for no reason
> https://phabricator.kde.org/D4422?vs=10881=10882

Interesting. It might be worth asking upstream about that.

>
>
> Major problem:
>  * It doesn't show context
> https://phabricator.kde.org/D4422
>
> "Context not available." is terrible, how is one supposed to review without
> being able to read the rest of the code?
>
> This is a deal breaker for me.

Please see https://secure.phabricator.com/T5029

This only occurs when patches are uploaded from the web interface and
the patch in question has minimal context.
At this time Phabricator is not able to automatically resolve context
using markers in the patch (there are certain complexities involved
for some SCMs, particularly for SVN - which Phabricator supports)

The fix for this is to either:
a) Use Arcanist, the recommended tool for working with Phabricator
(this is no different to rb-tools for Reviewboard)
b) Use "diff -U99" when generating your diffs for uploading to Phabricator

In regards to improvements in Diffusion (Repository Hosting) and
Differential (Code Review) please see the upstream task at
https://secure.phabricator.com/T12010 for the work which is currently
in active progress (many of these

>
> Cheers,
>   Albert

Regards,
Ben