GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/450/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Mar 2017 04:52:11 +
Build duration: 7 min 5 sec
CHANGE SET
Revision
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Like all the inbuilt shaders this now has a separate GLS source file which
works with a newer version without
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128426/
---
(Updated March 1, 2017, 2:33 a.m.)
Status
--
This change has been
ltoscano added a reviewer: dfaure.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4849
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano, dfaure
Cc: #frameworks, #documentation
ltoscano added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4850
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano, dfaure
Cc: #frameworks
ltoscano added a dependent revision: D4850: Use the new shared library exported
by KDocTools.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4849
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano
Cc: #frameworks,
ltoscano added a dependency: D4849: Export a proper shared library for
KDocTools.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4850
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano
Cc: #frameworks
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The only users are kio_help/kio_ghelp, so there should be no
API/ABI concerns.
TEST PLAN
It compiles against the shared KF5::DocTools
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
This is a unique situation, as the static library was supposed to be
temporary, and the only users are
davidedmundson updated this revision to Diff 11981.
davidedmundson added a comment.
Add @inherits
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4831?vs=11923=11981
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4831
davidedmundson added a comment.
I'm going to merge after Marco merges the QQC2 stuff that way we can inherit
directly from the newest label without having to worry about versioning this.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4831
EMAIL
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This matches what Qt does internally, it's easier to read and gives us
syntax highlighting on the shader files,
martinkostolny created this revision.
martinkostolny added a project: KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Before this patch: if one opens a write protected document, makes changes
vpilo added a comment.
In https://phabricator.kde.org/D4799#91109, @dfaure wrote:
> Yes interface->isServiceRegistered(dbusServiceName) is technically
blocking, but it can't block for a long time, since it's only talking to the
dbus daemon. The reply comes in rather quickly, unlike a
dfaure added a comment.
Yes interface->isServiceRegistered(dbusServiceName) is technically blocking,
but it can't block for a long time, since it's only talking to the dbus daemon.
The reply comes in rather quickly, unlike a blocking call to another KDE
process which could be busy or where
> [Differential] D4508: Plasma controls based on QtQuickControls2 [Commented
> On]
>
> I personally find that having a "vertical" line in which all the subjects of
> the differential emails start makes it much easier to read.
+1 I'd even shorten The 'Differential' part of it to just 'Diff'.
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/449/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Feb 2017 18:02:54 +
Build duration: 19 min
CHANGE SET
Revision f9d0cb47cf94e209f6171ac0e8d774e68156a6e4
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/449/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Feb 2017 18:02:54 +
Build duration: 19 min
CHANGE SET
Revision f9d0cb47cf94e209f6171ac0e8d774e68156a6e4
What do you think about rearranging the subject to move the
[Commented On]
[Changed Subscribers]
[Accepted]
[Updated, 2,978 lines]
etc
from the beginning to the end, i.e.
[Differential] [Updated, 2,978 lines] D4508: Plasma controls based on
QtQuickControls2
[Differential] [Commented On]
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D4508
REVISION DETAIL
https://phabricator.kde.org/D4508
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Label.qml:27
> It probably made sense when it was written, but your comments about layouts
> is outdated.
>
> No manual changes are needed.
>
> try:
> https://paste.kde.org/pgi2ui6e3
>
> If it was a problem we'd be seeing
mart updated this revision to Diff 11960.
mart added a comment.
- remove custom height
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4508?vs=11948=11960
BRANCH
arcpatch-D4508
REVISION DETAIL
https://phabricator.kde.org/D4508
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/448/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 28 Feb 2017 12:32:44 +
Build duration: 16 min
CHANGE SET
Revision
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in Label.qml:27
> the reason for the padding is that it makes it correctly vertically aligned
> with other widgets both in a Row and a RowLayout.
> without this default height, every label should be manually vertically
>
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2b3e8dfe866a: move setImagePath logic into
updateFrameData() (authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4707?vs=11632=11949#toc
REPOSITORY
R242 Plasma Framework
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in CMakeLists.txt:42
> It's easier to add something later than to remove it.
>
> I'd go with not installing for now, then revisit it. Maybe same for Menus.
ok. what about the combobox?
> davidedmundson wrote in Button.qml:28
>
mart updated this revision to Diff 11948.
mart marked 2 inline comments as done.
mart added a comment.
- don't install files that shouldn't
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4508?vs=11630=11948
BRANCH
arcpatch-D4508
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D4707
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
This revision was automatically updated to reflect the committed changes.
mart marked an inline comment as done.
Closed by commit R241:cae36e0efc65: make sure the cancel action is last
(authored by mart).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
mart updated this revision to Diff 11942.
mart added a comment.
remove dropmenu declaration from public header
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4739?vs=11682=11942
BRANCH
arcpatch-D4739
REVISION DETAIL
https://phabricator.kde.org/D4739
mart marked an inline comment as done.
mart added inline comments.
INLINE COMMENTS
> dfaure wrote in dropjob.h:38
> Not a good enough reason to have it in the public header (which doesn't use
> it anywhere), you can move that fwd decl to the .cpp file.
done
REPOSITORY
R241 KIO
REVISION
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D4739
REVISION DETAIL
https://phabricator.kde.org/D4739
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, #frameworks,
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in framesvg.cpp:804
> I don't understand this and the FrameData part of this change.
>
> q->imagePath() will still always be correct as before, you still set that in
> setImagePath() regardless of whether we are blocking
dfaure added inline comments.
INLINE COMMENTS
> mart wrote in dropjob.h:38
> used for class KIO::DropMenu : public QMenu in dropjob.cpp,
> doesn't compile otherwise
Not a good enough reason to have it in the public header (which doesn't use it
anywhere), you can move that fwd decl to the .cpp
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Nice. Note Kicker has some of those greyed out labels IIRC.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4831
EMAIL PREFERENCES
mart marked 4 inline comments as done.
mart added inline comments.
INLINE COMMENTS
> dfaure wrote in dropjob.h:38
> still here?
used for class KIO::DropMenu : public QMenu in dropjob.cpp,
doesn't compile otherwise
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4739
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:af2b27d1b89b: IconItem: Add roundToIconSize property
(authored by drosca).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4689?vs=11897=11934#toc
REPOSITORY
R242 Plasma Framework (Library)
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Almost good, you can add the signalspy and then ship it from my side.
INLINE COMMENTS
> iconitemtest.cpp:526
> +
> +item->setProperty("roundToIconSize", false);
> +
Might as well check
sebas added a comment.
I like it. If kbroulik is happy, consider that a +1 from me, too.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4831
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
broulik added inline comments.
INLINE COMMENTS
> DescriptiveLabel.qml:41
> + * properties, methods and signals.
> + */
> +Label {
@inherits ?
> DescriptiveLabel.qml:48
> + * property should be set to true when the label is being interacted
> with.
> + * The default is false
> + */
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6b70fd983b3c: [SliderStyle] Allow providing a
"hint-handle-size" element (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
vpilo added a comment.
@mck182 I didn't notice before, but KNotifications is already making blocking
calls on creation:
src/notifybypopup.cpp@182:
QDBusConnectionInterface *interface =
QDBusConnection::sessionBus().interface();
d->dbusServiceExists = interface &&
42 matches
Mail list logo
