Re: Test failures with networkmanager-qt

Hi, I didn't say you shouldn't investigate the cause. Could you please run the test with "-v2 -vs" parameters? Jan On úterý 28. března 2017 11:43:06 CEST Hartmut Goebel wrote: > Am 28.03.2017 um 08:10 schrieb Jan Grulich: > > I can't think of any reason why the test fails for you. Looking to

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 625 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/625/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 29 Mar 2017 02:27:24 + Build duration: 8 min 6 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 625 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/625/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 29 Mar 2017 02:27:24 + Build duration: 8 min 6 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 489 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/489/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 29 Mar 2017 01:58:10 + Build duration: 20 min CHANGE SET Revision

D5233: Fix build with Qt 5.9

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY kactivities-stats/tests/model/modeltest.cpp:455: undefined reference to `bool QTest::qCompare(int const&, unsigned int const&, char const*, char const*, char const*, int)'

D5231: Fix build with Qt branch 5.9

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY kitemmodels/autotests/proxymodeltestsuite/modeltest.cpp:464: undefined reference to `bool QTest::qCompare(int const&, unsigned int const&, char const*, char const*, char const*,

D4847: KAuth integration in document saving

martinkostolny marked 3 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel,

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12941. martinkostolny added a comment. Updating diff with refinements based on David's insights, thanks David! Regarding static slot, it was quite convenient to call it statically in unit test mode and it works. So I left it there like this. I

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > > > > > I don't see the advantage of using a single kauth action. This way you > > are generating

Jenkins-kde-ci: kapidox master stable-kf5-qt5 » Linux,gcc - Build # 174 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/174/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 20:50:47 + Build duration: 27 sec CHANGE SET Revision

Jenkins-kde-ci: kapidox master kf5-qt5 » Linux,gcc - Build # 173 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kapidox%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 20:50:47 + Build duration: 31 sec CHANGE SET Revision f654e484c09deb78585a0db4cd5dbb5485628267 by

Re: Scrap Baloo Thread Feedback

On Tue, Mar 28, 2017 at 5:21 AM, Matthieu Gallien < gallien.matth...@gmail.com> wrote: > Hello all, > > Sorry to exhume this old thread, but > > Is there a common agreement on the best path forward for Baloo versus > the current situation ? > > I have an interest in having a global KDE solution

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D5218 To: sitter, mdawson, apol Cc: #frameworks

D5215: [ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5215 To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

Re: Test failures with networkmanager-qt

Am 28.03.2017 um 11:43 schrieb Hartmut Goebel: > Which versions are you referring to in "the only relevant change". Guix > is currently lacking behind and still has 5.28, which we updated from > 5.27 (which passed tests). Update: The error occurs even with 5.32. -- Regards Hartmut Goebel |

D5167: Move .po and .ts files look-up to build-time

apol added a comment. Now it seems to work properly with scripts: $ LANGUAGE=pl kgeography KTranscript: Loaded property map: /home/apol/devel/kde5/share/locale/pl/LC_SCRIPTS/kgeography/general.pmapc KTranscript: Loaded module:

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12931. apol added a comment. Fix REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12930=12931 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED FILES CMakeLists.txt

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12930. apol added a comment. Fix several issues Properly test projects with ts and pmap files Make sure we install the files in the correct place Make sure we don't fail if the project calls KI18N_INSTALL twice REPOSITORY R249 KI18n CHANGES SINCE

D5174: Add support for wl_shell_surface::set_popup and popup_done

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6c89a61d2d17: Add support for wl_shell_surface::set_popup and popup_done (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

Re: Scrap Baloo Thread Feedback

Hello all, Sorry to exhume this old thread, but 2016-12-29 13:47 GMT+01:00 Dominik Haumann : > Hi all, > > CC: plasma-devel, due to stability issues > > On Fri, Oct 7, 2016 at 5:56 PM, Christoph Cullmann > wrote: >> Hi, >> > [...] >> Actually, the

Re: Test failures with networkmanager-qt

Am 28.03.2017 um 08:10 schrieb Jan Grulich: > I can't think of any reason why the test fails for you. Looking to the git > log > the only relevant change is fixed uninitialized state variable in > ActiveConnection, which may affect ActiveConnection::stateChanged() signal. So you suggest to

D5034: Add support for x-gvfs style options in fstab

broulik added a comment. If no-one objects I'll push this after the next frameworks release REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D5034 To: broulik, #plasma, dfaure, dhaumann Cc: dhaumann, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

D5056: [KCModuleProxy] Remove dead code

broulik added a comment. Ping REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D5056 To: broulik, dfaure Cc: ltoscano, #frameworks

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 278 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/278/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 13:01:43 + Build duration: 5 min 57 sec CHANGE SET No changes JUNIT RESULTS Name:

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit R244:3e9993625cf3: explicitly set NO_CMAKE_FIND_ROOT_PATH (authored by sitter). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5217?vs=12913=12915 REVISION DETAIL

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When using a toolchain file one often would want to set a CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent native

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5217 To: sitter, apol, mpyne Cc: #frameworks

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When using a toolchain file one often would want to set a CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent native

D5215: [ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Clicking the "add widgets" button multiple times in widget explorer no longer crashes/confuses it because the Repeater

D5200: [Calendar] Shrink and elide week names like is done with day delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5ae0651045c2: [Calendar] Shrink and elide week names like is done with day delegate (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5214: [Icon Item] Make "smooth" property actually do something

This revision was automatically updated to reflect the committed changes. Closed by commit R242:611a4b592055: [Icon Item] Make "smooth" property actually do something (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5212: support building against a qt without a11y enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9dac68ab5b64: support building against a qt without a11y enabled (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5212?vs=12902=12906

D5174: Add support for wl_shell_surface::set_popup and popup_done

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH popup-done REVISION DETAIL https://phabricator.kde.org/D5174 To: graesslin, #plasma_on_wayland, #frameworks, #kwin, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5200: [Calendar] Shrink and elide week names like is done with day delegate

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5200 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5214: [Icon Item] Make "smooth" property actually do something

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5214 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5208: Allow loading i18n catalogs from arbitrary locations

ilic added inline comments. INLINE COMMENTS > klocalizedstring.h:558 > > +static void addDomainLocaleDir(const QByteArray , const QString > ); > + Misses docstring. It should be made clear that this method is for "special purposes" (e.g. plugins and whatnot), and that normal programs

D5208: Allow loading i18n catalogs from arbitrary locations

ilic requested changes to this revision. ilic added a comment. This revision now requires changes to proceed. I think it's fine to add this capability, especially given that Gettext (which Ki18n is an extension of) not only has it, but uses it exclusively (it does not search through any

D5212: support building against a qt without a11y enabled

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5212 To: sitter, cfeck Cc: #frameworks

D5214: [Icon Item] Make "smooth" property actually do something

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We had m_smooth but never actually used it in the texture node. With Plasma SVG icons this shouldn't be used but when

D5212: support building against a qt without a11y enabled

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5212 AFFECTED FILES src/kcollapsiblegroupbox.cpp To:

D5202: [Default Tooltip] Fix icon size

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7487e208b696: [Default Tooltip] Fix icon size (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5202?vs=12878=12900

D4911: add Baloo DBus signals for moved or removed files

mgallien added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien, vhanda, dfaure Cc: cullmann, apol, #frameworks

D4911: add Baloo DBus signals for moved or removed files

mgallien reclaimed this revision. mgallien added a comment. Reopening since I am still convinced that getting signals from Baloo is a lot more sane than adding workaround in each users of Baloo. My point is that for a music player like the one I am working on (Elisa), I have to do the

D5202: [Default Tooltip] Fix icon size

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5202 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5209: Load translations from KPackage files if bundled

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 624 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/624/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 07:05:22 + Build duration: 5 min 29 sec CHANGE SET No changes JUNIT RESULTS

D5143: Introduce fetch-translations build command

sitter added a comment. Oh! OTOH, given fetch-translations pulls it into bin_dir while normally we'd have it in src_dir this may well be awkward in implementation. e.g. https://phabricator.kde.org/D5197 effectively ought to be ki18n_install("${CMAKE_SOURCE_DIR}/po")

D5143: Introduce fetch-translations build command

sitter added a comment. In https://phabricator.kde.org/D5143#97985, @apol wrote: > In https://phabricator.kde.org/D5143#97847, @aacid wrote: > > > That creates a dependency for ki18n for frameworks that only use .ts files, no? > > > One thing we can do is remove the

D5195: don't add the autotests dir when test building is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R249:16750048daf7: don't add the autotests dir when test building is disabled (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5195?vs=12859=12894

Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 66 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 06:06:36 + Build duration: 2 min 40 sec CHANGE SET Revision

Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 66 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 06:06:36 + Build duration: 2 min 40 sec CHANGE SET Revision

Re: Test failures with networkmanager-qt

Hi, I can't think of any reason why the test fails for you. Looking to the git log the only relevant change is fixed uninitialized state variable in ActiveConnection, which may affect ActiveConnection::stateChanged() signal. Regards, Jan On pondělí 27. března 2017 18:02:05 CEST Hartmut

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 06:06:36 + Build duration: 2 min 40 sec CHANGE SET Revision

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 06:06:36 + Build duration: 2 min 40 sec CHANGE SET Revision