jpoelen added a reviewer: Framework: Syntax Hightlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6128
To: jpoelen, #framework_syntax_hightlighting
Cc: #frameworks
jpoelen updated this revision to Diff 15240.
jpoelen added a comment.
- cmake test: add an expression with nested parenthesis
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6128?vs=15239=15240
BRANCH
upstream
REVISION DETAIL
jpoelen updated this revision to Diff 15239.
jpoelen added a comment.
Previous diff on bad branch
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6128?vs=15238=15239
BRANCH
upstream
REVISION DETAIL
https://phabricator.kde.org/D6128
jpoelen updated this revision to Diff 15238.
jpoelen edited the summary of this revision.
jpoelen added a comment.
- Update test reference data
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6128?vs=15237=15238
BRANCH
upstream
REVISION
jpoelen retitled this revision from "CMake: OR/AND not highlighted after expr
in () If you type in "if((A AND B) OR C)", "OR" is not highlighted." to "Bug
360656 - CMake: OR/AND not highlighted after expr in ()".
jpoelen edited the summary of this revision.
jpoelen edited the test plan for this
jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R216 Syntax Highlighting
BRANCH
upstream
REVISION DETAIL
https://phabricator.kde.org/D6128
AFFECTED FILES
data/syntax/cmake.xml
To:
apol added a comment.
+1 would it make sense to add a clazy check that identifies uses of this
method? Or deprecating the method altogether?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6126
To: davidedmundson, #plasma
Cc: apol, plasma-devel, kwrite-devel,
apol abandoned this revision.
apol added a comment.
dfaure fixed it separately in commit
https://phabricator.kde.org/R241:aafa5b7bbc89301c478f8089d6738a4c5896bcac
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6042
To: apol, #frameworks
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, kwrite-devel,
plasma-devel.
REVISION SUMMARY
QPaintDevice::devicePixelRatio was replaced by devicePixelRatioF when Qt
supported fractional
sars added a comment.
I think I fixed it.
The comment about the dragging was only partially correct. The press must be
inside the slider for dragging, so when the initial press is outside or not
translated from the mini-map coordinates, the dragging does not start.
My solution is to
cfeck added a comment.
The patch is simple, but it is always a good idea to ask for a review.
Since this frameworks is new as of 5.28, should we really mark each class
this way? We did not do this for other "new" frameworks, such as prison or
kwayland.
REPOSITORY
R216 Syntax
dhaumann added a comment.
Hi, I'm sorry I am a bit late to the game: I once also tried to implement
this, but the result was a messy patch that did not always get the location
right. So I would not be surprised if there are corner cases that do not work.
In any case, either we stabilize
tfry created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
I hate having to look up when interesting new classes were added.
Patch is straight-forward (I think), but:
- should @since be added on all memebers, when it's already on the class?
- would
zhigalin added reviewers: Kate, KTextEditor.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6121
To: zhigalin, #kate, #ktexteditor
Cc: #frameworks
zhigalin created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Angular uses special characters in HTML atributes
This disables the error highlighting for []()*# in HTML tag attributes
TEST PLAN
Hi packagers,
(cc: to kde-frameworks-devel only for heads-up)
with ECM/KF5 5.35.0 now snapshot and being prepared for release, a new feature
has already been pushed to the master branches of ECM and almost all the non-
deprecated KF5 modules, which might need some more fine-tuning in the few
BUILD SUCCESS
Build URL
https://build-sandbox.kde.org/job/Frameworks%20khtml%20kf5-qt5%20XenialQt5.7/10/
Project:
Frameworks khtml kf5-qt5 XenialQt5.7
Date of build:
Tue, 06 Jun 2017 15:09:55 +
Build duration:
5 min 9 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20khtml%20kf5-qt5%20XenialQt5.7/9/
Project:
Frameworks khtml kf5-qt5 XenialQt5.7
Date of build:
Tue, 06 Jun 2017 15:05:15 +
Build duration:
3 min 50 sec and counting
CONSOLE OUTPUT
kfunk added a comment.
There are a couple of problems with the new behavior -- though I can't tell
precisely when they're caused. And not sure they're new or not either.
Things I'm seeing while mini map is enabled, only in some documents though:
- When the slider is position at the
BUILD SUCCESS
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Tue, 06 Jun 2017 13:36:17 +
Build duration:
55 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/7/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Tue, 06 Jun 2017 13:33:52 +
Build duration:
37 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:563011436d5f: Port a bunch of classes away from
Plasma::Package (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:75031fb7a53a: Use the right scope for the installpath
variable (authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6104?vs=15181=15219
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:00aa6b29644b: Make it possible to use QXmlStreamReader to
read a KNS registry file (authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D6067#114528, @apol wrote:
> In https://phabricator.kde.org/D6067#114498, @leinir wrote:
>
> > On a similar note to handling comments, how does it now
On Sat, Jun 3, 2017 at 11:32 AM, David Faure wrote:
> On mardi 30 mai 2017 16:18:42 CEST Aleix Pol wrote:
>> On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano
> wrote:
>> > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote:
>> >> Is there a reason
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:ffb40b433368: Update introspections (NM 1.8.0) (authored
by jgrulich).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6115?vs=15209=15211#toc
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE
jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
There is a new additional StateChanged() signal coming from NetworkManager
with additional reason property so
with that we can now check
jgrulich added a reviewer: lvsouza.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6116
To: jgrulich, lvsouza
Cc: #frameworks
jgrulich abandoned this revision.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6115
To: jgrulich
Cc: #frameworks
jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add new stateChanged() signal to active connection
There is a new additional StateChanged() signal coming from NetworkManager
with
apol added a comment.
In https://phabricator.kde.org/D6067#114498, @leinir wrote:
> On a similar note to handling comments, how does it now handle
unknown/garbage tags? While it won't affect the cache code, it would
potentially affect other things (ocs is not guaranteed to be perfectly
> On Feb. 13, 2015, 12:06 a.m., Kevin Funk wrote:
> > You're aware that Kate (and any other decent editor) has session management
> > which probably solves your issue? It saves the session when you close it,
> > and re-opens all the files that had been opened.
>
> Thomas Murach wrote:
>
leinir added a comment.
On a similar note to handling comments, how does it now handle
unknown/garbage tags? While it won't affect the cache code, it would
potentially affect other things (ocs is not guaranteed to be perfectly formed,
and it's one of the ways the framework's retained
elvisangelaccio updated this revision to Diff 15197.
elvisangelaccio added a comment.
- Bumped @since
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6008?vs=14932=15197
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6008
AFFECTED FILES
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Personally less fond of auto than you are... But, that is just me, and this
is a framework, and it's fine :) A massive reduction in allocations is a very
good thing, go for it :)
kfunk added a comment.
+1 from my side -- Please wait for another +1 from another person.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6102
To: arrowdodger, #frameworks
Cc: kfunk
37 matches
Mail list logo