nalvarez added a comment.
I knew the text of RFCs was under a somewhat-restrictive license. I didn't
know code snippets were explicitly excluded and BSD'd instead. We can work with
that then :)
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
jkt added a comment.
Re "extracting bits from the RFC", RFC 6020 says (among other things) that
//"Code Components extracted from this document must include Simplified BSD
License text as described in Section 4.e of the Trust Legal Provisions and are
provided without warranty as described
jkt accepted this revision.
jkt added a comment.
Oops, sorry, I forgot to comment here. I appreciate your conversion, it works
really nicely!
Compared to the vim version, my QtCreator theme is not highlighting the
`true` and `false` keywords in statements such as `mandatory true;`.
nalvarez added a comment.
Sorry, I don't know enough about the language to provide a meaningful test. I
made these highlighting rules on request by @jkt, partly translating the .vim
file and partly reading the RFC, without even understanding what the language
is for. I was hoping he could
tcberner updated this revision to Diff 15532.
tcberner added a comment.
Fix identation.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6253?vs=15531=15532
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6253
AFFECTED FILES
tcberner edited the summary of this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D6253
To: tcberner, #freebsd, dfaure
Cc: #frameworks
tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
FreeBSD also as sys/inotify.h available, but it is a library.
We added FindInotify.cmake to ecm a while a go for this, but never got
adridg abandoned this revision.
adridg added a comment.
https://phabricator.kde.org/R159:b5e20a709fbef7015874e9536cc06e5aa22aa5c0
REPOSITORY
R159 KActivities Statistics
REVISION DETAIL
https://phabricator.kde.org/D5715
To: adridg, ivan
Cc: apol, #frameworks
BUILD SUCCESS
Build URL
https://build-sandbox.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.7/24/
Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 17 Jun 2017 18:47:16 +
Build duration:
2 min 4 sec and counting
JUnit
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:28833ae05d00: Extend unittests to test stable sort.
(authored by adridg).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6049?vs=15016=15530
REVISION DETAIL
aacid added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in file.cpp:1382
> Can't this go in file_unix.cpp, without ifdefs?
Why is there an ifdef anyway? KAuth has at least a mac backend (no idea how
much it works) but adding an ifdef at this level seems the wrong thing to do.
dhaumann added a comment.
I am not yet convinced this is a good idea: We changed the foreground color
of highlighted text just recently:
https://git.reviewboard.kde.org/r/127554/diff/2/
The idea is to have just one color for search results that need to match.
This currently is the
dhaumann added a comment.
@gszymaszek Could you also add a unit test to autotest/input/highlight.less ?
This way, we can guarantee to not break the highlighting with future changes,
which is very hard otherwise. The reference data is created by calling
autotest/update-reference-data.sh in
dhaumann added a comment.
@nalvarez Ping? Essentially, you're good to go. It would help, if you could
add a unit test for this (autotest/input/) along with the reference data (use
the script autotest/update-reference-data.sh in your build folder to update
this into the src folder).
dhaumann added a comment.
@broulik Ping. Is there anything that keeps you from submitting this?
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D5034
To: broulik, #plasma, dhaumann, dfaure
Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
Any news on this? Also, do we have a unit test on this? Please decide on one
version and make a review request again to get this done.
REPOSITORY
R216 Syntax Highlighting
dhaumann added a comment.
Please everyone: If you make changes to .xml files, please ALWAYS (!!!)
increase the version numbers. Otherwise the files will not get picked up by
Kate's download dialog and other scripts that run in the background on
http://kate-editor.org. This is important.
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c81a3cad: Makefile: increase version number (authored
by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6180?vs=15341=15524#toc
REPOSITORY
R216 Syntax Highlighting
CHANGES
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
ping?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D4716
To: arichardson, dhaumann, vkrause
Cc: #frameworks
dfaure added a comment.
I don't use wayland, I use X11. I bet I'm not the only one. As long as that's
the case, fixing bugs in the X11 implementation makes a lot of sense.
Man it's demotivating to contribute to KDE. Users say all sorts of bad things
about KDE, and then
dhaumann added a comment.
@arrowdodger Isn't there a line missing:
+
+
+
<-- This line ?
+
Also, is the lineEndContext #pop or should it rather be #stay?
Please clarify/confirm.
Also: could you provide us with a small demo code
dfaure updated this revision to Diff 15522.
dfaure added a comment.
Adjustments suggested by Martin Graesslin
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6233?vs=15487=15522
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6233
dfaure added inline comments.
INLINE COMMENTS
> graesslin wrote in kkeyserver.cpp:160-180
> This looks very unrelated to the described change. Maybe an own commit?
Well those are the XK_KP_* codes, i.e. Num Keypad keys, so it's related. But
yeah, it would probably work without this change, it
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
I will change the patch slightly and commit: Instead of StringDetect, we
better use WordDetect. Also, we need to increase the version="" number. Besides
that, the patch looks good.
dfaure added inline comments.
INLINE COMMENTS
> dolphinview.cpp:667
> const QList list = simplifiedSelectedUrls();
> +KFileItemList itemList;
> +foreach(QUrl u , list) {
itemList.reserve(list.count());
> dolphinview.cpp:668
> +KFileItemList itemList;
> +foreach(QUrl u ,
> On June 5, 2017, 12:53 p.m., Aleix Pol Gonzalez wrote:
> > I can see how this could be useful, but then it can be weird when '<' is
> > used as less-than.
Indeed, this patch is problematic, since < and > is very often not balanced. As
Aleix noted, this is the case for less than and greater
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Add a note that the 'session' and 'always' values are meaningless with
the polkit-1 backend, and explain what they actually do.
REPOSITORY
R283 KAuth
BRANCH
master
REVISION
chinmoyr updated this revision to Diff 15518.
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6199?vs=15390=15518
REVISION DETAIL
https://phabricator.kde.org/D6199
AFFECTED FILES
src/dolphinmainwindow.cpp
src/views/dolphinview.cpp
To: chinmoyr,
chinmoyr updated this revision to Diff 15517.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15516=15517
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
src/ioslaves/file/file.cpp
src/ioslaves/file/file_unix.cpp
chinmoyr updated this revision to Diff 15516.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15388=15516
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
src/ioslaves/file/file.cpp
src/ioslaves/file/file_unix.cpp
chinmoyr updated this revision to Diff 15515.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=15385=15515
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
autotests/kiotesthelper.h
src/core/jobuidelegateextension.h
palimaka updated this revision to Diff 15514.
palimaka added a comment.
Fix indentation.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6249?vs=15512=15514
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6249
AFFECTED FILES
palimaka added a reviewer: kossebau.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6249
To: palimaka, #frameworks, kossebau
Cc: asturmlechner, #build_system
palimaka created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REVISION SUMMARY
Passing NO_DEFAULT_PATH ignores $PATH and ensures that we use the
previously-detected Qt5 binary path.
TEST PLAN
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> file.actions:3
> +Name=Remove items as a privileged user.
> +Description=Remove items as a privileged user.
> +Policy=auth_admin
Let's
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
If I don't enter the authentication password, after ~20 seconds I get the
"Access denied to " error. Is this some timeout in the ioslave?
INLINE COMMENTS
>
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6246
To: hein, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
graesslin added a comment.
> I need to point out that this creates a functional difference to Wayland
and according to the latest rules of Plasma such changes are no longer allowed
unless the implementation is done first for Wayland.
After reading through KWin code together with your
38 matches
Mail list logo
