KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 28 Jul 2017 02:37:59 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447Failed: TestSuite.completion_test build.log Description: Binary data
D6946: Emit connectionDied if the QPA is destroyed
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6946 To: davidedmundson, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6727: Destroy all kwayland objects created by registry when it is destroyed
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D6727 To: davidedmundson, graesslin Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6772: Fix usage of query_qmake: differ between calls expecting qmake or not
kossebau added a comment. In https://phabricator.kde.org/D6772#129531, @apol wrote: > Works for me. > Are you sure we don't need to include the `TRY` on other calls? Any calls you would be thinking off? The ones where this patch does not add `TRY` are in code which expects qmake to exist and the method to return a proper value, and which do not have a fallback plan if it doesn't. Which boils down to the case where the user explicitly set `KDE_INSTALL_USE_QT_SYS_PATHS` to `TRUE` but no qmake-qt5 is around. These are the calls I am aware off, and where TRY is only passed if failing is handled directly or rather indirectly): kde-modules/KDEInstallDirs.cmake:query_qmake(qt_install_prefix_dir QT_INSTALL_PREFIX TRY) kde-modules/KDEInstallDirs.cmake:query_qmake(qt_plugins_dir QT_INSTALL_PLUGINS) kde-modules/KDEInstallDirs.cmake:query_qmake(qt_imports_dir QT_INSTALL_IMPORTS) kde-modules/KDEInstallDirs.cmake:query_qmake(qt_qml_dir QT_INSTALL_QML) kde-modules/KDEInstallDirs.cmake:query_qmake(qt_docs_dir QT_INSTALL_DOCS) modules/ECMAddQch.cmake:query_qmake(qt_docs_dir QT_INSTALL_DOCS TRY) modules/ECMGeneratePriFile.cmake:query_qmake(qt_install_prefix_dir QT_INSTALL_PREFIX TRY) modules/ECMGeneratePriFile.cmake: query_qmake(qt_host_data_dir QT_HOST_DATA) REPOSITORY R240 Extra CMake Modules BRANCH handlenoqmakefound REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system
D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f9eb528acffc: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6685?vs=16663=17292 REVISION DETAIL https://phabricator.kde.org/D6685 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h To: elvisangelaccio, #frameworks, dfaure
D6772: Fix usage of query_qmake: differ between calls expecting qmake or not
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Works for me. Are you sure we don't need to include the `TRY` on other calls? REPOSITORY R240 Extra CMake Modules BRANCH handlenoqmakefound REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system
D6772: Fix usage of query_qmake: differ between calls expecting qmake or not
kossebau marked an inline comment as done. kossebau added a comment. If there are no objections, will push on Saturday, 29th July REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system
Re: Disable automatic connection switch
Hi, On středa 19. července 2017 10:03:55 CEST Federico Buti wrote: > Hi list. > > I've been tasked from my boss to write a little wrapper for > NetworkManagerQt to provide specific operations suited from the devices of > my company. > > Currently the devices have wifi, umts modem and ethernet interfaces. The > latter should not be used to communicate with our server thus I've added > "never-default = true" to the eth. configuration we create. In most of > other connections we heavily rely on "autoConnect" set to true so that once > a connection with higher priority is available the NM just switches to that > (e.g. umts modem to wifi). > That should work, using "never-default" means that the connection won't be the default one used for regular network traffic. > So far, so good. Among the requirements of the API I should provide there > must be a function do disable the automatic switch of connections. In > certain cases we want that the current primary connection remains the > primary one even if a connection with higher priority is available. > > I thought about using again "never-default". Once my API to disable > connections switch is called I simply set "never-default" to true on all > the available connections expect the primary one. That is the most obvious > approach I could come up with by reading NM API documentation. > I think this would work only in case you set "never-default" before the new connection gets activated, if you use "autoconnect" then you won't have a chance to do so and you will have to re-connect the new connection again to take the new configuration. > Now, questions time: > >- Is my interpretation of the NM API correct? >- Is it the "right" approach? >- Is there a more smart/easy approach? > I think the best would be to ask NM devs what could be the best approach for this and whatever solution they come up with, then you should be able to use NMQT for that as well. Regards, Jan
Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl
> On Nov. 20, 2016, 9:52 p.m., David Faure wrote: > > I forgot to review this, sorry for the delay. Sorry my own delay. Thanks for the detailled review. Everything should be fixed now. - Gregor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127111/#review100988 --- On July 27, 2017, 11:15 a.m., Gregor Mi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127111/ > --- > > (Updated July 27, 2017, 11:15 a.m.) > > > Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus. > > > Bugs: 335616 > https://bugs.kde.org/show_bug.cgi?id=335616 > > > Repository: kio > > > Description > --- > > Moved logic from https://git.reviewboard.kde.org/r/123253 to here. > > Provides a signal to implement bug > https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent > folder selects child folder". > > > Diffs > - > > autotests/CMakeLists.txt 83b7b73b4b92e09076ece2d4618559ddb8089368 > autotests/urlutiltest.cpp PRE-CREATION > src/filewidgets/kurlnavigator.h ff155c7bbdc8c72f579f730993286a4dccae6338 > src/filewidgets/kurlnavigator.cpp 033046f06dd5bea3f4124669c55803aba3a31789 > src/filewidgets/urlutil_p.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127111/diff/ > > > Testing > --- > > > Thanks, > > Gregor Mi > >
Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127111/ --- (Updated July 27, 2017, 11:15 a.m.) Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus. Changes --- * Rename urlutil.h to urlutil_p.h * Remove include QDebug which is no longer used * Rename local variables to better reflect the meaning (childPath, parentPath) * Remove confusing or useless comments; fix other comments * unit test: Move urlutil test from tests to autotest * unit test: Replace ugly _LURL_ preprocessor macro with inline function * unit test: remove plain wrong call of QUrl::fromLocalFile with a path containing an URL scheme * unit test: add a test with # in the path to find potential path/url confusion in the code * unit test: all tests pass Bugs: 335616 https://bugs.kde.org/show_bug.cgi?id=335616 Repository: kio Description --- Moved logic from https://git.reviewboard.kde.org/r/123253 to here. Provides a signal to implement bug https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder". Diffs (updated) - autotests/CMakeLists.txt 83b7b73b4b92e09076ece2d4618559ddb8089368 autotests/urlutiltest.cpp PRE-CREATION src/filewidgets/kurlnavigator.h ff155c7bbdc8c72f579f730993286a4dccae6338 src/filewidgets/kurlnavigator.cpp 033046f06dd5bea3f4124669c55803aba3a31789 src/filewidgets/urlutil_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127111/diff/ Testing --- Thanks, Gregor Mi
D6914: Switch from QtScript to QtQml
carewolf updated this revision to Diff 17281. carewolf edited the summary of this revision. carewolf added a comment. Fixed ruby tests REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6914?vs=17224=17281 REVISION DETAIL https://phabricator.kde.org/D6914 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/src/bug313759.cpp autotests/src/bug317111.cpp autotests/src/script_test_base.cpp autotests/src/scriptdocument_test.cpp autotests/src/templatehandler_test.cpp autotests/src/testutils.cpp autotests/src/testutils.h autotests/src/vimode/CMakeLists.txt src/CMakeLists.txt src/include/ktexteditor/cursor.h src/script/data/indentation/ada.js src/script/data/indentation/cstyle.js src/script/data/indentation/pascal.js src/script/data/indentation/ruby.js src/script/katecommandlinescript.cpp src/script/kateindentscript.cpp src/script/katescript.cpp src/script/katescript.h src/script/katescriptdocument.cpp src/script/katescriptdocument.h src/script/katescripthelpers.cpp src/script/katescripthelpers.h src/script/katescriptview.cpp src/script/katescriptview.h src/script/scriptcursor.h src/script/scriptrange.h src/utils/katetemplatehandler.cpp To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6856: Reset url in closeUrl()
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH reset-url-in-closeUrl REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
D6856: Reset url in closeUrl()
elvisangelaccio marked an inline comment as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
D6856: Reset url in closeUrl()
elvisangelaccio edited the summary of this revision. elvisangelaccio edited the test plan for this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
D6856: Reset url in closeUrl()
elvisangelaccio updated this revision to Diff 17278. elvisangelaccio added a comment. - Drop TODO REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6856?vs=17247=17278 BRANCH reset-url-in-closeUrl REVISION DETAIL https://phabricator.kde.org/D6856 AFFECTED FILES autotests/parttest.cpp autotests/parttest.h src/readonlypart.cpp src/readonlypart.h src/readonlypart_p.h To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
D6941: fix plasmashell unsetting QSG_RENDER_LOOP
This revision was automatically updated to reflect the committed changes. Closed by commit R296:886dd7aaa33d: fix plasmashell unsetting QSG_RENDER_LOOP (authored by mkoller). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6941?vs=17258=17276 REVISION DETAIL https://phabricator.kde.org/D6941 AFFECTED FILES src/quickaddons/qtquicksettings.cpp To: mkoller, davidedmundson Cc: #frameworks
D6727: Destroy all kwayland objects created by registry when it is destroyed
davidedmundson updated this revision to Diff 17272. davidedmundson added a comment. Updated docs + unit test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6727?vs=16758=17272 BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D6727 AFFECTED FILES autotests/client/test_wayland_registry.cpp src/client/blur.h src/client/contrast.h src/client/datadevice.h src/client/datadevicemanager.h src/client/dataoffer.h src/client/datasource.h src/client/dpms.h src/client/event_queue.h src/client/fakeinput.h src/client/idle.h src/client/output.cpp src/client/output.h src/client/outputconfiguration.h src/client/outputdevice.cpp src/client/outputdevice.h src/client/outputmanagement.h src/client/plasmashell.h src/client/plasmawindowmanagement.h src/client/pointerconstraints.h src/client/pointergestures.h src/client/registry.cpp src/client/registry.h src/client/relativepointer.h src/client/seat.h src/client/server_decoration.h src/client/shadow.h src/client/shm_pool.h src/client/slide.h src/client/surface.h src/client/textinput.h src/client/xdgshell.h To: davidedmundson Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6946: Emit connectionDied if the QPA is destroyed
davidedmundson created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6946 AFFECTED FILES src/client/connection_thread.cpp To: davidedmundson Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6829: Add ability to use the new kauth helper in file ioslave
dfaure added inline comments. INLINE COMMENTS > slavebase.cpp:1464 > +QByteArray buffer; > +buffer.setNum(0); > +send(MSG_PRIVILEGE_EXEC); Better in one line: const QByteArray buffer = "0"; > file.h:115 > +}; > +virtual bool execWithElevatedPrivilege(int error, ActionType action, > const QVariant , > + const QVariant = QVariant(), Why virtual? Nothing inherits from this class, right? REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6832: Integrate new file ioslave in KIO job
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good, apart from a few minor things. INLINE COMMENTS > job.cpp:276 > +// Whether or not sub-jobs have PrivilegeExecution flag set > doesn't matter. > +// If its not set in parent job then don't continue. > +return false; its -> it's > job_p.h:197 > + * > + * @since 5.37 > + */ Private header -> no need for @since doc, it's not part of the API. > simplejob.cpp:346 > +bool confirmed = tryAskPrivilegeOpConfirmation(); > +m_slave->send(MSG_PRIVILEGE_EXEC, QByteArray::number(confirmed)); > +} I'm not sure if the bool->int conversion is safe and guaranteed (AFAIK, in theory a bool can convert to 2 or anything else that is not 0, depending on how it was set in the first place) This would be safer if it said QByteArray::number(confirmed ? 1 : 0), but then that's even better written as confirmed ? "1" : "0", no need to call int->string conversion code; REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6833: Add support for PrivilegeExecution in KIO jobs
dfaure added a comment. Ah, well, if the flag is completely unused in subjobs then yes sure, just remove the code that adds it. REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6833: Add support for PrivilegeExecution in KIO jobs
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > chinmoyr wrote in copyjob.cpp:1674 > Ideally it should be set when m_privilegeExecutionEnabled is true. But it > will add more lines. Even though its just 2-3 lines, it doesn't look good. > Besides the flag is ineffective if the parent job doesn't have this flag set. > Shall I remove it? To me it looks worse to unconditionally pass a security-critical flag when it shouldn't be set, it reads like a security hole (even if, as you say, upon further research it turns out that the flag has no effect). Maybe make it a helper method flagsForSubJob() to avoid any duplication. BTW isn't the flag missing for the KIO::symlink case above? > copyjob.cpp:294 > +break; > +default: > +break; Remove default statement, which would leave the variable uninitialized. This way the compiler will warn if a new value is added to the CopyMode enum. REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6685 To: elvisangelaccio, #frameworks, dfaure
