BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/44/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 05 Aug 2017 02:45:47 +
Build duration:
19 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20WindowsQt5.7/12/
Project:
Frameworks kdesignerplugin kf5-qt5 WindowsQt5.7
Date of build:
Fri, 04 Aug 2017 21:30:53 +
Build duration:
23 min and counting
JUnit
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7142
To: dfaure, dmariano, davidedmundson
Cc: #frameworks
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
> on multiscreen systems, the notification dialog gets resized to 0x0
> by someone else (either kwin, notification applet or Qt code)
So which is it?
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6834
To: chinmoyr, dfaure
Cc: #frameworks
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Please resubmit with context.
Also, did you check that unittests still pass? No kauth prompt should occur
:-)
INLINE COMMENTS
> file.cpp:242
> #if defined(ENOTSUP)
> -
dfaure added inline comments.
INLINE COMMENTS
> file_unix.cpp:659
> +{
> +if (error != EACCES || !isPrivilegeOperationAllowed()) {
> +return false;
with EPERM we should try as root too, no?
(e.g. for unlink, rename, chown...)
REVISION DETAIL
https://phabricator.kde.org/D6829
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
The diff has no context in phabricator, which is a problem for this one (e.g.
for the "do we need this here?" questions). Can you upload the update using
`arc diff` for example?
INLINE
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Urls without schemes shouldn't really happen, so this fix doesn't make me too
happy. I debugged this KCM a bit and it seems the issue is the commit that
prepends a scheme (like
dfaure created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
commit
https://phabricator.kde.org/R241:4e2a52c67167507b62553ca595bb561b925dc440
prepends a scheme (like socks://), which interfers with
the assumption that after the first ':' comes the port.
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It's not necessary, and it breaks when cross-compiling, as find_file
changes its behavior then.
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7136
vkrause updated this revision to Diff 17727.
vkrause added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Fix homepage URL
REPOSITORY
R868 Yocto: KDE Frameworks Packaging
CHANGES SINCE LAST UPDATE
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi added a comment.
BUG: 369646
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi added a reviewer: elvisangelaccio.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano
Cc: ltoscano, #frameworks
gregormi updated this revision to Diff 17723.
gregormi edited the summary of this revision.
gregormi added a comment.
- add FSearch and AngrySearch to search tools
- Add new grouping "screenrecorder" with Peek and Simples Screen Recorder
- Add new grouping "mouse-tools"
- Add new
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:ba75a6c6a023: Allow to build KConfig without Qt5Gui
(authored by vkrause).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6994?vs=17588=17722
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:703b48665f3d: Allow to build KSyntaxHighlighter without
Qt5Gui (authored by vkrause).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e7dcacfe64bf: Add cross-compilation support for the
highlighting indexer (authored by vkrause).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks kdesignerplugin kf5-qt5 XenialQt5.7
Date of build:
Fri, 04 Aug 2017 16:23:48 +
Build duration:
2 min 25 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20FreeBSDQt5.7/8/
Project:
Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 04 Aug 2017 16:23:48 +
Build duration:
1 min 6 sec and counting
gregormi added a comment.
In https://phabricator.kde.org/D7130#132409, @ltoscano wrote:
> Just update the English messages.
> More generally, why do we need copies of the system desktop files (even
the ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use
the
ltoscano added a comment.
Just update the English messages.
More generally, why do we need copies of the system desktop files (even the
ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use the
existing desktop files if installed? We don't want to duplicate what
mart updated this revision to Diff 17712.
mart added a comment.
- fix check
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7127?vs=17704=17712
BRANCH
arcpatch-D7127
REVISION DETAIL
https://phabricator.kde.org/D7127
AFFECTED FILES
gregormi added a comment.
In https://phabricator.kde.org/D7130#132397, @ltoscano wrote:
> I think there is more than what you want: the translations of desktop are
handled automatically by scripty.
Thanks for the hint. I copied the desktop files from the system installation.
I
mart marked an inline comment as done.
mart added inline comments.
INLINE COMMENTS
> broulik wrote in dialog.cpp:1045
> So it will never update its size? Shouldn't it be size == oldSize?
ouch, sure, sorry :)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.
I think there is more than what you want: the translations of desktop are
handled automatically by scripty.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
gregormi retitled this revision from "Update and fix desktopfiles" to
"KMoreTools: Update and fix desktopfiles".
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano
Cc: ltoscano, #frameworks
gregormi created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
AFFECTED FILES
autotests/kmoretools/kmoretoolstest.cpp
kfunk added inline comments.
INLINE COMMENTS
> ktimecombobox.cpp:33
> +public:
> +KTimeValidator(QString timeFormat, QObject *parent = Q_NULLPTR);
> +KTimeValidator(QString timeFormat, QTime min, QTime max, QObject *parent
> = Q_NULLPTR);
Here and below: `nullptr` can be used directly
matank added a comment.
I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves
the issue.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7071
To: matank, #plasma, davidedmundson
Cc: mart, plasma-devel, davidedmundson,
broulik added inline comments.
INLINE COMMENTS
> dialog.cpp:1045
>
> +if (re->size().isEmpty() || re->size() != re->oldSize()) {
> +return;
So it will never update its size? Shouldn't it be size == oldSize?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
mart updated this revision to Diff 17706.
mart added a comment.
remove unrelated changes
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6964?vs=17703=17706
BRANCH
arcpatch-D6964
REVISION DETAIL
https://phabricator.kde.org/D6964
mart added a comment.
looking into it, i still think the dialog code is correct.
what happens is that someone external resizes the notification window to 0x0
pixels wide right after the componentcomplete event. if as in this patch the
dialog is resized explicitly in componentcomplete, that
mart updated this revision to Diff 17703.
mart added a comment.
ignore resizes to empty sizes
on multiscreen, it happens that notification windows areresized to 0,0
by somebody else (not dialog code, perhaps kwin, perhaps notification applet
this makes the notification main item
mart added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7085
To: davidedmundson, #plasma
Cc: #frameworks
37 matches
Mail list logo
