D7732: Force KAuth helpers to have UTF-8 support

2017-09-08 Thread David Edmundson
davidedmundson added a comment. :( Though worst case it'll fallback to C which is no worse than where we started. @ltoscano Do you know of any other solution? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson Cc: ltoscano, #frameworks

D5775: Don't include the pid in the dbus path when on flatpak

2017-09-08 Thread Albert Astals Cid
aacid added a comment. So if i have two okular open, how do i access the second via dbus? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich, aacid Cc: dfaure, davidedmundson, aacid

D7736: Not-to-be-merged review of Python bindings generator

2017-09-08 Thread Shaheed Haque
shaheed added a comment. My suggestion would be to focus any review efforts in this order: 1. files in the top level directory. 2. possibly files the ./templates subdirectory. 3. __init__.py and CMakelists.txt in the ./PyKF5 subdirectory. Ignore all other files therein. REPOSITORY

D7736: Not-to-be-merged review of Python bindings generator

2017-09-08 Thread Shaheed Haque
shaheed added inline comments. INLINE COMMENTS > lbeltrame wrote in CMakeLists.txt:49 > Don't use `find_package(FOO REQUIRED)`. Use `find_package(FOO)` then > `set_package_properties(FOO TYPE REQUIRED...`. There are many examples in KDE > git you can use. You will need to include

D7736: Not-to-be-merged review of Python bindings generator

2017-09-08 Thread Shaheed Haque
shaheed added a comment. My comments here are phrased as if this SIP-based approach was the solution eventually adopted (cppyy might be different). With that said... This... > (this thing is huge). and this... > One question: would it be possible to have the bindings

D5775: Don't include the pid in the dbus path when on flatpak

2017-09-08 Thread Aleix Pol Gonzalez
apol marked 2 inline comments as done. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich, aacid Cc: dfaure, davidedmundson, aacid

D7738: Coding style and readability

2017-09-08 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Address some issues pointed out in https://phabricator.kde.org/D5775 REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D7738 AFFECTED FILES

D7729: Drop KAction references from kxmlgui apidox

2017-09-08 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R263:302aee4debe1: Drop KAction references from kxmlgui apidox (authored by elvisangelaccio). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7729?vs=19294=19314

D7736: Not-to-be-merged review of Python bindings generator

2017-09-08 Thread Luca Beltrame
lbeltrame added a comment. A small number of reviews (this thing is huge). One question: would it be possible to have the bindings per-framework, rather than a single, long list? This is also what made PyKDE4 unwieldy. IOW, each Framework should ship their (optional) bindings. We can put

D7736: Not-to-be-merged review of Python bindings generator

2017-09-08 Thread Shaheed Haque
shaheed edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7736 To: shaheed, lbeltrame Cc: #frameworks, #build_system

D7736: Not-to-be-merged review of Python bindings generator

2017-09-08 Thread Shaheed Haque
shaheed retitled this revision from "Not-to-be-merged review fo Python bindings generator" to "Not-to-be-merged review of Python bindings generator". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7736 To: shaheed, lbeltrame Cc: #frameworks, #build_system

D7736: Not-to-be-merged review fo Python bindings generator

2017-09-08 Thread Shaheed Haque
shaheed edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7736 To: shaheed, lbeltrame Cc: #frameworks, #build_system

D7736: Not-to-be-merged review fo Python bindings generator

2017-09-08 Thread Shaheed Haque
shaheed created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY As per https://marc.info/?l=kde-core-devel=150464598710128=2, this is a snapshot of the current state of the

D7732: Force KAuth helpers to have UTF-8 support

2017-09-08 Thread Luigi Toscano
ltoscano added a comment. C.UTF-8 is not glibc, even few distributions added it (historically Debian and Ubuntu, more recently Fedora). REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson Cc: ltoscano, #frameworks

D7732: Force KAuth helpers to have UTF-8 support

2017-09-08 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Our helper runs as root and doesn't have the user's environment (including $LANG). This defaults to one without UTF-8. Without

D7699: Add support for custom search paths for application-specific syntax and theme definitions

2017-09-08 Thread Volker Krause
vkrause added a comment. Ah, learned something new then :) So we can have an additional hard-coded QRC search path, that would only prevent us from having indexed content in there. Probably fine, as we are looking at a handful of custom syntax definitions at most, right? Installing the