D8450: User can now hide an entire places group from KFilePlacesView
ervin added inline comments. INLINE COMMENTS > franckarrecot wrote in kfileplacesview.cpp:863-866 > Oki I add that to my list :-) Cool, I'll wait for that extra review to appear before accepting that one. So that we don't forget it. :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent Cc: mwolff, #frameworks
D8367: Hidding place groups implementation in KFilePlacesModel
ervin added inline comments. INLINE COMMENTS > franckarrecot wrote in kfileplacesmodel.cpp:870 > Because it wouldn't compile without the whole KFIlePlacesModel:: prefix, so I > end up going for variable renaming, seemed cleaner Let's go for naming it "groupHidden" then. It's a weird shortening otherwise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks
KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 24 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/24/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 27 Nov 2017 02:10:27 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdelibs4configmigratortestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.krandomtest
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 5 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/5/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 02:10:27 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kshelltest
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 7 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 02:10:27 + Build duration: 8 min 20 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kshelltest
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 66 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/66/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 02:10:27 + Build duration: 6 min 23 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest
KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 - Build # 5 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/5/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 01:51:37 + Build duration: 3 min 39 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report80% (4/5)86% (61/71)86% (61/71)74% (1960/2633)44% (2750/6303)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (25/25)100% (25/25)100% (419/419)50% (1223/2438)src74% (17/23)74% (17/23)76% (843/1110)43% (428/989)src.extractors85% (17/20)85% (17/20)65% (676/1047)38% (1067/2790)src.writers100% (2/2)100% (2/2)73% (22/30)43% (32/74)tests0% (0/1)0% (0/1)0% (0/27)0% (0/12)
KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 - Build # 16 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/16/ Project: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 27 Nov 2017 01:51:37 + Build duration: 4 min 25 sec and counting CONSOLE OUTPUT [...truncated 238.80 KB...][ 80%] Building CXX object autotests/CMakeFiles/propertyinfotest.dir/propertyinfotest_autogen/mocs_compilation.cpp.objpropertyinfotest.cppmocs_compilation.cpp[ 81%] Linking CXX executable ..\bin\propertyinfotest.exe[ 81%] Built target propertyinfotestScanning dependencies of target externalextractortest[ 82%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/__/src/externalextractor.cpp.obj[ 84%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest.cpp.obj[ 84%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest_autogen/mocs_compilation.cpp.objexternalextractortest.cppmocs_compilation.cppexternalextractor.cpp[ 85%] Linking CXX executable ..\bin\externalextractortest.exe[ 85%] Built target externalextractortestScanning dependencies of target externalwritertest[ 86%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/externalwritertest.cpp.obj[ 87%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/__/src/externalwriter.cpp.obj[ 88%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/externalwritertest_autogen/mocs_compilation.cpp.objexternalwritertest.cppmocs_compilation.cppexternalwriter.cpp[ 89%] Linking CXX executable ..\bin\externalwritertest.exe[ 89%] Built target externalwritertestScanning dependencies of target extractorcollectiontest[ 91%] Building CXX object autotests/CMakeFiles/extractorcollectiontest.dir/extractorcollectiontest.cpp.obj[ 91%] Building CXX object autotests/CMakeFiles/extractorcollectiontest.dir/extractorcollectiontest_autogen/mocs_compilation.cpp.objextractorcollectiontest.cppmocs_compilation.cpp[ 92%] Linking CXX executable ..\bin\extractorcollectiontest.exe[ 92%] Built target extractorcollectiontestScanning dependencies of target usermetadatawritertest[ 93%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest.cpp.obj[ 95%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest_autogen/mocs_compilation.cpp.obj[ 95%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/__/src/usermetadata.cpp.objusermetadatawritertest.cppC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\autotests\usermetadatawritertest.cpp(24): fatal error C1083: Cannot open include file: 'fileref.h': No such file or directoryjom: C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\build\autotests\CMakeFiles\usermetadatawritertest.dir\build.make [autotests\CMakeFiles\usermetadatawritertest.dir\usermetadatawritertest.cpp.obj] Error 2usermetadata.cppmocs_compilation.cppc:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\xattr_p.h(144): warning C4267: 'argument': conversion from 'size_t' to 'DWORD', possible loss of dataC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(34): warning C4273: 'KFileMetaData::UserMetaData::UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(32): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(40): warning C4273: 'KFileMetaData::UserMetaData::UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(33): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(45): warning C4273: 'KFileMetaData::UserMetaData::~UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(34): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(50): warning C4273: 'KFileMetaData::UserMetaData::operator =': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(39): note: see previous definition of '='C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(56): warning C4273: 'KFileMetaData::UserMetaData::filePath': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(41): note: see previous definition of 'filePath'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(61): warning C4273: 'KFileMetaData::UserMetaData::setTags': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(44): note: see previous definition of 'setTa
KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.7 - Build # 37 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.7/37/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 01:51:37 + Build duration: 1 min 25 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.7 - Build # 4 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.7/4/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 01:51:37 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report80% (4/5)85% (57/67)85% (57/67)75% (1896/2525)44% (2836/6423)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (23/23)100% (23/23)100% (393/393)50% (1252/2496)src74% (17/23)74% (17/23)76% (843/1110)44% (475/1089)src.extractors83% (15/18)83% (15/18)66% (638/965)39% (1077/2752)src.writers100% (2/2)100% (2/2)73% (22/30)43% (32/74)tests0% (0/1)0% (0/1)0% (0/27)0% (0/12)
KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 - Build # 15 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/15/ Project: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 27 Nov 2017 01:07:02 + Build duration: 2 min 42 sec and counting CONSOLE OUTPUT [...truncated 238.25 KB...][ 80%] Building CXX object autotests/CMakeFiles/propertyinfotest.dir/propertyinfotest_autogen/mocs_compilation.cpp.objpropertyinfotest.cppmocs_compilation.cpp[ 81%] Linking CXX executable ..\bin\propertyinfotest.exe[ 81%] Built target propertyinfotestScanning dependencies of target externalextractortest[ 83%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest.cpp.obj[ 83%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/__/src/externalextractor.cpp.obj[ 84%] Building CXX object autotests/CMakeFiles/externalextractortest.dir/externalextractortest_autogen/mocs_compilation.cpp.objexternalextractortest.cppmocs_compilation.cppexternalextractor.cpp[ 85%] Linking CXX executable ..\bin\externalextractortest.exe[ 85%] Built target externalextractortestScanning dependencies of target externalwritertest[ 86%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/externalwritertest.cpp.obj[ 88%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/externalwritertest_autogen/mocs_compilation.cpp.obj[ 88%] Building CXX object autotests/CMakeFiles/externalwritertest.dir/__/src/externalwriter.cpp.objexternalwritertest.cppmocs_compilation.cppexternalwriter.cpp[ 89%] Linking CXX executable ..\bin\externalwritertest.exe[ 89%] Built target externalwritertestScanning dependencies of target extractorcollectiontest[ 91%] Building CXX object autotests/CMakeFiles/extractorcollectiontest.dir/extractorcollectiontest.cpp.obj[ 91%] Building CXX object autotests/CMakeFiles/extractorcollectiontest.dir/extractorcollectiontest_autogen/mocs_compilation.cpp.objextractorcollectiontest.cppmocs_compilation.cpp[ 92%] Linking CXX executable ..\bin\extractorcollectiontest.exe[ 92%] Built target extractorcollectiontestScanning dependencies of target usermetadatawritertest[ 93%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest.cpp.obj[ 94%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/__/src/usermetadata.cpp.obj[ 95%] Building CXX object autotests/CMakeFiles/usermetadatawritertest.dir/usermetadatawritertest_autogen/mocs_compilation.cpp.objusermetadatawritertest.cppC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\autotests\usermetadatawritertest.cpp(24): fatal error C1083: Cannot open include file: 'fileref.h': No such file or directoryjom: C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\build\autotests\CMakeFiles\usermetadatawritertest.dir\build.make [autotests\CMakeFiles\usermetadatawritertest.dir\usermetadatawritertest.cpp.obj] Error 2usermetadata.cppmocs_compilation.cppc:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\xattr_p.h(144): warning C4267: 'argument': conversion from 'size_t' to 'DWORD', possible loss of dataC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(34): warning C4273: 'KFileMetaData::UserMetaData::UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(32): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(40): warning C4273: 'KFileMetaData::UserMetaData::UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(33): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(45): warning C4273: 'KFileMetaData::UserMetaData::~UserMetaData': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(34): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(50): warning C4273: 'KFileMetaData::UserMetaData::operator =': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(39): note: see previous definition of '='C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(56): warning C4273: 'KFileMetaData::UserMetaData::filePath': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(41): note: see previous definition of 'filePath'C:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9\src\usermetadata.cpp(61): warning C4273: 'KFileMetaData::UserMetaData::setTags': inconsistent dll linkagec:\ci\workspace\frameworks kfilemetadata kf5-qt5 windowsmsvcqt5.9\src\usermetadata.h(44): note: see previous definition of 'setTa
D9012: Revert "Detach before setting the d pointer"
kossebau added a comment. See also discussion at https://phabricator.kde.org/D7194#159565 ff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9012 To: kossebau, whiting, leinir, apol Cc: #frameworks
D9012: Revert "Detach before setting the d pointer"
kossebau created this revision. kossebau added reviewers: whiting, leinir, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This reverts commits https://phabricator.kde.org/R304:04cc49c71bdb948e06ccae2d97d7cc1a1d2f62af as well as the follow-up partial fix https://phabricator.kde.org/R304:c32c8d002e1216373560c94738841a7a5e1b976b The whole internal data sync'ing design of the KNewStuff core library relies on EntryInternal instances explicitely sharing the data. Changing only EntryInternal to implicitly shared data broke things. And changed behaviour of that class also for any 3rd-party consumers. BUG: 386156 REPOSITORY R304 KNewStuff BRANCH unbreakEntryInternalDataSyncing REVISION DETAIL https://phabricator.kde.org/D9012 AFFECTED FILES src/core/entryinternal.cpp To: kossebau, whiting, leinir, apol Cc: #frameworks
D8007: popplerextractor: don't try to guess the title if there isn't one.
mgallien added subscribers: vhanda, mgallien. mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry for me being late to review your work. I had not noticed it. Thanks for your work. I am all for this change. The code you are removing is not currently covered by the automatic tests and is different from the same code in Okular (generator_pdf.cpp:705). Even if the result of the current automatic test should not be affected by this change, could you please accept the offer from @aacid and test with some of his documents (or better with all) ? I have another question also related to some bugfixes I have done in KFileMetaData. Do you have an idea how to trigger an update of the Baloo database since your changes may modify the title of documents people have in the Baloo database ? @vhanda do you know if there is something to do to update Baloo database when metadata returned by KFileMetaData are changed even if the file itself did not change ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc: mgallien, vhanda, ngraham, #frameworks
D9004: Input validation of SubJobs
anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in kcompositejob.cpp:102 > When a subclass calls this slotResult implementation, they expect the > behaviour of "finish with an error if the subjob had an error". > > But NOT emitResult in the normal case (no error), since we might want to > continue by creating another subjob. > > I'm still missing a proper explanation of what's happening and what shouldn't > happen. Yes, i saw in the code but i understand it a bit strange. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D9004: Input validation of SubJobs
dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kcompositejob.cpp:102 > Yeah, you are right, but we ever emit on error? It's finish whole composite > job (deleteLater will be called) When a subclass calls this slotResult implementation, they expect the behaviour of "finish with an error if the subjob had an error". But NOT emitResult in the normal case (no error), since we might want to continue by creating another subjob. I'm still missing a proper explanation of what's happening and what shouldn't happen. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D8983: Properly parse dates in cookies when running in non-English locale
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcookiejar.cpp:117 > > + // Only English month names are allowed, thus use the C locale. > +const QLocale cLocale = QLocale::c(); indentation seems strange, but maybe that's just phabricator messing up... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks
D9004: Input validation of SubJobs
anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in kcompositejob.cpp:102 > No no no this is all wrong, please don't change the logic here. > After a subjob is done, we might want to start another one. > Most KIO jobs work like that. Yeah, you are right, but we ever emit on error? It's finish whole composite job (deleteLater will be called) > kcompositejob.cpp:68 > +job->setParent(nullptr); > +job->disconnect(this); > +return true; I rethink it, sorry. Let's remove only own connections. disconnect(job, &KJob::result, this, &KCompositeJob::slotResult); disconnect(job, &KJob::infoMessage, this, &KCompositeJob::slotInfoMessage); in two places. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D8983: Properly parse dates in cookies when running in non-English locale
schwab marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks
D8983: Properly parse dates in cookies when running in non-English locale
schwab updated this revision to Diff 22971. schwab added a comment. Rename variable and constify. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8983?vs=22970&id=22971 REVISION DETAIL https://phabricator.kde.org/D8983 AFFECTED FILES src/ioslaves/http/kcookiejar/kcookiejar.cpp To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks
D9002: add PKGUILD to bash syntax
dhaumann closed this revision. dhaumann added a comment. Committed: https://cgit.kde.org/syntax-highlighting.git/commit/?id=105aca796ffbfebc4ffed4581f1cf69a531da996 Thanks for the patch! INLINE COMMENTS > bash.xml:11 > ]> > - extensions="*.sh;*.bash;*.ebuild;*.eclass;*.nix;.bashrc;.bash_profile;.bash_login;.profile" > mimetype="application/x-shellscript" casesensitive="1" author="Wilbert > Berendsen (wilb...@kde.nl)" license="LGPL"> > + extensions="*.sh;*.bash;*.ebuild;*.eclass;*.nix;.bashrc;.bash_profile;.bash_login;.profile;PKGBUILD" > mimetype="application/x-shellscript" casesensitive="1" author="Wilbert > Berendsen (wilb...@kde.nl)" license="LGPL"> > Please increase the version to ="5". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D9002 To: jvanderwaa, #framework_syntax_highlighting, vkrause Cc: dhaumann, ngraham, #frameworks, genethomas, cullmann, vkrause
D8983: Properly parse dates in cookies when running in non-English locale
dfaure added a comment. Thanks for the fix, looks good, just two minor improvement suggestions. INLINE COMMENTS > kcookiejar.cpp:78 > const QString weekday = value.left(index); > +QLocale l = QLocale::c(); > for (int i = 1; i < 8; ++i) { "i" and "l" local variables are hard to read, please rename to locale or cLocale > kcookiejar.cpp:119 > +// Only English month names are allowed, thus use the C locale. > +dt = QLocale::c().toDateTime(value, QL1S(date_formats[i])); > if (dt.isValid()) { You could (and probably should) do like the above loop and move QLocale::c() to a local variable defined before the `for` loop. QLocale::c() creates a QLocale instance every time, so better do that only once. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks
D9004: Input validation of SubJobs
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Just do another arc diff, if your uploaded patch isn't the latest one. INLINE COMMENTS > anthonyfieroni wrote in kcompositejob.cpp:102 > Here after remove last job it should emit no? No no no this is all wrong, please don't change the logic here. After a subjob is done, we might want to start another one. Most KIO jobs work like that. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D8983: Properly parse dates in cookies when running in non-English locale
schwab marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks
D8983: Properly parse dates in cookies when running in non-English locale
schwab updated this revision to Diff 22970. schwab added a comment. Use the week names from the C locale REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8983?vs=22882&id=22970 REVISION DETAIL https://phabricator.kde.org/D8983 AFFECTED FILES src/ioslaves/http/kcookiejar/kcookiejar.cpp To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 4 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/4/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 26 Nov 2017 15:26:26 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report65% (22/34)65% (278/425)65% (278/425)51% (29781/58059)37% (17374/47206)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests97% (66/68)97% (66/68)92% (7809/8486)50% (4839/9758)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src.core83% (98/118)83% (98/118)57% (8064/14105)50% (4745/9584)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (29/37)78% (29/37)49% (3707/7629)31% (1507/4805)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (2/2)100% (2/2)53% (434/819)44% (324/736)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1364)0% (0/1513)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1783/4338)35% (1375/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1332)55% (656/1184)src.ioslaves.remote100% (2/2)100% (2/2)28% (71/258)8% (17/220)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)52% (725/1385)46% (449/968)src.ioslaves.trash.tests67% (2/3)67% (2/3)88% (709/802)47% (515/1089)src.kcms.kio0%
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 4 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/4/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 26 Nov 2017 15:26:26 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report62% (21/34)65% (275/425)65% (275/425)50% (29196/58033)36% (16951/47130)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests97% (66/68)97% (66/68)91% (7684/8485)49% (4750/9758)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src.core82% (97/118)82% (97/118)55% (7776/14085)48% (4585/9580)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (29/37)78% (29/37)49% (3706/7629)31% (1506/4805)src.gui0% (0/2)0% (0/2)0% (0/105)0% (0/74)src.ioslaves.file100% (2/2)100% (2/2)53% (434/819)44% (324/736)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1364)0% (0/1513)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)39% (1705/4337)32% (1261/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1332)55% (656/1184)src.ioslaves.remote100% (2/2)100% (2/2)28% (71/258)8% (17/220)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)52% (715/1385)45% (437/968)src.ioslaves.trash.tests67% (2/3)67% (2/3)88% (709/802)47% (515/1089)src.kcms.kio0%
D8546: Add Aztec code generator
This revision was automatically updated to reflect the committed changes. Closed by commit R280:2e2664b0ab0a: Add Aztec code generator (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8546?vs=22559&id=22969 REVISION DETAIL https://phabricator.kde.org/D8546 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/aztec/aztec.qrc autotests/aztec/encoding/aztec-complete-big.png autotests/aztec/encoding/aztec-complete-compact1.png autotests/aztec/encoding/aztec-complete-compact3.png autotests/aztec/encoding/aztec-complete-compact4.png autotests/aztec/encoding/aztec-complete-full5.png autotests/aztec/rendering/aztec-compact-data-0011.png autotests/aztec/rendering/aztec-compact-data-0101.png autotests/aztec/rendering/aztec-compact-data-1001.png autotests/aztec/rendering/aztec-compact-data-1010.png autotests/aztec/rendering/aztec-compact-data-.png autotests/aztec/rendering/aztec-compact-grid.png autotests/aztec/rendering/aztec-compact-mode-.png autotests/aztec/rendering/aztec-compact-mode-1234-rev.png autotests/aztec/rendering/aztec-compact-mode-1234.png autotests/aztec/rendering/aztec-full-data-0011.png autotests/aztec/rendering/aztec-full-data-0101.png autotests/aztec/rendering/aztec-full-data-1001.png autotests/aztec/rendering/aztec-full-data-1010.png autotests/aztec/rendering/aztec-full-data-.png autotests/aztec/rendering/aztec-full-grid.png autotests/aztec/rendering/aztec-full-mode-.png autotests/aztec/rendering/aztec-full-mode-1234-rev.png autotests/aztec/rendering/aztec-full-mode-1234.png autotests/aztecbarcodetest.cpp autotests/reedsolomontest.cpp src/lib/CMakeLists.txt src/lib/aztecbarcode.cpp src/lib/aztecbarcode.h src/lib/bitvector.cpp src/lib/bitvector_p.h src/lib/prison.cpp src/lib/reedsolomon.cpp src/lib/reedsolomon_p.h To: vkrause, #frameworks, svuorela, dfaure Cc: dfaure, #frameworks
D9002: add PKGUILD to bash syntax
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D9002 To: jvanderwaa, #framework_syntax_highlighting, vkrause Cc: #frameworks, genethomas, cullmann, vkrause, dhaumann
D8434: Created 'remote' section
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3e8eb3746b33: Created 'remote' section (authored by Renato Araujo Oliveira Filho, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22961&id=22968 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
D8945: Return a valid bookmark object for any entry in KFilePlacesModel
renatoo updated this revision to Diff 22964. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22953&id=22964 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp To: renatoo, dfaure Cc: ngraham, #frameworks
D8947: Expose KFilePlacesModel 'iconName' role
renatoo updated this revision to Diff 22966. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22955&id=22966 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesmodel.h To: renatoo, dfaure Cc: ngraham, kossebau, #frameworks
D8946: Avoid unnecessary 'dataChanged' signal
renatoo updated this revision to Diff 22965. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22954&id=22965 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp To: renatoo, dfaure Cc: ngraham, #frameworks
D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'
renatoo updated this revision to Diff 22967. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22956&id=22967 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h To: renatoo, dfaure Cc: #frameworks
D8944: Create a 'KFilePlacesModel::refresh' function
renatoo updated this revision to Diff 22963. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22952&id=22963 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h To: renatoo, dfaure Cc: ngraham, #frameworks
D8943: Create 'KFilePlacesModel::convertedUrl' static function
renatoo updated this revision to Diff 22962. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22951&id=22962 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h src/filewidgets/kfileplacesview.cpp To: renatoo, dfaure Cc: ngraham, #frameworks
D8434: Created 'remote' section
renatoo updated this revision to Diff 22961. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22950&id=22961 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 3 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/3/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 26 Nov 2017 14:44:56 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report62% (21/34)65% (275/425)65% (275/425)50% (29158/57978)36% (16927/47053)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests97% (66/68)97% (66/68)91% (7634/8435)49% (4724/9696)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src.core82% (97/118)82% (97/118)55% (7784/14086)48% (4588/9580)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (29/37)78% (29/37)49% (3700/7623)31% (1491/4790)src.gui0% (0/2)0% (0/2)0% (0/105)0% (0/74)src.ioslaves.file100% (2/2)100% (2/2)53% (434/819)44% (324/736)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1364)0% (0/1513)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)39% (1705/4337)32% (1261/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1332)55% (656/1184)src.ioslaves.remote100% (2/2)100% (2/2)28% (71/258)8% (17/220)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)52% (725/1385)46% (449/968)src.ioslaves.trash.tests67% (2/3)67% (2/3)88% (709/802)47% (515/1089)src.kcms.kio0%
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 3 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/3/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 26 Nov 2017 14:44:56 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report65% (22/34)65% (278/425)65% (278/425)51% (29718/58003)37% (17317/47129)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests97% (66/68)97% (66/68)92% (7759/8436)50% (4812/9696)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src.core83% (98/118)83% (98/118)57% (8062/14105)49% (4744/9584)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (29/37)78% (29/37)49% (3701/7623)31% (1492/4790)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (2/2)100% (2/2)53% (434/819)44% (324/736)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1364)0% (0/1513)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1788/4338)35% (1373/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1332)55% (656/1184)src.ioslaves.remote100% (2/2)100% (2/2)28% (71/258)8% (17/220)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)52% (715/1385)45% (437/968)src.ioslaves.trash.tests67% (2/3)67% (2/3)88% (709/802)47% (515/1089)src.kcms.kio0%
D8434: Created 'remote' section
ngraham added a comment. @renatoo Next! :-) Time to update this one, too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
D8348: Add a section for removable devices
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3db04cfc5179: Add a section for removable devices (authored by Renato Araujo Oliveira Filho, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22949&id=22960 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kpropertiesdialog.cpp:2904-2906 > It's a private function, i can't image why it can be call with null pointers > :) I am looking up the UI components based on name and I was getting some nullptrs until I found the right way to get them correctly from the layout. Not sure if they are needed but in case something in the layout changes (like a name of a button) it might pass in a nullptr REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
anthonyfieroni added a comment. > ! In https://phabricator.kde.org/D8536#172105, @elvisangelaccio wrote: > > Unfortunately many websites only show you the SHA1 or, even worse, only the MD5 of the file. As I said, it doesn't matter that your preferred algo is e.g. SHA256, if the website doesn't actually provide it. > > @petermajchrak I vote to revert to the collapsible groupbox layout. We should also ask feedback from the people involved in the original design (@colomar in particular). You are right, but after i saw the screenshots still prefer dropdown, it looks clear and simple to me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
anthonyfieroni added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:2904-2906 > +if (calculateButton == nullptr || copyButton == nullptr) { > +return; > +} It's a private function, i can't image why it can be call with null pointers :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8998: Add FindSeccomp to find-modules
davidk marked 7 inline comments as done. davidk added a comment. Thank you, missed this when renaming the docs. INLINE COMMENTS > cgiboudeaux wrote in FindSeccomp.cmake:12 > so, what about naming your variables Seccomp_LIBRARIES and > Seccomp_INCLUDE_DIRS in the file ? WellI'm for it! ;) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8998 To: davidk, graesslin Cc: cgiboudeaux, #frameworks, #build_system
D8998: Add FindSeccomp to find-modules
davidk updated this revision to Diff 22958. davidk added a comment. Fix variable names REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8998?vs=22931&id=22958 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8998 AFFECTED FILES find-modules/FindSeccomp.cmake To: davidk, graesslin Cc: cgiboudeaux, #frameworks, #build_system
D9004: Input validation of SubJobs
anthonyfieroni added a comment. In https://phabricator.kde.org/D9004#172096, @jtamate wrote: > - I can't reproduce now bug 364039 even without a patched kio But to be correct as needed KIO' one should land too when David accept it. INLINE COMMENTS > kcompositejob.cpp:104 > removeSubjob(job); > +emitResult(); > } if (d->subjobs.isEmpty()) { emitResult(); } REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak updated this revision to Diff 22957. petermajchrak added a comment. I reverted back to the group box layout and parallelized hash calculations (removed the annoying recursive function). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8536?vs=21535&id=22957 REVISION DETAIL https://phabricator.kde.org/D8536 AFFECTED FILES src/widgets/checksumswidget.ui src/widgets/kpropertiesdialog.cpp src/widgets/kpropertiesdialog_p.h To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8348: Add a section for removable devices
renatoo added a comment. In https://phabricator.kde.org/D8348#172032, @ngraham wrote: > @renatoo, now that https://phabricator.kde.org/D8332 is in, this no patch longer applies cleanly. Can you update so I can land it? I updated it. Could you try again. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks
D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'
renatoo updated this revision to Diff 22956. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22818&id=22956 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h To: renatoo, dfaure Cc: #frameworks
D8947: Expose KFilePlacesModel 'iconName' role
renatoo updated this revision to Diff 22955. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22817&id=22955 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesmodel.h To: renatoo, dfaure Cc: ngraham, kossebau, #frameworks
D8946: Avoid unnecessary 'dataChanged' signal
renatoo updated this revision to Diff 22954. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22816&id=22954 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp To: renatoo, dfaure Cc: ngraham, #frameworks
D8944: Create a 'KFilePlacesModel::refresh' function
renatoo updated this revision to Diff 22952. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22814&id=22952 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h To: renatoo, dfaure Cc: ngraham, #frameworks
D8945: Return a valid bookmark object for any entry in KFilePlacesModel
renatoo updated this revision to Diff 22953. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22815&id=22953 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp To: renatoo, dfaure Cc: ngraham, #frameworks
D8943: Create 'KFilePlacesModel::convertedUrl' static function
renatoo updated this revision to Diff 22951. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22813&id=22951 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h src/filewidgets/kfileplacesview.cpp To: renatoo, dfaure Cc: ngraham, #frameworks
D8348: Add a section for removable devices
renatoo updated this revision to Diff 22949. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22811&id=22949 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks
D8434: Created 'remote' section
renatoo updated this revision to Diff 22950. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22812&id=22950 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
elvisangelaccio added reviewers: VDG, colomar. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
elvisangelaccio added a subscriber: colomar. elvisangelaccio added a comment. In https://phabricator.kde.org/D8536#165899, @anthonyfieroni wrote: > In https://phabricator.kde.org/D8536#165865, @elvisangelaccio wrote: > > > As I mentioned, using //only// a combobox doesn't work, because the main functionality (= check integrity of downloaded files) is now harder to use. > > > In other hand moslty user check one of following algorithms i.e. when i check a downloaded file i validate sha256, so i selected it in combobox (if needed) then paste expected. In most of time *one* prefered algorithm is used. Unfortunately many websites only show you the SHA1 or, even worse, only the MD5 of the file. As I said, it doesn't matter that your preferred algo is e.g. SHA256, if the website doesn't actually provide it. @petermajchrak I vote to revert to the collapsible groupbox layout. We should also ask feedback from the people involved in the original design (@colomar in particular). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak added a comment. I am still not clear on what to do now. Should I revert it to be a lot of separate buttons (hidden in a collapsible group box) (as @elvisangelaccio said) or should I keep it in a dropdown (ok according to me and @anthonyfieroni)?... I'm going to fix some other stuff in the meantime. I also made this `verifyChecksumRecursive` function to verify the checksums serially (one after another)(because up to 2 algorithms can be candidates for certain checksum inputs) to not consume too much resources. I'm thinking of doing that in parallel instead. Do you think it's a good idea? Are there any guidelines for these situations? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D9004: Input validation of SubJobs
jtamate marked 4 inline comments as done. jtamate added a comment. I've missed to do: git add -u git commit before doing the last arc diff If I do arc land (when the ship it! comes), will it do the right thing? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D9004: Input validation of SubJobs
jtamate updated this revision to Diff 22948. jtamate added a comment. - Improved input validation for SubJobs - Added the changes suggested by anthony - I can't reproduce now bug 364039 even without a patched kio REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9004?vs=22947&id=22948 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9004 AFFECTED FILES src/lib/jobs/kcompositejob.cpp To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D9005: fix crash during file copy after message box warning
anthonyfieroni added a comment. +1 Could you please check, while you are on KCoreAddons and KIO for other jobs that emitting result in same way? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: anthonyfieroni, elvisangelaccio
D9004: Input validation of SubJobs
anthonyfieroni requested changes to this revision. anthonyfieroni added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcompositejob.cpp:67 > +if (d->subjobs.removeAll(job) > 0) { > +job->setParent(nullptr); > +return true; We don't want to be notified about this job too job->disconnect(this); > kcompositejob.cpp:87 > Q_FOREACH (KJob *job, d->subjobs) { > job->setParent(nullptr); > } Here same as line:68 > kcompositejob.cpp:99 > setErrorText(job->errorText()); > emitResult(); > } I agree that we set first error but we shouldn't emit if job queue isn't empty. > kcompositejob.cpp:102 > > removeSubjob(job); > } Here after remove last job it should emit no? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure, anthonyfieroni Cc: anthonyfieroni
D9004: Input validation of SubJobs
jtamate updated this revision to Diff 22947. jtamate added a comment. - Improved input validation for SubJobs by dfaure REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9004?vs=22943&id=22947 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9004 AFFECTED FILES src/lib/jobs/kcompositejob.cpp To: jtamate, #frameworks, dfaure
D8920: Fixes url navigation with relative links on KUrlNavigator
emateli added a comment. @dfaure I've managed to take another look at this, added a `directory` property which controls the base dir. Works as it should, however there is one case where I'm not sure which way we want it and is probably just a matter of preference. User types `~/some-dir` which does not exist. The `kshorturifilter` plugin will expand that to `/home/.../some-dir`, check that it doesn't exist, and then decide to not return the expanded value, but rather the original value. The result of this is that the `KUrlNavigator` will attempt to browse `/home/.../~/some-dir` instead of `/home/.../some-dir` which perhaps might be slightly confusing, this works as it should if the directory does exist though. On the upside directories named `~` are browsable. Thoughts? Do we try to "fix" this or is the current behaviour okay. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks
D8998: Add FindSeccomp to find-modules
cgiboudeaux added inline comments. INLINE COMMENTS > FindSeccomp.cmake:12 > +# The seccomp include directories > +# ``Seccomp_LIBRARIES`` > +# The seccomp libraries for linking so, what about naming your variables Seccomp_LIBRARIES and Seccomp_INCLUDE_DIRS in the file ? > FindSeccomp.cmake:24 > +#= > +# Copyright (c) 2017 Martin Flöser , David Kahles > > +# One author per line > FindSeccomp.cmake:56 > + > +find_path(Seccomp_INCLUDE_DIR > +NAMES Seccomp_INCLUDE_DIRS > FindSeccomp.cmake:62 > +) > +find_library(Seccomp_LIBRARY > +NAMES Seccomp_LIBRARIES > FindSeccomp.cmake:74-75 > +REQUIRED_VARS > +Seccomp_LIBRARY > +Seccomp_INCLUDE_DIR > +VERSION_VAR same thing here > FindSeccomp.cmake:83-85 > +IMPORTED_LOCATION "${Seccomp_LIBRARY}" > +INTERFACE_COMPILE_OPTIONS "${Seccomp_DEFINITIONS}" > +INTERFACE_INCLUDE_DIRECTORIES "${Seccomp_INCLUDE_DIR}" and there > FindSeccomp.cmake:89 > + > +mark_as_advanced(Seccomp_LIBRARY Seccomp_INCLUDE_DIR) > + here as well REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8998 To: davidk, graesslin Cc: cgiboudeaux, #frameworks, #build_system
D9005: fix crash during file copy after message box warning
jtamate added a comment. The backtrace without this patch: Thread 1 (Thread 0x7f0a25cc5dc0 (LWP 18492)): [KCrash Handler] #6 0x7f0a1fe9b156 in KJob::isAutoDelete() const (this=0x1ae3410) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:333 #7 0x7f0a1fe9a826 in KJob::finishJob(bool) (this=0x1ae3410, emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:112 #8 0x7f0a1fe9aeff in KJob::emitResult() (this=0x1ae3410) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:293 #9 0x7f0a21676cba in KIO::FileCopyJob::slotResult(KJob*) (this=0x1ae3410, job=0x21cbe50) at /g/5kde/frameworks/kio/src/core/filecopyjob.cpp:509 #10 0x7f0a1fe9a126 in QtPrivate::FunctorCall, QtPrivate::List, void, void (KCompositeJob::*)(KJob*)>::call(void (KCompositeJob::*)(KJob*), KCompositeJob*, void**) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x1ae3410, arg=0x7ffe447f26f0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:136 #11 0x7f0a1fe99d14 in QtPrivate::FunctionPointer::call, void>(void (KCompositeJob::*)(KJob*), KCompositeJob*, void**) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x1ae3410, arg=0x7ffe447f26f0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:169 #12 0x7f0a1fe9992d in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x21d0040, r=0x1ae3410, a=0x7ffe447f26f0, ret=0x0) at /usr/include/qt5/QtCore/qobject_impl.h:120 #13 0x7f0a1df9f73c in QMetaObject::activate(QObject*, int, int, void**) () at /usr/lib64/libQt5Core.so.5 #14 0x7f0a1fe9c6cb in KJob::result(KJob*, KJob::QPrivateSignal) (this=0x21cbe50, _t1=0x21cbe50, _t2=...) at /virtual/kde5/5kde/build/frameworks/kcoreaddons/src/lib/KF5CoreAddons_autogen/include/moc_kjob.cpp:570 #15 0x7f0a1fe9a816 in KJob::finishJob(bool) (this=0x21cbe50, emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:109 #16 0x7f0a1fe9aeff in KJob::emitResult() (this=0x21cbe50) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:293 #17 0x7f0a2167e313 in KIO::SimpleJob::slotFinished() (this=0x21cbe50) at /g/5kde/frameworks/kio/src/core/simplejob.cpp:233 #18 0x7f0a2167e42d in KIO::SimpleJob::slotError(int, QString const&) (this=0x21cbe50, err=115, errorText=...) at /g/5kde/frameworks/kio/src/core/simplejob.cpp:246 #19 0x7f0a2167f336 in KIO::SimpleJob::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=0x21cbe50, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7ffe447f2a20) at /virtual/kde5/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_simplejob.cpp:104 #20 0x7f0a1df9f63a in QMetaObject::activate(QObject*, int, int, void**) () at /usr/lib64/libQt5Core.so.5 #21 0x7f0a21665732 in KIO::SlaveInterface::error(int, QString const&) (this=0x1ba8950, _t1=115, _t2=...) at /virtual/kde5/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_slaveinterface.cpp:414 #22 0x7f0a21663694 in KIO::SlaveInterface::dispatch(int, QByteArray const&) (this=0x1ba8950, _cmd=102, rawdata=...) at /g/5kde/frameworks/kio/src/core/slaveinterface.cpp:192 #23 0x7f0a21663154 in KIO::SlaveInterface::dispatch() (this=0x1ba8950) at /g/5kde/frameworks/kio/src/core/slaveinterface.cpp:89 #24 0x7f0a216676d0 in KIO::Slave::gotInput() (this=0x1ba8950) at /g/5kde/frameworks/kio/src/core/slave.cpp:406 #25 0x7f0a216f7625 in KIO::Slave::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=0x1ba8950, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7ffe447f2d80) at /virtual/kde5/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/EWIEGA46WW/moc_slave.cpp:89 #26 0x7f0a1df9f63a in QMetaObject::activate(QObject*, int, int, void**) () at /usr/lib64/libQt5Core.so.5 #27 0x7f0a2160d0ff in KIO::Connection::readyRead() (this=0x1b0c640) at /virtual/kde5/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:144 #28 0x7f0a2160bef7 in KIO::ConnectionPrivate::dequeue() (this=0x1fe9d20) at /g/5kde/frameworks/kio/src/core/connection.cpp:46 #29 0x7f0a2160cf1c in KIO::Connection::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=0x1b0c640, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x22a98b0) at /virtual/kde5/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:87 #30 0x7f0a1dfa0022 in QObject::event(QEvent*) () at /usr/lib64/libQt5Core.so.5 #31 0x7f0a1f3ceafc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5 #32 0x7f0a1f3d5eb4 in QApplication::notify(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5 #33 0x7f0a1df72128 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib64/libQt5Core.so.5 #34 0x7f0a1df74715 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib64/libQt5Core.so.5 REPOSITORY R241 KIO
D9005: fix crash during file copy after message box warning
jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: elvisangelaccio
D9004: Input validation of SubJobs
dfaure added a comment. Ah wait this could be made faster to avoid the double lookup. if (d->subjobs.removeAll(job) > 0) { job->setParent(nullptr); return true; } return false; (and then we don't even need the job==nullptr check, that's included in the removeAll check) REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure
D9004: Input validation of SubJobs
dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure
D9004: Input validation of SubJobs
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9004 To: jtamate, #frameworks, dfaure
D9005: fix crash during file copy after message box warning
elvisangelaccio added a comment. If this doesn't fix bug #332948, please remove it from the BUG: keyword, otherwise it will be automatically closed when pushing this commit. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: elvisangelaccio
D9005: fix crash during file copy after message box warning
jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY As a temporary workaround for the problems with nested eventloops and warning messages in the move/copy operation when it can't change the destination file rights and the user is asked to retry and after some failed retries he press cancel. Even this is not the right solution, this fixes the crash of: BUG: 364039 The right solution implies also solving: BUG: 332948 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9005 AFFECTED FILES src/core/filecopyjob.cpp To: jtamate, #frameworks, dfaure
D9001: Better handle of subjobs
jtamate abandoned this revision. jtamate added a comment. Creating two review requests. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9001 To: jtamate, #frameworks, dfaure Cc: ngraham, anthonyfieroni, ltoscano
D9004: Input validation of SubJobs
jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY Don't remove a SubJob pointer if it is not in the list of SubJobs. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9004 AFFECTED FILES src/lib/jobs/kcompositejob.cpp To: jtamate, #frameworks, dfaure