D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

mlaurent added a comment. indeed code will be broken if we don't use QString::fromUtf8. Could you fix it please ? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks

Re: KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 22 - Still Failing!

Hi Andreas, Please see below. Following your two commits, breeze-icons failed on all platform/Qt versions monitored by the CI system. If you could fix that please it would be appreciated. Cheers, Ben On Wed, Jan 10, 2018 at 9:42 AM, CI System wrote: > *BUILD FAILURE* > Build

Re: Problem in loading QM translations with LANGUAGE="" envar

Well, I don't want to remove it but it's a must. First it's not right logically and second is that Qt prefers it over LANG, and use any locale varient since it has no country name. (QLocale("ar") returns "Arabic (Egypt)" (which is defind in unicode), instead of my "Arabic (Bahrain)" locale. And

D9712: balooctl status: produce parseable output

michaelh added a reviewer: vhanda. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9712 To: michaelh, #frameworks, vhanda Cc: elvisangelaccio, lueck, dfaure, ngraham

Re: Problem in loading QM translations with LANGUAGE="" envar

El dimarts, 9 de gener de 2018, a les 20:08:02 CET, Safa Alfulaij va escriure: > Hello all. > > After doing some investigation about a problem, I came into an issue in > loading correct translations in Frameworks (that has the “_qt” suffix in > translation system). > Previously, I had my LANGUAGE

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 20:39:01 + Build duration: 3 min 27 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 36 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/36/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 09 Jan 2018 20:39:01 + Build duration: 2 min 9 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 23 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 20:39:01 + Build duration: 1 min 11 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 20:39:01 + Build duration: 32 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 35 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/35/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 09 Jan 2018 20:34:51 + Build duration: 3 min 0 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 20:34:51 + Build duration: 3 min 19 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 20:34:51 + Build duration: 49 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 20:34:51 + Build duration: 41 sec and counting CONSOLE

D9729: [KPropertiesDialog] Enable word wrap for checksum description

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9729 To: broulik, #frameworks, elvisangelaccio

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 19:22:46 + Build duration: 8 min 33 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/21/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 19:22:46 + Build duration: 3 min 35 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 19:22:46 + Build duration: 1 min 28 sec and counting JUnit

D9770: Optimization of byteSize(double size)

broulik added a comment. Nice catch. INLINE COMMENTS > kjobtrackerformatters.cpp:29 > > +const char* units[] {"%1 B", "%1 KiB", "%1 MiB", "%1 GiB", "%1 TiB", "%1 > PiB", "%1 EiB", "%1 ZiB", "%1 YiB"}; > +const int unitsSize = sizeof(units)/sizeof(const char *); These aren't translated

D9770: Optimization of byteSize(double size)

jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Copying 20Gib, using callgrind, before it used 5,2% of the cpu, and after only 0,58%. Applying this patch, the

Problem in loading QM translations with LANGUAGE="" envar

Hello all. After doing some investigation about a problem, I came into an issue in loading correct translations in Frameworks (that has the “_qt” suffix in translation system). Previously, I had my LANGUAGE enviroment variable containing “ar”, which is because I added Arabic in my “Language” KCM

Re: duplicate icon in breeze-icons

Hi, are there already duplcated icons in master? didn't find one. Andreas_K 2018-01-05 10:13 GMT+01:00 David Faure : > Hello Andreas, > > I'm emailing you since you committed some gnumeric icons to breeze-icons. > > CI fails because it says that >

Re: duplicate icon in breeze-icons

thanks done 2018-01-09 15:43 GMT+01:00 David Faure : > Hi, > > Yes the problem is still there, at least in "icons-dark". > > `ctest` says: > " > The following files are duplicates but not links: > - breeze-icons/icons-dark/actions/24/gnumeric-pagesetup-hf-cell.svg > -

D9768: Cache KColorScheme instances

This revision was automatically updated to reflect the committed changes. Closed by commit R858:89760fddd4cb: Cache KColorScheme instances (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9768?vs=25031=25032#toc REPOSITORY R858 Qt Quick Controls 2: Desktop Style

D9768: Cache KColorScheme instances

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D9768 To: apol, #frameworks, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9768: Cache KColorScheme instances

apol created this revision. apol added reviewers: Frameworks, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This patch catches the few different KColorScheme we use so that

D9766: Use at least the requested width for the argument hint tree

mwolff added reviewers: KDevelop, Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9766: Use at least the requested width for the argument hint tree

mwolff created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This ensures the code completion tree and the argument hint tree have the same width in the

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 14:48:35 + Build duration: 8 min 40 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/20/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 14:48:35 + Build duration: 6 min 12 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 14:48:35 + Build duration: 2 min 24 sec and counting JUnit

Re: duplicate icon in breeze-icons

Hi, Yes the problem is still there, at least in "icons-dark". `ctest` says: " The following files are duplicates but not links: - breeze-icons/icons-dark/actions/24/gnumeric-pagesetup-hf-cell.svg - breeze-icons/icons-dark/actions/24/gnumeric-formulaguru.svg " -rw-r--r-- 1 dfaure users

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/19/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 14:19:16 + Build duration: 3 min 38 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/18/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 14:07:10 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 14:14:17 + Build duration: 2 min 17 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 14:11:53 + Build duration: 4 min 23 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 14:07:10 + Build duration: 6 min 50 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/17/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 14:07:10 + Build duration: 4 min 41 sec and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/20/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 13:22:20 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 13:22:20 + Build duration: 8 min 18 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 13:22:20 + Build duration: 6 min 46 sec and counting

D9760: Fix kded dbus name in solid-networking howto

This revision was automatically updated to reflect the committed changes. Closed by commit R239:8ab28756d66c: Fix kded dbus name in solid-networking howto (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9760?vs=25012=25013

D9760: Fix kded dbus name in solid-networking howto

kfunk accepted this revision. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9760 To: habacker, kfunk Cc: kfunk, #frameworks

D9760: Fix kded dbus name in solid-networking howto

habacker updated this revision to Diff 25012. habacker added a comment. - fix reference to kded5 also in DESIGN REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9760?vs=25010=25012 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9760

D9760: Fix kded dbus name in solid-networking howto

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. //src/solid-networkstatus/DESIGN// also still references `org.kde.kded`. Please update, too. Rest LGTM REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL

D9760: Fix kded dbus name in solid-networking howto

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. habacker requested review of this revision. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9760 AFFECTED

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/17/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 12:16:15 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/16/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 12:16:15 + Build duration: 2 min 33 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 12:16:15 + Build duration: 2 min 4 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/15/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 11:53:55 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 11:53:55 + Build duration: 3 min 40 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 11:53:55 + Build duration: 2 min 22 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Jan 2018 11:42:50 + Build duration: 5 min 59 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 11:42:50 + Build duration: 4 min 2 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/15/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 11:42:50 + Build duration: 3 min 36 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 09:56:24 + Build duration: 32 min and counting JUnit Tests

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 17 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/17/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Tue, 09 Jan 2018 10:08:48 + Build duration: 9 min 5 sec and counting JUnit Tests Name:

D9750: ExpandingWidgetModel: find the right-most column based on location

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:7c648c89ed11: ExpandingWidgetModel: find the right-most column based on location (authored by mwolff). REPOSITORY

D9749: Simplify code: return early to reduce indentation depth

This revision was automatically updated to reflect the committed changes. Closed by commit R39:181c6146d399: Simplify code: return early to reduce indentation depth (authored by mwolff). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9749?vs=24974=24992

D9750: ExpandingWidgetModel: find the right-most column based on location

mwolff added a comment. I'll push it then REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 To: mwolff, #kate Cc: cullmann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Mon, 08 Jan 2018 23:49:41 + Build duration: 9 hr 47 min and counting CONSOLE OUTPUT

D9750: ExpandingWidgetModel: find the right-most column based on location

kfunk added a comment. LGTM, but I'll let someone else approve. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 To: mwolff, #kate Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9750: ExpandingWidgetModel: find the right-most column based on location

cullmann added a comment. ;=) I assume then a KDevelop person must try it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 To: mwolff, #kate Cc: cullmann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

D9749: Simplify code: return early to reduce indentation depth

cullmann accepted this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9749 To: mwolff, #kate, kfunk, cullmann Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9749: Simplify code: return early to reduce indentation depth

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9749 To: mwolff, #kate, kfunk Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann