D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Dominik Haumann]

dhaumann added a comment.


  @davidedmundson If the associated bug is fixed, it should be closed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/24/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 20 Jan 2018 22:26:47 +
 Build duration:
3 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5eece6769f21: Fix one source of log spam referenced in 
Bug 388389 (Empty filename passed to… (authored by rkron, committed by 
davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9928?vs=25540=25699

REVISION DETAIL
  https://phabricator.kde.org/D9928

AFFECTED FILES
  src/plasma/svg.cpp

To: rkron, #frameworks, davidedmundson
Cc: ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron added a comment.


  I'm new to phabricator and do not have commit access. Does someone need to 
commit this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: ngraham, alexeymin, aacid, #frameworks

D9973: ktooltipwidget: Fix tooltip positioning

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> michaelh wrote in ktooltipwidget.cpp:155
> > Are you saying that you don't want to correct it at the second place, just 
> > because tests did not reveal a bug?
> 
> Yes, but it is rather like this: Due to my lack of my experience I don't 
> introduce chances which I can't test or see the results of. More a question 
> of 'dare' than 'want' :)
> 
> As margin is not included in sizeHint() I think it is correct to do
> 
>   +margin when tooltip is displayed right of rect and 
>   -margin when displayed left of rect. 
> 
> Both would result in a margin-wide space between rect and tooltip which is 
> necessary to dismiss the tooltip. 
> @elvisangelaccio: What do you think?

Sorry but I'm not the original author of this code, so I don't really know 
what's going on here.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: cfeck

D9989: tools: Make all output messages translatable

[Michael Heidelbach]

michaelh marked 2 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh added a comment.


  > Can you please describe exactly how many bugs are there and how to 
reproduce them?
  
  I can't exactly. There at least to phenomenona
  
  1. 2 stages of metadata loading most likely affecting tooltip sizing
  
  F5665675: tooltip.mkv 
  
  This is a very extreme case specific to my setup. This delay albeit much 
smaller is noticable when accessing e.g. a remote smb-share.
  
  2. Truncation as depicted in some screenshots above
  
  I believe baloo or kfilemetadata is responsible for this. I'll have to 
investigate.
  
  >   I understand that's a lot to ask (so feel free to ignore it).
  
  NP, learning to unit test is on my agenda anyway. But it comes at a price :)
  
  1. Patience on your side. I will take days.
  2. Your opinon on the weird arithmetic in line 147. It works for me but I 
don't know why.
  3. Tell me please where I can find the code for the popup menu behind the 
icon left to the navbar.
  
  F5665653: what is my name.png 
  
  I also believe the positioning issue I'm trying to fix here is quite 
independent from (to?) the phenomena above.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: cfeck

D9973: ktooltipwidget: Fix tooltip positioning

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @michaelh Can you please describe exactly how many bugs are there and how to 
reproduce them?
  
  Also, ideally each bug should be reproduced by a test case in 
`ktooltipwidgettest.cpp`, but I understand that's a lot to ask (so feel free to 
ignore it).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: cfeck

Re: KHolidays as Framework (redux)

[Dominik Haumann]

Am 20.01.2018 17:22 schrieb "Volker Krause" :

Thanks, should be fixed now.


Certainly better, although code examples and the like still would make a
significant difference ;)

Cheers
Dominik




On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote:
> Hi,
>
> CC: only kdepim, kde-frameworks-devel
>
> I have some general comments about the API documentation. Looking at
> https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html
> the list mostly (only?) contains classes that are internal. Looking at
> https://github.com/KDE/kholidays/blob/master/src/holiday.h
> we can see documentation exists also for important classes, but the docs
> are not listed because the class documentation is missing.
>
> This is not a showstopper, but without accessible API, the visibility of
> this framework is much reduced. It would be nice, if the API documentation
> is complete, so here is still some room for improvement ;)
>
> Best regards
> Dominik
>
>
>
> Am 20.01.2018 11:39 schrieb "Volker Krause" :
>
> On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:
> > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:
> > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > > Hi,
> > > > > >
> > > > > > It's xmas holidays, so it must be time to poke a stick at
>
> KHolidays
>
> > > > > > again
> > > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > > outstanding
> > > > > > porting issues with KHolidays and it is ready for review to be
> > > > > > included
> > > > > > as
> > > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > > step?
> > > > >
> > > > > Please make sure it passes all of the items in this checklist
> > > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > >
> > > > AFAICS this is followed, apart from using the KF5 version number and
> > > > actually being marked as a framework, which I guess is pending
>
> framework
>
> > > > approval.
> > >
> > > This got lost somehow, any objection to executing the move to
frameworks
> > > for 5.43, say end of this week?
> >
> > Go ahead.
>
> The necessary metainfo and CMake changes are pushed, the sysadmin ticket
for
> the repo metadata change is T7791.
>
> Summary: KHolidays will not be part of the 18.x KDE Application releases
> anymore, but instead become part of the KDE Frameworks releases with
version
> 5.43. There are no ABI or name changes, just the .so version increases
from
> 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully
be
> hardly noticeable.
> Side benefit: plasma-workspace no longer depends on a library from KDE
> Application releases.
>
> Regards,
> Volker

Re: KHolidays as Framework (redux)

[Volker Krause]

Thanks, should be fixed now.

On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote:
> Hi,
> 
> CC: only kdepim, kde-frameworks-devel
> 
> I have some general comments about the API documentation. Looking at
> https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html
> the list mostly (only?) contains classes that are internal. Looking at
> https://github.com/KDE/kholidays/blob/master/src/holiday.h
> we can see documentation exists also for important classes, but the docs
> are not listed because the class documentation is missing.
> 
> This is not a showstopper, but without accessible API, the visibility of
> this framework is much reduced. It would be nice, if the API documentation
> is complete, so here is still some room for improvement ;)
> 
> Best regards
> Dominik
> 
> 
> 
> Am 20.01.2018 11:39 schrieb "Volker Krause" :
> 
> On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:
> > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:
> > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > It's xmas holidays, so it must be time to poke a stick at
> 
> KHolidays
> 
> > > > > > again
> > > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > > outstanding
> > > > > > porting issues with KHolidays and it is ready for review to be
> > > > > > included
> > > > > > as
> > > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > > step?
> > > > > 
> > > > > Please make sure it passes all of the items in this checklist
> > > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > > 
> > > > AFAICS this is followed, apart from using the KF5 version number and
> > > > actually being marked as a framework, which I guess is pending
> 
> framework
> 
> > > > approval.
> > > 
> > > This got lost somehow, any objection to executing the move to frameworks
> > > for 5.43, say end of this week?
> > 
> > Go ahead.
> 
> The necessary metainfo and CMake changes are pushed, the sysadmin ticket for
> the repo metadata change is T7791.
> 
> Summary: KHolidays will not be part of the 18.x KDE Application releases
> anymore, but instead become part of the KDE Frameworks releases with version
> 5.43. There are no ABI or name changes, just the .so version increases from
> 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be
> hardly noticeable.
> Side benefit: plasma-workspace no longer depends on a library from KDE
> Application releases.
> 
> Regards,
> Volker



signature.asc
Description: This is a digitally signed message part.

Re: A new tier1 for icontheme.rcc handling

[Andrius da Costa Ribas]

+1 for the name kiconsupport as Ben suggested.


Em 19 de jan de 2018 21:49, "Ben Cooksley"  escreveu:

On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth  wrote:
> Hi everyone.

Hi Hannah,

>
> Only some few of you will be aware of KIconThemes ability to load binary
> icon themes automagically.
>
> https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48
>
> The code looks for a icontheme.rcc and sets it as default theme.
>
> On Windows and Mac we rely on that code as it is more feasible to
> install that one
> file with an single application installer. This code also ensures that
> the theme path is set,
> which on Linux is done by the qpa.
>
> The problem with the current solution is that it only allows one single
> theme and is in a tier3
> framework.
>
> I recently talked to David Faure and we agreed that it would be best to
> put those few line of code into a new
> created tier1 framework, with an explicit call instead of the magical
> loading.
>
> The explicit call would allow to specify the theme loaded and we  can
> still maintain the current behaviour by putting a call to
> that new framework into KIconThemes.
>
> Now we need a name for that tier1 framework and ideally someone who
> steps up for the once in a lifetime chance to become
> maintainer of a glorious new tier1 framework.

While I can't be the maintainer for the framework, to get the ball
rolling may I suggest the name of 'kiconsupport' for the Framework?

>
> Cheers,
>
> Hannah
>

Cheers,
Ben

D9989: tools: Make all output messages translatable

[Burkhard Lück]

lueck added a comment.


  In https://phabricator.kde.org/D9989#193705, @michaelh wrote:
  
  > added i18n context
  
  
  OK from i18n pov, thanks

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

Re: KHolidays as Framework (redux)

[Dominik Haumann]

Hi,

CC: only kdepim, kde-frameworks-devel

I have some general comments about the API documentation. Looking at
https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html
the list mostly (only?) contains classes that are internal. Looking at
https://github.com/KDE/kholidays/blob/master/src/holiday.h
we can see documentation exists also for important classes, but the docs
are not listed because the class documentation is missing.

This is not a showstopper, but without accessible API, the visibility of
this framework is much reduced. It would be nice, if the API documentation
is complete, so here is still some room for improvement ;)

Best regards
Dominik



Am 20.01.2018 11:39 schrieb "Volker Krause" :

On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:
> On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:
> > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > Hi,
> > > > >
> > > > > It's xmas holidays, so it must be time to poke a stick at
KHolidays
> > > > > again
> > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > outstanding
> > > > > porting issues with KHolidays and it is ready for review to be
> > > > > included
> > > > > as
> > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > step?
> > > >
> > > > Please make sure it passes all of the items in this checklist
> > > > https://community.kde.org/Frameworks/CreationGuidelines
> > >
> > > AFAICS this is followed, apart from using the KF5 version number and
> > > actually being marked as a framework, which I guess is pending
framework
> > > approval.
> >
> > This got lost somehow, any objection to executing the move to frameworks
> > for 5.43, say end of this week?
>
> Go ahead.

The necessary metainfo and CMake changes are pushed, the sysadmin ticket for
the repo metadata change is T7791.

Summary: KHolidays will not be part of the 18.x KDE Application releases
anymore, but instead become part of the KDE Frameworks releases with version
5.43. There are no ABI or name changes, just the .so version increases from
5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be
hardly noticeable.
Side benefit: plasma-workspace no longer depends on a library from KDE
Application releases.

Regards,
Volker

D9989: tools: Make all output messages translatable

[Michael Heidelbach]

michaelh updated this revision to Diff 25687.
michaelh added a comment.


  added i18n context

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9989?vs=25676=25687

BRANCH
  translate-all (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9989

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/baloosearch/main.cpp
  src/tools/balooshow/main.cpp

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

D9990: Fix compilation of just the UI-less host tools

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:eddccea61f31: Fix compilation of just the UI-less host 
tools (authored by vkrause).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9990?vs=25680=25686

REVISION DETAIL
  https://phabricator.kde.org/D9990

AFFECTED FILES
  CMakeLists.txt

To: vkrause, #frameworks, apol

D9595: Don't export kded5 as a CMake target

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:55e9a348870f: Dont export kded5 as a CMake target 
(authored by vkrause).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9595?vs=24556=25685

REVISION DETAIL
  https://phabricator.kde.org/D9595

AFFECTED FILES
  src/CMakeLists.txt

To: vkrause, #frameworks, apol

D9990: Fix compilation of just the UI-less host tools

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9990

To: vkrause, #frameworks, apol

D9595: Don't export kded5 as a CMake target

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9595

To: vkrause, #frameworks, apol

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 94 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/94/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 20 Jan 2018 11:09:27 +
 Build duration:
47 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31553/59387)38%
(18561/48464)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8609/9037)50%
(5311/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8362/14345)50%
(4874/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3849/7794)33%
(1618/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(510/974)42%
(395/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

D9989: tools: Make all output messages translatable

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> michaelh wrote in monitorcommand.cpp:66
> Context needed?

yes, please add context about the meaning of %1

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

D9585: Fix finding libintl when "cross"-compiling native Yocto packages

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:5c98cc08767b: Fix finding libintl when 
cross-compiling native Yocto packages (authored by vkrause).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9585?vs=24541=25681

REVISION DETAIL
  https://phabricator.kde.org/D9585

AFFECTED FILES
  cmake/FindLibIntl.cmake

To: vkrause, #frameworks, ilic

D9595: Don't export kded5 as a CMake target

[Volker Krause]

vkrause added a comment.


  ping

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D9595

To: vkrause, #frameworks

D9990: Fix compilation of just the UI-less host tools

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  ECM usually takes care of disabling tests, but it nevertheless requires
  all targets the tests depend on to exist. With the new test_highlighter
  test this is not the case when building just the host tools though.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9990

AFFECTED FILES
  CMakeLists.txt

To: vkrause, #frameworks

Possible regression in kio with data loss

[Jaime]

Hi,

  Last weekend I did the following:
  * build kio using kdesrc-build
  * copy the resulting bin/kf5/file.so to /usr/lib64/qt5/plugins/kf5/kio
  * ldconfig
  * restart the session
  Just to be sure that all processes are using the new kio.

  I copied files to an ntfs filesystem and the files were copied and the
messages about rights where shown.

  Today I've done the same as last weekend, but when I copy a file to the
same filesystem, there is a message that the owner can't be changed, and
the resulting file has always 0 bytes (screenshot attached). If I move the
file, the original file content is lost, and also the destination has 0
bytes.

  This can be reproduced also in a loopback vfat, created following the
next steps:

dd if=/dev/zero of=fat.fs bs=1024 count=5120
(create the file fat.fs with only 5 MB)
/usr/sbin/mkfs.vfat fat.fs
(create the filesystem)
sudo mount -t vfat -o uid=,fmask=0007,dmask=,rw,noexec,loop fat.fs
/mnt
(mount being root the owner)

try to copy any file to /mnt

sudo umount /mnt
(don't forget to umount it when the tests are finished).

Best Regards.

D9585: Fix finding libintl when "cross"-compiling native Yocto packages

[Chusslove Illich]

ilic accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9585

To: vkrause, #frameworks, ilic

D9585: Fix finding libintl when "cross"-compiling native Yocto packages

[Volker Krause]

vkrause added a comment.


  ping

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D9585

To: vkrause, #frameworks

Re: KHolidays as Framework (redux)

[Volker Krause]

On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:
> On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:
> > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > Hi,
> > > > > 
> > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays
> > > > > again
> > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > outstanding
> > > > > porting issues with KHolidays and it is ready for review to be
> > > > > included
> > > > > as
> > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > step?
> > > > 
> > > > Please make sure it passes all of the items in this checklist
> > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > 
> > > AFAICS this is followed, apart from using the KF5 version number and
> > > actually being marked as a framework, which I guess is pending framework
> > > approval.
> > 
> > This got lost somehow, any objection to executing the move to frameworks
> > for 5.43, say end of this week?
> 
> Go ahead.

The necessary metainfo and CMake changes are pushed, the sysadmin ticket for 
the repo metadata change is T7791.

Summary: KHolidays will not be part of the 18.x KDE Application releases 
anymore, but instead become part of the KDE Frameworks releases with version 
5.43. There are no ABI or name changes, just the .so version increases from 
5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be 
hardly noticeable. 
Side benefit: plasma-workspace no longer depends on a library from KDE 
Application releases.

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Veluri Mithun]

velurimithun added a comment.


  Sry for the late patch :))
  
  I was busy with setting up Ruqola...
  
  I have one doubt that why this(kdirwatch_unittest.cpp ) file is in 
autotests?? It should be in unit tests right?
  
  Thank You for your patience.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9420

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Veluri Mithun]

velurimithun updated this revision to Diff 25677.
velurimithun added a comment.


  - use QLating1String
  - compile commenting remove_definition(DQT_NO_CAST_FROM_ASCII
  - Make necessary changes according to comments in 
https://phabricator.kde.org/D9420
  - Use QString::fromUtf8(..) to decode an escape sequence like \x21
  - Merge with origin/master
  - Rewrite strings using QLatin1String() and QString::fromLatin1()

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9420?vs=25076=25677

BRANCH
  complieWithoutRemoveDef

REVISION DETAIL
  https://phabricator.kde.org/D9420

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/desktoptojsontest.cpp
  autotests/kaboutdataapplicationdatatest.cpp
  autotests/kaboutdatatest.cpp
  autotests/kautosavefiletest.cpp
  autotests/kdelibs4migrationtest.cpp
  autotests/kdirwatch_unittest.cpp
  autotests/kformattest.cpp
  autotests/kpluginfactorytest.cpp
  autotests/kpluginloadertest.cpp
  autotests/kpluginmetadatatest.cpp
  autotests/kprocesstest.cpp
  autotests/krandomtest.cpp
  autotests/kshelltest.cpp
  autotests/kstringhandlertest.cpp
  autotests/ktexttohtmltest.cpp
  autotests/kusertest.cpp
  autotests/multiplugin.cpp

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

D9989: tools: Make all output messages translatable

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> monitorcommand.cpp:66
>  m_currentFile = filePath;
> -m_out << "Indexing: " << filePath;
> +m_out << i18n("Indexing: %1", filePath);
>  }

Context needed?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

D9989: tools: Make all output messages translatable

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: smithjd, Frameworks, vhanda.
michaelh added a project: Frameworks.
michaelh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  translate-all (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9989

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/baloosearch/main.cpp
  src/tools/balooshow/main.cpp

To: michaelh, smithjd, #frameworks, vhanda
Cc: ngraham

D9989: tools: Make all output messages translatable

[Michael Heidelbach]

michaelh added a reviewer: lueck.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/24/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 20 Jan 2018 09:08:28 +
 Build duration:
3 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D9959: baloosearch: Send summary to stderr

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3e1a9b843dfd: baloosearch: Send summary to stderr 
(authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9959?vs=25586=25673

REVISION DETAIL
  https://phabricator.kde.org/D9959

AFFECTED FILES
  src/tools/baloosearch/main.cpp

To: michaelh, #frameworks, vhanda, smithjd, broulik, lbeltrame

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Laurent Montel]

mlaurent added a comment.


  Ping bis ?:)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9420

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

D9987: Lessen log spam by not checking for existence of file with empty name

[Henrik Fehlauer]

rkflx updated this revision to Diff 25672.
rkflx added a comment.


  Spelling.

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9987?vs=25671=25672

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9987

AFFECTED FILES
  src/kdeinit/kinit.cpp

To: rkflx, #frameworks
Cc: dhaumann

D9987: Lessen log spam by not checking for existence of file with empty name

[Henrik Fehlauer]

rkflx updated this revision to Diff 25671.
rkflx added a comment.


  Add comment. Thanks for the tip, Dominik :)

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9987?vs=25670=25671

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9987

AFFECTED FILES
  src/kdeinit/kinit.cpp

To: rkflx, #frameworks
Cc: dhaumann

D9959: baloosearch: Send summary to stderr

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R293 Baloo

BRANCH
  search-summary

REVISION DETAIL
  https://phabricator.kde.org/D9959

To: michaelh, #frameworks, vhanda, smithjd, broulik, lbeltrame

D9958: balooctl status: Produce parseable output

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  Changes are trivial enough IMO. Perhaps wait one or two days to see if anyone 
objects, then you can land this.

REPOSITORY
  R293 Baloo

BRANCH
  formatting

REVISION DETAIL
  https://phabricator.kde.org/D9958

To: michaelh, #frameworks, vhanda, smithjd, lbeltrame
Cc: broulik, ngraham

D9987: Lessen log spam by not checking for existence of file with empty name

[Dominik Haumann]

dhaumann added a comment.


  +1, but someone else must approve.
  
  You could even add this as comment: // check for empty string to avoid 
warning message in QFileExists.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: dhaumann