D10918: taglibextractor: Refactor for better readability

astippich added a comment. Btw, I'm not opposed anymore for merging before D10803 , as I need some more time to think about the value types and probably also need to extend the tests. I will adapt to the changes afterwards. REPOSITORY R286 KFileMetaData

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/71/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 04:18:22 + Build duration: 1 hr 33 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 152 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/152/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 04:17:50 + Build duration: 1 hr 19 min and counting JUnit Tests Name: (

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/23/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 04:17:50 + Build duration: 51 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 173 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/173/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Mar 2018 04:17:50 + Build duration: 31 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/96/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Mar 2018 04:18:22 + Build duration: 19 min and counting JUnit Tes

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Mar 2018 04:17:27 + Build duration: 15 min and counting JUnit Tests Name: (root) F

D10621: Highlighting Indexer: list of suggestions

jpoelen added a comment. I've already planned to fix all the suggestions, but I lost a lot of time updating the `sql*.xml` files and came across a very strange bug related to QRegularExpression by adding some tests. At the moment, I do not know if it's my tool to test, my version of Qt that

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: broulik, #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham updated this revision to Diff 29366. ngraham added a comment. Actually fix the problem, using the same fix as in qqc-desktop-style (D11274 ) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11244

D10078: Add separate lib KF5::DBusRunner

davidedmundson updated this revision to Diff 29364. davidedmundson added a comment. Rewritten with the second class I suggested. Not trying to comandeer your work, if you think it was better before, go for that. IMHO it's nice and OO now with the submit/cancel methods being with the

D10078: Add separate lib KF5::DBusRunner

davidedmundson updated this revision to Diff 29362. davidedmundson added a comment. Add the two really boring changes I wanted (virtual hook + class rename) REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10078?vs=25888&id=29362 BRANCH master REVISION

D10078: Add separate lib KF5::DBusRunner

davidedmundson commandeered this revision. davidedmundson edited reviewers, added: kossebau; removed: davidedmundson. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D10078 To: davidedmundson, broulik, kossebau Cc: michaelh, ngraham, #frameworks

D1231: Add Remote Access interface to KWayland

romangg added a comment. Please rebase onto master (or if this leads to problems with your remote merge master). REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich, romangg, ngraham, alexeymin, #framew

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham added a comment. Here's the bug tracking the QQC2 issue: https://bugs.kde.org/show_bug.cgi?id=391780 FWIW, by coincidence someone in the VDG room today actually independently noticed the difference between the two rendering styles (In Discover, which uses Kirigami, which uses t

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Mar 2018 18:29:59 + Build duration: 8 min 50 sec and counting JUnit Test

D10669: Reduce plasmashell frozen time

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ff6c795dcda7: Reduce plasmashell frozen time (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10669?vs=27575&id=29346#toc REPOSITORY R278 KWindowSystem CHANGES SINCE LA

D11260: avoid asking for an empty protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R313:a3364a87dda4: avoid asking for an empty protocol (authored by jtamate). REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11260?vs=29316&id=29343 REVISION DETAIL http

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham planned changes to this revision. ngraham added a comment. Hah, that's funny. That also implies that there's absolutely nothing wrong with `Text.QtRendering`, if QQC2-using non-Plasma apps been accidentally using it for years and nobody has found any issues. REPOSITORY R242 Plasma

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/95/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Mar 2018 15:22:49 + Build duration: 15 min and counting JUnit Tes

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/70/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Mar 2018 15:22:49 + Build duration: 6 min 58 sec and counting

D11137: overflow-menu as view-more-symbolic, and horizontal

Fuchs added a comment. Yes, I very much like the overflow and the usage you describe, as per the discussion on Telegram and https://phabricator.kde.org/D11231, I think mixer is however not an example where it should be used, because in the mixer it's not an overflow of functionality, but rat

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/94/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Mar 2018 14:32:19 + Build duration: 42 min and counting JUnit Tes

Re: KUserFeedback UUID question

12.03.2018, 15:18, "Volker Krause" : > On Monday, 12 March 2018 13:00:31 CET Aleksey Kontsevich wrote: >>  12.03.2018, 11:25, "Volker Krause" : >>  > I'm fine with changing things, I'm just still trying to understand the >>  > requirements correctly :) >> >>  Main idea and requirements: we need mor

Re: KUserFeedback UUID question

12.03.2018, 15:18, "Volker Krause" : > On Monday, 12 March 2018 11:06:59 CET Aleksey Kontsevich wrote: >You could still do that as part of the custom data source, the request does > after all only have to happen once, rather than on every submission. I agree - only once. We could use such approach

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/69/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Mar 2018 14:32:19 + Build duration: 5 min 57 sec and counting

D11260: avoid asking for an empty protocol

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D11260 To: jtamate, #frameworks, dfaure Cc: michaelh

Re: KUserFeedback UUID question

On Monday, 12 March 2018 13:00:31 CET Aleksey Kontsevich wrote: > 12.03.2018, 11:25, "Volker Krause" : > > I'm fine with changing things, I'm just still trying to understand the > > requirements correctly :) > > Main idea and requirements: we need more generic and extendable approach, in > particu

Re: KUserFeedback UUID question

On Monday, 12 March 2018 11:06:59 CET Aleksey Kontsevich wrote: > 12.03.2018, 11:25, "Volker Krause" : > > On Sunday, 11 March 2018 16:23:33 CET Aleksey Kontsevich wrote: > >> Thanks, Volker, for the answer. Will think more and try it in action > >> provider<->server<->analytic app to see how it

Re: KUserFeedback UUID question

12.03.2018, 11:25, "Volker Krause" : > I'm fine with changing things, I'm just still trying to understand the > requirements correctly :) Main idea and requirements: we need more generic and extendable approach, in particular: - network communication - local statistics log - settings - UI: audit

Re: KUserFeedback UUID question

12.03.2018, 11:25, "Volker Krause" : > On Sunday, 11 March 2018 16:23:33 CET Aleksey Kontsevich wrote: >>  Thanks, Volker, for the answer. Will think more and try it in action >>  provider<->server<->analytic app to see how it works to better understand. >>  However still have some concerns: if I w

D11260: avoid asking for an empty protocol

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Another case of empty protocol for findProtocol. https://phabricator.kde.org/D11013 In this case, just st

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/22/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 12 Mar 2018 11:00:52 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 172 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/172/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Mar 2018 11:00:52 + Build duration: 8 min 43 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 151 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/151/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Mar 2018 11:00:52 + Build duration: 6 min 42 sec and counting JUnit Tests Name:

D11088: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cbedf15311aa: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11088?vs=29085&id=29314

Re: KUserFeedback UUID question

On Sunday, 11 March 2018 16:23:33 CET Aleksey Kontsevich wrote: > Thanks, Volker, for the answer. Will think more and try it in action > provider<->server<->analytic app to see how it works to better understand. > However still have some concerns: if I want to get such id from the server I > need

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Kai's right. The patch doesn't work as indented. You're (accidentally) just always enabling Text.QtRendering If we take your code in Label and change it to the