D11038: balooctl: Add clean option to remove stale file index entries

smithjd added a comment. D11529 hooks up the index cleaner class. I've modified it so that it skips unmounted directories. This patch could probably be dropped, though some form of integrity checker that ignores mount points might still be useful for

D11529: Balooctl: Deindex unfound files with check command.

smithjd added reviewers: vhanda, michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30466. smithjd added a comment. - Change check command description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30173=30466 BRANCH master-filedeindexer REVISION DETAIL https://phabricator.kde.org/D11529

D11642: Fix the rcc binary package generation

kossebau added inline comments. INLINE COMMENTS > KF5PackageMacros.cmake:164 > + DEPENDS ${GENERATED_RCC_CONTENTS} > ${component}-${root}-metadata-json ${kpkgqrc}) > +install(FILES ${GENERATED_RCC_CONTENTS} DESTINATION >

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 162 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/162/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 21:39:13 + Build duration: 2 hr 28 min and counting JUnit Tests Name:

D11204: Support NTFS hidden files

dfaure requested changes to this revision. dfaure added inline comments. INLINE COMMENTS > file_unix.cpp:415 > +#ifdef Q_OS_LINUX > +bool isNtfsHidden(const QString ) > +{ static > file_unix.cpp:422 > +} > +constexpr size_t xattr_size = 1024; > +char strAttr[xattr_size]; Doesn't

D10621: Highlighting Indexer: list of suggestions

jpoelen updated this revision to Diff 30448. jpoelen added a comment. New suggestions: - Regex "^xyz\b" -> WordDetect with column=0 - Regex "^xyz" with xyz a string of more than 2 characters -> StringDetext with column=0 Output: - Double quote are no longer escaped -

D11642: Fix the rcc binary package generation

davidedmundson accepted this revision. davidedmundson added a comment. Seems to work \o/ Good stuff. Ship this, but lets not rush the workspace changes back in without some more people verifying that. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11642 To:

D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

kossebau added inline comments. INLINE COMMENTS > graesslin wrote in netwm.cpp:2845-2847 > I guess we need to fix this Thanks for having done that :) REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11414 To: graesslin, #frameworks, #kwin, #plasma,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 183 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/183/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 21:39:13 + Build duration: 27 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/33/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 21:39:13 + Build duration: 23 min and counting JUnit Tests Name: (root)

D11628: Fix remotedirnotify service file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6338394f3424: Fix remotedirnotify service file (authored by valeriymalov). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11628?vs=30358=30443 REVISION DETAIL

D11193: Sonnet : use current hunspell API

rjvbb added a comment. No problem if there's a good reason to wait! Surprising that OpenSuSE has such an old hunspell but apparently a new enough Qt and other dependencies required for building Plasma5 desktops! (My Ubuntu 14.04 also has hunspell 1.3.2 but is stuck on Qt 5.2 so I'm

D11193: Sonnet : use current hunspell API

dfaure added a comment. OpenSuSE Leap 42.3 (whose core packages are starting to get really old...) has hunspell-1.3.2-7.4.x86_64 Can you wait for a few months? OpenSuSE 15 should be released end of May. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To:

D11193: Sonnet : use current hunspell API

rjvbb added a comment. > Which version of hunspell does this raise the requirement to? 1.5.1 it seems: https://github.com/hunspell/hunspell/commit/f90e69759203a945128b704a1b7037697a5113dd Is that acceptable (that release is almost 2 years old by now)? REPOSITORY R246 Sonnet

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

On Sun, Mar 25, 2018 at 6:59 AM, Martin Flöser wrote: > Hi Ben, Hi Martin, > > I pushed a possible fix. No guarnatees as this code obviously compiled on my > system. Thanks. That has fixed the issue. > > Could the compiler settings please be adjusted so that we have

KDE CI: Frameworks kcompletion kf5-qt5 AndroidQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20AndroidQt5.10/1/ Project: Frameworks kcompletion kf5-qt5 AndroidQt5.10 Date of build: Sat, 24 Mar 2018 19:40:18 + Build duration: 3 min 57 sec and counting

KDE CI: Frameworks kjobwidgets kf5-qt5 AndroidQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20AndroidQt5.10/1/ Project: Frameworks kjobwidgets kf5-qt5 AndroidQt5.10 Date of build: Sat, 24 Mar 2018 19:40:17 + Build duration: 3 min 9 sec and counting

D11193: Sonnet : use current hunspell API

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Which version of hunspell does this raise the requirement to? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To: rjvbb, #frameworks, dfaure, mlaurent,

D11183: Sonnet: don't impose the default client

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I like the idea. INLINE COMMENTS > loader.cpp:101 > +// if it does it will be contained in lClients. > +QVectorIterator itr1(lClients); > +bool unknown =

D11657: Do not export sanitizer by default

michaelh created this revision. michaelh added reviewers: Baloo, davidedmundson. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY The interfaces of DatabaseSanitizer

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 17:54:55 + Build duration: 3 min 30 sec and counting JUnit

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

Hi Ben, I pushed a possible fix. No guarnatees as this code obviously compiled on my system. Could the compiler settings please be adjusted so that we have warnings be warnings on all ci systems and not fail on randomly? This was rather unexpected for me and makes it quite difficult to

D11642: Fix the rcc binary package generation

bshah marked 2 inline comments as done. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11642 To: bshah, mart, davidedmundson, apol Cc: kossebau, #frameworks, michaelh, ngraham

D11652: Don't show the background if Button.flat

apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. apol requested review of this revision. REVISION SUMMARY Otherwise the flat property is ignored TEST PLAN Tested on KDE

D11642: Fix the rcc binary package generation

bshah updated this revision to Diff 30412. bshah added a comment. - regnerate rcc file on every build - add comment in add_custom_target for logging in build log - Fix the path in the qrc file which broke in previous attempt, plasma/plasmoids// v/s plasma/plasmoids// REPOSITORY R290

KDE CI: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.10/8/ Project: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 24 Mar 2018 16:30:51 + Build duration: 37 min and counting JUnit Tests

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

lueck updated this revision to Diff 30411. lueck added a comment. fix typo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11619?vs=30340=30411 REVISION DETAIL https://phabricator.kde.org/D11619 AFFECTED FILES src/customization/entities/general.entities To: lueck,

D11552: [WIP] Handle CJK characters

michaelh marked 5 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham

D11552: [WIP] Handle CJK characters

michaelh updated this revision to Diff 30410. michaelh added a comment. - Retain term positions - Optimize - Apply suggested change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11552?vs=30337=30410 BRANCH cjk (branched from master) REVISION DETAIL

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 16:33:16 + Build duration: 4 min 13 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 16:33:16 + Build duration: 3 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 16:33:16 + Build duration: 2 min 7 sec and counting JUnit Tests

D11649: Fix crash in the file slave

aacid created this revision. aacid added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. aacid requested review of this revision. REVISION SUMMARY When doing a KIO::storedPut to a filename that has a .part file existing there were two problems: - We were

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh updated this revision to Diff 30407. michaelh added a comment. - Test position info REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11587?vs=30336=30407 BRANCH termgeneratortest (branched from master) REVISION DETAIL

KDE CI: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.10 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsMSVCQt5.10/7/ Project: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 24 Mar 2018 13:35:33 + Build duration: 2 hr 15 min and counting JUnit

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.10/6/ Project: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 24 Mar 2018 13:35:30 + Build duration: 2 hr 6 min and counting JUnit Tests

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:36:21 + Build duration: 1 hr 21 min and counting JUnit

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:36:28 + Build duration: 1 hr 19 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:36:14 + Build duration: 1 hr 18 min and counting JUnit Tests

D11193: Sonnet : use current hunspell API

rjvbb added a comment. Any objections if I commit this by the end of the week? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To: rjvbb, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

rjvbb added a comment. Any objections if I commit this by the end of the week? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/32/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:34:41 + Build duration: 1 hr 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:35:46 + Build duration: 1 hr 5 min and counting JUnit Tests Name:

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:35:24 + Build duration: 1 hr 4 min and counting JUnit Tests

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.9 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Frameworks threadweaver kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:37:21 + Build duration: 1 hr 1 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/113/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:36:55 + Build duration: 59 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:33:34 + Build duration: 1 hr 1 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/88/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:55 + Build duration: 55 min and counting

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:34:31 + Build duration: 56 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:33:15 + Build duration: 52 min and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:33:05 + Build duration: 50 min and counting JUnit Tests Name:

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:22 + Build duration: 44 min and counting CONSOLE

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:21 + Build duration: 43 min and counting JUnit

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/32/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:13 + Build duration: 43 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:36:14 + Build duration: 40 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 182 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/182/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:34:40 + Build duration: 40 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:01 + Build duration: 37 min and counting JUnit Tests

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:36:21 + Build duration: 38 min and counting JUnit Tests

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:36:28 + Build duration: 35 min and counting JUnit Tests Name:

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. ping. Unless someone objects, I will push this change in a couple days. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux Cc: #build_system, #frameworks, michaelh, ngraham

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:35:46 + Build duration: 32 min and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:35:51 + Build duration: 31 min and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:35:51 + Build duration: 32 min and counting JUnit Tests Name:

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:35:45 + Build duration: 29 min and counting JUnit Tests Name:

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:35:38 + Build duration: 29 min and counting JUnit Tests Name:

D11642: Fix the rcc binary package generation

bshah added a comment. In D11642#232866 , @apol wrote: > See older reviews. This won't work because cmake doesn't know when one of the contained files is modified so rcc files are never regenerated properly. I've solution for that in

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:35:24 + Build duration: 28 min and counting JUnit Tests

D10251: [RFC] Use mipmap filtering in window thumbnails

ngraham added a comment. Could we land this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg, davidedmundson Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 161 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/161/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:34:40 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:35:23 + Build duration: 27 min and counting JUnit Tests Name:

D11643: Fix crash when device emits ready read after job is finished

aacid added a comment. Should fix T8280 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11643 To: aacid, #frameworks, dfaure Cc: michaelh, ngraham

KDE CI: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.10/7/ Project: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 24 Mar 2018 13:32:44 + Build duration: 27 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 38 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:33:34 + Build duration: 26 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/33/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:33:34 + Build duration: 24 min and counting JUnit

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:34:30 + Build duration: 21 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/66/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:33:15 + Build duration: 18 min and counting JUnit Tests

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:34:31 + Build duration: 16 min and counting JUnit

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:33:05 + Build duration: 16 min and counting JUnit Tests Name:

D11642: Fix the rcc binary package generation

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. See older reviews. This won't work because cmake doesn't know when one of the contained files is modified so rcc files are never regenerated properly. I suggest actually checking

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/21/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Mar 2018 13:32:10 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/49/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:33:16 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:33:05 + Build duration: 9 min 39 sec and counting JUnit Tests

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/53/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Mar 2018 13:32:10 + Build duration: 10 min and counting JUnit Tests Name: (root)

Re: kwidgetsaddons unstable in CI

Bah, that's much larger than the test assumes. I'll have to investigate. No idea how long that will take :( And, .. thanks for your answer, Ben. Michael On 24.03.2018 11:28, Ben Cooksley wrote: On Sat, Mar 24, 2018 at 9:14 PM, Michael Heidelbach wrote: Hi! Hi Michael,

D11643: Fix crash when device emits ready read after job is finished

aacid created this revision. aacid added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. aacid requested review of this revision. TEST PLAN Run test without the change in transferjob.cpp -> crash Run test with the change and it works REPOSITORY R241 KIO

D11642: Fix the rcc binary package generation

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in KF5PackageMacros.cmake:158 > This "Generating xyz" might be still good to have. Please consider picking > this up with a > > COMMENT "Generating: ${xyz}" > > added to `add_custom_command`, where ${xyz} gets a proper

D11642: Fix the rcc binary package generation

kossebau added inline comments. INLINE COMMENTS > KF5PackageMacros.cmake:158 > -include(${kpackagedir}/qrc.cmake) > -message(STATUS \"Generating: > ${KDE_INSTALL_FULL_DATADIR}/${install_dir}/${root}/${component}/contents.rcc\") > -execute_process(COMMAND ${KPACKAGE_RCC}

D11642: Fix the rcc binary package generation

bshah added reviewers: mart, davidedmundson, apol. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11642 To: bshah, mart, davidedmundson, apol Cc: #frameworks, michaelh, ngraham

D11642: Fix the rcc binary package generation

bshah updated this revision to Diff 30385. bshah edited the test plan for this revision. bshah added a comment. update commit message REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11642?vs=30384=30385 BRANCH fix-bundled-packages REVISION DETAIL

D11642: Fix the rcc binary package generation

bshah created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY kpackage_install_bundled_package used install(CODE ..) for the generation and installation of the

D11628: Fix remotedirnotify service file

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. Good catch, thanks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11628 To: valeriymalov, #frameworks,

Re: kwidgetsaddons unstable in CI

On Sat, Mar 24, 2018 at 9:14 PM, Michael Heidelbach wrote: > Hi! Hi Michael, > > A unit test for ktooltipswidget is failing in CI. Most likely that is > because that test is dependent on screen size. To fix that it would be good > to know the size(s) of the screen(s) used in

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

Hi Martin, Please see below. Could you please fix this as soon as possible? This is blocking all FreeBSD Dependency builds meaning any change to the binary compatibility state of the FreeBSD platform will break the whole CI system on FreeBSD. Cheers, Ben On Wed, Mar 21, 2018 at 6:51 PM, CI

kwidgetsaddons unstable in CI

Hi! A unit test for ktooltipswidget is failing in CI. Most likely that is because that test is dependent on screen size. To fix that it would be good to know the size(s) of the screen(s) used in CI. Could you tell me please. MIchael

KDE CI: Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20AndroidQt5.10/1/ Project: Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.10 Date of build: Sat, 24 Mar 2018 10:03:02 + Build duration: 9 min 3 sec and counting

KDE CI: Frameworks threadweaver kf5-qt5 AndroidQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20AndroidQt5.10/1/ Project: Frameworks threadweaver kf5-qt5 AndroidQt5.10 Date of build: Sat, 24 Mar 2018 10:02:52 + Build duration: 7 min 14 sec and counting

KDE CI: Frameworks karchive kf5-qt5 AndroidQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20AndroidQt5.10/1/ Project: Frameworks karchive kf5-qt5 AndroidQt5.10 Date of build: Sat, 24 Mar 2018 10:03:03 + Build duration: 6 min 34 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 AndroidQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20AndroidQt5.10/1/ Project: Frameworks extra-cmake-modules kf5-qt5 AndroidQt5.10 Date of build: Sat, 24 Mar 2018 10:03:01 + Build duration: 5 min 55 sec and counting

KDE CI: Frameworks kcodecs kf5-qt5 AndroidQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.10/1/ Project: Frameworks kcodecs kf5-qt5 AndroidQt5.10 Date of build: Sat, 24 Mar 2018 10:02:53 + Build duration: 5 min 22 sec and counting

  1   2   >