D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. I'll leave the string the way it is for now so this can go into Frameworks 5.45, and change it after the string freeze. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham,

D11733: Allow opening items from the open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11733 To: ngraham, #dolphin, #frameworks Cc: michaelh, ngraham

D11735: Make it possible to fully build the project when crosscompiling

apol created this revision. apol added reviewers: Frameworks, vkrause, dhaumann. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Use cmake ExternalProject to compile the native tool we need to successfully build this framework.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/37/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 27 Mar 2018 00:14:38 + Build duration: 28 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 187 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/187/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 27 Mar 2018 00:14:38 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 166 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/166/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Mar 2018 00:14:38 + Build duration: 6 min 56 sec and counting CONSOLE OUTPUT

D11734: Have KIO build for Android

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. apol requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11734 AFFECTED FILES src/CMakeLists.txt

D11605: Fix look-up of KF5::Auth

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:96f58a28febd: Fix look-up of KF5::Auth (authored by apol). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11733: Allow opening items from the open/save dialogs

ngraham created this revision. ngraham added reviewers: Dolphin, Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch adds an Open menu item to the open/save dialogs' context menu. FEATURE: 392329 TEST PLAN

D11733: Allow opening items from the open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11733 To: ngraham, #dolphin, #frameworks Cc: michaelh, ngraham

D11732: Improve protocols documentation

romangg added a comment. Currently I'm reading through these protocols for my 5.13 color correction work and I was wondering about the output management related protocol documentation, which seems to me faulty in large areas. In fact it seems to me so wrong, that I'm asking myself if I just

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 186 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/186/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Mar 2018 22:26:57 + Build duration: 29 min and counting JUnit Tests Name: (root)

D11732: Improve protocols documentation

romangg created this revision. romangg added a reviewer: Frameworks. Restricted Application added a project: Frameworks. romangg requested review of this revision. REVISION SUMMARY Improves the outputmanagement and outputdevice protocol documentation. REPOSITORY R127 KWayland BRANCH

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/36/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Mar 2018 22:26:57 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 165 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/165/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 22:26:57 + Build duration: 4 min 6 sec and counting CONSOLE OUTPUT

D11705: Highlight selected items when showing parent folder from the open/save dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:05fe10da0034: Highlight selected items when showing parent folder from the open/save dialog (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11685: Implement single click on line number to select line of text

rkron edited the summary of this revision. rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. In D11569#234901 , @ngraham wrote: > I rather prefer Open With > Other Application... myself, and can change it back if folks prefer (I thought you wanted it this way, sorry!). That's what I reckoned, and even

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. I rather prefer Open With > Other Application... myself, and can change it back if folks prefer (I thought you wanted it this way, sorry!). REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. You probably had your reasons for also changing back Open With > Other Application…, but I guess this way it's fine too. Accepting for now. If there are no further objections until

D10803: handle more tags in taglibextractor

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. I am really sorry. I had missed that you had modified the diff to only include the safe set of changes. I should really apologize. Thanks for your work, it is very much appreciated.

D11183: Sonnet: don't impose the default client

rjvbb set the repository for this revision to R246 Sonnet. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause Cc: mwolff, kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

rjvbb updated this revision to Diff 30657. rjvbb marked an inline comment as done. rjvbb added a comment. next iteration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11183?vs=30617=30657 REVISION DETAIL https://phabricator.kde.org/D11183 AFFECTED FILES src/core/loader.cpp

D11183: Sonnet: don't impose the default client

rjvbb marked 4 inline comments as done. rjvbb added a comment. > If I suggest something and Milian suggests something else then Milian is right :-) Unconditionally? :) INLINE COMMENTS > dfaure wrote in loader.cpp:114 > can this ever happen now that you set it if it was empty? If it can

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file_unix.cpp:416 > > -#ifdef Q_OS_LINUX > +#ifdef HAVE_SYS_XATTR_H > static bool isNtfsHidden(const QString ) should be #if, not #ifdef. It's always

D11183: Sonnet: don't impose the default client

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I suggested find_if because I didn't think about any_of, which is even better indeed :-) If I suggest something and Milian suggests something else then Milian is right :-)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Mar 2018 15:52:51 + Build duration: 2 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Mar 2018 15:52:51 + Build duration: 1 min 46 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/35/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 15:52:51 + Build duration: 1 min 12 sec and counting JUnit Tests

D11705: Highlight selected items when showing parent folder from the open/save dialog

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D11705 REVISION DETAIL https://phabricator.kde.org/D11705 To: ngraham, #frameworks, broulik Cc: broulik, michaelh, ngraham

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Mar 2018 14:08:45 + Build duration: 5 min 58 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Mar 2018 14:08:45 + Build duration: 4 min 29 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 14:08:45 + Build duration: 1 min 10 sec and counting JUnit Tests

D11717: regenerate qrc on every build

This revision was automatically updated to reflect the committed changes. Closed by commit R290:f3619363ed63: regenerate qrc on every build (authored by bshah). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11717?vs=30628=30631 REVISION DETAIL

D11717: regenerate qrc on every build

davidedmundson accepted this revision. REPOSITORY R290 KPackage BRANCH regenerateqrc REVISION DETAIL https://phabricator.kde.org/D11717 To: bshah, mart, davidedmundson Cc: #frameworks, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

kossebau added a comment. From quick pure code reading this looks fine to me. +1 Have not tested though right now, so have to leave the ship-it to actual Dolphin/KIO maintainers. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11716 To: rominf, #dolphin, kossebau,

D11717: regenerate qrc on every build

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH regenerateqrc REVISION DETAIL https://phabricator.kde.org/D11717 To: bshah, mart Cc: #frameworks, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf updated this revision to Diff 30629. rominf added a comment. - Consider criticism REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11716?vs=30627=30629 BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL https://phabricator.kde.org/D11716

D11717: regenerate qrc on every build

bshah created this revision. bshah added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY this will ensure that file deletion and inclusion are taken care of

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

kossebau added inline comments. INLINE COMMENTS > config-kioslave-file.h.cmake:14 > +/* Defined if system has extended file attributes support. */ > +#cmakedefine01 HAVE_SYS_XATTR_H While FindACL.cmake sets internally the cmake variable HAVE_SYS_XATTR_H, it is not part of the officially set

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf updated this revision to Diff 30627. rominf added a comment. - Add a trailing newline to the end of the file REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11716?vs=30626=30627 BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf updated this revision to Diff 30626. rominf added a comment. - Actualy fixing build REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11716?vs=30625=30626 BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL https://phabricator.kde.org/D11716

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham added a comment. Also, we have a request to add an Open action to the menu (https://bugs.kde.org/show_bug.cgi?id=392329), which would take care of the use case of wanting to directly open the folder. I plan to submit a patch for that, too. REPOSITORY R241 KIO REVISION DETAIL

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

kossebau added a comment. Thanks for coming up so quick with a fix :) You surely wanted to also wrap the include of the "sys/xattr.h" header in the new condition? Missing from the patch. INLINE COMMENTS > config-kioslave-file.h.cmake:15 > +#cmakedefine01 HAVE_SYS_XATTR_H > \ No newline

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > kossebau wrote in file_unix.cpp:40 > This unconditional include sadly breaks the build at least on FreeBSD (see > https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/console > ) and other systems where this

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf created this revision. rominf added reviewers: Dolphin, kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. rominf requested review of this revision. REVISION SUMMARY Support hidden NTFS files only on OS that

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11705 To: ngraham, #frameworks Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11705 To: ngraham, #frameworks Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham added a comment. In D11705#234324 , @broulik wrote: > Good idea. > > How about folders? Perhaps we should use a different behavior for folders as you're imho more likely to want to open a folder in the file manager than look "where

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham updated this revision to Diff 30622. ngraham added a comment. Fix the case where nothing is selected (i.e. when the user right-clicks on the background) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11705?vs=30582=30622 BRANCH arcpatch-D11705

D11183: Sonnet: don't impose the default client

rjvbb added a comment. > ah, then this should be simplified by using `std::any_of` instead I was asked to use std::find_if, and (spicey detail) referred to the KDevelop code for examples how to use it :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To:

D11183: Sonnet: don't impose the default client

mwolff added inline comments. INLINE COMMENTS > cullmann wrote in loader.cpp:103 > Isn't there a == lClients.constEnd() behind that does that? ah, then this should be simplified by using `std::any_of` instead REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To:

D11204: Support NTFS hidden files

rominf marked 8 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, dfaure Cc: kossebau, dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

D11183: Sonnet: don't impose the default client

cullmann added inline comments. INLINE COMMENTS > mwolff wrote in loader.cpp:103 > nope, that's wrong. find_if returns an iterator - in this case a Client* > probably that gets converted to bool? Isn't there a == lClients.constEnd() behind that does that? REPOSITORY R246 Sonnet REVISION

D11183: Sonnet: don't impose the default client

mwolff added inline comments. INLINE COMMENTS > loader.cpp:103 > +// if it does it will be an element of lClients. > +bool unknown = std::find_if(lClients.constBegin(), > lClients.constEnd(), [backend] (const Client *client) { > +return client->name() == backend;

D11183: Sonnet: don't impose the default client

rjvbb marked an inline comment as done. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

rjvbb set the repository for this revision to R246 Sonnet. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, michaelh, ngraham

D11183: Sonnet: don't impose the default client

rjvbb updated this revision to Diff 30617. rjvbb added a comment. Modified as requested. (Please double-check, it works AFAICT but it's the first time I use this construct.) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11183?vs=29244=30617 REVISION DETAIL

D11204: Support NTFS hidden files

kossebau added inline comments. INLINE COMMENTS > file_unix.cpp:40 > #include > +#include > #include This unconditional include sadly breaks the build at least on FreeBSD (see https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/console ) and other

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Mar 2018 09:09:08 + Build duration: 3 min 1 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Mar 2018 09:09:08 + Build duration: 2 min 48 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/33/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 09:09:08 + Build duration: 2 min 12 sec and counting JUnit Tests

D11709: Don't create dependency loop

This revision was automatically updated to reflect the committed changes. Closed by commit R290:0a26d53a0f86: Dont create dependency loop (authored by bshah). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11709?vs=30610=30611 REVISION DETAIL

D11709: Don't create dependency loop

mart accepted this revision. REPOSITORY R290 KPackage BRANCH fix-kpackag REVISION DETAIL https://phabricator.kde.org/D11709 To: bshah, romangg, mart Cc: #frameworks, michaelh, ngraham

D11709: Don't create dependency loop

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH fix-kpackag REVISION DETAIL https://phabricator.kde.org/D11709 To: bshah, romangg Cc: #frameworks, michaelh, ngraham

D11709: Don't create dependency loop

bshah created this revision. bshah added a reviewer: romangg. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY The code tried to depend on the generated .rcc file which was

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/ --- (Updated March 26, 2018, 9:47 a.m.) Status -- This change has been

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/35/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Mar 2018 07:06:52 + Build duration: 19 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 185 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/185/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Mar 2018 07:06:52 + Build duration: 18 min and counting JUnit Tests Name: (root)

D11705: Highlight selected items when showing parent folder from the open/save dialog

broulik added a comment. Good idea. How about folders? Perhaps we should use a different behavior for folders as you're imho more likely to want to open a folder in the file manager than look "where it is" INLINE COMMENTS > kdiroperator.cpp:666 > { > -new KRun(currUrl, parent); >

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 164 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 07:06:52 + Build duration: 4 min 10 sec and counting CONSOLE OUTPUT

D11204: Support NTFS hidden files

rominf closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

D11204: Support NTFS hidden files

rominf edited the summary of this revision. REPOSITORY R241 KIO BRANCH ntfs-hidden (branched from master) REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks,

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30589. smithjd added a comment. - Optimize and make the loop actually work. - Change check command description. - Review changes. - Fix a threading issue. - Fix check operation order. - Use a single StorageDevices object. REPOSITORY R293 Baloo