KDE CI: Frameworks kcompletion kf5-qt5 SUSEQt5.9 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kcompletion kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 21:47:26 + Build duration: 4 min 54 sec and counting JUnit Tests

KDE CI: Frameworks kcompletion kf5-qt5 SUSEQt5.9 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks kcompletion kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 12:00:10 + Build duration: 9 hr 47 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:35:55 + Build duration: 3 hr 51 min and counting JUnit Tests Name: (

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:36:56 + Build duration: 1 hr 17 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:36:38 + Build duration: 1 hr 14 min and counting JUnit Tests Name

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:36:44 + Build duration: 1 hr 11 min and counting JUnit Tests Name:

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:36:42 + Build duration: 1 hr 8 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:35:24 + Build duration: 1 hr 5 min and counting JUnit Tes

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/97/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:35:55 + Build duration: 1 hr 4 min and counting JUnit Tests Name: (root) Fa

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:36:53 + Build duration: 1 hr 2 min and counting

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:36:42 + Build duration: 56 min and counting JUnit Test

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/24/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:35:15 + Build duration: 56 min and counting JUnit Tests Nam

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:35:12 + Build duration: 53 min and counting JUnit Tests Name: (root

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:36:38 + Build duration: 48 min and counting JUnit Tests Na

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/26/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 17:34:49 + Build duration: 50 min and counting JUnit Tests N

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:36:38 + Build duration: 44 min and counting JUnit Tests Name: (

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 38 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:36:57 + Build duration: 42 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 154 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/154/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:36:53 + Build duration: 41 min and counting JUnit Te

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:36:44 + Build duration: 41 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:36:42 + Build duration: 35 min and counting JUnit Tests

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:36:23 + Build duration: 33 min and counting JUnit Tests Name: (roo

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:36:15 + Build duration: 31 min and counting JUnit Tests Na

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:36:29 + Build duration: 30 min and counting JUnit Tests Name: (

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/28/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:36:25 + Build duration: 30 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 249 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/249/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:35:55 + Build duration: 27 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.10/9/ Project: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 Date of build: Fri, 04 May 2018 17:35:04 + Build duration: 26 min and counting JUnit Tes

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/80/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:35:15 + Build duration: 20 min and counting JUnit Tests N

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/42/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:35:24 + Build duration: 19 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:35:24 + Build duration: 16 min and counting JUnit

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/33/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:35:12 + Build duration: 14 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:35:15 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/82/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 17:34:49 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:35:12 + Build duration: 10 min and counting JUnit Tests Name

D12511: optimization of KTextEditor::DocumentPrivate::views()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:90157a222b5e: optimization of KTextEditor::DocumentPrivate::views() (authored by jtamate). REPOSITORY R39 KTextEditor

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 17:34:49 + Build duration: 4 min 29 sec and counting JUnit

Re: QStandardPaths::GenericDataLocation on MacOS

I'll shuffle the bits in this mail a bit, in an attempt to get the discussion back to the main topic (or at least the thing that I intended to be the main topic): On Thu, 03 May 2018 23:11:56 +0200 René J.V. Bertin wrote: > On Thursday May 03 2018 21:57:03 Thomas Friedrichsmeier wrote: > > Ah, go

Re: QStandardPaths::GenericDataLocation on MacOS

On Thu, 03 May 2018 21:09:03 +0200 René J.V. Bertin wrote: > >On Fri, May 4, 2018 at 2:38 AM, Thomas Friedrichsmeier > > >> homebrew, craft). It is also about the fact that this installation > >> option causes problems, e.g. if users are to mix MacPorts and a > >> single-app-bundled KF5 app >

D12511: optimization of KTextEditor::DocumentPrivate::views()

mwolff accepted this revision. mwolff added a comment. OK, cool! That clearly shows that this patch _is_ valuable: Before we have ~6% CPU cycle cost, now it's down to 1.5% (inclusively). This is a significant reduction, so I'm all for it. But note once again the stark difference in these

D12511: optimization of KTextEditor::DocumentPrivate::views()

jtamate added a comment. In D12511#258212 , @mwolff wrote: > https://phabricator.kde.org/file/data/w4qogv4brtxlc5p5bnwr/PHID-FILE-q62giymcptudpl5m6bt3/kwrite_perf_after_25_dwarf_caller.png shows ~1.5% in notifyAboutRangeChange (inclusively). Is

D12511: optimization of KTextEditor::DocumentPrivate::views()

mwolff added a comment. `perf record -g` produces unusable data files, since it relies on the frame pointer which is usually not available. Use `perf record --call-graph dwarf` instead. https://phabricator.kde.org/file/data/w4qogv4brtxlc5p5bnwr/PHID-FILE-q62giymcptudpl5m6bt3/kwrite_perf_afte

D12511: optimization of KTextEditor::DocumentPrivate::views()

jtamate added a comment. In D12511#258193 , @mwolff wrote: > Actually, no. Ignore what I said. The pictures you are showing are pretty meaningless. Did you run perf with `--call-graph dwarf`? Better look at the flamegraph and search for the func

D12511: optimization of KTextEditor::DocumentPrivate::views()

mwolff added a comment. Actually, no. Ignore what I said. The pictures you are showing are pretty meaningless. Did you run perf with `--call-graph dwarf`? Better look at the flamegraph and search for the function you are interested in (Kate::TextBuffer::notifyAboutRangeChange) or use the Cal

D12511: optimization of KTextEditor::DocumentPrivate::views()

mwolff added a comment. But the hotspot screenshot clearly shows that you are spending time on optimizing things that are barely noticeable. You have optimized a function that consumes 0.3% of the CPU cycles. It now consumes only ~0.15%, at the cost of slightly higher memory consumption.

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/23/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 12:00:32 + Build duration: 11 min and counting JUnit Tests Nam

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 33623. jtamate edited the summary of this revision. jtamate added a comment. Add the new tests instead of replace. Use QTRY_COMPARE instead of custom loops. Reduce the number of files to 100. In my machine, the mime type of file.html is "applicatio

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/79/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 12:00:32 + Build duration: 8 min 14 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 12:00:32 + Build duration: 8 min 7 sec and counting JUnit Tes

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 11:59:35 + Build duration: 7 min 59 sec and counting JUnit Tests Nam

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 11:59:35 + Build duration: 2 min 31 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 11:59:35 + Build duration: 2 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 11:59:35 + Build duration: 1 min 32 sec and counting JUnit Tests

D12071: add a new ConstrainedSquare formfactor

kossebau added a comment. In D12071#243259 , @mart wrote: > suggests that is more about it being constrained both horizontally and vertically than being a square, which may not be a given (the actual name comes from an old enum value in Plasma 4

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 11:59:25 + Build duration: 1 min 49 sec and counting JUnit Tests Name:

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 11:59:25 + Build duration: 2 min 17 sec and counting JUnit Tests Nam

D12696: Use the new uds implementation

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY This new implementation is the fastest in the autotests. The replaceOrInsert in KFileItem::setName is due

D12016: [ktexteditor] much faster positionFromCursor

This revision was automatically updated to reflect the committed changes. Closed by commit R39:81996f55b1ab: [ktexteditor] much faster positionFromCursor (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12016?vs=31853&id=33615#toc REPOSITORY R39 KTextEditor CHANGE

D12511: optimization of KTextEditor::DocumentPrivate::views()

jtamate updated this revision to Diff 33613. jtamate edited the test plan for this revision. jtamate added a comment. Add and remove from the list. About the tools I use to profile: - I'm used to use slow machines, I have no problems running under valgrind. - When I can run a progra

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 248 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/248/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 09:03:59 + Build duration: 15 min and counting JUnit Tests Name: (root) Fai

D12016: [ktexteditor] much faster positionFromCursor

cullmann added a comment. If the stuff still works for you and is fast now, I am still for merging that. If somebody has time to do a even nicer integration, a new request can be done afterwards. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate

D12016: [ktexteditor] much faster positionFromCursor

jtamate added a comment. In D12016#257862 , @cullmann wrote: > Actually, given the functionality is only used there, if that code is in the view or in that helper class makes no real difference, or? I've tried to extend KateViewInternal i

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/96/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 May 2018 09:03:59 + Build duration: 6 min 20 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 04 May 2018 09:03:59 + Build duration: 5 min 15 sec and counting JUnit Tests Name:

D12659: two new UDS structures

This revision was automatically updated to reflect the committed changes. Closed by commit R241:01b2e536aeb3: two new UDS structures (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12659?vs=33607&id=33608 REVISION DETAIL https://phabricato

D12511: optimization of KTextEditor::DocumentPrivate::views()

mwolff added a comment. Oh and again: please start using perf/hotspot instead of callgrind. Really, the performance numbers you get from callgrind are just *instructions*! It doesn't mean "65% of CPU". It means 65% of the instructions. You are doing such good work with profiling and opti

D12511: optimization of KTextEditor::DocumentPrivate::views()

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. lgtm in general, but codewise can be improved INLINE COMMENTS > katedocument.cpp:2835 > m_views.insert(view, static_cast(view)); > +m_viewsCache = m_views.keys(); > ju

D12659: two new UDS structures

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12659 To: jtamate, dfaure, #frameworks Cc: bruns, michaelh

D12659: two new UDS structures

jtamate updated this revision to Diff 33607. jtamate added a comment. Removed some methods that are not used in the benchmarks. Added the asserts to check the type of the data at the beginning of every insert and replaceOrInsert. FYI: Checking the new implementation in live, so far only