D13398: [KFileItem] Check most local URL for whether it's shared

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: gregormi, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `desktop:/` KIO rewrites the URL but it is still a local file which could be 
shared.

TEST PLAN
  Noticed that when I did D13397 
  
  - Shared a file on the desktop, emblem showed up (didn't refresh on its own 
but that is a separate bug)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13398

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, gregormi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#274965 , @brauch wrote:
  
  > To submit the change with your name on it, I'd need a full name and email 
address, can you provide that? Thanks!
  
  
  Name: Shubham
  Mail: aryan100jan...@gmail.com

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/37/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 07 Jun 2018 03:43:22 +
 Build duration:
8 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)22%
(487/2194)23%
(300/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)76%
(249/326)57%
(147/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/61/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 07 Jun 2018 03:43:22 +
 Build duration:
5 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(458/2194)21%
(270/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)59%
(111/188)src100%
(8/8)100%
(8/8)69%
(226/326)48%
(123/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 173 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/173/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 07 Jun 2018 03:43:21 +
 Build duration:
3 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3560/13477)19%
(1978/10667)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/473)0%
(0/265)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3535)28%
(826/2957)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/1072)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/24/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 07 Jun 2018 03:43:21 +
 Build duration:
2 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D13395: Pony: fix single quote escape and a possible infinite loop with #

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-pony

REVISION DETAIL
  https://phabricator.kde.org/D13395

AFFECTED FILES
  autotests/folding/highlight.pony.fold
  autotests/html/highlight.pony.html
  autotests/input/highlight.pony
  autotests/reference/highlight.pony.ref
  data/syntax/pony.xml

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 35730.
smithjd added a comment.


  Split-up scheduler overhaul patchset.
  
  - The power state signal should only be emitted when the power state changes.
  - Re-write the the file index scheduler.
  - Update the balooctl tool with the changed suspend/resume behaviour.
  - Make use of the scheduler halt method.
  - Check for unindexed files when folder watches are installed.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=35199=35730

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/mainhub.cpp
  src/file/powerstatemonitor.cpp
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen edited the summary of this revision.
jpoelen added a reviewer: dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  - new keywords, attributes and standard macros
  - hexadecimal floatting point (c++17)
  - highlight UDL (standard and user)
  - fix some syntax error (`operator""_x`, `#elif 0`, ...)
  - highlight the content of #define to the color of c++

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.y.fold
  autotests/folding/preprocessor-bug363280.cpp.fold
  autotests/html/folding.cpp.html
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/folding.cpp.ref
  autotests/reference/highlight.cpp.ref
  data/syntax/gcc.xml
  data/syntax/isocpp.xml

To: jpoelen
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  If I understand your summary correctly, your patch changes different things. 
While these are clearly related, can you try to separate the changes?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

Re: KDE Frameworks 5.47.0

[Matthieu Gallien]

On mercredi 6 juin 2018 23:10:52 CEST Albert Astals Cid wrote:
> El dimecres, 6 de juny de 2018, a les 12:55:15 CEST, Jonathan Riddell va
> 
> escriure:
> > On Sat, Jun 02, 2018 at 09:57:08PM +0200, David Faure wrote:
> > > Dear packagers,
> > > 
> > > KDE Frameworks 5.47.0 has been uploaded to the usual place.
> > 
> > KFileMetaData continues not to compile
> 
> That was already discussed and it's because you're using an old ffmpeg,
> right?
> 
> Matthieu did you not commit that patch to make it clear a newer version is
> needed?

Yes but I failed to understand that the FindFFmpeg.cmake was not able to check 
the version. I have now open https://phabricator.kde.org/D13302 that just uses 
the new API if one has a newer FFmpeg or uses the old API.
This should definitely solve the problem.

I am sorry for not having understood that was the only feasible solution.

> Cheers,
>   Albert
> 
> > Jonathan

Best regards

--
Matthieu Gallien

Re: KDE Frameworks 5.47.0

[Albert Astals Cid]

El dimecres, 6 de juny de 2018, a les 12:55:15 CEST, Jonathan Riddell va 
escriure:
> On Sat, Jun 02, 2018 at 09:57:08PM +0200, David Faure wrote:
> > Dear packagers,
> > 
> > KDE Frameworks 5.47.0 has been uploaded to the usual place.
> 
> KFileMetaData continues not to compile

That was already discussed and it's because you're using an old ffmpeg, right?

Matthieu did you not commit that patch to make it clear a newer version is 
needed?

Cheers,
  Albert

> 
> Jonathan

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  To submit the change with your name on it, I'd need a full name and email 
address, can you provide that? Thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D12992: New elisa icon

[Matthieu Gallien]

mgallien added a comment.


  In D12992#269849 , @abetts wrote:
  
  > In D12992#269803 , @lshoravi 
wrote:
  >
  > > @abetts Yes, I've been concepting a little on different ideas but not 
really coming anywhere I feel would fit in.
  > >
  > > Looks great!
  > >
  > > As for the background, when I think of soundwaves I think of something 
that would be produced by a visualizer, or a sine wave.
  > >
  > > Did you make the letters yourself or is it a font? I'm asking just in 
case the font is licensed.
  >
  >
  > The letters are from a font from Google Fonts. We should be OK to use it. 
We can also modify a bit if you want. Although I feel it looks good.
  
  
  Your proposal is looking great and it should be easily recognizable. I really 
like it. It also looks quite modern.
  Sorry for the delay for my answer. Thanks a lot for your help.
  
  >> Could you using blue and teal for the accent colours? I'm thinking that's 
what Elisa uses by default.
  > 
  > I sure can! Can you give me a couple of reference colors so that I can 
start from there? I mean a teal and blue HEX numbers.
  
  The blue used by Elisa is the following: #3daee9 .
  The grey used by Elisa is the following: #c4c5c5 .
  
  > 
  > 
  >> (Speaking of that, I can't start Elisa. No error message in terminal or 
anything, it just doesnt start.)
  
  Do you have the possibility to test it from the flathub flatpak repository ? 
At least, the 0.1.1 bug fix version is there. I am not so sure about the status 
of the flatpak nightly builds hosted by KDE. In case, you would need them, we 
should ping people from the flatpak team.
  You can also try to send me any log you may have to try to understand what 
happen.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: abetts, paullesur, januz, astippich, mgallien, alex-l, andreask, 
kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, 
michaelh, ngraham, bruns, kmf

D13216: Overhaul the file index scheduler.

[Matthieu Gallien]

mgallien added a comment.


  Sounds good to me. I will try to do a proper review as soon as I can. Sorry 
for the delay.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13302: check for needed version of libavcode, libavformat and libavutil

[Matthieu Gallien]

mgallien updated this revision to Diff 35712.
mgallien added a comment.


  - checks if FFmpeg provides the new API and use it only in this case
  
  extend the existing configure header to allow to compile both versions of the 
code in the FFmpeg extractor
  
  in case the new API exists, we prefer it and we also support compilation with 
the old one
  
  kelpt the code checking for the new versions even we do not know how to 
properly check for it (pkg-config is only used to get an hint before searching 
headers and libraries and only on platforms with pkg-config)

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13302?vs=35457=35712

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13302

AFFECTED FILES
  CMakeLists.txt
  cmake/FindFFmpeg.cmake
  src/config-kfilemetadata.h.in
  src/extractors/CMakeLists.txt
  src/extractors/ffmpegextractor.cpp

To: mgallien, romangg, adridg
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13386: haskell.xml: remove types from "prelude function" section

[Li-yao Xia]

xialiyao created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
xialiyao requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haskell-remove-nonsense

REVISION DETAIL
  https://phabricator.kde.org/D13386

AFFECTED FILES
  autotests/folding/highlight.hs.fold
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  autotests/input/highlight.hs
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.lhs.ref
  data/syntax/haskell.xml

To: xialiyao
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag updated this revision to Diff 35705.
zzag added a comment.


  Move `maskFrame->cachedBackground = QPixmap();` to the maskFrame->refcount() 
== 1
  branch. Do we really need this assignment?

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13384?vs=35704=35705

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13384

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag updated this revision to Diff 35704.
zzag added a comment.


  Do not invalidate looked up frames.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13384?vs=35699=35704

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13384

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13380: haskell.xml: don't highlight Prelude data constructors differently from others

[Li-yao Xia]

xialiyao updated this revision to Diff 35703.
xialiyao added a comment.


  Apply similar change to class names

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13380?vs=35684=35703

BRANCH
  haskell-data-prelude

REVISION DETAIL
  https://phabricator.kde.org/D13380

AFFECTED FILES
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  data/syntax/haskell.xml

To: xialiyao
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag added a comment.


  Sorry for the nasty diff. Caching is hard. :(

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: Plasma, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  It might happen that the maskFrame is shared by several instances of
  FrameSvg. In that case, do not wreck maskFrame and instead act as
  follows:
  
  - try to lookup shared frames
  - if there is matching frame, use it
  - otherwise create a new one

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13384

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/23/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 06 Jun 2018 17:56:57 +
 Build duration:
4 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 172 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/172/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 06 Jun 2018 17:56:07 +
 Build duration:
3 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13477)19%
(1977/10667)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/473)0%
(0/265)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3535)28%
(826/2957)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/1072)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/22/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 06 Jun 2018 17:52:02 +
 Build duration:
4 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 171 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/171/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 06 Jun 2018 17:52:02 +
 Build duration:
4 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13477)19%
(1977/10667)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/473)0%
(0/265)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3535)28%
(826/2957)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/1072)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a46cd14553c2: FrameSvg: Draw corners only if both borders 
in both directions are enabled (authored by zzag).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13218?vs=35198=35697

REVISION DETAIL
  https://phabricator.kde.org/D13218

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks, mart
Cc: mart, kde-frameworks-devel, ragreen, Pitel, michaelh, ZrenBot, ngraham, 
bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dce258bee3da: FrameSvg: Recache maskFrame if 
enabledBorders has been changed (authored by zzag).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13215?vs=35542=35698

REVISION DETAIL
  https://phabricator.kde.org/D13215

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks, mart
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Vlad Zagorodniy]

zzag added a comment.


  In D13215#274782 , @mart wrote:
  
  > it has nothing to do with compositing, but it *should* fix the non 
composite mask never the less, as it was coming from a misrendering  of the 
framesvg
  
  
  Could someone please show me what's wrong with Oxygen corners? (I still don't 
know what's wrong with them, sorry)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-framesvg-alphamask

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks, mart
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

[Vlad Zagorodniy]

zzag added a comment.


  In D13218#274785 , @mart wrote:
  
  > how does this relates with D13215 ?
  
  
  If maskFrame isn't recached after enabledBorders has been changed, I would 
expect the "After" picture rather the "Before" picture because the bottom part 
isn't enabled. (sorry for broken English)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-paintcorner

REVISION DETAIL
  https://phabricator.kde.org/D13218

To: zzag, #plasma, #frameworks, mart
Cc: mart, kde-frameworks-devel, ragreen, Pitel, michaelh, ZrenBot, ngraham, 
bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-paintcorner

REVISION DETAIL
  https://phabricator.kde.org/D13218

To: zzag, #plasma, #frameworks, mart
Cc: mart, kde-frameworks-devel, ragreen, Pitel, michaelh, ZrenBot, ngraham, 
bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

[Marco Martin]

mart added a project: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13218

To: zzag, #plasma, #frameworks
Cc: mart, kde-frameworks-devel, ragreen, Pitel, michaelh, ZrenBot, ngraham, 
bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

[Marco Martin]

mart added a comment.


  how does this relates with D13215 ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13218

To: zzag, #plasma, #frameworks
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-framesvg-alphamask

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks, mart
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Marco Martin]

mart added a comment.


  In D13215#270880 , @zzag wrote:
  
  > In D13215#270878 , @broulik 
wrote:
  >
  > > Wow. I wasted hours in FrameSvg trying to find this. Does this also fix 
the panel mask in non-composited mode, e.g. round corners with Oxygen? (Quickly 
browsing the bug numbers suggests it does \o/)
  >
  >
  > It has nothing to do with compositing. ;-)
  >
  > I noticed when I was working on this diff that paintCorner is not working 
_really_ correct. I'll check it with Oxygen.
  
  
  it has nothing to do with compositing, but it *should* fix the non composite 
mask never the less, as it was coming from a misrendering  of the framesvg

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13034: Add mechanism to notify other clients of config changes over DBus

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> kconfigwatcher.cpp:61
> +
> +for(const QString : watchedPaths) {
> +QDBusConnection::sessionBus().connect(QString(),

I think you forgot qAsConst. ;-)

  for (const QString  : qAsConst(watchedPaths)) {

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13034

To: davidedmundson, broulik
Cc: broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Andres Betts]

abetts added a comment.


  What can we do to help this patch move forward @zzag ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Vlad Zagorodniy]

zzag added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Vlad Zagorodniy]

zzag retitled this revision from "FrameSVG: Recache maskFrame if enabledBorders 
has been changed" to "FrameSvg: Recache maskFrame if enabledBorders has been 
changed".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

[Vlad Zagorodniy]

zzag retitled this revision from "Draw FrameSVG corners only if both borders in 
both directions are enabled" to "FrameSvg: Draw corners only if both borders in 
both directions are enabled".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13218

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

[Vlad Zagorodniy]

zzag added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13218

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  Yes that looks better, I'll submit it later today.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13380: haskell.xml: don't highlight Prelude data constructors differently from others

[Li-yao Xia]

xialiyao created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
xialiyao requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haskell-data-prelude

REVISION DETAIL
  https://phabricator.kde.org/D13380

AFFECTED FILES
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  data/syntax/haskell.xml

To: xialiyao
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham updated this revision to Diff 35683.
shubham added a comment.


  I believe this is the final patch.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13365?vs=35643=35683

REVISION DETAIL
  https://phabricator.kde.org/D13365

AFFECTED FILES
  src/render/katerenderer.cpp

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13358: Add new class that is a model of numbers between two values

[David Edmundson]

davidedmundson updated this revision to Diff 35681.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  Most review comments
  
  As for the locale enum, I'm not sure.
  
  I'm working on a QML module and I'm trying to resolve any QML specific issues 
there rather 
  than complicate these classes. I'll get that onto phab and we can see what 
ends up being cleanest overall.

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13358?vs=35599=35681

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13358

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/knumbermodeltest.cpp
  src/CMakeLists.txt
  src/knumbermodel.cpp
  src/knumbermodel.h

To: davidedmundson
Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns

D13034: Add mechanism to notify other clients of config changes over DBus

[David Edmundson]

davidedmundson marked 2 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in kconfigwatcher.cpp:82
> no, `parts` is `const`

zzag was right then I changed it, but I hadn't clicked the "done" checkbox 
after fixing.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13034

To: davidedmundson, broulik
Cc: broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13034: Add mechanism to notify other clients of config changes over DBus

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> zzag wrote in kconfigwatcher.cpp:82
> Won't this detach?

no, `parts` is `const`

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13034

To: davidedmundson, broulik
Cc: broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13358: Add new class that is a model of numbers between two values

[David Edmundson]

davidedmundson marked 11 inline comments as done.
davidedmundson added a comment.


  > In all the documentation blocks you miss the argument and return value 
documentation.
  
  Are there any instances where that would provide any added value?

INLINE COMMENTS

> broulik wrote in knumbermodeltest.cpp:26
> `QVariant(QStringLiteral("3"))`?

Autotest has cast from ascii turned on as we don't care about minor performance 
here, it ends up being the same code.

> davidedmundson wrote in knumbermodel.cpp:121
> right, the max should be 0.
> 
> The +1 is for the first entry
> 
> i.e 
> min=5 max=5  = 1 starting point
> min=5 max=7  = 1 starting poing + 2 complete steps  == 3 rows

Edit, remembered why I did this

surprisingly std::floor(double) returns a double.

so I can either leave as-is with the implicit cast of an int , or use qFloor.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D13358

To: davidedmundson
Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  Thank you Brauch for your quick reply.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  Click "download raw diff" at the top-right of the page. This is the diff you 
uploaded. This is not the change we want to apply when merging this review 
request; it only contains the changes you did from your earlier version to the 
latest one, not the set of changes which needs to be applied to the repository. 
If you try to apply this patch to ktexteditor master, you will see that it 
fails.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  
  
  In D13365#274589 , @brauch wrote:
  
  > The change is good now but you screwed up the patch: you need to submit the 
full set of changes you want to do as a patch, not only the last iteration. Can 
you fix that? Thank you!
  
  
  Brauch,I didnt get you, can  you please elaborate?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

Re: KDE Frameworks 5.47.0

[Jonathan Riddell]

On Sat, Jun 02, 2018 at 09:57:08PM +0200, David Faure wrote:
> Dear packagers,
> 
> KDE Frameworks 5.47.0 has been uploaded to the usual place.

KFileMetaData continues not to compile

Jonathan

D13358: Add new class that is a model of numbers between two values

[Kai Uwe Broulik]

broulik added a comment.


  Just saw I forgot to submit those comments yesterday

INLINE COMMENTS

> knumbermodeltest.cpp:26
> +QCOMPARE(m.rowCount(), 3);
> +QCOMPARE(m.data(m.index(0, 0), Qt::DisplayRole), QVariant("3"));
> +QCOMPARE(m.data(m.index(1, 0), Qt::DisplayRole), QVariant("4"));

`QVariant(QStringLiteral("3"))`?

> knumbermodeltest.cpp:57
> +QCOMPARE(m.rowCount(), 1);
> +QCOMPARE(m.data(m.index(0, 0), Qt::DisplayRole), QVariant("1,000"));
> +

This probably fails in non-English locale?

> knumbermodel.cpp:103
> +}
> +dataChanged(index(0, 0, QModelIndex()), index(rowCount(), 0, 
> QModelIndex()));
> +emit formattingOptionsChanged();

Only `DisplayRole` changes

> knumbermodel.cpp:117
> +
> +int KNumberModel::rowCount(const QModelIndex ) const {
> +if (index.parent().isValid()) {

Coding style, new line

> knumbermodel.cpp:140
> +{
> +QHash roleNames;
> +roleNames[Display] = QByteArrayLiteral("display");

return QHash{
  {DisplayRole, QByteArrayLiteral("display")
  ...

> knumbermodel.h:2
> +/*
> + * Copyright (C) 2018 David Edmundson
> + *

Missing email

> knumbermodel.h:37
> + * Value, the actual value as a number
> + */
> +class KITEMMODELS_EXPORT KNumberModel: public QAbstractListModel

`@since`

> knumbermodel.h:38
> + */
> +class KITEMMODELS_EXPORT KNumberModel: public QAbstractListModel
> +{

Coding style, space before colon

> knumbermodel.h:41
> +Q_OBJECT
> +Q_PROPERTY (qreal min READ min WRITE setMin NOTIFY minChanged)
> +Q_PROPERTY (qreal max READ max WRITE setMax NOTIFY maxChanged)

Should those be `minimumValue`, `maximumValue`, `stepSize` to match Qt's APIs?

> knumbermodel.h:44
> +Q_PROPERTY (qreal step READ step WRITE setStep NOTIFY stepChanged)
> +Q_PROPERTY (QLocale::NumberOptions formattingOptions READ 
> formattingOptions WRITE setFormattingOptions NOTIFY formattingOptionsChanged)
> +

Does this work, given the enum is defined elsewhere? I had huge trouble when I 
did time formatting in `KFormat`'s QML proxy

> knumbermodel.h:48
> +KNumberModel(QObject *parent = nullptr);
> +~KNumberModel();
> +

`override`

> knumbermodel.h:51
> +enum Roles {
> +Display = Qt::DisplayRole,
> +Value = Qt::UserRole

Name those `...Role` since it's not an `enum class`?

> knumbermodel.h:93
> +
> +int rowCount(const QModelIndex =QModelIndex()) const override;
> +QVariant data(const QModelIndex , int role) const  override;

Coding style

> knumbermodel.h:94
> +int rowCount(const QModelIndex =QModelIndex()) const override;
> +QVariant data(const QModelIndex , int role) const  override;
> +QHash roleNames() const override;

`int role = Qt::DisplayRole`?

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D13358

To: davidedmundson
Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  The change is good now but you screwed up the patch: you need to submit the 
full set of changes you want to do as a patch, not only the last iteration. Can 
you fix that? Thank you!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#274460 , @cullmann wrote:
  
  > Yep, looks nice!
  
  
  Thank you for accepting the patch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13377: Fixup @since for skip switcher API

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  Not released yet.

TEST PLAN
  No testing performed at all.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13377

AFFECTED FILES
  src/client/plasmashell.h
  src/client/plasmawindowmodel.h
  src/server/plasmashell_interface.h

To: fvogt, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#274453 , @brauch wrote:
  
  > Yep, with that, it looks good to me. Do you have commit access?
  
  
  Thank you for committing it on my behalf

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:20f7137145f6: Support Icon Scale from Icon naming 
specification 0.13 (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6313?vs=35318=35667#toc

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=35318=35667

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/23/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 06 Jun 2018 07:16:05 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24108/28752)52%
(11787/22728)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11227/11509)49%
(7707/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1783/2752)src.server97%
(111/115)97%
(111/115)86%
(6834/7970)64%
(2077/3252)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/51/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 06 Jun 2018 07:16:05 +
 Build duration:
6 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24106/28751)52%
(11787/22728)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11225/11508)49%
(7707/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1783/2752)src.server97%
(111/115)97%
(111/115)86%
(6834/7970)64%
(2077/3252)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/13/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 06 Jun 2018 07:16:05 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 14 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testTextInputFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

D13377: Fixup @since for skip switcher API

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:46f333a06508: Fixup @since for skip switcher API 
(authored by fvogt).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13377?vs=35663=35664

REVISION DETAIL
  https://phabricator.kde.org/D13377

AFFECTED FILES
  src/client/plasmashell.h
  src/client/plasmawindowmodel.h
  src/server/plasmashell_interface.h

To: fvogt, #plasma, stikonas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13377: Fixup @since for skip switcher API

[Andrius Štikonas]

stikonas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13377

To: fvogt, #plasma, stikonas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns