KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 55 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/55/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sun, 15 Jul 2018 03:18:38 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/80/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 03:18:11 + Build duration: 19 min and counting JUnit Tests Name: (root

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Thanks for uploading this, that looks fine to me! REPOSITORY R244 KCoreAddons BRANCH msvc_fix REVISION DETAIL https://phabricator.kde.org/D14122 To: bruns, #frameworks, kosseb

D14123: Add `drive-optical` icon

ngraham added reviewers: Breeze, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14123 To: ngraham, broulik, andreask, #breeze, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14123: Add `drive-optical` icon

ngraham created this revision. ngraham added reviewers: broulik, andreask. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY It's just a symlink to `media-optical` which

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/78/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 15 Jul 2018 03:18:38 + Build duration: 5 min 23 sec and counting JUnit Tests Nam

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

bruns added a dependency: D14121: KFormat: Add unit tests for mili/micro SI prefixes. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14122 To: bruns, #frameworks, kossebau, bcooksley Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14121: KFormat: Add unit tests for mili/micro SI prefixes

bruns added a dependent revision: D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14121 To: bruns, #frameworks, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a dependent revision: D14121: KFormat: Add unit tests for mili/micro SI prefixes. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D14121: KFormat: Add unit tests for mili/micro SI prefixes

bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond bytes and seconds. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14121 To: bruns, #frameworks, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

bruns created this revision. bruns added reviewers: Frameworks, kossebau, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY MSVC is unable to parse UTF-8 sequen

D14121: KFormat: Add unit tests for mili/micro SI prefixes

bruns created this revision. bruns added reviewers: Frameworks, kossebau. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Add test cases for KFormat::formatValue(...) wi

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. This outputs 'µ' twice, so QChar(0xB5) should be equivalent: qWarning() << QString(QChar(0xB5)) << QString(QChar(u'µ')); REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau, k

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. You can add #windows to a review, however there still needs to be a degree of responsibility by those who are actually making commits to projects (especially in the case of #Frameworks

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. Is there some tag which can be used to pull the people in who want to support that Closed Source Microsoft platform in such cases? I wasted some time of my FLOSS life meanwhile and found https://developercommunity.visualstudio.com/content/problem/198547/error-c2

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. Unfortunately we cannot leave it in a broken condition. Could we try encoding it differently perhaps? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau, kde-frameworks-devel

D14118: Improve "Remove this [widget]" text

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14118 To: ngraham, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adds the word "widget" onto the end of

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. In D13583#292049 , @bcooksley wrote: > Sorry, but MSVC doesn't like this. > Please see https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/ MSVC seems to be broken, i

D9394: Show "Search wrapped" message in center of view for better visibility

ngraham added a comment. Retroactive +1 on the positioning and wording, but I would have stayed with an Informational (blue) KMessageWidget instead of making it Positive (and hence, green). Eh, not a huge deal. Shoulda piped up sooner! REPOSITORY R39 KTextEditor REVISION DETAIL https://

D13394: C++: update for c++20 and fix some syntax errors

jpoelen added a comment. Thank you, but I already made the request and it was accepted last night. I will do the next push :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: kwrite-devel, cullmann, kde-frameworks

D7245: Improve reStructuredText highlighting

cullmann added a comment. If you are happy with the current state, I can add some auto-test for you and push this. REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D10587: Restore KTextEditor Document Dbus bindings

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. I still don't agree with having that just for the use-case of "auto-s

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/29/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 20:09:38 + Build duration: 5 min 49 sec and counting JUnit Te

D9219: WIP: Extend Scripting API

cullmann added a comment. Hi, I appreciate the attention on the test, but as you see in https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/51/ they work again and the breakage was introduced (by me) in https://phabricator.kde.org/D13394 Cross-module bre

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/51/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sat, 14 Jul 2018 20:06:14 + Build duration: 6 min 35 sec and counting JUnit Tests

D9219: WIP: Extend Scripting API

bcooksley added a comment. This change introduced changes which broke tests that previously passed. Please see https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/48/testReport/(root)/TestSuite/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. Sorry, but MSVC doesn't like this. Please see https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich C

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/50/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sat, 14 Jul 2018 17:40:41 + Build duration: 2 hr 25 min and counting CONSOLE OUTPUT

D12295: Supporting nested brackets for Kate autobrackets

cullmann added a comment. I like the idea. For the patch: I think one should check with isEmpty() if the thing is empty, instead of the size() > 0 things, thats more clear. And is there no m_currentAutobraceClosingChar clear missing somewhere? e.g. don't go this two stack out of sync

D12295: Supporting nested brackets for Kate autobrackets

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: sraizada, #ktexteditor, #kate, cullmann, dhaumann Cc: ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, micha

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 94 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/94/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 18:29:01 + Build duration: 6 min 34 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/28/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 18:29:01 + Build duration: 1 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/93/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 17:42:27 + Build duration: 11 min and counting JUnit Tests N

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/27/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 17:40:41 + Build duration: 6 min 17 sec and counting JUnit T

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/92/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 17:27:01 + Build duration: 15 min and counting JUnit Tests N

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/49/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sat, 14 Jul 2018 17:27:01 + Build duration: 7 min 22 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/26/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 17:27:01 + Build duration: 6 min 48 sec and counting JUnit T

D12271: Don't remove trailing whitespace from cursor line

cullmann requested changes to this revision. cullmann added a comment. > I agree that the current state is ok and we arrived there after X iterations. I can agree that it might be bad for people with the habit to save each 5 seconds, but actually, given we have swap files for crash recovery,

D9394: Show "Search wrapped" message in center of view for better visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R39:cc8b22089c4d: Show "Search wrapped" message in center of view for better visibility (authored by dhaumann, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phab

D9394: Show "Search wrapped" message in center of view for better visibility

cullmann added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. I tried it, it is more obvious, if that is perfect, I don't know. I will push that now, before it rots ;=) (like other requests). And if the outcry is

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/25/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 17:16:41 + Build duration: 8 min 27 sec and counting JUnit T

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/48/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sat, 14 Jul 2018 17:16:41 + Build duration: 6 min 57 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 91 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/91/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 17:16:41 + Build duration: 6 min 51 sec and counting JUnit Tests

D9219: WIP: Extend Scripting API

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c2580c5b0f22: Extend Scripting API (authored by dhaumann, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9219?vs=23543&id=37759 REVISION

D13394: C++: update for c++20 and fix some syntax errors

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a2343cae2bb5: C++: update for c++20 and fix some syntax errors (authored by jpoelen, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D13394: C++: update for c++20 and fix some syntax errors

cullmann added a comment. Restricted Application added a project: Kate. Restricted Application added a subscriber: kwrite-devel. To get this in, I will push it for you. If you need some reason for a developer account, you can just link this request. REPOSITORY R216 Syntax Highlighting BR

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/24/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 16:34:16 + Build duration: 8 min 37 sec and counting JUnit T

D13747: Fuzzy filename search for Baloo

bruns added a comment. I think this design has several problems: 1. adding or renaming documents becomes very write heavy - consider adding e.g. foobar.png - this will add 7 bigrams. Each bigram has an associated list of matching documents. The document list is sorted. This means we

D14111: Install MIME type definition for text/x-rst ourselves for now

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. In D14111#291934 , @kossebau wrote: > In D14111#291933 , @pino wrote: > > > NACK. > > M

D14111: Install MIME type definition for text/x-rst ourselves for now

kossebau added a comment. In D14111#291933 , @pino wrote: > NACK. > Make sure that the request for shared-mime-info (https://bugs.freedesktop.org/show_bug.cgi?id=107227) is accepted, and that is enough. Even if the request is accepted

D14111: Install MIME type definition for text/x-rst ourselves for now

pino added a comment. NACK. Make sure that the request for shared-mime-info (https://bugs.freedesktop.org/show_bug.cgi?id=107227) is accepted, and that is enough. There is enough stuff in `kde5.xml` already, even shipped in shared-mime-info, so adding more is not a good idea. REPOSITORY

D14111: Install MIME type definition for text/x-rst ourselves for now

kossebau created this revision. kossebau added reviewers: dfaure, pino. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY As ECM docs are written in reStructuredText fo

D12233: Avoid manipulation of lists with quadratic complexity

bruns added a comment. In D12233#283521 , @bruns wrote: > In D12233#279389 , @bruns wrote: > > > Still waiting for a final review ... > > > Hello! Anyone at home? Another 2 weeks ... RE

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/93/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 14:24:25 + Build duration: 8 min 3 sec and counting JUnit Tests

D13814: Speedup sort

bruns added a comment. In D13814#291913 , @jtamate wrote: > Also amended the commit message. thanks, but unfortunately this won't change the git commit message :-( REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/16/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 14:24:25 + Build duration: 3 min 37 sec and counting JUnit T

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/38/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 14 Jul 2018 14:24:25 + Build duration: 3 min 22 sec and counting JUnit Tests

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. In D13583#291895 , @kossebau wrote: > @bruns Please update all the "@since" to 5.49, as this will be only part of the next KF version now. Sorry, updated and pushed REPOSITORY R244 KCoreAddons REVISION DETAIL

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 39 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/39/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 14 Jul 2018 14:24:26 + Build duration: 1 min 17 sec and counting

D14110: KFormat: correct @since tag for new KFormat::formatValue

This revision was automatically updated to reflect the committed changes. Closed by commit R244:0a81ae65b760: KFormat: correct @since tag for new KFormat::formatValue (authored by bruns). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14110?vs=37747&id=377

D13814: Speedup sort

jtamate added a comment. Also amended the commit message. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andr

D14110: KFormat: correct @since tag for new KFormat::formatValue

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14110 To: bruns, #frameworks, kossebau Cc: kde-frameworks-devel, michaelh, ngraham,

D13584: KFormat: Replace byte specific implementation with generic one

bruns updated this revision to Diff 37748. bruns added a comment. Rebase REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13584?vs=36259&id=37748 BRANCH D13584 REVISION DETAIL https://phabricator.kde.org/D13584 AFFECTED FILES src/lib/util/kformat

D13814: Speedup sort

jtamate edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuel

D14110: KFormat: correct @since tag for new KFormat::formatValue

bruns created this revision. bruns added reviewers: Frameworks, kossebau. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The change landed immediately after the KF 5.48

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/38/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 14 Jul 2018 14:06:30 + Build duration: 42 sec and counting CONSOL

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/92/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 13:58:08 + Build duration: 6 min 53 sec and counting JUnit Tests

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. @bruns Please update all the "@since" to 5.49, as this will be only part of the next KF version now. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: kossebau, kde-frameworks-devel, astippich,

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/37/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 14 Jul 2018 14:00:09 + Build duration: 3 min 5 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/36/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 14 Jul 2018 13:51:20 + Build duration: 8 min 46 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/15/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 13:54:49 + Build duration: 4 min 1 sec and counting JUnit Te

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/91/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 13:51:20 + Build duration: 6 min 46 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 14 Jul 2018 13:51:20 + Build duration: 3 min 26 sec and counting JUnit T

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

This revision was automatically updated to reflect the committed changes. Closed by commit R244:45dee45c8922: KFormat: Allow usage of quantities beyond bytes and seconds (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13583?vs=36735&id=37746#toc REPOSITORY R244 KCor

D13571: Correct KFormat::formatBytes examples

This revision was automatically updated to reflect the committed changes. Closed by commit R244:59dc873bcbe1: Correct KFormat::formatBytes examples (authored by bruns). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13571?vs=36731&id=37744 REVISION DETAIL

D13814: Speedup sort

bruns added a comment. In D13814#291757 , @jtamate wrote: > In D13814#291644 , @bruns wrote: > > > Any reason why you have pushed this with an obviously wrong commit message? > > > Because I th

D13316: manually set format in jpeg thumbnail creator

miklosm added a comment. In D13316#288653 , @elvisangelaccio wrote: > I guess this change makes sense (given that we are in the jpeg plugin), but what about `QImageReader::decideFormatFromContent()` ? The file type was already detected t

D13808: Fix KMainWindow saving incorrect widget settings

dfaure added a comment. Hmm, good point, I thought this was in already :( REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: arojas, marten, asturmlechner, w

D13829: Lua: fix multi-line string

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7d435174e96d: Lua: fix multi-line string (authored by jpoelen, committed by dhaumann). Restricted Application added a project: Kate. Restricted Application added a subscriber: kwrite-devel. REPOSITORY

D14020: RPM Spec: add MIME type

This revision was automatically updated to reflect the committed changes. Closed by commit R216:79df3675d4fc: RPM Spec: add MIME type (authored by nibags, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14020?vs=37491&id=3773

D14062: Python: fix escapes in quoted-comments

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2627d3e421f6: Python: fix escapes in quoted-comments (authored by nibags, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14062?v

D13808: Fix KMainWindow saving incorrect widget settings

arojas added a comment. This has been approved for two weeks and fixes a major issue... could the fix be pushed and then keep working on the auto test later? It already missed 5.48 REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. In D11176#291740 , @bcooksley wrote: > This change has broken the build of all projects that make use of pmap resources on Windows, as the Python path at build time is not necessarily the path at install time (and i

D14062: Python: fix escapes in quoted-comments

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks! Looks good to me. REPOSITORY R216 Syntax Highlighting BRANCH fix-python REVISION DETAIL https://phabricator.kde.org/D14062 To: nibags, #framework_syntax_highlighting, #k