KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 55 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/55/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 15 Jul 2018 03:18:38 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)21%
(435/2119)20%
(214/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(119/123)58%
(56/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/80/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 15 Jul 2018 03:18:11 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

[Ben Cooksley]

bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.


  Thanks for uploading this, that looks fine to me!

REPOSITORY
  R244 KCoreAddons

BRANCH
  msvc_fix

REVISION DETAIL
  https://phabricator.kde.org/D14122

To: bruns, #frameworks, kossebau, bcooksley
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14123: Add `drive-optical` icon

[Nathaniel Graham]

ngraham added reviewers: Breeze, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14123

To: ngraham, broulik, andreask, #breeze, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14123: Add `drive-optical` icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, andreask.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  It's just a symlink to `media-optical` which looks great and fits the bill.
  
  BUG: 396432
  FIXED-IN 5.49

REPOSITORY
  R266 Breeze Icons

BRANCH
  drive-optical-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14123

AFFECTED FILES
  icons-dark/devices/16/drive-optical.svg
  icons-dark/devices/22/drive-optical.svg
  icons-dark/devices/64/drive-optical.svg
  icons/devices/16/drive-optical.svg
  icons/devices/22/drive-optical.svg
  icons/devices/64/drive-optical.svg

To: ngraham, broulik, andreask
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/78/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 15 Jul 2018 03:18:38 +
 Build duration:
5 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(406/2119)17%
(186/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
   

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

[Stefan Brüns]

bruns added a dependency: D14121: KFormat: Add unit tests for mili/micro SI 
prefixes.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14122

To: bruns, #frameworks, kossebau, bcooksley
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Stefan Brüns]

bruns added a dependent revision: D14122: KFormat: Replace unicode literal with 
unicode codepoint to fix MSVC build.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14121

To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

bruns added a dependent revision: D14121: KFormat: Add unit tests for 
mili/micro SI prefixes.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Stefan Brüns]

bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond 
bytes and seconds.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14121

To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, kossebau, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  MSVC is unable to parse UTF-8 sequences when the file has no BOM (byte
  order mark), and fails with "error C2015: too many characters in constant".

TEST PLAN
  run kformattest unit test

REPOSITORY
  R244 KCoreAddons

BRANCH
  msvc_fix

REVISION DETAIL
  https://phabricator.kde.org/D14122

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: bruns, #frameworks, kossebau, bcooksley
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14121: KFormat: Add unit tests for mili/micro SI prefixes

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, kossebau.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Add test cases for KFormat::formatValue(...) with value smaller than
  1.0, with fixed and automatic SI prefix.

REPOSITORY
  R244 KCoreAddons

BRANCH
  test1

REVISION DETAIL
  https://phabricator.kde.org/D14121

AFFECTED FILES
  autotests/kformattest.cpp

To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

bruns added a comment.


  This outputs 'µ' twice, so QChar(0xB5) should be equivalent:
  
  qWarning() << QString(QChar(0xB5)) << QString(QChar(u'µ'));

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Ben Cooksley]

bcooksley added a comment.


  You can add #windows  to a review, 
however there still needs to be a degree of responsibility by those who are 
actually making commits to projects (especially in the case of #Frameworks 
).
  
  Otherwise we'll end up in a situation where developers who do care about 
these platforms for their applications are continuously having to fix breakages 
created by others who don't care at all, which is an unsustainable dynamic.
  This would have substantial negative impacts on projects such as #Krita 
, #KDevelop 
, #RKWard 
, #Elisa 
, #digikam 
, #Marble 
, #Peruse 
, #Falkon 
 and #Kate 
 among others.
  
  The fix in this case is likely relatively trivial, so it should be done by 
the original developer.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Is there some tag which can be used to pull the people in who want to support 
that Closed Source Microsoft platform in such cases?
  
  I wasted some time of my FLOSS life meanwhile and found 
https://developercommunity.visualstudio.com/content/problem/198547/error-c2015-for-fixed-encoding-character-literals.html
 and 
https://stackoverflow.com/questions/5060560/how-to-print-the-microsecond-symbol-in-c
 which might be interesting. But at the end of the day it needs to be the 
Windows people to work on fixing this.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Ben Cooksley]

bcooksley added a comment.


  Unfortunately we cannot leave it in a broken condition. Could we try encoding 
it differently perhaps?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

D14118: Improve "Remove this [widget]" text

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14118

To: ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch adds the word "widget" onto the end of the string that's currently 
"Remove this [widget]", which yields the following user interface improvements:
  
  - The string is no longer grammatically incorrect when the name of the widget 
is a plural noun (e.g. "Remove this Notes" vs "Remove this Notes widget")
  - Reinforces the fact that everything in Plasma is a widget, emphasizing its 
modularity

TEST PLAN
  [images go here]

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14118

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/private/applet_p.cpp

To: ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

bruns added a comment.


  In D13583#292049 , @bcooksley 
wrote:
  
  > Sorry, but MSVC doesn't like this.
  >  Please see 
https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/
  
  
  MSVC seems to be broken, it chokes on
  `QChar(u'µ')`
  
  I don't have access to MSVC, so I can't do anything about it.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

D9394: Show "Search wrapped" message in center of view for better visibility

[Nathaniel Graham]

ngraham added a comment.


  Retroactive +1 on the positioning and wording, but I would have stayed with 
an Informational (blue) KMessageWidget instead of making it Positive (and 
hence, green). Eh, not a huge deal. Shoulda piped up sooner!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9394

To: dhaumann, neundorf, cullmann, kfunk, mwolff
Cc: kwrite-devel, kde-frameworks-devel, ngraham, broulik, michaelh, 
kevinapavew, bruns, demsking, cullmann, sars, dhaumann

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen added a comment.


  Thank you, but I already made the request and it was accepted last night. I 
will do the next push :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann, cullmann
Cc: kwrite-devel, cullmann, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D7245: Improve reStructuredText highlighting

[Christoph Cullmann]

cullmann added a comment.


  If you are happy with the current state, I can add some auto-test for you and 
push this.

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D10587: Restore KTextEditor Document Dbus bindings

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  I still don't agree with having that just for the use-case of "auto-save" 
untitled documents.
  
  I would make much more sense to have a more clever handling for that, which 
would solve bug https://bugs.kde.org/show_bug.cgi?id=394833
  
  I am fine with a solution for that, but not for introducing again some 
interface that has only one use and leads to overhead registering stuff at dbus 
for each open document.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10587

To: lukedashjr, cullmann, dhaumann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, anthonyfieroni, #ktexteditor, #kate, 
asturmlechner, gregormi, dhaumann, cullmann, michaelh, kevinapavew, ngraham, 
bruns, demsking, head7, kfunk, sars, #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/29/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 20:09:38 +
 Build duration:
5 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)

D9219: WIP: Extend Scripting API

[Christoph Cullmann]

cullmann added a comment.


  Hi, I appreciate the attention on the test, but as you see in
  
  https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/51/
  
  they work again and the breakage was introduced (by me) in
  
  https://phabricator.kde.org/D13394
  
  Cross-module breakage is ugly :/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9219

To: dhaumann, cullmann, mwolff
Cc: bcooksley, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 51 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/51/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 14 Jul 2018 20:06:14 +
 Build duration:
6 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)90%
(258/288)90%
(258/288)69%
(33844/49116)52%
(16772/32008)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4323/4620)49%
(1669/3400)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1864)77%
(1285/1678)src.completion100%
(11/11)100%
(11/11)57%
(1771/3116)42%
(1159/2731)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/836)0%
(0/238)src.document100%
(4/4)100%
(4/4)59%
(1889/3181)49%
(1640/3331)src.export100%
(4/4)100%
(4/4)86%
(107/125)71%
(115/162)src.include.ktexteditor100%
(14/14)100%
(14/14)91%
(222/243)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(169/419)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/294)src.render100%
(7/7)100%
(7/7)76%
(923/1214)66%
(613/926)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)69%
(736/1060)59%
(267/453)src.search100%
(6/6)100%
(6/6)74%
(1100/1493)63%
(569/902)src.spellcheck86%
(6/7)86%
(6/7)30%

D9219: WIP: Extend Scripting API

[Ben Cooksley]

bcooksley added a comment.


  This change introduced changes which broke tests that previously passed.
  Please see 
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/48/testReport/(root)/TestSuite/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9219

To: dhaumann, cullmann, mwolff
Cc: bcooksley, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Ben Cooksley]

bcooksley added a comment.


  Sorry, but MSVC doesn't like this.
  Please see 
https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, 
bruns

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/50/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 14 Jul 2018 17:40:41 +
 Build duration:
2 hr 25 min and counting
   CONSOLE OUTPUT
  [...truncated 294.45 KB...][ 85%] Built target commands_testScanning dependencies of target bug286887[ 85%] Building CXX object autotests/CMakeFiles/bug286887.dir/src/bug286887.cpp.o[ 86%] Building CXX object autotests/CMakeFiles/bug286887.dir/bug286887_autogen/mocs_compilation.cpp.o[ 86%] Linking CXX executable ../bin/bug286887[ 86%] Built target bug286887Scanning dependencies of target undomanager_test[ 86%] Building CXX object autotests/CMakeFiles/undomanager_test.dir/src/undomanager_test.cpp.o[ 87%] Building CXX object autotests/CMakeFiles/undomanager_test.dir/undomanager_test_autogen/mocs_compilation.cpp.o[ 87%] Linking CXX executable ../bin/undomanager_test[ 87%] Built target undomanager_testScanning dependencies of target movingrange_test[ 87%] Building CXX object autotests/CMakeFiles/movingrange_test.dir/src/movingrange_test.cpp.o[ 87%] Building CXX object autotests/CMakeFiles/movingrange_test.dir/movingrange_test_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../bin/movingrange_test[ 88%] Built target movingrange_testScanning dependencies of target katewildcardmatcher_test[ 88%] Building CXX object autotests/CMakeFiles/katewildcardmatcher_test.dir/src/katewildcardmatcher_test.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/katewildcardmatcher_test.dir/katewildcardmatcher_test_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../bin/katewildcardmatcher_test[ 89%] Built target katewildcardmatcher_testScanning dependencies of target bug313759[ 90%] Building CXX object autotests/CMakeFiles/bug313759.dir/src/bug313759.cpp.o[ 90%] Building CXX object autotests/CMakeFiles/bug313759.dir/src/testutils.cpp.o[ 90%] Building CXX object autotests/CMakeFiles/bug313759.dir/bug313759_autogen/mocs_compilation.cpp.o[ 90%] Linking CXX executable ../bin/bug313759[ 90%] Built target bug313759Scanning dependencies of target scripting_test[ 90%] Building CXX object autotests/CMakeFiles/scripting_test.dir/src/scripting_test.cpp.o[ 91%] Building CXX object autotests/CMakeFiles/scripting_test.dir/src/script_test_base.cpp.o[ 91%] Building CXX object autotests/CMakeFiles/scripting_test.dir/src/testutils.cpp.o[ 91%] Building CXX object autotests/CMakeFiles/scripting_test.dir/scripting_test_autogen/mocs_compilation.cpp.o[ 91%] Linking CXX executable ../bin/scripting_test[ 91%] Built target scripting_testScanning dependencies of target wordcompletiontest[ 92%] Building CXX object autotests/CMakeFiles/wordcompletiontest.dir/src/wordcompletiontest.cpp.o[ 92%] Building CXX object autotests/CMakeFiles/wordcompletiontest.dir/wordcompletiontest_autogen/mocs_compilation.cpp.o[ 92%] Linking CXX executable ../bin/wordcompletiontest[ 92%] Built target wordcompletiontestScanning dependencies of target bug205447[ 92%] Building CXX object autotests/CMakeFiles/bug205447.dir/src/bug205447.cpp.o[ 92%] Building CXX object autotests/CMakeFiles/bug205447.dir/src/testutils.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/bug205447.dir/bug205447_autogen/mocs_compilation.cpp.o[ 93%] Linking CXX executable ../bin/bug205447[ 93%] Built target bug205447Scanning dependencies of target katesyntaxtest[ 93%] Building CXX object autotests/CMakeFiles/katesyntaxtest.dir/src/katesyntaxtest.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/katesyntaxtest.dir/katesyntaxtest_autogen/mocs_compilation.cpp.o[ 93%] Linking CXX executable ../bin/katesyntaxtest[ 93%] Built target katesyntaxtestScanning dependencies of target messagetest[ 93%] Building CXX object autotests/CMakeFiles/messagetest.dir/src/messagetest.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/messagetest.dir/messagetest_autogen/mocs_compilation.cpp.o[ 93%] Linking CXX executable ../bin/messagetest[ 93%] Built target messagetestScanning dependencies of target kateview_test[ 93%] Building CXX object autotests/CMakeFiles/kateview_test.dir/src/kateview_test.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/kateview_test.dir/kateview_test_autogen/mocs_compilation.cpp.o[ 94%] Linking CXX executable ../bin/kateview_test[ 94%] Built target kateview_testScanning dependencies of target vimode_completion[ 94%] Building CXX object autotests/src/vimode/CMakeFiles/vimode_completion.dir/completion.cpp.o[ 95%] Building CXX object autotests/src/vimode/CMakeFiles/vimode_completion.dir/base.cpp.o[ 95%] Building CXX object autotests/src/vimode/CMakeFiles/vimode_completion.dir/fakecodecompletiontestmodel.cpp.o[ 95%] Building CXX object autotests/src/vimode/CMakeFiles/vimode_completion.dir/vimode_completion_autogen/mocs_compilation.cpp.o[ 95%] Linking CXX executable ../../../bin/vimode_completion[ 95%] Built target vimode_completionScanning dependencies of target vimode_modes[ 95%] 

D12295: Supporting nested brackets for Kate autobrackets

[Christoph Cullmann]

cullmann added a comment.


  I like the idea.
  For the patch:
  
  I think one should check with isEmpty() if the thing is empty, instead of the 
size() > 0 things, thats more clear.
  And is there no m_currentAutobraceClosingChar clear missing somewhere? e.g. 
don't go this two stack out of sync?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12295

To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D12295: Supporting nested brackets for Kate autobrackets

[Christoph Cullmann]

cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12295

To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 94 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/94/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 14 Jul 2018 18:29:01 +
 Build duration:
6 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)90%
(258/288)90%
(258/288)69%
(33844/49114)52%
(16773/32008)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4322/4619)49%
(1669/3400)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1864)77%
(1285/1678)src.completion100%
(11/11)100%
(11/11)57%
(1771/3116)42%
(1159/2731)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/836)0%
(0/238)src.document100%
(4/4)100%
(4/4)59%
(1889/3181)49%
(1640/3331)src.export100%
(4/4)100%
(4/4)86%
(107/125)71%
(115/162)src.include.ktexteditor100%
(14/14)100%
(14/14)91%
(222/243)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(169/419)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/294)src.render100%
(7/7)100%
(7/7)76%
(923/1214)66%
(613/926)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)69%
(736/1060)59%
(267/453)src.search100%
(6/6)100%
(6/6)74%
(1100/1493)63%
(569/902)src.spellcheck86%
(6/7)86%
(6/7)30%

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 28 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/28/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 18:29:01 +
 Build duration:
1 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on FreeBSD Builder 3 in /usr/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/ktexteditor > git init /usr/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 # timeout=10Fetching upstream changes from git://anongit.kde.org/ktexteditor > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/ktexteditor +refs/heads/*:refs/remotes/origin/* # timeout=120ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/ktexteditor +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: read error: Connection reset by peer	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2002)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1721)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:405)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:614)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 3		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor469.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at com.sun.proxy.$Proxy83.execute(Unknown Source)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1146)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:113)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:85)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:75)		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/93/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 14 Jul 2018 17:42:27 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.kateindenttest_testCppstyle
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)90%
(258/288)90%
(258/288)69%
(33837/49114)52%
(16772/32008)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4322/4619)49%
(1669/3400)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1864)77%
(1285/1678)src.completion100%
(11/11)100%
(11/11)57%
(1771/3116)42%
(1159/2731)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/836)0%
(0/238)src.document100%
(4/4)100%
(4/4)59%
(1889/3181)49%
(1640/3331)src.export100%
(4/4)100%
(4/4)86%
(107/125)71%
(115/162)src.include.ktexteditor100%
(14/14)100%
(14/14)91%
(222/243)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(169/419)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/294)src.render100%
(7/7)100%
(7/7)76%
(923/1214)66%
(613/926)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)69%
(736/1060)59%
(267/453)src.search100%
(6/6)100%
(6/6)74%
(1100/1493)63%
(569/902)src.spellcheck86%
(6/7)86%
(6/7)30%
 

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/27/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 17:40:41 +
 Build duration:
6 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCppstyle

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/92/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 14 Jul 2018 17:27:01 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.katesyntaxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)90%
(258/288)90%
(258/288)69%
(33841/49114)52%
(16780/32008)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4326/4619)49%
(1678/3400)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1864)77%
(1285/1678)src.completion100%
(11/11)100%
(11/11)57%
(1771/3116)42%
(1159/2731)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/836)0%
(0/238)src.document100%
(4/4)100%
(4/4)59%
(1889/3181)49%
(1640/3331)src.export100%
(4/4)100%
(4/4)86%
(107/125)71%
(115/162)src.include.ktexteditor100%
(14/14)100%
(14/14)91%
(222/243)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(169/419)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/294)src.render100%
(7/7)100%
(7/7)76%
(923/1214)66%
(613/926)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)69%
(736/1060)59%
(267/453)src.search100%
(6/6)100%
(6/6)74%
(1100/1493)63%
(569/902)src.spellcheck86%
(6/7)86%
  

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/49/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 14 Jul 2018 17:27:01 +
 Build duration:
7 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.katesyntaxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)90%
(258/288)90%
(258/288)69%
(33841/49116)52%
(16780/32008)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4327/4620)49%
(1678/3400)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1864)77%
(1285/1678)src.completion100%
(11/11)100%
(11/11)57%
(1771/3116)42%
(1159/2731)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/836)0%
(0/238)src.document100%
(4/4)100%
(4/4)59%
(1889/3181)49%
(1640/3331)src.export100%
(4/4)100%
(4/4)86%
(107/125)71%
(115/162)src.include.ktexteditor100%
(14/14)100%
(14/14)91%
(222/243)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(169/419)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/294)src.render100%
(7/7)100%
(7/7)76%
(923/1214)66%
(613/926)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)69%
(736/1060)59%
(267/453)src.search100%
(6/6)100%
(6/6)74%
(1100/1493)63%
(569/902)src.spellcheck86%
(6/7)86%
  

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/26/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 17:27:01 +
 Build duration:
6 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.katesyntaxtest

D12271: Don't remove trailing whitespace from cursor line

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.


  > I agree that the current state is ok and we arrived there after X 
iterations. I can agree that it might be bad for people with the habit to save 
each 5 seconds, but actually, given we have swap files for crash recovery, 
there is no reason to do so.
  
==

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12271

To: sraizada, #ktexteditor, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, dhaumann, anthonyfieroni, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D9394: Show "Search wrapped" message in center of view for better visibility

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:cc8b22089c4d: Show Search wrapped message in 
center of view for better visibility (authored by dhaumann, committed by 
cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9394?vs=24063=37762

REVISION DETAIL
  https://phabricator.kde.org/D9394

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h

To: dhaumann, neundorf, cullmann, kfunk, mwolff
Cc: kwrite-devel, kde-frameworks-devel, ngraham, broulik, michaelh, 
kevinapavew, bruns, demsking, cullmann, sars, dhaumann

D9394: Show "Search wrapped" message in center of view for better visibility

[Christoph Cullmann]

cullmann added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  I tried it, it is more obvious, if that is perfect, I don't know.
  
  I will push that now, before it rots ;=) (like other requests).
  
  And if the outcry is large, we can still revert it.
  I think there is no way to see if it is better beside user testing.

REPOSITORY
  R39 KTextEditor

BRANCH
  SearchMessages (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9394

To: dhaumann, neundorf, cullmann, kfunk, mwolff
Cc: kwrite-devel, kde-frameworks-devel, ngraham, broulik, michaelh, 
kevinapavew, bruns, demsking, cullmann, sars, dhaumann, #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/25/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 17:16:41 +
 Build duration:
8 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.katesyntaxtest

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 48 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/48/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 14 Jul 2018 17:16:41 +
 Build duration:
6 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.katesyntaxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)90%
(258/288)90%
(258/288)69%
(33834/49119)52%
(16775/32000)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4327/4620)49%
(1678/3400)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1864)77%
(1285/1678)src.completion100%
(11/11)100%
(11/11)57%
(1771/3116)42%
(1159/2731)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/836)0%
(0/238)src.document100%
(4/4)100%
(4/4)59%
(1889/3181)49%
(1640/3331)src.export100%
(4/4)100%
(4/4)86%
(107/125)71%
(115/162)src.include.ktexteditor100%
(14/14)100%
(14/14)91%
(222/243)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(169/419)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/294)src.render100%
(7/7)100%
(7/7)76%
(923/1214)66%
(613/926)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)69%
(736/1060)59%
(267/453)src.search100%
(6/6)100%
(6/6)73%
(1097/1497)63%
(564/894)src.spellcheck86%
(6/7)86%
  

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 91 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/91/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 14 Jul 2018 17:16:41 +
 Build duration:
6 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: TestSuite.katesyntaxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)90%
(258/288)90%
(258/288)69%
(33834/49117)52%
(16775/32000)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4326/4619)49%
(1678/3400)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1864)77%
(1285/1678)src.completion100%
(11/11)100%
(11/11)57%
(1771/3116)42%
(1159/2731)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/836)0%
(0/238)src.document100%
(4/4)100%
(4/4)59%
(1889/3181)49%
(1640/3331)src.export100%
(4/4)100%
(4/4)86%
(107/125)71%
(115/162)src.include.ktexteditor100%
(14/14)100%
(14/14)91%
(222/243)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(169/419)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/294)src.render100%
(7/7)100%
(7/7)76%
(923/1214)66%
(613/926)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)69%
(736/1060)59%
(267/453)src.search100%
(6/6)100%
(6/6)73%
(1097/1497)63%
(564/894)src.spellcheck86%
(6/7)86%

D9219: WIP: Extend Scripting API

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c2580c5b0f22: Extend Scripting API (authored by dhaumann, 
committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9219?vs=23543=37759

REVISION DETAIL
  https://phabricator.kde.org/D9219

AFFECTED FILES
  src/CMakeLists.txt
  src/script/katescript.cpp
  src/script/katescript.h
  src/script/katescripteditor.cpp
  src/script/katescripteditor.h

To: dhaumann, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D13394: C++: update for c++20 and fix some syntax errors

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a2343cae2bb5: C++: update for c++20 and fix some syntax 
errors (authored by jpoelen, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13394?vs=36229=37756

REVISION DETAIL
  https://phabricator.kde.org/D13394

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.y.fold
  autotests/folding/preprocessor-bug363280.cpp.fold
  autotests/html/folding.cpp.html
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/folding.cpp.ref
  autotests/reference/highlight.cpp.ref
  data/syntax/gcc.xml
  data/syntax/isocpp.xml

To: jpoelen, dhaumann, cullmann
Cc: kwrite-devel, cullmann, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D13394: C++: update for c++20 and fix some syntax errors

[Christoph Cullmann]

cullmann added a comment.
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.


  To get this in, I will push it for you.
  If you need some reason for a developer account, you can just link this 
request.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann, cullmann
Cc: kwrite-devel, cullmann, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/24/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 16:34:16 +
 Build duration:
8 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.completion_test

D13747: Fuzzy filename search for Baloo

[Stefan Brüns]

bruns added a comment.


  I think this design has several problems:
  
  1. adding or renaming documents becomes very write heavy
- consider adding e.g. foobar.png - this will add 7 bigrams. Each bigram 
has an associated list of matching documents. The document list is sorted. This 
means we have 7 read-modify-write operations.
  
  2. Lots of additional data
- to be fast, we have to keep this data in memory. We also have to fetch it 
from disk at startup.
  
  3. It ties the searching algorithm to the data structure
  
  4. The searching may become inefficient when the data set becomes large
- The lookup of each bigram is fast
- You have to lookup several bigrams when the search term becomes longer
- You have to evaluate all result sets and combine them in some way

INLINE COMMENTS

> fuzzysearchtest.cpp:63
> +}
> +
> +void FuzzySearchTest::testFeatures()

The test cases above are good in general, as these test a small aspect.
Improvement:
These are not different test cases, but iterations of the same test. This calls 
for data driven testing, see:
http://doc.qt.io/qt-5/qttestlib-tutorial2-example.html

> fuzzysearchtest.cpp:69
> +  QMap correct;
> +
> +  auto make = [](quint8 wid, quint8 len) -> FuzzyDataList {

I think this test should be written in a different way:

- check if the map has the correct size
- check if each entry has the correct docId
- check the terms:

  for (const auto& feat : { "no", "ot", "te", "es"} ) {
  QCOMPARE(exported[feat].size(), 1); // one document
  QCOMPARE(exported[feat][0].wid, 0); // first word
  QCOMPARE(exported[feat][0].len, 5); // strlen("notes")
  }
  ...
  QCOMPARE(exported["md"][0].wid, 3);
  QCOMPARE(exported["md"][0].len, 2);

> fuzzysearchtest.cpp:119
> +  db.unite(FuzzySearch::features(2, file2));
> +  db.unite(FuzzySearch::features(3, file3));
> +  db.unite(FuzzySearch::features(4, file4));

You should have a separate test case here, or even 2 - you should test if the 
merging works as expected:

- for same feats from different documents ("notes")
- for same feat from one documents ("not_es_", "wedn_es_day", i.e. "es")

> fuzzysearchtest.cpp:129
> +  db.unite(FuzzySearch::features(12, file12));
> +
> +  FuzzyDataList list;

If you create a list of the files, you can use a loop for the insertion here.

  QList files = {
  {"notes", "april8", "2018", "md"},
  {"notes", "wednesday", "04092018", "md"},
  ...
  {"LMC2200"}
  }
  ...
  for (size_t i = 0; i < files.size(); i++) {
db.unite(FuzzySearch::features(i, files[i]));
  }

> fuzzysearchtest.cpp:131
> +  FuzzyDataList list;
> +  FuzzyDataGetter getter = [&](const FuzzyFeature& feat) -> const 
> FuzzyDataList& {
> +list.m_datalist.clear();

This function itself calls for a unit test - for a given feature, return the 
matching documents
Also, either capture the list, or return it (then, by value, not by reference), 
but don't do both. I strongly prefer return by value here.

> fuzzysearchtest.cpp:143
> +  results = fuzzy.search(QString("wensday"), getter);
> +  QCOMPARE(results, QList({ 2 }));
> +

If you create a `QSet foundFiles = files[result[0]];`, you can 
compare it with `QSet({{"notes", "wednesday", "04092018", "md"}});`
This way, it becomes obvious what you expect as output here.
To make it more obvious what the QStringList refers to, you can use `using 
FileNameTerms = QStringList;`

> CMakeLists.txt:18
>  postingdb.cpp
> +fuzzydb.cpp
>  postingiterator.cpp

Please remove the db from the patch, this should be a separate patch, after the 
fuzzy matcher itself is paved out.

> database.cpp:25
>  #include "postingdb.h"
> +#include "fuzzydb.h"
>  #include "documentdb.h"

later ...

> database.cpp:108
>   */
> -mdb_env_set_maxdbs(m_env, 12);
> +mdb_env_set_maxdbs(m_env, 13);
>  

later ...

> fuzzysearch.cpp:80
> +  // Keep track of the score of each document and its length
> +  auto score = scores.find(doc);
> +  if (score == scores.end()) {

You are matching for document *and* term here, I don't think thats what you 
want.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13747

To: michaeleden, vhanda, #baloo
Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D14111: Install MIME type definition for text/x-rst ourselves for now

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  In D14111#291934 , @kossebau wrote:
  
  > In D14111#291933 , @pino wrote:
  >
  > > NACK.
  > >  Make sure that the request for shared-mime-info 
(https://bugs.freedesktop.org/show_bug.cgi?id=107227) is accepted, and that is 
enough.
  >
  >
  > Even if the request is accepted, it will take some time until it makes it 
to the users/developers, given smo 1.10 was tagged/released only some days ago, 
and as smo release cycle seems to be half a year or longer. Which in developer 
life is ages, especially looking at the web rivals, which deliver each months 
to everyone :/
  
  
  If that is problematic enough, talk with hadess (Bastien Nocera) about that.
  
  >> There is enough stuff in `kde5.xml` already, even shipped in 
shared-mime-info, so adding more is not a good idea.
  > 
  > Sure that needs some clean-up. I already started a patch to split this up 
and make things depend on the found smo version, so just the stuff is installed 
which is really needed.
  
  I thought about a similar approach in the past, but
  
  - unless you really maintain the amount of files, and properly tie each to a 
version of s-m-i, it becomes a mess to maintain
  - once you update s-m-i, you are back to a potential conflict (since the new 
s-m-i version may carry a new mimetype shipped in `kde5.xml`)
  - related to the point above: s-m-i is really a //runtime// dependency, so 
version checks at //build// time are not exactly good ideas...
  
  > Perhaps you can reconsider your take on this one once that has been 
uploaded and reviewed :)
  
  Not really: even if you implement what you mention above, the duplication is 
still there.
  
  Just to expand a bit more: when we switched to s-m-i during the kde4 
development (more than 12 years ago), I took the task of migrating our 
mimetypes to the "new" format. Call it "mistakes of youth", "limitations of the 
toolchain at that point", etc, the result was a single `kde.xml` carrying all 
the mimetype definitions that kdelibs had, and that s-m-i had not. Some of the 
mimetypes were generic enough to be added to s-m-i, so they were included (see 
various commits with myself as author), and some were not (see the various "smi 
rejected" comments floating around). To overcome the lack of these mimetypes in 
s-m-i, they were added in `kde.xml`, because of the reasons you mention above. 
Soon though I realized it was not a good idea, since a) neither of the 
mimetypes were critical enough to warrant duplicates b) basically nobody else 
than @dfaure me maintained `kde.xml`. See for example the recent 
e5f09f84a945af4edf4f346aed409acf29905414 
, 
which is one of the biggest cleanups after so many years. Or 
a7be6bab411d7f1fe2555ab5adc0465ca0cfc5d9 
, 
i.e. synchronize a local copy of a s-m-i mimetype ...
  
  So yes, I understand your reasons, but because of all the history involved I 
really do not want to add more stuff to `kde5.xml` that is really material for 
s-m-i.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14111

To: kossebau, dfaure, pino
Cc: fabianr, kde-frameworks-devel, michaelh, ngraham, bruns

D14111: Install MIME type definition for text/x-rst ourselves for now

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D14111#291933 , @pino wrote:
  
  > NACK.
  >  Make sure that the request for shared-mime-info 
(https://bugs.freedesktop.org/show_bug.cgi?id=107227) is accepted, and that is 
enough.
  
  
  Even if the request is accepted, it will take some time until it makes it to 
the users/developers, given smo 1.10 was tagged/released only some days ago, 
and as smo release cycle seems to be half a year or longer. Which in developer 
life is ages, especially looking at the web rivals, which deliver each months 
to everyone :/
  
  > There is enough stuff in `kde5.xml` already, even shipped in 
shared-mime-info, so adding more is not a good idea.
  
  Sure that needs some clean-up. I already started a patch to split this up and 
make things depend on the found smo version, so just the stuff is installed 
which is really needed. 
  Perhaps you can reconsider your take on this one once that has been uploaded 
and reviewed :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14111

To: kossebau, dfaure, pino
Cc: fabianr, kde-frameworks-devel, michaelh, ngraham, bruns

D14111: Install MIME type definition for text/x-rst ourselves for now

[Pino Toscano]

pino added a comment.


  NACK.
  Make sure that the request for shared-mime-info 
(https://bugs.freedesktop.org/show_bug.cgi?id=107227) is accepted, and that is 
enough. There is enough stuff in `kde5.xml` already, even shipped in 
shared-mime-info, so adding more is not a good idea.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14111

To: kossebau, dfaure, pino
Cc: fabianr, kde-frameworks-devel, michaelh, ngraham, bruns

D14111: Install MIME type definition for text/x-rst ourselves for now

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: dfaure, pino.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  As ECM docs are written in reStructuredText format as well as the
  new version of KDE HIG, having a proper MIME type definition should
  improve appearance/handling of such files in the UI.

TEST PLAN
  .rst fules are displayed to be of type reStructuredText document
  in file manager/dialog.

REPOSITORY
  R244 KCoreAddons

BRANCH
  addrsttosmo

REVISION DETAIL
  https://phabricator.kde.org/D14111

AFFECTED FILES
  src/mimetypes/kde5.xml

To: kossebau, dfaure, pino
Cc: fabianr, kde-frameworks-devel, michaelh, ngraham, bruns

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns added a comment.


  In D12233#283521 , @bruns wrote:
  
  > In D12233#279389 , @bruns wrote:
  >
  > > Still waiting for a final review ...
  >
  >
  > Hello! Anyone at home?
  
  
  Another 2 weeks ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh, mgallien
Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/93/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 14 Jul 2018 14:24:25 +
 Build duration:
8 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6302/8405)43%
(10089/23327)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2682/2758)49%
(5757/11815)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(726/908)52%
(825/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D13814: Speedup sort

[Stefan Brüns]

bruns added a comment.


  In D13814#291913 , @jtamate wrote:
  
  > Also amended the commit message.
  
  
  thanks, but unfortunately this won't change the git commit message :-(

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/16/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 14:24:25 +
 Build duration:
3 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/38/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 14 Jul 2018 14:24:25 +
 Build duration:
3 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6303/8405)43%
(10089/23323)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2682/2758)49%
(5758/11817)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(726/908)52%
(824/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

bruns added a comment.


  In D13583#291895 , @kossebau wrote:
  
  > @bruns Please update all the "@since" to 5.49, as this will be only part of 
the next KF version now.
  
  
  Sorry, updated and pushed

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 39 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/39/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 14 Jul 2018 14:24:26 +
 Build duration:
1 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 106.33 KB...]**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your coresScanning dependencies of target KF5CoreAddons_autogen[  0%] Automatic MOC for target KF5CoreAddons[  0%] Built target KF5CoreAddons_autogenScanning dependencies of target desktoptojson_autogen[  0%] Automatic MOC for target desktoptojson[  0%] Built target desktoptojson_autogenScanning dependencies of target ktexttohtmltest_autogen[  0%] Automatic MOC for target ktexttohtmltest[  0%] Built target ktexttohtmltest_autogenScanning dependencies of target KF5CoreAddons[  0%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.obj[  1%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.obj[  1%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[  2%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.objkaboutdata.cpp[  3%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.obj[  5%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.obj[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.obj[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.obj[  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.objkcoreaddons.cpp[  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.objkmessage.cpp[  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.objkcompositejob.cppkjobtrackerinterface.cpp[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.obj[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.objkbackup.cppKDE5 TODO: Remove KConfig correctlykurlmimedata.cpp[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.objkfilesystemtype.cpp[ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.objkautosavefile.cppkjob.cpp[ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.obj[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.obj[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.objkjobuidelegate.cppkmacroexpander.cppkdirwatch.cppkrandomsequence.cppkpluginfactory.cppkprocess.cppdesktopfileparser.cppkrandom.cppkpluginloader.cppkstringhandler.cppkpluginmetadata.cpp[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.obj[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.objktexttohtml.cppkdelibs4migration.cpp[ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4configmigrator.cpp.objC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(124): warning C4996: 'KPluginFactory::createPartObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(103): note: see declaration of 'KPluginFactory::createPartObject'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(129): warning C4996: 'KPluginFactory::createObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(93): note: see declaration of 'KPluginFactory::createObject'kdelibs4configmigrator.cpp[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformat.cpp.objkformat.cpp[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformatprivate.cpp.objkformatprivate.cpp[ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell.cpp.objkshell.cpp[ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/caching/kshareddatacache_win.cpp.objkshareddatacache_win.cpp[ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander_win.cpp.objkmacroexpander_win.cpp[ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell_win.cpp.objkshell_win.cpp[ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kuser_win.cpp.obj[ 19%] Building CXX object 

D14110: KFormat: correct @since tag for new KFormat::formatValue

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:0a81ae65b760: KFormat: correct @since tag for new 
KFormat::formatValue (authored by bruns).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14110?vs=37747=37749

REVISION DETAIL
  https://phabricator.kde.org/D14110

AFFECTED FILES
  src/lib/util/kformat.h

To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13814: Speedup sort

[Jaime Torres Amate]

jtamate added a comment.


  Also amended the commit message.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

D14110: KFormat: correct @since tag for new KFormat::formatValue

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14110

To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

[Stefan Brüns]

bruns updated this revision to Diff 37748.
bruns added a comment.


  Rebase

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13584?vs=36259=37748

BRANCH
  D13584

REVISION DETAIL
  https://phabricator.kde.org/D13584

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13814: Speedup sort

[Jaime Torres Amate]

jtamate edited the summary of this revision.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

D14110: KFormat: correct @since tag for new KFormat::formatValue

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, kossebau.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The change landed immediately after the KF 5.48 release, so update it to
  @since 5.49.

TEST PLAN
  grep 5.48 no longer returns any match

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14110

AFFECTED FILES
  src/lib/util/kformat.h

To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 38 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/38/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 14 Jul 2018 14:06:30 +
 Build duration:
42 sec and counting
   CONSOLE OUTPUT
  [...truncated 106.84 KB...]**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your coresScanning dependencies of target KF5CoreAddons_autogen[  0%] Automatic MOC for target KF5CoreAddons[  0%] Built target KF5CoreAddons_autogenScanning dependencies of target desktoptojson_autogen[  0%] Automatic MOC for target desktoptojson[  0%] Built target desktoptojson_autogenScanning dependencies of target ktexttohtmltest_autogen[  0%] Automatic MOC for target ktexttohtmltest[  0%] Built target ktexttohtmltest_autogenScanning dependencies of target KF5CoreAddons[  0%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.obj[  1%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.obj[  1%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[  2%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.obj[  5%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[  4%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[  5%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[  5%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.obj[  5%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.objkaboutdata.cpp[  5%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.obj[  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.obj[  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.objkcoreaddons.cpp[  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.objkmessage.cpp[  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.objkbackup.cppKDE5 TODO: Remove KConfig correctlykjobtrackerinterface.cpp[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.obj[  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.objkjob.cppkcompositejob.cpp[ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.objkurlmimedata.cpp[ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.obj[ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.objkfilesystemtype.cpp[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.objkautosavefile.cpp[ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.objkjobuidelegate.cppkstringhandler.cppkdirwatch.cppkmacroexpander.cppkpluginfactory.cppkprocess.cppkpluginloader.cppkrandomsequence.cppkrandom.cppdesktopfileparser.cppkpluginmetadata.cpp[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.obj[ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.objktexttohtml.cppC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(124): warning C4996: 'KPluginFactory::createPartObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(103): note: see declaration of 'KPluginFactory::createPartObject'C:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(129): warning C4996: 'KPluginFactory::createObject': was declared deprecatedC:\CI\workspace\Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10\src\lib\plugin\kpluginfactory.cpp(93): note: see declaration of 'KPluginFactory::createObject'kdelibs4migration.cpp[ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4configmigrator.cpp.obj[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformat.cpp.obj[ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kformatprivate.cpp.objkdelibs4configmigrator.cppkformat.cppkformatprivate.cpp[ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell.cpp.obj[ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/caching/kshareddatacache_win.cpp.objkshell.cppkshareddatacache_win.cpp[ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander_win.cpp.objkmacroexpander_win.cpp[ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kshell_win.cpp.obj[ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kuser_win.cpp.objkshell_win.cppkuser_win.cpp[ 19%] Building CXX object 

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/92/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 14 Jul 2018 13:58:08 +
 Build duration:
6 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6302/8405)43%
(10089/23327)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2682/2758)49%
(5757/11815)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(726/908)52%
(825/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @bruns Please update all the "@since" to 5.49, as this will be only part of 
the next KF version now.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/37/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 14 Jul 2018 14:00:09 +
 Build duration:
3 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6303/8405)43%
(10089/23323)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2682/2758)49%
(5758/11817)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(726/908)52%
(824/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/36/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 14 Jul 2018 13:51:20 +
 Build duration:
8 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6243/8335)43%
(10019/23199)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2668/2744)49%
(5725/11751)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/15/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 13:54:49 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/91/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 14 Jul 2018 13:51:20 +
 Build duration:
6 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6242/8335)43%
(10018/23201)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2668/2744)49%
(5724/11749)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/14/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 14 Jul 2018 13:51:20 +
 Build duration:
3 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:45dee45c8922: KFormat: Allow usage of quantities beyond 
bytes and seconds (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13583?vs=36735=37746#toc

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13583?vs=36735=37746

REVISION DETAIL
  https://phabricator.kde.org/D13583

AFFECTED FILES
  autotests/kformattest.cpp
  autotests/kformattest.h
  src/lib/util/kformat.cpp
  src/lib/util/kformat.h
  src/lib/util/kformatprivate.cpp
  src/lib/util/kformatprivate_p.h

To: bruns, #frameworks, astippich
Cc: kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13571: Correct KFormat::formatBytes examples

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:59dc873bcbe1: Correct KFormat::formatBytes examples 
(authored by bruns).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13571?vs=36731=37744

REVISION DETAIL
  https://phabricator.kde.org/D13571

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformat.h

To: bruns, #frameworks, dhaumann
Cc: dhaumann, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13814: Speedup sort

[Stefan Brüns]

bruns added a comment.


  In D13814#291757 , @jtamate wrote:
  
  > In D13814#291644 , @bruns wrote:
  >
  > > Any reason why you have pushed this with an obviously wrong commit 
message?
  >
  >
  > Because I though the commit message was right.
  >
  > What should it be?
  
  
  The new code uses a reference to the  collator instead of copying and 
reinitializing it again and again. This is the reason for the speedup.
  
  Changing the implementation from a  Functor class to a Lambda removes some 
boilerplate code, but is not relevant for performance.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

D13316: manually set format in jpeg thumbnail creator

[Miklós Máté]

miklosm added a comment.


  In D13316#288653 , 
@elvisangelaccio wrote:
  
  > I guess this change makes sense (given that we are in the jpeg plugin), but 
what about `QImageReader::decideFormatFromContent()` ?
  
  
  The file type was already detected to be "jpeg" (especially after D13315 
 gets accepted), that is how the jpeg 
plugin got chosen. There is no need to detect the file type again. See D13416 
 for the other image types.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D13316

To: miklosm, dfaure, elvisangelaccio, #frameworks
Cc: ngraham

D13808: Fix KMainWindow saving incorrect widget settings

[David Faure]

dfaure added a comment.


  Hmm, good point, I thought this was in already :(

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D13829: Lua: fix multi-line string

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7d435174e96d: Lua: fix multi-line string (authored by 
jpoelen, committed by dhaumann).
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13829?vs=37009=37739

REVISION DETAIL
  https://phabricator.kde.org/D13829

AFFECTED FILES
  autotests/folding/highlight.lua.fold
  autotests/html/highlight.lua.html
  autotests/input/highlight.lua
  autotests/reference/highlight.lua.ref
  data/syntax/lua.xml

To: jpoelen, dhaumann, cullmann, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14020: RPM Spec: add MIME type

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:79df3675d4fc: RPM Spec: add MIME type (authored by 
nibags, committed by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14020?vs=37491=37738

REVISION DETAIL
  https://phabricator.kde.org/D14020

AFFECTED FILES
  data/syntax/rpmspec.xml

To: nibags, #framework_syntax_highlighting, vkrause
Cc: kwrite-devel, bcooksley, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14062: Python: fix escapes in quoted-comments

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2627d3e421f6: Python: fix escapes in quoted-comments 
(authored by nibags, committed by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14062?vs=37722=37737

REVISION DETAIL
  https://phabricator.kde.org/D14062

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.py.ref
  data/syntax/python.xml

To: nibags, #framework_syntax_highlighting, #kate, dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, 
demsking, cullmann, sars, dhaumann

D13808: Fix KMainWindow saving incorrect widget settings

[Antonio Rojas]

arojas added a comment.


  This has been approved for two weeks and fixes a major issue... could the fix 
be pushed and then keep working on the auto test later? It already missed 5.48

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: arojas, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D11176#291740 , @bcooksley 
wrote:
  
  > This change has broken the build of all projects that make use of pmap 
resources on Windows, as the Python path at build time is not necessarily the 
path at install time (and it definitely not on the Binary Factory nodes)
  >  In particular it breaks KGeography - see 
https://binary-factory.kde.org/job/KGeography_Nightly_win32/112/console
  
  
  FTR, this should be fixed by 
https://cgit.kde.org/ki18n.git/commit/?id=c5b721dc1753f8ca3c5af06169425751379f635f
  
  Tests ran successfully:
  
  - Building ki18n, running ctest,
  - Applying the change to ki18n 5.48.0, building, running ctest

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: bcooksley, kde-frameworks-devel, sitter, dfaure, #build_system, michaelh, 
ngraham, bruns

D14062: Python: fix escapes in quoted-comments

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Thanks! Looks good to me.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-python

REVISION DETAIL
  https://phabricator.kde.org/D14062

To: nibags, #framework_syntax_highlighting, #kate, dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, 
demsking, cullmann, sars, dhaumann

D13814: Speedup sort

[Jaime Torres Amate]

jtamate added a comment.


  In D13814#291644 , @bruns wrote:
  
  > Any reason why you have pushed this with an obviously wrong commit message?
  
  
  Because I though the commit message was right.
  
  What should it be?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp