D14449: Display used space in GiB also

shubham added a comment. F6159605: Screenshot_20180729_112335.png : SS REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Display used space in GiB also

dhaumann added a comment. Can you add a screenshot? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Display used space in GiB also

shubham created this revision. shubham added reviewers: elvisangelaccio, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY BUG: 334263 TEST PLAN 1. Goto

D14237: Make Konqi look good in HiDPI

bruns added a comment. In D14237#299794 , @ngraham wrote: > sodipodi:absref="/home/sbruens/Downloads/aboutkde_doubled2.png" > ... > width="449.999" /> > Just delete the image element from the SVG and

D14237: Make Konqi look good in HiDPI

ngraham added a comment. Thanks! But where seems to be something wrong with that SVG. Qt complains when I try to load it into a `QPixmap`: couldn't create image from "file:///home/sbruens/Downloads/aboutkde_doubled2.png" Looking inside the SVG file itself, I see the following:

D13808: Fix KMainWindow saving incorrect widget settings

ngraham added a comment. In the Bugzilla ticket, it was mentioned that KMail (and only KMail) still suffers from the issue even with this patch, so it might be a KMail-specific issue. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2,

D13808: Fix KMainWindow saving incorrect widget settings

dfaure added a comment. Hmm, for me the bug is still there. Or maybe it means it's a different bug, but I kind of doubt it. Steps: 1. I start kmail (with a cleaned up ~/.config/kmail2rc to make sure the StatusBar and the Toolbar are shown). 2. I close it (Alt+F4

D14447: Sonnet: setLanguage should schedule a rehighlight if highlight is enabled

dfaure created this revision. dfaure added reviewers: sandsmark, mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY ... even if automatic enabling/disabling is

D14435: Fix KTimeComboBox input mask for AM/PM times

glennw updated this revision to Diff 38685. glennw added a comment. Added an autotest to ensure that the line edit mask is updated correctly. A couple of notes about the test results below: - I tried to set the current locale in the new test to ensure it reproduces. The setLocale()

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

apol added a comment. Why would we want to make it optional? In fact, the only one that is mandatory is the KNS one. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: tundracomp Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

apol added a comment. You didn't specify for which repository this is. REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: apol, ltoscano, cgiboudeaux, #frameworks, michaelh, ngraham, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. In D13805#299580 , @elvisangelaccio wrote: > @tmarshall Do you have commit access? I do not. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 183 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/183/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 28 Jul 2018 17:18:33 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 336 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/336/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 28 Jul 2018 17:18:33 + Build duration: 9 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/93/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 28 Jul 2018 17:18:33 + Build duration: 8 min 3 sec and counting JUnit Tests Name:

D13805: Present error dialog when user tries to create directory named "." or ".."

elvisangelaccio added a comment. @tmarshall Do you have commit access? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham,

D13805: Present error dialog when user tries to create directory named "." or ".."

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns,

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

elvisangelaccio added a comment. +1 REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D14290 To: broulik, dfaure Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/92/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 28 Jul 2018 15:13:58 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/15/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 28 Jul 2018 15:22:43 + Build duration: 1 min 29 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sat, 28 Jul 2018 15:22:43 + Build duration: 1 min 52 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 182 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/182/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 28 Jul 2018 15:13:58 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 335 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/335/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 28 Jul 2018 15:13:58 + Build duration: 5 min 55 sec and counting JUnit Tests Name:

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/42/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 28 Jul 2018 14:20:18 + Build duration: 3 min 48 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/20/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 28 Jul 2018 14:20:18 + Build duration: 3 min 41 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/97/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 28 Jul 2018 14:20:18 + Build duration: 3 min 17 sec and counting JUnit Tests

D14435: Fix KTimeComboBox input mask for AM/PM times

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. could you provide an autotest for it please ? (see autotest/ktimecomboboxtest.cpp) Thanks REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D14435: Fix KTimeComboBox input mask for AM/PM times

glennw added reviewers: cfeck, mlaurent. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14435 To: glennw, cfeck, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

ahiemstra accepted this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent Cc: mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D14435: Fix KTimeComboBox input mask for AM/PM times

glennw created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. glennw requested review of this revision. REVISION SUMMARY In some cases, the strings returned from amText() and pmText() may differ in case to

D14397: Support libcanberra for audio notification

rjvbb added a comment. [I didn't get to send this yesterday] > Not using something because it's from a "rival GUI" is not a valid argument. It is IMVHO if "it" introduces a dependency on another GUI middleware. Libcanberra does that to the best of my knowledge. > Canberra

D14360: Remove custom icon selection for trash

shubham removed a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

shubham updated this revision to Diff 38637. shubham added a comment. Add getter for icon's editability REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs=38633=38637 REVISION DETAIL https://phabricator.kde.org/D14360 AFFECTED FILES

D14360: Remove custom icon selection for trash

shubham added a comment. okay, then it's fine REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

pino added a comment. In D14360#299443 , @shubham wrote: > pino: suppose this function is created(canEditIcon()),then this function must also be called when we are creating the m_iconButton at line 123 so as to generalize it's creation ( as

D14360: Remove custom icon selection for trash

shubham added a comment. pino: suppose this function is created(canEditIcon()),then this function must also be called when we are creating the m_iconButton at line 123 so as to generalize it's creation ( as you had said to take into account other entries also if they are also to be