dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Qt itself tends to write "QCoreApplication" in such warnings instead of
Q*Application, but OK.
REPOSITORY
R249 KI18n
BRANCH
arcpatch-D14922
REVISION DETAIL
bruns added a comment.
This raises the minimum requirement to LLVM 5.0:
http://releases.llvm.org/5.0.0/tools/clang/docs/ReleaseNotes.html
LLVM 5.0 was released 2017-09-07:
http://lists.llvm.org/pipermail/llvm-announce/2017-September/75.html
REPOSITORY
R240 Extra CMake Modules
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3ebb3c09e512: SQL: various improvements and fix
if/case/loop/end detection with SQL (Oracle) (authored by jpoelen).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D11470?vs=32861=40010#toc
jpoelen added a comment.
Yes, my compilation folder was pointing to my fork on github from which I
make the patches (as I do not have the right version for ECM, I have a script
that does among other things a new CMakeLists.txt in another folder and adds
symbolic links for project files).
aacid added a comment.
Can you please replace your setLocale call in initTestCase for
void initLocale()
{
setenv("LC_ALL", "en_US.utf-8", 1);
}
Q_CONSTRUCTOR_FUNCTION(initLocale)
This should make it work (or at least it does here)
REPOSITORY
R244 KCoreAddons
On Sun, Aug 19, 2018 at 10:29 PM David Faure wrote:
>
> On lundi 13 août 2018 11:08:24 CEST Ben Cooksley wrote:
> > Hi David,
> >
> > Unfortunately it doesn't look like the fix we put in place on Saturday did
> > the trick.
> >
> > I have a feeling that QStandardPaths on Windows at least will
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/108/
Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
Date of build:
Sun, 19 Aug 2018 16:07:36 +
Build duration:
1 min 49 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/164/
Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
Date of build:
Sun, 19 Aug 2018 16:07:36 +
Build duration:
1 min 45 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ee8969a8437f: fix reference files empty lines have
different attributes after the fixes to… (authored by cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14603?vs=40004=40006#toc
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
The unit tests fail du to errors like:
-
-
+
+
Could it be your local version wasn't up to date?
I will regen the references, I see only empty lines change their
aacid updated this revision to Diff 40005.
aacid added a comment.
Use Q_ASSERT_X
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14922?vs=39980=40005
BRANCH
arcpatch-D14922
REVISION DETAIL
https://phabricator.kde.org/D14922
AFFECTED FILES
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/107/
Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
Date of build:
Sun, 19 Aug 2018 15:50:51 +
Build duration:
5 min 18 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/163/
Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
Date of build:
Sun, 19 Aug 2018 15:50:51 +
Build duration:
5 min 40 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and
Selector Tag highlighting (authored by jpoelen).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14603?vs=39067=40004#toc
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0c8cd4076b7d: kdirlistertest doesnt fail at random
(authored by jtamate).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11604?vs=39991=3
REVISION DETAIL
On Sun, 19 Aug 2018, 12:19 David Faure, wrote:
> On lundi 13 août 2018 11:06:12 CEST Ben Cooksley wrote:
> > On Mon, Aug 13, 2018 at 1:16 AM David Faure wrote:
> > > On samedi 11 août 2018 07:02:18 CEST Ben Cooksley wrote:
> > > > On Fri, Aug 10, 2018 at 7:28 PM David Faure wrote:
> > > > >
markg added a comment.
It "looks" oke to me, but i don't know this code one bit.
INLINE COMMENTS
> recentdocuments.cpp:82-83
> +if (urlInside.scheme() == "recentdocuments"
> +// Filter out things that can't be viewed in a file
> manager because they don't
dfaure created this revision.
dfaure added reviewers: adridg, arichardson.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.
REVISION SUMMARY
When /home is a symlink, for instance (as is
On lundi 13 août 2018 11:08:24 CEST Ben Cooksley wrote:
> Hi David,
>
> Unfortunately it doesn't look like the fix we put in place on Saturday did
> the trick.
>
> I have a feeling that QStandardPaths on Windows at least will also consider
> the Qt install prefix in addition to the local to the
On lundi 13 août 2018 11:06:12 CEST Ben Cooksley wrote:
> On Mon, Aug 13, 2018 at 1:16 AM David Faure wrote:
> > On samedi 11 août 2018 07:02:18 CEST Ben Cooksley wrote:
> > > On Fri, Aug 10, 2018 at 7:28 PM David Faure wrote:
> > > > Any idea why purpose can't find the KIO http and file
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Those comments were all for a single line of code ;)
But yes, your last change is exactly what I meant. "wait for nothing" is when
waiting for a spy to get to 0.
The line above that
jtamate updated this revision to Diff 39991.
jtamate marked an inline comment as done.
jtamate added a comment.
I'm never sure at how many lines the comments affects, but the last one
should be:
QTRY_COMPARE(m_dirLister.spyClear.count(), 1);
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Thanks. Almost there :-)
INLINE COMMENTS
> kdirlistertest.cpp:658
> +QTRY_COMPARE(dirLister2.spyStarted.count(), 1);
> QCOMPARE(dirLister2.spyCompleted.count(), 1);
>
jtamate updated this revision to Diff 39990.
jtamate marked 11 inline comments as done.
jtamate added a comment.
Fixed the inline comments.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11604?vs=39836=39990
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> kcatalog.cpp:188
> if (language != currentLanguage || !bindDone) {
> +Q_ASSERT(QCoreApplication::instance() && "You need to instantiate a
> Q*Application before using KCatalog");
> +if (!QCoreApplication::instance()) {
25 matches
Mail list logo
