D15071: Don't draw frames and shadows around images with transparency

anthonyfieroni added a comment. In D15071#315839 , @broulik wrote: > Why did the `ThumbCreator` frame flag get deprecated in the first place? https://git.reviewboard.kde.org/r/129921/ maybe because it's deprecated before thumbnail got

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/35/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Mon, 27 Aug 2018 03:47:40 + Build duration: 35 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/4/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 27 Aug 2018 03:47:50 + Build duration: 31 min and counting CONSOLE OUTPUT

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 204 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/204/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Aug 2018 03:48:20 + Build duration: 19 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/61/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Aug 2018 03:47:40 + Build duration: 11 min and counting JUnit

D15071: Don't draw frames and shadows around images with transparency

ngraham added a comment. In D15071#315839 , @broulik wrote: > I'm a bit concerned that removing the frame most of the time blurs the lines between "previews of images" and "actual file icons", especially for the SVG case. Thing is, this

D14940: kformattest: Use plural suffix (s) consequently

aacid added a comment. In D14940#315172 , @habacker wrote: > https://forum.wordreference.com/threads/decimals-plural-singular.2054431/#post-10279600 listed many public organisations that are using signular for values between 1 and -1.

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns added a reviewer: Frameworks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, apol, #frameworks Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D15071: Don't draw frames and shadows around images with transparency

broulik added a comment. I'm a bit concerned that removing the frame most of the time blurs the lines between "previews of images" and "actual file icons", especially for the SVG case. Now they all look like proper file icons rather than previews of the file's contents. I can see that

D15076: Build failures with KSyntaxHighlighting 5.49

asemke added a comment. In D15076#315803 , @cgiboudeaux wrote: > In D15076#315797 , @asemke wrote: > > > > > > > > >

D15076: Build failures with KSyntaxHighlighting 5.49

cgiboudeaux added a comment. In D15076#315797 , @asemke wrote: > > /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: cannot open output file ../../../bin/cantor/backends/cantor_nullbackend.so: Not a

D15091: Compile python bindings with the same sipname used by PyQt

arojas added inline comments. INLINE COMMENTS > bruns wrote in run-sip.py:11 > Is there a gurantee `-n` and its arg are space separated? > > otherwise: > > import re > m = re.search('-n\s*(\S+)', PYQT_CONFIGURATION["sip_flags"]) > if m: > sipArgs = ['-n', m.group(1)] + sipArgs I

D15091: Compile python bindings with the same sipname used by PyQt

arojas marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

arojas updated this revision to Diff 40479. arojas added a comment. Use a regex to account for the case where -n an its arg are not space-separated REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=40477=40479 REVISION DETAIL

D15076: Build failures with KSyntaxHighlighting 5.49

asemke added a comment. In D15076#315583 , @cgiboudeaux wrote: > In D15076#315506 , @mpyne wrote: > > > I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So

D15090: solid/udisks2: Add support for categorized logging

This revision was automatically updated to reflect the committed changes. Closed by commit R245:8b921f53ae5c: solid/udisks2: Add support for categorized logging (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15090?vs=40476=40478 REVISION

D15090: solid/udisks2: Add support for categorized logging

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D15090 To: bruns, #frameworks, broulik Cc: broulik, kde-frameworks-devel, michaelh,

D15089: Add syntax highlighting for SELinux kernel policy language

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH add-selinux REVISION DETAIL https://phabricator.kde.org/D15089 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D15091: Compile python bindings with the same sipname used by PyQt

bruns added inline comments. INLINE COMMENTS > run-sip.py:11 > +from PyQt5.Qt import PYQT_CONFIGURATION > +pyqt_sip_flags = PYQT_CONFIGURATION["sip_flags"].split(' ') > +index_n = pyqt_sip_flags.index('-n') Is there a gurantee `-n` and its arg are space separated? otherwise:

D15091: Compile python bindings with the same sipname used by PyQt

arojas created this revision. arojas added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY PyQt>=5.11 is compiled with the 'PyQt5.sip'

D14912: Bindings: Make generator forward compatible with Python 3

arojas added a comment. In D14912#315763 , @bruns wrote: > Thats on Arch? Yes REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel,

D14912: Bindings: Make generator forward compatible with Python 3

bruns added a comment. In D14912#315733 , @arojas wrote: > With this + D14914 + D14915 I can successfully compile bindings without having any python2 package installed.

D15090: solid/udisks2: Add support for categorized logging

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Allow users to enable/disable messages from the UDisks2 backend to aid debugging

D15089: Add syntax highlighting for SELinux kernel policy language

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15089 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D11945: Improve highlighting of SELinux CIL policies & file contexts

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham,

D15089: Add syntax highlighting for SELinux kernel policy language

nibags added a dependent revision: D11945: Improve highlighting of SELinux CIL policies & file contexts. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15089 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D11945: Improve highlighting of SELinux CIL policies & file contexts

nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting. nibags changed the visibility from "No One" to "Public (No Login Required)". nibags changed the edit policy from "No One" to "All Users". nibags added a dependency: D15089: Add

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/3/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 26 Aug 2018 14:49:06 + Build duration: 3 hr 17 min and counting JUnit Tests

D14912: Bindings: Make generator forward compatible with Python 3

arojas added a comment. With this + D14914 + D14915 I can successfully compile bindings without having any python2 package installed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D12127: Do not query properties when no interfaces are left

bruns added a comment. This has been open for more than 4! months now ...  REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12127 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D15089: Add syntax highlighting for SELinux kernel policy language

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15089 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D15089: Add syntax highlighting for SELinux kernel policy language

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add syntax highlighting for

D12127: Do not query properties when no interfaces are left

bruns added a reviewer: broulik. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12127 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D14915: Bindings: Check if bindings can be generated for a specific python version

bruns updated this revision to Diff 40471. bruns edited the summary of this revision. bruns edited the test plan for this revision. bruns added a comment. Also check for sip.h in the default paths (e.g. /usr/include/) REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 226 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/226/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 26 Aug 2018 14:49:06 + Build duration: 15 min and counting JUnit Tests Name: (root)

D15000: Display mounted file system type and mounted from fields in properties dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9e706796b152: Display mounted file system type and mounted from fields in properties dialog (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

xciml updated this revision to Diff 40467. xciml marked an inline comment as done. xciml added a comment. In D14236#315639 , @cullmann wrote: > I am not sure about the default argument for title, why not just have there QString() and in the code

D14915: Bindings: Check if bindings can be generated for a specific python version

bruns planned changes to this revision. bruns added a comment. sure ... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14915 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15000: Display mounted file system type and mounted from fields in properties dialog

broulik accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

vkrause added a comment. In D14236#315639 , @cullmann wrote: > Otherwise: Volker, what do you think? Fine with me, the features/changes make sense IMHO. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D15084: Change documentation to reflect the real toolchain CMake name

This revision was automatically updated to reflect the committed changes. Closed by commit R240:206c5123c37e: Change documentation to reflect the real toolchain CMake name (authored by bport). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

cullmann added a comment. I am not sure about the default argument for title, why not just have there QString() and in the code instead of isNull() an isEmpty => use file name fallback. The definitionForMimeType must perhaps use the priority, too, if there are duplicates, like the

Re: New framework: KF5Syndication

On Monday, 20 August 2018 22:51:44 CEST David Faure wrote: > On samedi 18 août 2018 15:38:48 CEST Volker Krause wrote: > > On Wednesday, 22 April 2015 21:44:05 CEST Daniel Vrátil wrote: > > > Hi all, > > > > > > I'd like to ask for review of another Framework from kdepimlibs: > > > KF5Syndication

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann abandoned this revision. cullmann added a comment. I fixed the hl files, I removed the stray Asterisk stuff, that was no proper HL for such files, they are more or less only normal .ini files, added .conf as end for ini. Indexer is checked in, too. I will do a new request for a

D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

cullmann added a comment. I will add the internal stuff like the wildcard check and the removed/fixed hls. I will not add the regex changes and any public API, I want to think about that once more first. That isn't that urgent anyways. KTextEditor uses its own code for that and the only

D14915: Bindings: Check if bindings can be generated for a specific python version

arojas added a comment. sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14915 To: bruns, #frameworks Cc: arojas,

D15076: Build failures with KSyntaxHighlighting 5.49

cgiboudeaux added a comment. In D15076#315506 , @mpyne wrote: > I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So presumably the change in behavior is something introduced in that release of ECM?

D15000: Display mounted file system type and mounted from fields in properties dialog

shubham added a comment. @cfeck @broulik any comments on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns