D14632: keyword rule: Spport for keywords inclusion from another language/file

[Christoph Cullmann]

cullmann added a comment.


  I don't know if the added complexity for loading only keywords is needed, but 
in any case one needs some recursive keyword resolving with a cycle guard.
  e.g. if you use a list that again includes another one.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 224 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/224/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 18 Sep 2018 04:57:46 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13114)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

D13315: Detect mime type of local files based on their contents

[Nathaniel Graham]

ngraham added a reviewer: broulik.
ngraham added a comment.


  @broulik, given your recent crusade against blocking calls, can you think of 
a better way to do this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13315

To: miklosm, #frameworks, dfaure, broulik
Cc: broulik, ngraham, apol, kde-frameworks-devel, michaelh, bruns

D13315: Detect mime type of local files based on their contents

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13315

To: miklosm, #frameworks, dfaure
Cc: broulik, ngraham, apol, kde-frameworks-devel, michaelh, bruns

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added reviewers: Frameworks, Dolphin, dfaure, elvisangelaccio.
ngraham set the repository for this revision to R320 KIO Extras.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D13416

To: miklosm, #frameworks, #dolphin, dfaure, elvisangelaccio

D13316: manually set format in jpeg thumbnail creator

[Nathaniel Graham]

ngraham added a comment.


  @miklosm, can this go in now, or it is dependent on either of your other two 
patches?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D13316

To: miklosm, dfaure, elvisangelaccio, #frameworks
Cc: ngraham

D13316: manually set format in jpeg thumbnail creator

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D13316

To: miklosm, dfaure, elvisangelaccio, #frameworks
Cc: ngraham

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 403 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/403/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 18 Sep 2018 02:22:45 +
 Build duration:
7 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31967/60003)38%
(16477/43902)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9061/9493)48%
(4278/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8309/14370)50%
(4639/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3892/7924)34%
(1584/4665)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(698/1373)42%
  

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/17/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 18 Sep 2018 02:22:45 +
 Build duration:
2 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on Windows Builder 2 in C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests: The process cannot access the file because it is being used by another process.	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)	at java.nio.file.Files.deleteIfExists(Unknown Source)	at hudson.Util.tryOnceDeleteFile(Util.java:316)	at hudson.Util.deleteFile(Util.java:272)Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from artonis.kde.org/195.201.167.115:49678		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at hudson.FilePath.act(FilePath.java:1070)		at hudson.FilePath.act(FilePath.java:1059)		at hudson.FilePath.deleteRecursive(FilePath.java:1266)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		at java.util.concurrent.FutureTask.run(FutureTask.java:266)		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)		at java.lang.Thread.run(Thread.java:748)Caused: java.io.IOException: Unable to delete 'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.	at hudson.Util.deleteFile(Util.java:277)	at hudson.FilePath.deleteRecursive(FilePath.java:1303)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1312)	at hudson.FilePath.deleteRecursive(FilePath.java:1294)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1312)	at hudson.FilePath.deleteRecursive(FilePath.java:1294)	at hudson.FilePath.access$1600(FilePath.java:211)	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1272)	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1268)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3084)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)	at java.lang.Thread.run(Unknown Source)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D15557: Improve "insufficient disk space" error message

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15557: Improve "insufficient disk space" error message

[Nathaniel Graham]

ngraham retitled this revision from "Improve "insufficient disk space" error 
messgae" to "Improve "insufficient disk space" error message".

REPOSITORY
  R241 KIO

BRANCH
  improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15557: Improve "insufficient disk space" error messgae

[Shubham]

shubham added a comment.


  Maybe "Dont have enough space available on the disk"

REPOSITORY
  R241 KIO

BRANCH
  improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15583: [Balooctl] fix directory parent check

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Baloo, Dolphin, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  [Submitting this patch on behalf of James Ausmus, who attached it to 
https://bugs.kde.org/show_bug.cgi?id=396535 and did not respond to a request to 
submit it here]
  
  balooctl add includeFolders/excludeFolders was checking for parent
  directories using a startsWith string match, so directories with the
  same initial character would match - for example:
  
$ balooctl add excludeFolders t
$ balooctl add excludeFolders test
Parent folder /test/kde/baloo/t is already in the list of exclude folders
  
  Fix this by appending a path separator to the path used for parent
  checking.
  
  BUG: 396535
  FIXED-IN: 5.51

TEST PLAN
  Executed the test plan from https://bugs.kde.org/show_bug.cgi?id=396535; it 
works now.

REPOSITORY
  R293 Baloo

BRANCH
  fix-hyphen-in-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15583

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: ngraham, #baloo, #dolphin, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/16/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 17 Sep 2018 22:37:59 +
 Build duration:
1 hr 21 min and counting
   JUnit Tests
  Name: (root) Failed: 27 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiocore-deletejobtestFailed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kfileitemtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiocore-mkpathjobtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-jobguitestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kdynamicjobtrackernowidgetstestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kpasswdservertest

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  (I inadvertently edit the operators list in the previous commit)
  
  Finally, I added a parameter to `load()` and `loadHighlighting()` rather than 
a new function because there was a lot of code duplication.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen updated this revision to Diff 41872.
jpoelen added a comment.


  - restore operators list
  - lazy load keyword lists

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14632?vs=41298=41872

BRANCH
  kwinclude

REVISION DETAIL
  https://phabricator.kde.org/D14632

AFFECTED FILES
  data/schema/language.xsd
  data/syntax/scss.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/definition.cpp
  src/lib/definition_p.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D15582: Reference product "KF5" in widget metadata, instead of "KDE"

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  kdeiskf5now

REVISION DETAIL
  https://phabricator.kde.org/D15582

AFFECTED FILES
  src/kde.widgets

To: kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 223 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/223/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 23:11:58 +
 Build duration:
3 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13114)19%
(1820/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/28/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 23:08:59 +
 Build duration:
2 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7100/9495)55%
(3475/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(775/1378)44%
(294/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3313/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/40/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 23:08:59 +
 Build duration:
2 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7100/9495)55%
(3471/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3137)51%
(1259/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(776/1378)44%
(293/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3313/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/76/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 23:02:34 +
 Build duration:
4 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1153/2121)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(144/461)26%
(131/506)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/54/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 23:02:34 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1153/2121)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(144/461)26%
(131/506)

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 23 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/23/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 17 Sep 2018 23:02:34 +
 Build duration:
38 sec and counting
   CONSOLE OUTPUT
  [...truncated 73.25 KB...]  "KF5DocTools" provides a separate development package or SDK, be sure it  has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5DBus * Qt5 (required version >= 5.8.0) * KF5Archive (required version >= 5.50.0) * Gettext * KF5I18n (required version >= 5.50.0) * KF5CoreAddons (required version >= 5.50.0) * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Core * Qt5Test (required version >= 5.8.0)   Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.50.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks/kpackage/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target mockhandler_autogenScanning dependencies of target testpackage-rccScanning dependencies of target KF5Package_autogen[  1%] Automatic MOC for target mockhandler[  5%] Generating testpackage-rcc/contents.rcc[  5%] Automatic MOC for target KF5Package[  5%] Built target mockhandler_autogen[  5%] Built target testpackage-rcc[  5%] Built target KF5Package_autogen[  6%] Automatic RCC for kpackage.qrcScanning dependencies of target mockhandler[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.o[ 10%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Package[ 11%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 13%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 15%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.o[ 20%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejobthread.cpp.o[ 22%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/versionparser.cpp.o[ 23%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/version.cpp.o[ 25%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/kpackage_debug.cpp.o[ 27%] Linking CXX executable ../../bin/mockhandler[ 27%] Built target mockhandler[ 28%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/mocs_compilation.cpp.o[ 30%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/EWIEGA46WW/qrc_kpackage.cpp.o[ 32%] Linking CXX shared library ../../bin/libKF5Package.so/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 402 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/402/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 22:37:59 +
 Build duration:
7 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)52%
(30967/59998)36%
(15869/43902)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(55/56)98%
(55/56)87%
(8211/9481)43%
(3878/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)56%
(8106/14365)48%
(4467/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7924)34%
(1586/4665)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/112/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 22:27:19 +
 Build duration:
4 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6333/8428)43%
(10169/23445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2703/2776)49%
(5813/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/56/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 22:27:19 +
 Build duration:
3 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8428)43%
(10156/23441)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2700/2776)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D15479: fix for macOS

[Yurii Kolesnykov]

yurikoles added a comment.


  In D15479#325443 , @bcooksley 
wrote:
  
  > Does this still build on Linux systems?
  
  
  I have problems building it under Linux even without a patch. I had tried 
Arch AUR (kdnssd-git) and Ubuntu 18.10 (cosmic), which has `kdnssd-kf5-5.50.0` 
in archive.
  
Error: Input 
/home/yurikoles/kdnssd-kf5-5.50.0/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml
 is not a file or cannot be accessed

Error: Input 
/home/yurikoles/kdnssd-kf5-5.50.0/src/org.freedesktop.Avahi.ServiceBrowser.xml 
is not a file or cannot be accessed

Error: Input 
/home/yurikoles/kdnssd-kf5-5.50.0/src/org.freedesktop.Avahi.DomainBrowser.xml 
is not a file or cannot be accessed

make[3]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:91: 
src/avahi_servicetypebrowser_interface.cpp] Error 1
make[3]: *** Waiting for unfinished jobs
make[3]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:69: 
src/avahi_domainbrowser_interface.cpp] Error 1
make[3]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:80: 
src/avahi_servicebrowser_interface.cpp] Error 1
make[3]: Leaving directory 
'/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:3996: src/CMakeFiles/KF5DNSSD.dir/all] 
Error 2
make[2]: *** Waiting for unfinished jobs
qt.qpa.plugin: Could not find the Qt platform plugin "minimal" in ""
This application failed to start because no Qt platform plugin could be 
initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)
make[3]: Leaving directory 
'/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
[ 84%] Built target KF5DNSSD_QCH
make[2]: Leaving directory 
'/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:144: all] Error 2
make[1]: Leaving directory 
'/home/yurikoles/kdnssd-kf5-5.50.0/obj-x86_64-linux-gnu'
dh_auto_build: cd obj-x86_64-linux-gnu && make -j8 "INSTALL=install 
--strip-program=true" returned exit code 2
make: *** [debian/rules:7: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
debuild: fatal error at line 1152:
dpkg-buildpackage -rfakeroot -us -uc -ui -b failed

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D15479

To: yurikoles, arichardson
Cc: bcooksley, arichardson, yurikoles, kde-frameworks-devel, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 246 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/246/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 17:47:27 +
 Build duration:
5 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(32016/60002)38%
(16500/43902)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9061/9493)48%
(4278/8928)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8366/14371)50%
(4660/9283)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3892/7924)34%
(1584/4665)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(698/1373)42%

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 15 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/15/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 17 Sep 2018 17:47:28 +
 Build duration:
1.3 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on Windows Builder 2 in C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests: The process cannot access the file because it is being used by another process.	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)	at java.nio.file.Files.deleteIfExists(Unknown Source)	at hudson.Util.tryOnceDeleteFile(Util.java:316)	at hudson.Util.deleteFile(Util.java:272)Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from artonis.kde.org/195.201.167.115:49678		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at hudson.FilePath.act(FilePath.java:1070)		at hudson.FilePath.act(FilePath.java:1059)		at hudson.FilePath.deleteRecursive(FilePath.java:1266)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		at java.util.concurrent.FutureTask.run(FutureTask.java:266)		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)		at java.lang.Thread.run(Thread.java:748)Caused: java.io.IOException: Unable to delete 'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.	at hudson.Util.deleteFile(Util.java:277)	at hudson.FilePath.deleteRecursive(FilePath.java:1303)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1312)	at hudson.FilePath.deleteRecursive(FilePath.java:1294)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1312)	at hudson.FilePath.deleteRecursive(FilePath.java:1294)	at hudson.FilePath.access$1600(FilePath.java:211)	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1272)	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1268)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3084)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)	at java.lang.Thread.run(Unknown Source)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D14006: Fix WebDAV destination header on COPY and MOVE operations

[Daniel Nicoletti]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1f24f49baba4: Fix WebDAV destination header on COPY and 
MOVE operations (authored by dantti).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14006?vs=37460=41858

REVISION DETAIL
  https://phabricator.kde.org/D14006

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: dantti, dfaure, #frameworks, #dolphin
Cc: bruns, anthonyfieroni, ngraham, kde-frameworks-devel, michaelh

D14072: Don't try to restore invalid user places

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Shouldn't this skip the invalid bookmark rather than abort completely ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14072

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13316: manually set format in jpeg thumbnail creator

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D13316

To: miklosm, dfaure, elvisangelaccio, #frameworks
Cc: ngraham

D13676: Make it possible to change directory up even with trailing slashes in the url

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13676

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15096

To: broulik, dfaure, fvogt, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  FullyEncoded makes perfect sense for sending in a protocol implementation.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14006

To: dantti, dfaure, #frameworks, #dolphin
Cc: bruns, anthonyfieroni, ngraham, kde-frameworks-devel, michaelh

D15573: replace custom backtracing in SlaveBase with KCrash

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15573

To: sitter, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15220: implement more basic tags for taglibwriter

[Alexander Stippich]

astippich added a comment.


  In D15220#325580 , @bruns wrote:
  
  > Can you add some Unicode exercising tests?
  
  
  I plan to extend the tests in a later patch, if you don't mind, I would 
prefer to add this there.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:18
> Side note - bad implementation, see D13700 
> 
> 
> Also see inverse q2t in taglibwritertest.cpp

I have that on my todo list to switch to taglib's builtin functions

> bruns wrote in taglibwriter.cpp:67
> Tracknumber can be negative AFAIK, "Hidden track"

taglib only allows unsigned int for year and track, so I don't know how that's 
possible with taglib.
I added checks to ensure only values greater zero are written to it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15220

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15220: implement more basic tags for taglibwriter

[Alexander Stippich]

astippich updated this revision to Diff 41856.
astippich added a comment.


  - check for values greater than zero for tracknumber and year

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15220?vs=40861=41856

BRANCH
  taglib_write

REVISION DETAIL
  https://phabricator.kde.org/D15220

AFFECTED FILES
  autotests/taglibwritertest.cpp
  src/writers/taglibwriter.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/51/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 15:20:47 +
 Build duration:
4 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/107/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 15:20:47 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:39cdcdf6c1d5: kcfg_compiler now documents valid inputs 
for its Color type (authored by sitter).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15576?vs=41837=41849

REVISION DETAIL
  https://phabricator.kde.org/D15576

AFFECTED FILES
  src/kconfig_compiler/README.dox

To: sitter, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15557: Improve "insufficient disk space" error messgae

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R241 KIO

BRANCH
  improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15557: Improve "insufficient disk space" error messgae

[Andres Betts]

abetts added a comment.


  In D15557#327094 , @ngraham wrote:
  
  > We can't use the words "file" or "move" since this part of the code can't 
know whether the user is moving or copying, or whether the thing being moved or 
copied is a file or a directory. Adjusting the code here to know those pieces 
of information not easily possible and would involve patches to multiple other 
repos--and it's also out of scope for this patch. :)
  
  
  Not married to any string. I think the patch is already improving it, just 
showing some perspective. I guess my main angle is to communicate the 
information as soon as the sentence starts. Something like "Not enough" or 
"Unable to" right off the bat so it can have a more immediate understanding 
from the user. ;)

REPOSITORY
  R241 KIO

BRANCH
  improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15576

To: sitter, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

[Harald Sitter]

sitter added a subscriber: broulik.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D15576

To: sitter
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it wasn't exactly clear what the inputs for a Color type may be. this is
  now explained along with special type descriptions. it isn't perfectly
  ideal here since it is a bit hard to find, but better be hard to find
  than not documented at all.
  
  from a quick glance at the code indeed anything goes that QColor can
  construct from a QString. there is also custom regex code in the compiler
  that allows construction from r,g,b,a via the appropriate ctor of qcolor.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15576

AFFECTED FILES
  src/kconfig_compiler/README.dox

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D8708#326590 , @dhaumann wrote:
  
  > What I would like to see is a comment // KF6: Merge 
KTextEditor::AnnotationViewInterfaceV2 into 
KTextEditor::AnnotationViewInterface (kossebau).
  >  For me, this comment is really important, since this tells you that you 
will in 2-3 years (when Qt6 arrives) work on this and merge it down: Since 
there is only you (KDevelop) who is using this interface, so you have to 
maintain it ;)
  
  
  Forgot that in the previous update, now added. Curious though why you do not 
expect Kate to offer users some similar annotation display experience one day 
if working on versioned text documents ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8708

To: kossebau, #kate, #kdevelop
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

[TheAssassin]

TheAssassin added a comment.


  The AppImage project doesn't do any versioning right now. We've recently 
extracted libappimage into a separate project to be able to start versioning of 
it, as projects like KDE expect and somehow need that. We're discussing a 
suitable versioning scheme right now. Please feel free to participate in the 
discussion in https://github.com/AppImage/AppImageKit/issues/849, and add your 
point of view.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15417

To: broulik, #frameworks, TheAssassin, anthonyfieroni

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 41828.
kossebau added a comment.


  also add todo about merging KTextEditor::AnnotationViewInterfaceV2 into 
KTextEditor::AnnotationViewInterface

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=41778=41828

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/utils/ktexteditor.cpp
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau, #kate, #kdevelop
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

[Anthony Fieroni]

anthonyfieroni added a comment.


  Maybe it's better to make new code conditional to version that satisfy 
appimage_read_file_into_buffer_following_symlinks

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15417

To: broulik, #frameworks, TheAssassin, anthonyfieroni

D15573: replace custom backtracing in SlaveBase with KCrash

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  as discussed on mailing list.
  
  KCrash originally was automatically initialized, but now needs to be
  explicitly linked to work.
  additionally the custom backtrace() in the SlaveBase is only marginally
  useful and largely replaced by improvements to KCrash (such as core pattern
  support on linux to allow raising crashes to a global core collector such
  as systemd's coredumpd).
  
  If someone wants to resurrect the custom backtrace() feature it needs to
  be moved to KCrash and actually made signal-safe (explicitly load libgcc;
  see backtrace manpage).
  
  CHANGELOG: KIO slave crashes are now handled by KCrash instead of subpar 
custom code

TEST PLAN
  - q_assert(false) in a slave now brings up drkonqi

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15573

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/ConfigureChecks.cmake
  src/core/config-kiocore.h.cmake
  src/core/slavebase.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 50 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/50/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 11:42:22 +
 Build duration:
4 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

[Laurent Montel]

mlaurent added a comment.


  I fixed 2 repos.
  Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some 
module is not compiles on my computer)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15566

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 106 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/106/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 11:42:22 +
 Build duration:
1 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

[Anthony Fieroni]

anthonyfieroni requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15417

To: broulik, #frameworks, TheAssassin, anthonyfieroni

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

[Anthony Fieroni]

anthonyfieroni added a comment.


  
https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/CMakeLists.txt$10
  
  It should be specified the version that contains 
appimage_read_file_into_buffer_following_symlinks

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15417

To: broulik, #frameworks, TheAssassin, anthonyfieroni

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir requested review of this revision.
leinir added a comment.


  Previous patch had BIC issues - new patch attempts to address this, but as a 
result (of course) requires another round of review.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 41815.
leinir added a comment.


  After discovering that the previous version of this patch had introduced a 
binary incompatibility, and panicking momentarily that this had been done in a 
release, Jonathan reverted it (as i was away for a bit and unable to do so 
myself). The patch here attempts to fix the BIC issue, while also readjusting 
the logic for how the tag filters reach the provider. It is now done directly 
by the provider itself, rather than through each search request. While this 
does introduce that nasty d-pointer hack, it also makes more logical sense that 
the Provider itself holds the information (as that's where those filters are 
directly relevant). So, nasty surprise to find out i'd caused things to break, 
but the end result is, i think, kind of better anyway (even though it 
introduces that todo for kf-next).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6513?vs=41133=41815

REVISION DETAIL
  https://phabricator.kde.org/D6513

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/entryinternal.h
  src/core/provider.cpp
  src/core/provider.h
  src/core/tagsfilterchecker.cpp
  src/core/tagsfilterchecker.h
  src/staticxml/staticxmlprovider.cpp
  tests/CMakeLists.txt
  tests/khotnewstuff_test-ui/main.qml
  tests/khotnewstuff_test-ui/main.qmlc
  tests/khotnewstuff_test.knsrc.in
  tests/knewstuff2_test.cpp
  tests/knewstuff2_test.h
  tests/knewstuff2_test.knsrc
  tests/testdata/entry.xml
  tests/testdata/provider.xml

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D15443: [server] Allow multiple touch interfaces per client

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> seat_interface.cpp:1332
> -d->touchInterface.focus.touch->down(id, serial, globalPosition - 
> d->touchInterface.focus.offset);
> -} else if (id == 0 && focusedTouchSurface()) {
>  #if HAVE_LINUX_INPUT_H

what happened to the 
if (id == 0 )

which is making sure if you multi touch we only send the first as a mouse event.

> seat_interface.cpp:1361
> +// note: this function may not be called after cancel,
> +// but for performance reasons still do not assert like in touchUp case?
>  Q_D();

If you have a release build Q_ASSERT get completely compiled out and no code 
will run.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

Re: kio slaves + kcrash + drkonqi

[Harald Sitter]

On Sun, Sep 16, 2018 at 10:48 AM David Faure  wrote:
> How about just killing the KDE_DEBUG check *and* the code that prints out a
> backtrace?

I'm always in favor of less code, so I'll prepare a diff for this.

> > - Possibly KCRASH_AUTO_RESTARTED needs setting by something in KIO.
> > From what I see, if I make a slave crash on every invocation, KIO
> > would try to repeat the action it wanted to do by restarting the salve
> > ad infinitum when instead it should abort at some point so as to not
> > spam the user with drkonqis.
>
> I don't see why KIO would try to repeat the action.
> The app creates a job, it fails because the kioslave crashed, end of story.
> There is no autorestart here.
>
> Although, I can imagine that if you copy one directory with 1000 files and the
> kioslave only crashes in the file copy code, you'd get 1000 drkonqis.
> But this seems a bit corner case and is all unrelated to this KF5 porting
> issue (the missing call to KCrash::initialize).

I had an assert fail in GetFileSystemFreeSpace which caused a drkonqi
to repeatedly start, but with what I've learned since then I think
that was caused by dolphin repeatedly trying to get the info. This
isn't something restart handling would or could prevent. With that in
mind this type of issue likely needs solving in drkonqi, i.e. I think
the problem is with the presentation of the repeated crashing more
than the crashing itself.

> > The end result is that we still have the stderr backtrace, which I
> > think is very useful.
>
> Did you test it? Was it really useful?

Well, it was more useful than no backtrace at all, but as you say the
actual symbol names are useless as far as the salve is concerned.

> > In fact, by dropping the KDE_DEBUG condition
> > it's always enabled even when the user disables drkonqi using
> > KDE_DEBUG=1.
>
> Either this is unsafe (because of memory allocations) and we shouldn't do it,
> or if we think it's safe and useful, then as you say it should be done by
> kcrash. Conclusion, no, this code shouldn't be kept at all in SlaveBase...
>
> More details on whether this is safe: the man page says
>
> "backtrace() and backtrace_symbols_fd() don't call malloc() explicitly, but
> they are part of libgcc, which gets loaded dynamically when first used.
> Dynamic loading usually triggers a call to malloc(3).  If you need certain
> calls to these two functions to not allocate memory (in signal handlers, for
> example), you need to make sure libgcc is loaded beforehand."
>
> I'm pretty sure we don't do that...

I've had a look and indeed I can not find any explicit call to make
sure libgcc is loaded.

> > (In fact, I'd even argue that maybe kcrash itself should do the
> > backtrace() print. It seems useful in all crash scenarios I'd imagine,
> > in particular consider drkonqi can be disabled or not installed. But
> > then I don't know if/what performance penalty it'd entail with regards
> > to auto restarts.)
>
> My opinion is that a debugger is much better suited for getting useful
> backtraces (including parameter values, and the ability to inspect local
> variables).

Yes I agree.

So, the new plan is to remove the handler code from SlaveBase and
instead initialize KCrash. backtrace() code goes away entirely.
If someone wants the backtrace() feature it should be moved to KCrash
and before setting the crash handler libgcc needs to be explicitly
lazy-loaded with a call to any libgcc function. I would suggest people
check out coredumpd or another core handler though.

HS

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/21/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 10:10:11 +
 Build duration:
3 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)82%
(14/17)82%
(14/17)45%
(1613/3583)36%
(715/1991)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(272/378)53%
(76/144)src.imageformats91%
(10/11)91%
(10/11)44%
(1337/3071)36%
(637/1789)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/27/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 10:10:11 +
 Build duration:
57 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1484/3581)32%
(647/1991)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(282/378)53%
(77/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1198/3069)32%
(568/1789)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/20/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 17 Sep 2018 09:54:41 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)82%
(14/17)82%
(14/17)45%
(1613/3583)36%
(715/1983)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(272/378)53%
(76/144)src.imageformats91%
(10/11)91%
(10/11)44%
(1337/3071)36%
(637/1781)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/26/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 17 Sep 2018 09:54:41 +
 Build duration:
1 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1484/3581)33%
(647/1983)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(282/378)53%
(77/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1198/3069)32%
(568/1781)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image)

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R287:98c65a438dfb: [EPS] Fix crash at app shutdown (being 
tried to persist clipboard image) (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15405?vs=41341=41808#toc

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15405?vs=41341=41808

REVISION DETAIL
  https://phabricator.kde.org/D15405

AFFECTED FILES
  src/imageformats/eps.cpp

To: kossebau, zccrs, dfaure, pino
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image)

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R287 KImageFormats

BRANCH
  fixepscrashonappshutdown

REVISION DETAIL
  https://phabricator.kde.org/D15405

To: kossebau, zccrs, dfaure, pino
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

[David Faure]

dfaure added a comment.


  Looks OK now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14757

To: shubham, pino, dfaure, broulik, ngraham
Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

[David Faure]

dfaure added a comment.


  Do all frameworks build with this change?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15566

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

[Vlad Zagorodniy]

zzag added a comment.


  Ping.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D15353

To: zzag, #kwin
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns