D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. I can live with the second kind of loading state, but in any case one needs to fix the recursion detection and handling of nested included keyword lists. e.g. a includes b includes c ATM I think "something" will happen REPOSITORY R216 Syntax Highlighting

D15778: Log wallet open failure errors

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwalletd.cpp:685 > +const auto errorStr = > KWallet::Backend::openRCToString(rc); > +qWarn

D15780: YAML: add literal & folded block styles

turbov accepted this revision. turbov added a comment. This revision is now accepted and ready to land. Good job! @dhaumann, my +1 REPOSITORY R216 Syntax Highlighting BRANCH fix-literal-style-yaml REVISION DETAIL https://phabricator.kde.org/D15780 To: nibags, cullmann, dhaum

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/11/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 26 Sep 2018 20:52:26 + Build duration: 9 min 27 sec and counting JUnit Tests

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/54/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 26 Sep 2018 20:52:26 + Build duration: 4 min 28 sec and counting JUnit Tests Name: (root) Fa

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/110/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 26 Sep 2018 20:52:26 + Build duration: 4 min 12 sec and counting JUnit Tests Name: (root)

D11880: Add firewall-config and firewall-applet icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:61ac11747089: Add firewall-config and firewall-applet icons (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs

D11880: Add firewall-config and firewall-applet icons

ngraham added a comment. Shipping it! REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

abetts added a comment. Love it! Ship it! +100 REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

ngraham accepted this revision. ngraham added a comment. +1 ship it! Final #VDG review? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze,

D14632: keyword rule: Spport for keywords inclusion from another language/file

dhaumann added a comment. @cullmann Can you make a decision? I trust it will be a good one ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-d

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

This revision was automatically updated to reflect the committed changes. Closed by commit R236:953939b4727c: [KCollapsibleGroupBox] Respect style's widget animation duration (authored by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15611?vs=4

D15771: Logcat & SELinux: improvements for the new Solarized schemes

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH update-logcat-selinux REVISION DETAIL https://phabricator.kde.org/D15771 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-framew

D15780: YAML: add literal & folded block styles

dhaumann added a comment. I cannot really say much about it, since I never use YAML. Still, if the unit test works, then I am fine with this. +1 from my side. Anyone else with a +2? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15780 To: nibags, c

D15780: YAML: add literal & folded block styles

nibags retitled this revision from "YAML: add support for literal & folded block styles" to "YAML: add literal & folded block styles". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15780 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kw

D11880: Add firewall-config and firewall-applet icons

ndavis updated this revision to Diff 42390. ndavis added a comment. Add firewall-applet-shields_up icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=42257&id=42390 BRANCH firewalld-icons (branched from master) REVISION DETAIL https://p

D15780: YAML: add support for literal & folded block styles

nibags edited the summary of this revision. nibags edited the test plan for this revision. nibags added reviewers: cullmann, dhaumann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15780 To: nibags, cullmann, dhaumann, #frame

D11880: Add firewall-config and firewall-applet icons

bruns added a comment. In D11880#332426 , @ndavis wrote: > In D11880#332406 , @bruns wrote: > > > Looks good - can you provide an overview png of the complete firewall-applet icon set? I.e. the (now

D11880: Add firewall-config and firewall-applet icons

ndavis added a comment. In D11880#332406 , @bruns wrote: > Looks good - can you provide an overview png of the complete firewall-applet icon set? I.e. the (now four) status icons and the config icon? F6286904: firewall_icons.png

D15780: YAML: add support for literal & folded block styles

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-literal-style-yaml REVISION DETAIL https://phabricator.kde.org/D1578

D11880: Add firewall-config and firewall-applet icons

bruns added a comment. In D11880#332364 , @ndavis wrote: > How about this? F6286776: firewall-applet-shields_up.png Looks good - can you provide an overview png of the complete firewall-applet icon

D11880: Add firewall-config and firewall-applet icons

bruns added a comment. In D11880#332347 , @ndavis wrote: > I'm down to add a shields-up state icon. shields-down can just be the normal icon. Thats completely fine IMHO, we just need two different icons for shields up and down. REPOSITO

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

cullmann added a comment. Have you some backtrace from the crash? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15773 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,

D11880: Add firewall-config and firewall-applet icons

ndavis added a comment. How about this? F6286776: firewall-applet-shields_up.png REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc:

D15778: Log wallet open failure errors

arjun created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arjun requested review of this revision. REVISION SUMMARY Hopefully this would end up on syslog and grab the attention of the sysadmin. REPOSITORY R311 KWallet REVISION DETAIL

D11880: Add firewall-config and firewall-applet icons

ndavis added a comment. I'm down to add a shields-up state icon. REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel,

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY After upgrading to KDE Frame

D15644: Provide option to hide menu bar for Ksysguard

ngraham accepted this revision. ngraham added a comment. Looks perfect to me. BTW, you can mark inline comments as done by clicking in their checkboxes and then clicking Submit on the bottom of the page (I know, I know, it's a bit weird). @sitter, does this look good to you now? REVISIO

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham planned changes to this revision. ngraham added a comment. In D15194#328915 , @abetts wrote: > In D15194#328651 , @romangg wrote: > > > If there are more items than space available in the lis

D15771: Logcat & SELinux: improvements for the new Solarized schemes

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Some changes so that `logcat

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42368. lsartorelli added a comment. little clean up CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42350&id=42368 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsarto

D11880: Add firewall-config and firewall-applet icons

bruns added a comment. In D11880#332193 , @ngraham wrote: > So we need more icons, then? Preferably yes, but both would fall back to `firewall-applet` otherwise. REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from mast

D11880: Add firewall-config and firewall-applet icons

ngraham added a comment. So we need more icons, then? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, m

D11880: Add firewall-config and firewall-applet icons

bruns added a comment. In D11880#331724 , @ngraham wrote: > Never mind, it's a Cuttlefish issue. Everything looks good to me. > > Do we have final sign-off by other #VDG folks? Sorry to add some

D15644: Provide option to hide menu bar for Ksysguard

sitter added a subscriber: broulik. sitter added inline comments. INLINE COMMENTS > ksysguard.cpp:148 > + // set up 'Settings' menu > + mShowMenuBarAction = KStandardAction::showMenubar(this, > SLOT(toggleShowMenuBar()), actionCollection()); > @broulik just pointed out that KStandardAction

D15644: Provide option to hide menu bar for Ksysguard

sitter added a comment. Looks almost perfect to me. Only nit-pick I have is the fact that the include is out of order. Other than that it looks awesome 👍 INLINE COMMENTS > ksysguard.cpp:54 > #include > +#include > That should be sorted alphabetically. REVISION DETAIL https://phabric

D15644: Provide option to hide menu bar for Ksysguard

ngraham accepted this revision. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15510: Introduce HKDF

volkov added a reviewer: Frameworks. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks

D6513: Add support for Attica tags support

leinir updated this revision to Diff 42360. leinir added a comment. Address @cfeck's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=41886&id=42360 REVISION DETAIL https://phabricator.kde.org/D6513 AFFECTED FILES autotests/knewstuffe

D6513: Add support for Attica tags support

leinir marked 3 inline comments as done. leinir added a comment. In D6513#332106 , @cfeck wrote: > Using a hash to map public to private class is a good idea. The only thing I'm not sure about is if there is a memory leak. I would think that havin

D6513: Add support for Attica tags support

cfeck added a comment. Using a hash to map public to private class is a good idea. The only thing I'm not sure about is if there is a memory leak. I would think that having only pointers in the hash will never free the referenced values. INLINE COMMENTS > provider.cpp:44 > +if (!ret) >

D6513: Add support for Attica tags support

leinir added a comment. Sorry for pinging again, but i'd quite like this to get in, bic fixed and all that, before the next release... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfau

D15763: Set correct image attributes on directory thumbnail

broulik created this revision. broulik added reviewers: Frameworks, dfaure, anthonyfieroni, jtamate. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise `PreviewJob` will refu

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42350. lsartorelli added a comment. Removed unused parameter in toggleShowMenuBar() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42298&id=42350 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.c