D14449: Modify device usage information

[Pino Toscano]

pino added a comment.


  In D14449#335788 , @shubham wrote:
  
  > won't the pie chart representation look good, as we have in windows?
  
  
  That would be way too much wasted space for eye candy.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, ngraham, #frameworks, rkflx
Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, bruns

D14449: Modify device usage information

[Nathaniel Graham]

ngraham added a comment.


  A pie chart could work. But is there something wrong with the current 
representation?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, ngraham, #frameworks, rkflx
Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Nathaniel Graham]

ngraham added a comment.


  How can I test this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  #VDG  is finalizing a guideline for the 
use of emblems stating that they should only be used for non-default, uncommon, 
unusual, or unexpected  statuses. This is described in D15897 
.
  
  Accordingly, we should only show an emblem when a disk is unmounted, not when 
it's mounted. Being mounted is the expected status for a disk; being 
unmounted-but-visible-anyway is what's unusual and deserves an emblem.
  
  As an added bonus, this hugely improves the look of the Places panel by 
default.
  
  Closes T9740 

TEST PLAN
  Dolphin Places panel now:
  [image goes here]

REPOSITORY
  R245 Solid

BRANCH
  no-mounted-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15935

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

[David Faure]

dfaure added a comment.


  I guess the implicit part of the question is "what if kio-extras isn't 
installed ?".
  I assume it will lead to a broken item.
  
  So this should probably use a check like 
`KProtocolInfo::isKnownProtocol("recentdocuments")`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp

D7446: [Places panel] Add a Recently Used item by default

[Nathaniel Graham]

ngraham added a comment.


  In D7446#336214 , @davidedmundson 
wrote:
  
  > This is in frameworks, recentdocuments is in kio-extras.
  >
  > Are you sure you can do this?
  
  
  Not sure I catch your meaning. The `recentdocuments:/` kioslave has been 
shipped since forever; this patch just adds it to the Places panel by default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I think I'm fine with it now, but please wait until next Monday (Oct 8) 
before pushing, so it doesn't break the upcoming KF5 release. I'm not 100% 
confident (given that earlier versions of the patch had obvious bugs that 
were not detected by the unittests).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

D15932: [UDisks2] Power down drive on remove if supported

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great with the unencrypted and LUKS-unencrypted single- and 
multi-partition ext4 disks that I tried out. Code change looks sane too. 
Wonderful work!

REPOSITORY
  R245 Solid

BRANCH
  udisks2_power_down

REVISION DETAIL
  https://phabricator.kde.org/D15932

To: bruns, #frameworks, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis updated this revision to Diff 42829.
ndavis added a comment.


  Change standard name breeze-dark battery icons to symlinks

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15934?vs=42828=42829

BRANCH
  other-desktop-compatibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15934

AFFECTED FILES
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/16/bluetooth-active.svg
  icons-dark/status/16/bluetooth-disabled.svg
  icons-dark/status/16/bluetooth-paired.svg
  icons-dark/status/16/bluetooth.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/22/bluetooth-active.svg
  icons-dark/status/22/bluetooth-disabled.svg
  icons-dark/status/22/bluetooth-paired.svg
  icons-dark/status/22/bluetooth.svg
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-010-charging.svg
  icons/status/16/battery-010.svg
  icons/status/16/battery-020-charging.svg
  icons/status/16/battery-020.svg
  icons/status/16/battery-030-charging.svg
  icons/status/16/battery-030.svg
  icons/status/16/battery-040-charging.svg
  icons/status/16/battery-040.svg
  icons/status/16/battery-050-charging.svg
  icons/status/16/battery-050.svg
  icons/status/16/battery-060-charging.svg
  icons/status/16/battery-060.svg
  icons/status/16/battery-070-charging.svg
  icons/status/16/battery-070.svg
  icons/status/16/battery-080-charging.svg
  icons/status/16/battery-080.svg
  icons/status/16/battery-090-charging.svg
  icons/status/16/battery-090.svg
  icons/status/16/battery-100-charging.svg
  icons/status/16/battery-100.svg
  icons/status/16/battery-caution-charging.svg
  icons/status/16/battery-caution.svg
  icons/status/16/battery-empty-charging.svg
  icons/status/16/battery-empty.svg
  icons/status/16/battery-full-charging.svg
  icons/status/16/battery-full.svg
  icons/status/16/battery-good-charging.svg
  icons/status/16/battery-good.svg
  icons/status/16/battery-low-charging.svg
  icons/status/16/battery-low.svg
  icons/status/16/battery-missing.svg
  icons/status/16/bluetooth-active.svg
  icons/status/16/bluetooth-disabled.svg
  

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Add 16 and 22 px battery and bluetooth icons with names that should be 
compatible with other desktop environments. Note that while the freedesktop.org 
naming spec says that battery-low is for <20% and battery-caution is for <40%, 
I don't think there is any DE that actually uses them that way. Instead, low is 
usually <40% and caution is <20%.

REPOSITORY
  R266 Breeze Icons

BRANCH
  other-desktop-compatibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15934

AFFECTED FILES
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/16/bluetooth-active.svg
  icons-dark/status/16/bluetooth-disabled.svg
  icons-dark/status/16/bluetooth-paired.svg
  icons-dark/status/16/bluetooth.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/22/bluetooth-active.svg
  icons-dark/status/22/bluetooth-disabled.svg
  icons-dark/status/22/bluetooth-paired.svg
  icons-dark/status/22/bluetooth.svg
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-010-charging.svg
  icons/status/16/battery-010.svg
  icons/status/16/battery-020-charging.svg
  icons/status/16/battery-020.svg
  icons/status/16/battery-030-charging.svg
  icons/status/16/battery-030.svg
  icons/status/16/battery-040-charging.svg
  icons/status/16/battery-040.svg
  icons/status/16/battery-050-charging.svg
  icons/status/16/battery-050.svg
  icons/status/16/battery-060-charging.svg
  icons/status/16/battery-060.svg
  icons/status/16/battery-070-charging.svg
  icons/status/16/battery-070.svg
  icons/status/16/battery-080-charging.svg
  icons/status/16/battery-080.svg
  icons/status/16/battery-090-charging.svg
  icons/status/16/battery-090.svg
  icons/status/16/battery-100-charging.svg
  icons/status/16/battery-100.svg
  icons/status/16/battery-caution-charging.svg
  icons/status/16/battery-caution.svg
  icons/status/16/battery-empty-charging.svg
  icons/status/16/battery-empty.svg
  

D7446: [Places panel] Add a Recently Used item by default

[David Edmundson]

davidedmundson added a comment.


  This is in frameworks, recentdocuments is in kio-extras.
  
  Are you sure you can do this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp

D15932: [UDisks2] Power down drive on remove if supported

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15932

To: bruns, #frameworks
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15932: [UDisks2] Power down drive on remove if supported

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15932

To: bruns, #frameworks
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15932: [UDisks2] Power down drive on remove if supported

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  It is preferable to to do a controlled shutdown prior to disconnecting
  and eventually cutting of power to the drive.

TEST PLAN
  Connect external drive, select "Savely Remove" from context menu
  
  1. if drive has only on partition, fs is unmounted and drive spins down
  2. if drive has multiple partitions: a) first (not last) partition can be 
unmounted and remounted b) "Remove"ing last partition spins down drive

REPOSITORY
  R245 Solid

BRANCH
  udisks2_power_down

REVISION DETAIL
  https://phabricator.kde.org/D15932

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D7446: [Places panel] Add a Recently Used item by default

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp

D7446: [Places panel] Add a Recently Used item by default

[Nathaniel Graham]

ngraham added a comment.


  Ping!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a comment.


  Thanks again for this lovely icon, @ndavis. Next up, we need a variant of it 
that communicates "I'm the OS/root volume!" See 
https://bugs.kde.org/show_bug.cgi?id=399307
  
  This supports one of the next open tasks for T8349: Improve Places panel 
usability and presentation  that is a 
prerequisite for D15739: [Places panel] Don't show Root by default 
.
  
  Thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15931: [Places panel] use more appropriate network icon

[Andrew Crouthamel]

acrouthamel added a comment.


  +1 from me, makes sense. I say that as a guy who stares at server racks all 
day.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

[Nathaniel Graham]

ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The current Breeze icon used for the default Network(`network-workgroup`) is 
not ideal for several reasons:
  
  - It it not clear what it depicts (I was told it's a server rack, but there's 
not enough detail to make this apparent)
  - Even if the visuals were clear, its iconography (a server rack) is not 
familiar to people who are not sysadmins
  
  This patch replaces it with `folder-network`, which yields the following 
improvements:
  
  - This icon includes the "sideways dotted V" imagery that is used in other 
contexts (shared folder emblem, Share menu, which teaches the user its meaning
  - Many other platforms use circular globe or world iconography for their 
network icons. Even though this new icon is not a globe or world, it is 
circular, which helps to re-use some of a user's prior experience on other 
platforms
  - Semantically, `folder-network` is just a more appropriate icon to use for 
this than `network-workgroup`. The item leads to the whole network, not a 
specific workgroup.

TEST PLAN
  New icon shows up in all Places panels for new user accounts, or if you 
delete `~/.local/share/user-places.xbel` in an existing user account
  
  Dolphin Places panel:
  [image goes here]

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15912: Don't silently error if damage is sent before buffer

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  For 5.52.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15912

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15871

To: madcatx, elvisangelaccio, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

KDE Applications on Android sprint

[Aleix Pol]

Hi,
We're entertaining the idea of organising a sprint about Android
applications towards the end of November in València [1].

If you think you'd be interested in joining, please let me know and
add yourself to the kde-android mailing list [2].

Cheers!
Aleix

[1] https://notes.kde.org/p/kdeonandroid-sprint
[2] https://mail.kde.org/mailman/listinfo/kde-android

D15912: Don't silently error if damage is sent before buffer

[David Edmundson]

davidedmundson updated this revision to Diff 42820.
davidedmundson added a comment.


  Leave useless code in

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15912?vs=42766=42820

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15912

AFFECTED FILES
  src/server/surface_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D15909: Fix compile failure on Windows targets

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:2e364ebbf240: Fix compile failure on Windows targets 
(authored by zrax, committed by cgiboudeaux).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15909?vs=42756=42816

REVISION DETAIL
  https://phabricator.kde.org/D15909

AFFECTED FILES
  src/plugins/voikko/voikkodict.cpp

To: zrax, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15927: Use specified Perl interpreter instead of relying on PATH

[Michael Hansen]

zrax added a comment.


  PERL_EXECUTABLE is set by cmake's FindPerl module 
(https://cmake.org/cmake/help/v3.0/module/FindPerl.html), so it should always 
be defined.  This only fixes the case where it's overridden on the command line 
(or cmake-gui, etc).

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15927

To: zrax
Cc: vonreth, kde-doc-english, kde-frameworks-devel, michaelh, ngraham, bruns, 
skadinna

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer updated this revision to Diff 42813.
mweichselbaumer added a comment.


  Added autotests and additional test: mediaendpointconnector

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42313=42813

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/media.cpp
  autotests/fakebluez/media.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  autotests/noinputnooutputagenttest.cpp
  autotests/noinputnooutputagenttest.h
  src/CMakeLists.txt
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  src/manager_p.h
  src/media.cpp
  src/media.h
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/noinputnooutputagent.cpp
  src/noinputnooutputagent.h
  src/pendingcall.h
  src/request.cpp
  src/request.h
  src/services.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

[Manuel Weichselbaumer]

mweichselbaumer edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15927: Use specified Perl interpreter instead of relying on PATH

[Hannah von Reth]

vonreth added a comment.


  Please fallback on looking up perl from path if that perl does not exists.
  Purely relying on a hardcoded path would break the capability of relocating 
kdoctools.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15927

To: zrax
Cc: vonreth, kde-doc-english, kde-frameworks-devel, michaelh, ngraham, bruns, 
skadinna

D15927: Use specified Perl interpreter instead of relying on PATH

[Michael Hansen]

zrax created this revision.
Herald added projects: Frameworks, Documentation.
Herald added a subscriber: kde-doc-english.
zrax requested review of this revision.

REVISION SUMMARY
  If a PERL_EXECUTABLE is passed on the CMake command line, e.g. because the 
default one in PATH is insufficient, kdoctools would still use the one in PATH 
incorrectly.  This fixes it to use the specified perl both at configure time 
and at build / install time.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15927

AFFECTED FILES
  cmake/uriencode.cmake
  src/CMakeLists.txt

To: zrax
Cc: kde-doc-english, kde-frameworks-devel, michaelh, ngraham, bruns, skadinna

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

[Michal Malý]

madcatx updated this revision to Diff 42807.
madcatx added a comment.


  Changed the KIO error code from ERR_INTERNAL to more specific 
ERR_CANNOT_RMDIR.

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15871?vs=42645=42807

REVISION DETAIL
  https://phabricator.kde.org/D15871

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: madcatx, elvisangelaccio, sitter
Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15909: Fix compile failure on Windows targets

[Michael Hansen]

zrax added a comment.


  No, I do not have push permissions.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D15909

To: zrax, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 233 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/233/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 03 Oct 2018 14:30:58 +
 Build duration:
9 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13120)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 158 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/158/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Oct 2018 14:30:58 +
 Build duration:
5 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5180/13180)29%
(2735/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(386/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/57/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Oct 2018 13:33:58 +
 Build duration:
2 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/113/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 03 Oct 2018 13:33:58 +
 Build duration:
1 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

D15891: Fix monochrome icons missing stylesheets

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9e71a0266047: Fix monochrome icons missing stylesheets 
(authored by ndavis, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15891?vs=42701=42793

REVISION DETAIL
  https://phabricator.kde.org/D15891

AFFECTED FILES
  icons-dark/actions/22/application-exit.svg
  icons-dark/actions/22/call-stop.svg
  icons-dark/actions/22/document-close.svg
  icons-dark/actions/22/edit-delete.svg
  icons-dark/actions/22/im-ban-kick-user.svg
  icons-dark/actions/22/im-kick-user.svg
  icons-dark/actions/22/irc-remove-operator.svg
  icons-dark/actions/22/irc-unvoice.svg
  icons-dark/actions/22/news-unsubscribe.svg
  icons-dark/actions/22/process-stop.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/24/application-exit.svg
  icons-dark/actions/24/call-stop.svg
  icons-dark/actions/24/document-close.svg
  icons-dark/actions/24/edit-delete.svg
  icons-dark/actions/32/application-exit.svg
  icons-dark/actions/32/call-stop.svg
  icons-dark/actions/32/document-close.svg
  icons-dark/actions/32/edit-delete.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet-shields_up.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/16/hotspot.svg
  icons-dark/apps/16/plasmavault.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet-shields_up.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/22/hotspot.svg
  icons-dark/apps/22/plasmavault.svg
  icons/actions/22/application-exit.svg
  icons/actions/22/call-stop.svg
  icons/actions/22/document-close.svg
  icons/actions/22/edit-delete.svg
  icons/actions/22/im-ban-kick-user.svg
  icons/actions/22/im-kick-user.svg
  icons/actions/22/irc-remove-operator.svg
  icons/actions/22/irc-unvoice.svg
  icons/actions/22/news-unsubscribe.svg
  icons/actions/22/process-stop.svg
  icons/actions/22/window-close.svg
  icons/actions/24/application-exit.svg
  icons/actions/24/call-stop.svg
  icons/actions/24/document-close.svg
  icons/actions/24/edit-delete.svg
  icons/actions/32/application-exit.svg
  icons/actions/32/call-stop.svg
  icons/actions/32/document-close.svg
  icons/actions/32/edit-delete.svg
  icons/actions/32/window-close.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet-shields_up.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/16/hotspot.svg
  icons/apps/16/plasmavault.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet-shields_up.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/22/hotspot.svg
  icons/apps/22/plasmavault.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15891: Fix monochrome icons missing stylesheets

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  It looks like this was the reason why your new monochrome Firewall icons 
didn't correctly invert their colors in Cuttlefish. Fixed now for those and all 
other affected icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-stylesheets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15891

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

[Michal Malý]

madcatx added a comment.


  Ah, sorry, apparently there is ERR_CANNOT_RMDIR and ERR_COULD_NOT_RMDIR which 
translate to the same value with the latter being deprecated. I'll update the 
patch to use ERR_CANNOT_RMDIR.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15871

To: madcatx, elvisangelaccio, sitter
Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

[Michal Malý]

madcatx added a comment.


  Well, this 
(https://api.kde.org/frameworks/kio/html/deprecated.html#_deprecated15) 
marks KIO::ERR_COULD_NOT_RMDIR as deprecated. Is there an alternative I should 
use instead?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15871

To: madcatx, elvisangelaccio, sitter
Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

[David Faure]

dfaure added a comment.


  kio_file returns KIO::ERR_CANNOT_RMDIR when trying to delete a non-empty 
directory, maybe kio_smb could do the same? Although I see that the above isn't 
dependent on the command being executed But well, is there any other 
operation that would return ENOTEMPTY? If not, then ERR_CANNOT_RMDIR would be 
better IMHO (so KIO code or app code can check for it, if needed).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15871

To: madcatx, elvisangelaccio, sitter
Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D14449: Modify device usage information

[Shubham]

shubham added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, ngraham, #frameworks, rkflx
Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, bruns

D14449: Modify device usage information

[Shubham]

shubham added a comment.


  won't the pie chart representation look good, as we have in windows?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, ngraham, #frameworks, rkflx
Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

Re: QtCreator-style block highlighting (and colours) in Kate(part)?

[Dominik Haumann]

No and no :)
But feel free to create/add a color scheme called Qt Creator.

Greetings
Dominik

René J.V. Bertin  schrieb am Di., 2. Okt. 2018, 21:21:

> Hi,
>
> I quite like Qt Creator's feature that highlights blocks (in code) by
> applying a gradient of background darkening that makes code less
> conspicuous the further it is outside the current context. Has something
> like this ever been considered for Kate-based editors?
>
> I also find Creators default colour scheme very nicely done, is there a
> way to import it (from the XML file, not by hand via the GUI :))?
>
> Thanks,
> R.
>

D15909: Fix compile failure on Windows targets

[Dominik Haumann]

dhaumann added a comment.


  Btw, can you commit yourself, or shall we push this? If so, can someone take 
care of this, since I am not available for the next 10 days.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D15909

To: zrax, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15909: Fix compile failure on Windows targets

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Lgtm.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D15909

To: zrax, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Dominik Haumann]

dhaumann added a comment.


  Hm, two separator lines, even touching each other sounds like a hack. Is 
there no better way?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: dhaumann, romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns