KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 177 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/177/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Nov 2018 06:24:17 + Build duration: 36 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/75/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Nov 2018 06:23:02 + Build duration: 24 min and counting JUnit Tests Name: (root) Failed: 4

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/39/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Nov 2018 06:23:17 + Build duration: 22 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/101/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 06:23:02 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 251 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/251/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 06:24:17 + Build duration: 9 min 25 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/51/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 06:23:17 + Build duration: 7 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 48 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/48/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Nov 2018 06:17:32 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/74/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 06:17:32 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/63/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 06:02:52 + Build duration: 1 min 7 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/85/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 05:51:32 + Build duration: 1 min 12 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 63 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/63/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Nov 2018 05:51:32 + Build duration: 1 min 32 sec and counting JUnit Tests Name: (root)

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Simon Redman
sredman added a comment. This is going to be our cleanest patch ever once we've had everybody and their grandmother look at it. I guess this is what happens when you fix a hot bug!  In D16692#354783 , @jriddell wrote: > I can recreate the

D16409: [Bookmarks Runner] Open database connection in the query thread

2018-11-05 Thread Stefan Brüns
bruns edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16409 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 72 - Still Failing!

2018-11-05 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/72/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 06 Nov 2018 01:08:51 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Aleix Pol Gonzalez
apol added a comment. In D16692#354767 , @albertvaka wrote: > In my opinion this is a regression in KIO and it would be nice to check if it can somehow be fixed there: Upgrading KIO should not break existing apps. > > Even if we make a

D16684: Updated with petroleum industry units

2018-11-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great and works great! Nice first patch. Just one more thing is required before I can land it: add the following to the Summary section of the patch: BUG: 388074

D16524: [Extractor] Use QDataStream serialization in place of cooked one

2018-11-05 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:a3943b1fd575: [Extractor] Use QDataStream serialization in place of cooked one (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16395: Update the "About KDE" text

2018-11-05 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel,

D16395: Update the "About KDE" text

2018-11-05 Thread Nathaniel Graham
ngraham updated this revision to Diff 44942. ngraham added a comment. Add a link to the "Get Involved" page REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16395?vs=44605=44942 BRANCH arcpatch-D16395 REVISION DETAIL https://phabricator.kde.org/D16395

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Jonathan Riddell
jriddell added a comment. I can recreate the problem with 1.3 branch build of kdeconnect-kde in a virtualmachine install of KDE neon user edition The problem remains when building and installing it with the D16692 patch Building 1.3 branch on KDE

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R245:6d0f74132fcd: Fix root disk icon change so that it doesnt erroneously change other icons (authored by ngraham). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Nicolas Fella
nicolasfella added a comment. Probably related: D16189 REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduisters, #kde_connect, #frameworks, albertvaka Cc: nicolasfella, albertvaka, kdeconnect, shivanshukantprasad,

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-05 Thread Albert Vaca Cintora
albertvaka added a comment. As I commented in this similar patch (https://phabricator.kde.org/D16692 ) I think this is a regression that should be fixed in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc:

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Albert Vaca Cintora
albertvaka requested changes to this revision. albertvaka added a comment. This revision now requires changes to proceed. In my opinion this is a regression in KIO and it would be nice to check if it can somehow be fixed there: Upgrading KIO should not break existing apps. Even if we

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-11-05 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:52107a8af3ee: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-11-05 Thread Luca Beltrame
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH extractor REVISION DETAIL https://phabricator.kde.org/D16523 To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov,

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-11-05 Thread Stefan Brüns
bruns added a comment. good to go? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16523 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-05 Thread Emirald Mateli
emateli updated this revision to Diff 44938. emateli added a comment. - Initialize pointers to nullptr - Code style fix --- Thoughts on proceeding with the proposed changes to batchrenamejob? Also, the filenameutils namespace feels like duplicated work. Any existing solution

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 96 - Fixed!

2018-11-05 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/96/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 05 Nov 2018 22:05:10 + Build duration: 8 min 4 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 117 - Fixed!

2018-11-05 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Nov 2018 22:05:10 + Build duration: 2 min 46 sec and counting JUnit Tests Name:

Re: Python bindings using cppyy (was: An update on Python bindings)

2018-11-05 Thread Dominik Haumann
... wasn't there also some python related work by Stefan? Or is that unrelated? Greetings Dominik Am Mo., 5. Nov. 2018, 16:20 hat Shaheed Haque geschrieben: > I'm afraid that there has been no progress as I am buried in "startup" > mode. I'm not sure when that might change. > > On Mon, 5 Nov

D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-05 Thread Andreas Krutzler
akrutzler accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D16674 To: dfaure, akrutzler, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 95 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/95/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 05 Nov 2018 20:52:05 + Build duration: 2 min 18 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/116/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Nov 2018 20:52:05 + Build duration: 2 min 32 sec and counting JUnit Tests Name:

D16672: Add support for speex files to taglibextractor

2018-11-05 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:ac63b25577f3: Add support for speex files to taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16672?vs=44869=44937

D16694: Improve visibility for Konsole icon when using Breeze Dark

2018-11-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. Thanks for making those changes. Now we can see the icon, and also an issue that needs to be corrected. :) Notice how the corners look really bright--especially the bottom corners? That's a problem. I suspect what's

D16694: Improve visibility for Konsole icon when using Breeze Dark

2018-11-05 Thread Anish Giri
anishgiri retitled this revision from "Patch For Bug 367696" to "Improve visibility for Konsole icon when using Breeze Dark". anishgiri edited the summary of this revision. anishgiri edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-05 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D16674 To: dfaure, akrutzler, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef,

D16694: Patch For Bug 367696

2018-11-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a reviewer: VDG. ngraham added a comment. This revision now requires changes to proceed. Thanks for the patch! And thanks for using `arc`, too. That makes life a bit easier for us. :) Couple of things: 1. The title becomes

D16694: Patch For Bug 367696

2018-11-05 Thread Anish Giri
anishgiri created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. anishgiri requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH utilities-terminal (branched from master) REVISION DETAIL

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Nicolas Fella
nicolasfella added a reviewer: Frameworks. REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduisters, #kde_connect, #frameworks Cc: kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux,

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-11-05 Thread Fabian Vogt
fvogt added a comment. In D16471#354635 , @jgrulich wrote: > Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-11-05 Thread Jan Grulich
jgrulich added a comment. Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated successfuly? REPOSITORY R282 NetworkManagerQt REVISION DETAIL

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-05 Thread Ben Cooksley
bcooksley added a comment. You can rely on shared-mime-info being present on all platforms (Linux, FreeBSD, Windows, Android) yes. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: bcooksley, kde-frameworks-devel,

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-05 Thread Stefan Brüns
bruns added a comment. In D16593#354311 , @bcooksley wrote: > As noted in the build log on the CI system, kfilemetadata doesn't depend on kcoreaddons so you therefore cannot rely on the kde5.xml file being available: > > [kf5-qt5

D16684: Updated with petroleum industry units

2018-11-05 Thread Kai Uwe Broulik
broulik added a comment. Looking good now, +1 REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto, ngraham, broulik, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

2018-11-05 Thread Roman Gilg
romangg retitled this revision from "[server] Put (de-)activate, en-/disable callbacks in child classes" to "[server] Put text-input (de-)activate, en-/disable callbacks in child classes". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16676 To: romangg, #kwin,

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto updated this revision to Diff 44918. REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16684?vs=44917=44918 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16684 AFFECTED FILES README.md src/CMakeLists.txt

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto updated this revision to Diff 44917. joaonetto marked 3 inline comments as done. joaonetto added a comment. permeability.h renamed to permeability_p.h and change Darcy to start at 33000 REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE

D16684: Updated with petroleum industry units

2018-11-05 Thread Kai Uwe Broulik
broulik added a comment. The header file for `class Permeability` should probably be named `permeability_p.h` to match the other category classes since it's a not exported implementation detail INLINE COMMENTS > unit.h:335 > +/** @since 5.53 */ > +Darcy, > +/** @since 5.53 */

D16594: Add context to kcmodule connection to lambdas

2018-11-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R295:2da8aed41663: Add context to kcmodule connection to lambdas (authored by davidedmundson). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16594?vs=44659=44915

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto updated this revision to Diff 44914. joaonetto marked an inline comment as done. joaonetto added a comment. Reviewed with comments made on this diff. REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16684?vs=44906=44914 BRANCH master

D16684: Updated with petroleum industry units

2018-11-05 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > unit.h:65 > +ElectricalResistanceCategory, > +PermeabilityCategory > }; Please add `/** @since 5.53 */` here, following the pattern. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto,

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R858:8fa114df0ad1: Fix issue where theres only one element on the menu (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D16681: Updated with petroleum industry units

2018-11-05 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > unit.h:65 > +ElectricalResistanceCategory, > +PermeabilityCategory > }; `/** @since 5.53 */` is needed here too. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16681 To: joaonetto, ngraham, broulik,

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/74/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 05 Nov 2018 15:06:09 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 5

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Bhushan Shah
[sending again from right address since my gmail address is not subscribed to somee lists] Hello, On Mon, Nov 05, 2018 at 11:02:43PM +1300, Ben Cooksley wrote: > > In order to allow for hardware maintenance, one of our physical > > hardware hosts will need to be shutdown for a few hours on

Re: Python bindings using cppyy (was: An update on Python bindings)

2018-11-05 Thread Philipp A.
Hi Shaheed! The year is nearing its end, and I wonder if there has been any progress and/or if you people need help with the bindings! I’d really like to revive my IPython console in Kate :D Best, Philipp Shaheed Haque schrieb am Sa., 13. Jan. 2018 um 19:06 Uhr: > Thanks to some upstream

Re: Python bindings using cppyy (was: An update on Python bindings)

2018-11-05 Thread Shaheed Haque
I'm afraid that there has been no progress as I am buried in "startup" mode. I'm not sure when that might change. On Mon, 5 Nov 2018, 14:02 Philipp A. Hi Shaheed! > > The year is nearing its end, and I wonder if there has been any progress > and/or if you people need help with the bindings! > >

D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor

2018-11-05 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Current code contains a path to cleanup

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

2018-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/100/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Nov 2018 15:06:09 + Build duration: 4 min 37 sec and counting JUnit Tests Name: (root)

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Marco Martin
mart accepted this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D16685 To: apol, #frameworks, mart, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16684: Updated with petroleum industry units

2018-11-05 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > permeability.cpp:3 > + * Copyright (C) 2007-2009 Petri Damstén > + * Copyright (C) 2014 John Layt > + * Since you created this file, this should be your own copyright. > permeability.h:3 > + * Copyright (C) 2007-2009 Petri Damstén > + *

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems like this is only a problem if you have a single-item menu, and if you have that, you've done something wrong. :) Regardless, this seems to fix the issue, so +1. REPOSITORY R858

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This (random) height shows an odd padding on the menu when there's just the one element.

D16684: Updated with petroleum industry units

2018-11-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added reviewers: broulik, Frameworks. ngraham added a comment. This revision now requires changes to proceed. Great, thanks! This work well; I just have a few comments, listed below. To update this diff without accidentally creating a

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto abandoned this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16681 To: joaonetto, ngraham, broulik, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto updated this revision to Diff 44906. joaonetto added a comment. Couldn't update D16681 , creating new revision REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16684?vs=44905=44906 BRANCH permeability

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto abandoned this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto updated this revision to Diff 44905. joaonetto added a comment. Updated with permeability source code REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16684?vs=44904=44905 BRANCH permeability (branched from master) REVISION DETAIL

D16684: Updated with petroleum industry units

2018-11-05 Thread Nathaniel Graham
ngraham added a comment. Oops, you want to be sure you're on the `permeability` branch when you run `arc diff`. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto abandoned this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto updated this revision to Diff 44904. joaonetto added a comment. - Updated source code with permeability class REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16684?vs=44903=44904 BRANCH permeability (branched from master) REVISION

D16681: Updated with petroleum industry units

2018-11-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added reviewers: broulik, Frameworks. ngraham added a comment. This revision now requires changes to proceed. Great job, and nice first patch! Unfortunately, this doesn't compile: -- Configuring done CMake Error at

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto created this revision. joaonetto added a project: Frameworks. joaonetto requested review of this revision. REVISION SUMMARY Added a new volume unity Oil Barrels and a new permeability class that handles Darcy and MiliDarcys. REPOSITORY R292 KUnitConversion BRANCH permeability

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto abandoned this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto edited the summary of this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D16681 To: joaonetto Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto updated this revision to Diff 44901. joaonetto added a comment. Updating D16681 : Updated with petroleum industry units REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16681?vs=44899=44901 BRANCH

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira
joaonetto created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. joaonetto requested review of this revision. REVISION SUMMARY Added a new volume unity Oil Barrels and a new permeability class that handles Darcy and MiliDarcys. REPOSITORY

D15999: Add icons with added background to system.svgz

2018-11-05 Thread Phil Stefan
pstefan updated this revision to Diff 44890. pstefan added a comment. - Fixed z order REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=44889=44890 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15999 AFFECTED

D15999: Add icons with added background to system.svgz

2018-11-05 Thread Phil Stefan
pstefan updated this revision to Diff 44889. pstefan added a comment. - Added missing class attributes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=44862=44889 BRANCH master REVISION DETAIL

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Ben Cooksley
On Sat, Nov 3, 2018 at 7:50 AM Ben Cooksley wrote: > > Hi all, Hi all, > > In order to allow for hardware maintenance, one of our physical > hardware hosts will need to be shutdown for a few hours on Monday. > This downtime will commence around 9:30am UTC and may take several > hours. > >

D16677: Add BrightScript syntax

2018-11-05 Thread Daniel Levin
dlevin added a comment. There are various reasons I was using 1-element keyword lists instead of StringDetect: 1. keyword properly recognizes value surrounded by non-word characters, StringDetect does not. 2. BrightScript language is case insensitive, adding insensitive="true" to

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-11-05 Thread Harald Sitter
sitter added a comment. It's on my todo, unfortunately I am at a sprint this week so probably nothing much happening on this until next week. Meanwhile I'd still like some comments on the presented diff (: REPOSITORY R320 KIO Extras REVISION DETAIL

D16677: Add BrightScript syntax

2018-11-05 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, beside that I am not sure why you use 1-element keyword list instead of StringDetect at some places, I see no issues with that. If you like, you can change that, otherwise I am