D16983: Add 48px firewall-applet* icons

ndavis updated this revision to Diff 45929. ndavis added a comment. Remove 48px symlinks and move firewall-applet icons to status category REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16983?vs=45746=45929 BRANCH firewall-applet-fix-tests

D17065: Fix mem leak found with asan

mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17065 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17065: Fix mem leak found with asan

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Fix mem when I used dolphin #0 0x7fa8cd24d900 in operator new(unsigned long)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/78/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 21 Nov 2018 06:12:33 + Build duration: 4 min 2 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/134/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Nov 2018 06:12:33 + Build duration: 1 min 29 sec and counting JUnit Tests Name:

D17033: Change primary monochrome icon colors to match new HIG colors

This revision was automatically updated to reflect the committed changes. Closed by commit R266:53cd19094c8e: Change primary monochrome icon colors to match new HIG colors (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D17033: Change primary monochrome icon colors to match new HIG colors

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. From visual inspection of `/usr/share/icons/breeze/actions/*` in Dolphin after deploying the change, it's quite visible--and quite a noticeable improvement, which I imagine will be much

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/67/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 21 Nov 2018 02:49:27 + Build duration: 4 min 3 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/89/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Nov 2018 02:49:27 + Build duration: 1 min 5 sec and counting JUnit Tests Name: (root)

D16867: Don't generate appstream data for files that lack a description

apol closed this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D16867 To: apol, #plasma, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:1602 > QList::Iterator it = files.begin(); > +const auto fileSystem = > KFileSystemType::fileSystemType(m_globalDest.toString()); >

D17013: Show menu bar, how to re-enable, common shortcut dialog

aacid added inline comments. INLINE COMMENTS > lsartorelli wrote in ktoggleshowmenubaraction.cpp:77 > Do you suggest to add a warning in case of no shortcut? > The only options I am thinking of are > to tell the user add the missing shortcut via system settings, > to tell the user to modify the

D17048: Restore sendfile support

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice catch. ... and catching this is the whole reason for #if instead of #ifdef ... too bad this one was still using ifdef (if defined). REPOSITORY R241 KIO BRANCH master

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good! D17033 needs to land before this or the two will conflict, but there's nothing you need to do. REPOSITORY R266 Breeze Icons BRANCH

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added reviewers: VDG, Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17062 To: trickyricky26, #vdg, #breeze Cc: kde-frameworks-devel,

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-dialog-ok-apply (branched from master) REVISION DETAIL

D17028: Loader: Avoid Q_FOREACH

loh.tar added inline comments. INLINE COMMENTS > davidedmundson wrote in loader.cpp:273 > > Probably, yes. But Qt docu always says, "thanks to implicit sharing copying > > a container is very fast" > > That's mixing up docs. > > foreach() always does a const copy of the list. This is a cheap

D17052: Simplify reference counting of FrameData

zzag added a comment. In gneral, +1 for shared pointers. INLINE COMMENTS > framesvg.cpp:375 > //#define DEBUG_FRAMESVG_CACHE > FrameSvgPrivate::~FrameSvgPrivate() > +{} = default; > framesvg.cpp:569 > > -QRect FrameSvgPrivate::contentGeometry(FrameData* frame, const QSize& size) >

D17052: Simplify reference counting of FrameData

apol added a comment. In D17052#363101 , @zzag wrote: > > as it can change sometimes and crash the system. > > Could you please provide example when it can crash? Not really, it would crash mostly on complex plasmoids like taskmanager

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

loh.tar created this revision. Herald added a project: Frameworks. loh.tar requested review of this revision. REVISION SUMMARY This patch alone is reasonable but become really important with the aim of D17030 REPOSITORY R246 Sonnet REVISION DETAIL

D17028: Loader: Avoid Q_FOREACH

davidedmundson added inline comments. INLINE COMMENTS > loh.tar wrote in loader.cpp:273 > Probably, yes. But Qt docu always says, "thanks to implicit sharing copying a > container is very fast" > > Is copy previous into a const var a benefit (as I have seen recently)? Don't > think so. Or

D17055: Avoid Q_FOREACH

loh.tar created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. loh.tar requested review of this revision. REVISION SUMMARY VoikkoDict, HunspellClient, HSpellDict, GuessLanguage, parsetrigrams REPOSITORY R246 Sonnet REVISION DETAIL

D17028: Loader: Avoid Q_FOREACH

loh.tar added inline comments. INLINE COMMENTS > smartins wrote in loader.cpp:273 > will languages() detach ? Probably, yes. But Qt docu always says, "thanks to implicit sharing copying a container is very fast" Is copy previous into a const var a benefit (as I have seen recently)? Don't

D17048: Restore sendfile support

davidedmundson added a comment. It should be faster. It'll go from reading a file into a buffer in userspace and writing it back to it all being handled automagically. I'm not sure you can really blog about it, the code existed since 2003. REPOSITORY R241 KIO REVISION DETAIL

D17052: Simplify reference counting of FrameData

zzag added a comment. > as it can change sometimes and crash the system. Could you please provide example when it can crash? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: zzag, kde-frameworks-devel,

D17048: Restore sendfile support

ngraham added a comment. Does this result in a performance improvement? Anything quantifiable I can blog about? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17048 To: davidedmundson, dfaure Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D17052: Simplify reference counting of FrameData

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Leverages QSharedPointer for the reference counting. Keeps the last value of the

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 266 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/266/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Nov 2018 14:16:44 + Build duration: 13 min and counting JUnit Tests Name: (root)

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

kfunk added a comment. Yep, those are in fact separate commits. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17031 To: kfunk, mart Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

This revision was automatically updated to reflect the committed changes. Closed by commit R242:421e1c01266e: ASAN: Fix memory leak in CalendarPlugin (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17031?vs=45849=45891#toc REPOSITORY R242 Plasma Framework (Library)

D17051: Use correct variable type for returned value from read/sendfile

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17051 To: davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

kossebau added a comment. Good to see you caring for ECM documentation not getting broken with Qt 5.12 :) Any idea how we could perhaps deduplicate the FindQHelpGenerator.cmake with the one from find-modules (which is a helper for runtime with the ECMAddQch macro)? No instant idea

D17051: Use correct variable type for returned value from read/sendfile

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY n stores the read/transferred bytes. This returns a ssize_t. We were casting to an int, which

D17048: Restore sendfile support

davidedmundson updated this revision to Diff 45889. davidedmundson added a comment. Fixup cpp REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17048?vs=45886=45889 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17048 AFFECTED FILES

D17048: Restore sendfile support

apol added a comment. +1 looks good to me. Chenge `#if defined HAVE_SENDFILE` to `#if HAVE_SENDFILE` though, cmakedefine01 will define it always, if I'm not mistaken. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17048 To: davidedmundson, dfaure Cc: apol,

D17044: Add FindExiv2.cmake to ECM

cgiboudeaux added a comment. Done. kfilemetadata was also changed to use FindLibExiv2.cmake. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17044 To: cgiboudeaux, apol, dfaure Cc: kossebau, rempt, kde-frameworks-devel, kde-buildsystem, michaelh,

D17048: Restore sendfile support

davidedmundson edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17048 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17048: Restore sendfile support

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Somehow in the kdelibs -> framework port the cmake checks for HAVE_SENDFILE got lost. That removes

D17048: Restore sendfile support

davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17048 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17044: Add FindExiv2.cmake to ECM

cgiboudeaux added inline comments. INLINE COMMENTS > kossebau wrote in FindExiv2.cmake:31 > Could you not already do this now, before it's first released? > > Any potential users currently have their own copy, they will not use this > version. > Once they switch to rely on the version provided

D17044: Add FindExiv2.cmake to ECM

kossebau added inline comments. INLINE COMMENTS > FindExiv2.cmake:31 > +# Since 5.53.0. > +# TODO KF6: Rename to FindLibExiv2.cmake > +# Could you not already do this now, before it's first released? Any potential users currently have their own copy, they will not use this version. Once they

D17046: Use the new FindExiv2 module from ECM.

cgiboudeaux marked an inline comment as done. cgiboudeaux added a comment. In D17046#362988 , @mgallien wrote: > Please feel free to land this after solving my comment. The new module already sets the description and URL REPOSITORY

D17046: Use the new FindExiv2 module from ECM.

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c3cc05f4eee2: Use the new FindExiv2 module from ECM. (authored by cgiboudeaux). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17046?vs=45883=45884 REVISION

D17046: Use the new FindExiv2 module from ECM.

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Please feel free to land this after solving my comment. INLINE COMMENTS > CMakeLists.txt:57 > -set_package_properties(Exiv2 PROPERTIES DESCRIPTION "Image Tag reader" > -

D17046: Use the new FindExiv2 module from ECM.

cgiboudeaux created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY ECM 5.53 ships a modern FindExiv2.cmake module that will be needed when exiv 0.27 is released.

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux added a reviewer: kossebau. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17015 To: cgiboudeaux, kossebau Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17044: Add FindExiv2.cmake to ECM

cgiboudeaux closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17044 To: cgiboudeaux, apol, dfaure Cc: rempt, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17044: Add FindExiv2.cmake to ECM

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D17044 To: cgiboudeaux, apol, dfaure Cc: rempt, kde-frameworks-devel,

D17044: Add FindExiv2.cmake to ECM

rempt added a comment. Wow... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17044 To: cgiboudeaux, apol, dfaure Cc: rempt, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17044: Add FindExiv2.cmake to ECM

cgiboudeaux created this revision. cgiboudeaux added reviewers: apol, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY According to lxr, we have 8 copies of

Re: Framework Announcement Webpages

I found the template, here's an update for the new design On Tue, 20 Nov 2018 at 10:09, Jonathan Riddell wrote: > > Hola David, the Framework announcement webpages still use the old > website theme. Can I help in updating it to the new theme? I'm not > sure the process in creating the pages. >

D17043: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17043 To: cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17043: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY In Qt >= 5.12, the qhelpgenerator and qcollectiongenerator tools were fused, only

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli marked an inline comment as done. lsartorelli added inline comments. INLINE COMMENTS > aacid wrote in ktoggleshowmenubaraction.cpp:77 > If shortcut() returns a QKeySequence (i think it does), you want > toString(NativeText) > > Not a native speaker but i don't think "typing" is

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 45874. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45821=45874 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp

D17028: Loader: Avoid Q_FOREACH

davidedmundson added a comment. > .I have now done a search for more Q_FOREACH/foreach. Please let me know if you want each as own diff or all in once Can be all at once, but still go via review. There are some foreach / for differences and pitfalls to be wary of. REPOSITORY R246

D17028: Loader: Avoid Q_FOREACH

smartins added inline comments. INLINE COMMENTS > loader.cpp:273 > QStringList allLocalizedDictionaries; > -Q_FOREACH (const QString , languages()) { > +for (const QString : languages()) { > allLocalizedDictionaries.append(languageNameForCode(langCode)); will languages()

D17019: actually initialize kcrash properly

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5e32846b785b: actually initialize kcrash properly (authored by sitter). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17019?vs=45819=45873 REVISION DETAIL

D17040: Make FindExiv2.cmake work with exiv 0.27.

cgiboudeaux added a comment. In D17040#362883 , @rempt wrote: > Hm... I guess this would be good to have in Krita, too, which also has a findExiv2.cmake yep, if accepted, I'll copy the modules in kfilemetadata, koko, libkexiv2, krename,

D17040: Make FindExiv2.cmake work with exiv 0.27.

rempt added a comment. Hm... I guess this would be good to have in Krita, too, which also has a findExiv2.cmake REPOSITORY R260 Gwenview REVISION DETAIL https://phabricator.kde.org/D17040 To: cgiboudeaux, kde-buildsystem, kde-frameworks-devel Cc: rempt, clintmoyer, tdarboux, huoni,

Framework Announcement Webpages

Hola David, the Framework announcement webpages still use the old website theme. Can I help in updating it to the new theme? I'm not sure the process in creating the pages. https://www.kde.org/announcements/kde-frameworks-5.51.0.php Jonathan

D17040: Make FindExiv2.cmake work with exiv 0.27.

cgiboudeaux added a reviewer: kde-frameworks-devel. REPOSITORY R260 Gwenview REVISION DETAIL https://phabricator.kde.org/D17040 To: cgiboudeaux, kde-buildsystem, kde-frameworks-devel Cc: clintmoyer, tdarboux, huoni, muhlenpfordt, rkflx

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D17031 To: kfunk, mart Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

mart added a comment. looks good, thanks :) tough those fixes are quite unrelated, can they be made in separated commits? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17031 To: kfunk Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns