D17193: KateViewInternal: Remove unneeded functions

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I would prefer function calls to members, in the most cases, the performance 
difference is not measurable, even without inline.
  
  For non-exported functions that are one liners, feel free to make them inline.
  
  I have no issues with merging more stuff from internal to view, the 
distinction is ancient.
  
  Perhaps we could do this in parts. Could you change here the use of members 
to functions?
  Then we can apply this first.

REVISION DETAIL
  https://phabricator.kde.org/D17193

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17220: Use red X in disabled and muted status icons consistently

[Noah Davis]

ndavis added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 347 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/347/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 29 Nov 2018 04:26:48 +
 Build duration:
6 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32131/60087)38%
(16585/44072)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9098/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8389/14310)51%
(4689/9249)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1779/4288)36%
(1312/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
(682/1356)42%

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade updated this revision to Diff 46444.
pranavgade added a comment.


  Updated diff from prev commit->changes to latest commit->changes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17210?vs=46392&id=46444

REVISION DETAIL
  https://phabricator.kde.org/D17210

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  src/CMakeLists.txt
  src/settings/proxysetting.cpp
  src/settings/proxysetting.h
  src/settings/proxysetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/usersetting.cpp
  src/settings/usersetting.h
  src/settings/usersetting_p.h

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  You're the hero KDE needs.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Noah Davis]

ndavis added a comment.


  In D17220#367858 , @ngraham wrote:
  
  > In D17220#367849 , @ndavis wrote:
  >
  > > Here's what the Breeze Plasma desktop theme uses for the 
`network-wireless-off` icon: F6445522: Screenshot_20181128_204458.png 

  >
  >
  > That fact that slightly different versions those icons live in two places 
(Breeze plasma icon theme & general Breeze icon theme) is... not ideal. :/
  
  
  Yes, I'm working on bringing the Breeze desktop theme icons into 
breeze-icons, but it will take a while.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  In D17220#367849 , @ndavis wrote:
  
  > Here's what the Breeze Plasma desktop theme uses for the 
`network-wireless-off` icon: F6445522: Screenshot_20181128_204458.png 

  
  
  That fact that slightly different versions those icons live in two places 
(Breeze plasma icon theme & general Breeze icon theme) is... not ideal. :/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Noah Davis]

ndavis added a comment.


  Could a distinction between "off" and "muted" be useful? If that is true, 
then we should keep the red horizontal dash for muted and use a red slash 
through the whole icon for off/disabled. In general, I think a red X should 
mean "error", but we're not consistent about that yet. I also think the sound 
waves should be reversed on the microphone icon since microphones don't 
normally make noise.
  
  Here's what the Breeze Plasma desktop theme uses for the 
`network-wireless-off` icon: F6445522: Screenshot_20181128_204458.png 

  
  The icon above it with the red X is `network-wireless-disconnected`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:3247994e52a6: DictionaryComboBoxTest: Add stretch to 
avoid expanding Dump button (authored by loh.tar, committed by ngraham).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17026?vs=45835&id=46435

REVISION DETAIL
  https://phabricator.kde.org/D17026

AFFECTED FILES
  examples/dictionarycombobox.cpp

To: loh.tar, #frameworks, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar added a comment.


  Bug302689 - Impossible to delete unwanted dictionaries
  https://bugs.kde.org/show_bug.cgi?id=302689
  
  Does not quite fit, but relieves the symptoms. Enough to close that?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[loh tar]

loh.tar added a comment.


  No, but that's fine. One thing less where I can make mistakes :-)
  Should your next question be regarding author ship, take a look at 
edbf2e36c805 

  Thanks.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

To: loh.tar, #frameworks, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  the `status/22/audio-volume-muted` icons are still being replaced with 
symlinks, so I still can't apply the patch. :(

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[Nathaniel Graham]

ngraham added a comment.


  Do you have commit access?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

To: loh.tar, #frameworks, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, I see now. A smaller dump. :)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

To: loh.tar, #frameworks, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[loh tar]

loh.tar added a comment.


  Um, no(?) In that case I would have named this patch "Add stretch to ensure 
Dump button is expanding"
  Sorry, next time I try to describe the pics more precise.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

To: loh.tar, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE Privacy Sprint - Find a date

[Sandro Knauß]

Hey,

We volunteered to organize a KDE Privacy Sprint. We wanted to make it happen 
in March. We think at a sprint of five days. The main goal for the sprint is 
to locate privacy issues and after locating them hopefully fix them. Let's 
take the advantage to speak in person with multiple people of different part 
in KDE to find solutions. Currently the date is not fixed, so we doodle for 
one:

https://bitpoll.mafiasi.de/poll/8BYKJA5B/

Please add yourself to the doodle fast, so that we can have a fixed date 
within the next weeks.

Explicitly we would like to invite people from following teams:
Plasma
Plasma mobile
Vault
Falkon
Choqok
KDE Pim
Frameworks

Please feel also invited, if you are not in such a team an be simply 
interested in that topic!

The sprint will either be located in Leipzig(Germany) or Les Magnas (France) 
http://auxsaisons.free.fr/. At the moment both options are still open, but 
soon we need to decide. What is your preference of place?

Some issues that came into my mind:

*  currently when clicking on a link in an email the url is accessed within 
Plasma and than forward this to Firefox. If the user wants to use TorBrowser 
as default browser it is a Privacy Breach.
 *  having an interface to torify/vpn applications

Wifi:

* detect wiki login pages - do not access internet before, e.g. you are 
using inet of a hotel
*  have a way to allow/dissallow applications interact with inet for specific 
wifis, e.g. you are using inet of a hotel

TLS:

* detecting bad SSL standards aka only TLS 1.0...
* more helpful SSL problem dialog (properly if you have a wifi login page)

Mails:

* Encrypting headers of mails to give less metadata to surveillance T742.
* Make it possible to search in encrypted mails, as until now, the encrypted 
data are a binary blob for the search. The search important to find mails 
again T8447.
* Add GnuPG TOFU (Trust On First Use) trust model support for KMail. With 
TOFU you will get more security without exchanging the gpg fingerprints. To 
make it clear, exchanging fingerprints gives better security, but is 
exhausting.
* Make Akregator webviewer protect against ad trackers T7528.

For more information look at https://phabricator.kde.org/T8622.

Share your thoughts and see you!

louise and hefee

signature.asc
Description: This is a digitally signed message part.

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[Nathaniel Graham]

ngraham added a comment.


  So this patch makes the Dump button much wider?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

To: loh.tar, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

[loh tar]

loh.tar edited the test plan for this revision.
loh.tar added a reviewer: VDG.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17026

To: loh.tar, #frameworks, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17191: Perfect alignment between QML and QWidget KCM titles

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  phab/perfectalignment

REVISION DETAIL
  https://phabricator.kde.org/D17191

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17190: Add level api from Kirigami.Heading

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/heading

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 updated this revision to Diff 46419.
trickyricky26 added a comment.


  - Change symlinks

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17220?vs=46418&id=46419

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/mic-off.svg
  icons/status/16/audio-off.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/mic-off.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  If you reverse that such that no existing files are replaced with symlinks, 
it will certainly make it easier to review this patch. If necessary, after that 
I can do the symlink switcheroo in a separate commit to keep life sane.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 added a comment.


  I changed the symlinks to point from the off icons to the muted icons; but I 
could reverse that.
  
  Before, the symlinks pointed from the muted icons to the off icons, except 
for `audio-{on;off;ready}` icons, which don't exist at `22px` at all. Perhaps I 
should add `audio-on` and `audio-ready` in `22px` as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Nathaniel Graham]

ngraham added a comment.


  Oh jeez, this patch replaces some icons with symlinks which makes Phabricator 
unable to apply the patch. :/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 271 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/271/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 28 Nov 2018 15:36:21 +
 Build duration:
3 min 33 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17220: Use red X in disabled and muted status icons consistently

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/mic-off.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/status/16/audio-off.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/mic-off.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17167: Provide a method of assigning custom default icons for non-XDG dirs

[Kai Uwe Broulik]

broulik added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17167

To: ngraham, #frameworks, cfeck, broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17193: KateViewInternal: Remove unneeded functions

[loh tar]

loh.tar updated this revision to Diff 46411.
loh.tar added a comment.


  I think that's all. 
  Well, it looks less beneficial as previous anticipated by me, but I think 
it's still the right direction.
  
  Just a view questions regarding the mix in the KTextEditor::ViewPrivate code 
how to access some data:
  
  - doc() vs m_doc: doc() is inline
  - cursorPosition() vs m_viewInternal->m_cursor: cursorPosition() is NOT inline
  
  I may have used in my patch also a mix due to the variety of existing code. 
Let me know which one to use.
  Furthermore I offer a S&R to unify the existing code, as an own DIFF/ticket 
or if you like in this one.
  
  Normally I would prefer the function calls, but because the highliting looks 
so nice :-) and cursorPosition() is not inline I'm undecided.
  Would it be make sense to change them to inline?
  
  Some more things I noticed and offer to change.
  
  - KateViewInternal::updateView (slot) calls KateViewInternal::doUpdateView 
(nowhere else called). Any benefit from that construct? Think its only a 
leftover from the ancient. (would make sense to include in this patch)
  
  - KateViewInternal::renderer() (often used) just returns 
KTextEditor::ViewPrivate::m_renderer but is NOT inline. When removed, could the 
call "renderer()" replaced by "m_view->m_renderer" or "m_view->renderer()" (the 
latter is also NOT inline)
  
  KateViewInternal contains some additional classes: CalculatingCursor, 
BoundedCursor, WrappingCursor, together ~275 lines
  ZoomEventFilter ~53 lines
  
  At least the cursor stuff looks worth to move into an own file.
  
  Some out-commented FIXME KF5 stuff (4 years old) encapsulated in #ifndef 
QT_NO_ACCESSIBILITY, lines ~1921 and ~747.
  May removed in above S&R offer when commit is named "Cleanup" or similar.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17193?vs=46327&id=46411

REVISION DETAIL
  https://phabricator.kde.org/D17193

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D7446: [Places panel] Revamp the Recently Saved section

[David Edmundson]

davidedmundson added a comment.


  Note also that Kickoff's "History" with recent files is /yet another/ 
completely different data source.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
sourabhboss, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Using "Recently Used" as the section header label presents the following 
problems:
  
  - One of the items is named "Recently Used"
  - The other items actually do not display a list of recently used files; they 
display a list of recently //saved// files.
  
  That's why I was trying to come up with a generic section header label that 
could feasible encompass both.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
sourabhboss, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 270 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/270/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 28 Nov 2018 12:04:39 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
  

D7446: [Places panel] Revamp the Recently Saved section

[TrickyRicky]

trickyricky26 added a comment.


  I like this change a lot, however I think the Section header should be 
changed from "Recents" to "Recently Used". I think Recents just sound inelegant 
and weird

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
sourabhboss, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

shubham added a comment.


  Waiting for green flags.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham

D17210: Added proxy and user settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added proxy and user settings according to:
  https://developer.gnome.org/NetworkManager/stable/settings-proxy.html 
https://developer.gnome.org/NetworkManager/stable/settings-user.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17210

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  src/CMakeLists.txt
  src/settings/proxysetting.cpp
  src/settings/proxysetting.h
  src/settings/proxysetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/usersetting.cpp
  src/settings/usersetting.h
  src/settings/usersetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17205: Build kio_nfs against standalone libtirpc

[Harald Sitter]

sitter added a comment.


  LGTM
  
  I do wonder if we should support ntirpc too though. At a glance it's largely 
the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two 
libs and both seem to actively get commits.

INLINE COMMENTS

> CMakeLists.txt:2
>  ## Check for XDR functions
> -include(CheckFunctionExists)
> +include(CheckSymbolExists)
>  

I think we need CheckCXXSymbolExists here. Since we use and link from C++, 
whether or not the symbols can be found and linked from C is of no importance.

> CMakeLists.txt:15-26
>  if (HAVE_XDR_U_INT64_T)
>  add_definitions(-DHAVE_XDR_U_INT64_T)
>  endif (HAVE_XDR_U_INT64_T)
>  if (HAVE_XDR_UINT64_T)
>  add_definitions(-DHAVE_XDR_UINT64_T)
>  endif (HAVE_XDR_UINT64_T)
>  if (HAVE_XDR_U_HYPER)

As you are in the code already, maybe replace this abomination with a 
`configure_file`? 😉

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D17205

To: asturmlechner, #dolphin, dfaure, rdieter
Cc: sitter, kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, alexde, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D17206: Rename NotifyByFlatpak to NotifyByPortal

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:bfdcffe5bc5b: Rename NotifyByFlatpak to NotifyByPortal 
(authored by jgrulich).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17206?vs=46379&id=46382

REVISION DETAIL
  https://phabricator.kde.org/D17206

AFFECTED FILES
  src/CMakeLists.txt
  src/knotificationmanager.cpp
  src/notifybyflatpak.cpp
  src/notifybyflatpak.h
  src/notifybyportal.cpp
  src/notifybyportal.h

To: jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  snap-support

REVISION DETAIL
  https://phabricator.kde.org/D17206

To: jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17190: Add level api from Kirigami.Heading

[Fabian Riethmayer]

fabianr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

[Jan Grulich]

jgrulich added a comment.


  In D17206#367286 , @jgrulich wrote:
  
  > Make SNAP to use notification portal
  
  
  I didn't mean to push this change into this review, but I guess it doesn't 
matter. If you want it separated I can submit it separately.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17206

To: jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

[Jan Grulich]

jgrulich updated this revision to Diff 46379.
jgrulich added a comment.


  Make SNAP to use notification portal

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17206?vs=46377&id=46379

BRANCH
  snap-support

REVISION DETAIL
  https://phabricator.kde.org/D17206

AFFECTED FILES
  src/CMakeLists.txt
  src/knotificationmanager.cpp
  src/notifybyflatpak.cpp
  src/notifybyflatpak.h
  src/notifybyportal.cpp
  src/notifybyportal.h

To: jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

[Jan Grulich]

jgrulich added a reviewer: broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17206

To: jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  Portals are now used by Snap too, no reason to be use anything Flatpak 
specific

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17206

AFFECTED FILES
  src/CMakeLists.txt
  src/knotificationmanager.cpp
  src/notifybyflatpak.cpp
  src/notifybyflatpak.h
  src/notifybyportal.cpp
  src/notifybyportal.h

To: jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17185: Added ip-tunnel settings

[Pranav Gade]

pranavgade updated this revision to Diff 46376.
pranavgade removed a subscriber: kde-frameworks-devel.
pranavgade added a comment.


  Made a few minor changes

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17185?vs=46310&id=46376

REVISION DETAIL
  https://phabricator.kde.org/D17185

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  src/CMakeLists.txt
  src/settings/iptunnelsetting.h

To: pranavgade, jgrulich
Cc: michaelh, ngraham, bruns, kde-frameworks-devel

D17185: Added ip-tunnel settings

[Pranav Gade]

pranavgade marked 5 inline comments as done.
pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in iptunnelsettingtest.cpp:79
> Use NetworkManager defines, do not define your own new defines, there is no 
> reason for that.

I tried to follow the way it is done in ipv6settings.

> jgrulich wrote in connectionsettings.cpp:195
> IpTunnel setting is not part of Tun connection, it should be completely 
> separated connection type.

What should the new connection type be called?

> jgrulich wrote in iptunnelsetting.h:74
> Maybe turn this into QFlags?
> 
> See:
> typedef enum { /*< flags, prefix=NM_IP_TUNNEL_FLAG >*/
>   NM_IP_TUNNEL_FLAG_NONE   = 0x0,
>   NM_IP_TUNNEL_FLAG_IP6_IGN_ENCAP_LIMIT= 0x1,
>   NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_TCLASS= 0x2,
>   NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FLOWLABEL = 0x4,
>   NM_IP_TUNNEL_FLAG_IP6_MIP6_DEV   = 0x8,
>   NM_IP_TUNNEL_FLAG_IP6_RCV_DSCP_COPY  = 0x10,
>   NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FWMARK= 0x20,
> } NMIPTunnelFlags;

What do you mean? Should I create a new Enum?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17185

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns