KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 23 Dec 2018 05:42:57 + Build duration: 1 min 37 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/95/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 23 Dec 2018 05:42:57 + Build duration: 1 min 45 sec and counting JUnit Tests Name: (root)

D17727: Get default web browser from xdg-settings if it’s not set in KDE

achauvel abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17727 To: achauvel Cc: ngraham, rdieter, kde-frameworks-devel, michaelh, bruns

D17727: Get default web browser from xdg-settings if it’s not set in KDE

ngraham added a comment. D17371 just landed, so you can probably Abandon this now (it's under the Add Action... menu). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17727 To: achauvel Cc: ngraham, rdieter, kde-frameworks-devel,

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 160 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/160/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 23 Dec 2018 04:14:41 + Build duration: 2 min 31 sec and counting CONSOLE OUTPUT

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7bd7f38400b9: [KRun] when asked to open link in external browser, fall back to mimeapps.list… (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

ngraham updated this revision to Diff 48040. ngraham marked an inline comment as done. ngraham added a comment. Style fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17371?vs=48022=48040 BRANCH arcpatch-D17371 REVISION DETAIL

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17741 To: mkoller, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

knauss added a comment. I have made sure that kde/pim is now cleanup in terms of the issue of "not runnig ABI", by triggering a rebuilt. So it is a good test if the patch is working. With more tests I have detected, that builds still use the oldest commit instead of tags commits (fix

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17745: resolve tags to the commit, that was tagged.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17737: [CopyJob] Create clones in btrf/xfs mount

bruns added a comment. I think it would be much simpler if you just tried to do the the FICLONE iotctl in the job, without any prior checking: - no possibility for races - less syscals - less code INLINE COMMENTS > copyjob.cpp:742 > +if (!isDir && info.linkDest.isEmpty() &&

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > krun.cpp:1423 > +// If a default browser isn't set in kdeglobals, fall back to > mimeapps.list > +if (! d->m_externalBrowser.isEmpty()) { > +

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

dfaure added a comment. I assume the processEvents() is necessary to process DBus disconnection, then? In that case let's add a comment, so the next person doesn't think this is unnecessary (it's certainly not necessary for the QLocalServer/QLocalSocket stuff). REPOSITORY R241 KIO

D17726: Add helper function to disable redirections (useful for kde-open)

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17726 To: achauvel, dfaure, #frameworks, cfeck Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

sandsmark accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH addWordToSession REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann, sandsmark Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17743: Extend getExtensionFromPatternList reg exp filtering

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY getExtensionFromPatternList turns a filter string such "*.cpp" etc into an extension ".cpp". It

D17726: Add helper function to disable redirections (useful for kde-open)

achauvel updated this revision to Diff 48028. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17726?vs=47986=48028 REVISION DETAIL https://phabricator.kde.org/D17726 AFFECTED FILES src/widgets/krun.cpp src/widgets/krun.h src/widgets/krun_p.h To:

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

mkoller edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17741 To: mkoller, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

mkoller created this revision. mkoller added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mkoller requested review of this revision. REVISION SUMMARY Currently when logging out, kio_http_cache_cleaner stays alive and blocks in

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17371 To: ngraham, #frameworks, broulik, cfeck, elvisangelaccio Cc: achauvel, kde-frameworks-devel, michaelh, ngraham, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

ngraham updated this revision to Diff 48022. ngraham added a comment. Reduce unnecessary nesting with an early return REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17371?vs=48021=48022 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17371

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

ngraham updated this revision to Diff 48021. ngraham added a comment. Reduce unnecessary nesting with an early return REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17371?vs=46913=48021 BRANCH

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

achauvel added a comment. I think it’s better than what I proposed (without knowing about yours) in D17727 . INLINE COMMENTS > krun.cpp:1421-1431 > + > +// If a default browser isn't set in kdeglobals, fall back to > mimeapps.list > +if

D17737: [CopyJob] Create clones in btrf/xfs mount

chinmoyr created this revision. chinmoyr added reviewers: dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY If Copy-on-Write is enabled in a btrfs/xfs mount then create a

D17623: Add YaST icons

ndavis added a comment. In D17623#380743 , @fvogt wrote: > Turns out it's a trivial issue: breeze's index.theme doesn't contain the parameters for `apps/64` so it's like that directory doesn't even exist. > > I don't know how to fix it

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17733 To: loh.tar, #ktexteditor, #vdg, ngraham Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns,

D17727: Get default web browser from xdg-settings if it’s not set in KDE

ngraham added a comment. I submitted almost the same diff in D17371 . :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17727 To: achauvel Cc: ngraham, rdieter, kde-frameworks-devel, michaelh, bruns

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

ngraham added reviewers: cfeck, elvisangelaccio. ngraham added a comment. Can I get a review on this (or another version someone else submitted: D17727 )? #frameworks people? #dolphin

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

ngraham retitled this revision from "[KRun] when asked to open link in external browser, ball back to mimeapps.list if nothing is set in kdeglobals" to "[KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals". REPOSITORY R241 KIO

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Toggle the action instead enable/disable ensure the user

D17619: Change the path for every item of the subdirectories in a directory rename

jtamate updated this revision to Diff 48004. jtamate marked 4 inline comments as done. jtamate added a comment. Changes requested done and reduced code duplication. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17619?vs=47995=48004 REVISION DETAIL

D17619: Change the path for every item of the subdirectories in a directory rename

jtamate added inline comments. INLINE COMMENTS > dfaure wrote in kdirlistertest.cpp:1326 > What's drive_c? I started this patch following the structure of .wine/drive_c ... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17619 To: jtamate, dfaure, #frameworks Cc:

D17623: Add YaST icons

fvogt added a comment. In D17623#380551 , @ndavis wrote: > In D17623#380549 , @fvogt wrote: > > > In D17623#380511 , @ndavis wrote: > > > > > @fvogt

D17528: Refactor SlaveInterface::calcSpeed

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4e2a815b9a10: Refactor SlaveInterface::calcSpeed (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17528?vs=47950=48003 REVISION DETAIL

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

dfaure updated this revision to Diff 48002. dfaure added a comment. Upgrade the unittest to be data-driven, and to test for many different cases. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17632?vs=47689=48002 BRANCH skip_stat REVISION DETAIL

D17619: Change the path for every item of the subdirectories in a directory rename

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirlistertest.cpp:1326 > +QCOMPARE(m_dirLister.url().toLocalFile(), newDir); > +QVERIFY(ok); > +currDir = newDir; What's drive_c? >

D17726: Add helper function to disable redirections (useful for kde-open)

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good otherwise. INLINE COMMENTS > krun.h:161 > + * @param b wether to follow redirections or not. > + */ > +void setFollowRedirections(bool b); Missing @since

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure added a comment. Please add a KIO version ifdef to avoid breaking compilation with older versions of KIO. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham,

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48000. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Move the modified-label from far right to far left Once again without all other patches REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. How about to change the "action-labels" to buttons? Thisway would it be less "quirky" and we would have a feedback that there is an action available when hovered by mouse REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To:

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. Oops, have now the first commit omitted in this update. Perhaps not too bad this way(?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 47998. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Don't treat click in empty area as click on mode-label REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - KateStatusBar: Do actions on labels by single click instead

D17619: Change the path for every item of the subdirectories in a directory rename

jtamate updated this revision to Diff 47995. jtamate added a comment. Added the unit test. It crashes for me every time without the patch and none with the patch. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17619?vs=47731=47995 REVISION DETAIL

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar added a comment. Nothing else was done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17729 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar created this revision. loh.tar added reviewers: KTextEditor, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL