D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kcheckaccelerators.cpp:97
> +
> +if (!app->eventDispatcher()) {
> +// We are called with event dispatcher being null when KXmlGui is 
> being loaded

That's static member, you don't need instance. BTW can we check only for null 
app, i mean if it's not directly linked library qapp will be null, it's not 
checked.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D18204

To: aacid
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  BUGS: 337491

TEST PLAN
  Ran qtcreator and it no longer has the & in Details
  Added some debug and checked that okular still gets the code called

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18204

AFFECTED FILES
  src/kcheckaccelerators.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18201: Consistently fill the lock in the encrypted icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:27a6c17638c9: Consistently fill the lock in the encrypted 
icon (authored by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18201?vs=49299&id=49302

REVISION DETAIL
  https://phabricator.kde.org/D18201

AFFECTED FILES
  icons-dark/mimetypes/22/application-pgp-encrypted.svg
  icons/mimetypes/22/application-pgp-encrypted.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18201: Consistently fill the lock in the encrypted icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops! Nice catch.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-encrypted-22 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18201

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18199

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 49301.
trickyricky26 edited the summary of this revision.
trickyricky26 added a comment.


  - Use a lighter color for 16px and 22px

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18199?vs=49293&id=49301

BRANCH
  add-kotlin-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18199

AFFECTED FILES
  icons-dark/mimetypes/16/text-x-kotlin.svg
  icons-dark/mimetypes/22/text-x-kotlin.svg
  icons-dark/mimetypes/32/text-x-kotlin.svg
  icons-dark/mimetypes/64/text-x-kotlin.svg
  icons/mimetypes/16/text-x-kotlin.svg
  icons/mimetypes/22/text-x-kotlin.svg
  icons/mimetypes/32/text-x-kotlin.svg
  icons/mimetypes/64/text-x-kotlin.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18201: Consistently fill the lock in the encrypted icon

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18201

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18201: Consistently fill the lock in the encrypted icon

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18201

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18201: Consistently fill the lock in the encrypted icon

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-encrypted-22 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18201

AFFECTED FILES
  icons-dark/mimetypes/22/application-pgp-encrypted.svg
  icons/mimetypes/22/application-pgp-encrypted.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18038: Fix semantics for ghns_exclude

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, in addition to the testing tool working, this patch seems to actually 
fix the issue in production (e.g. "Tree on Island" is no longer visible in the 
wallpaper downloader), and as far as I can tell the code is sane. Thanks for 
the additional documentation and commenting too.
  
  Should this be marked as actually fixing 402888? If so, it should be `BUG: 
402888`

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18038

To: leinir, ronaldv, #kde_store, ngraham
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, 
alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck

D18199: Add Kotlin (.kt) mimetype icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18199

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  Pretty pictures? :) As discussed in chat, you'll need to submit a merge 
request to add support in `shared-mime-info` too.
  
  Here is a commit where someone else added a new mimetype: 
https://gitlab.freedesktop.org/xdg/shared-mime-info/commit/7dea7e65c4f6872d70d1b17141caa11196e6405b
  
  Hopefully you can use that as a template/inspiration for yours.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18199

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18192: Remove unused forward declaration

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18192

To: vkrause, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 11 Jan 2019 21:00:32 +
 Build duration:
6 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D17797: Include applets/22

[Nicolas Fella]

nicolasfella updated this revision to Diff 49294.
nicolasfella added a comment.


  - Rebase
  - add to Breeze dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17797?vs=48191&id=49294

BRANCH
  fix

REVISION DETAIL
  https://phabricator.kde.org/D17797

AFFECTED FILES
  icons-dark/index.theme
  icons/index.theme

To: nicolasfella, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns

D18199: Add Kotlin (.kt) mimetype icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-kotlin-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18199

AFFECTED FILES
  icons-dark/mimetypes/16/text-x-kotlin.svg
  icons-dark/mimetypes/22/text-x-kotlin.svg
  icons-dark/mimetypes/32/text-x-kotlin.svg
  icons-dark/mimetypes/64/text-x-kotlin.svg
  icons/mimetypes/16/text-x-kotlin.svg
  icons/mimetypes/22/text-x-kotlin.svg
  icons/mimetypes/32/text-x-kotlin.svg
  icons/mimetypes/64/text-x-kotlin.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Fabian Vogt]

fvogt added a comment.


  In D10716#391331 , @jriddell wrote:
  
  > > Is it necessary to write the mock su/sudo in python? That introduces a 
big and mostly unnecessary dependency on python.
  >
  > Nope but that's what was easiest for me and I'm out of energy for this
  >
  > > The testcases would be simpler if it used QTESTDATA and rows for the 
su/sudo and correct/incorrect password cases
  >
  > Something else I need to learn about.
  
  
  Ok, those aren't major issues anyway.
  
  >> By adding a new constructor to SuCommand which allows to specify the full 
path to su/sudo, testing would be much easier. It might be usable outside of 
the tests as well.
  > 
  > I looked at that but I'd be scared of introducing binary incompatiblity.  
This approach covers the current needs.
  
  I don't really like that there's now a config entry only used for and during 
testing, maybe an environment variable would work?
  
  Other than that, this is still missing:
  
  - Autotests need to be conditional based on BUILD_TESTING
  
  It would be nice to have a check for python3 as well, but IMO the message on 
failure should be obvious enough.

INLINE COMMENTS

> jriddell wrote in su:28
> Not sure what you mean by won't work anywhere else, it'll work using the 
> kdesu_stub which is built by the local compile.  It doens't need kdesu_stub 
> to be installed.

Now it doesn't - the comment was referring to the hardcoded path to kdesu_stub, 
which is now gone.

To avoid such misleading comments in the future, you can mark a comment as done 
to prevent it from reappearing out of context.

> suprocess.cpp:122
> +KConfigGroup group(config, "super-user-command");
> +QByteArray defaultPath = QByteArray(CMAKE_INSTALL_FULL_LIBEXECDIR_KF5) + 
> "/kdesu_stub";
> +QString kdesuStubPath = group.readEntry("kdesu_stub_path", 
> QString::fromLatin1(defaultPath));

Use QStringLiteral instead.

> suprocess.h:75
>  private:
> +friend class KdeSuTest;
>  enum SuErrors {

Still necessary?

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18192: Remove unused forward declaration

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Technically SIC, but this is "leaking" D-Bus related classes into user
  code which doesn't exist on Android.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18192

AFFECTED FILES
  src/knotification.h

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18191: Rebuild AAR when Java sources change

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This is a fairly aggressive heuristic, but that's fine as Gradle wont do
  much if nothing relevant changed, so it's more important that we don't
  miss anything.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18191

AFFECTED FILES
  cmake/modules/FindGradle.cmake

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 11 Jan 2019 16:47:30 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:24ba84914a84: [kcmutils] Add ellipsis to search labels in 
KPluginSelector (authored by Krešimir Čohar , committed 
by GB_2).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18043?vs=48872&id=49264

REVISION DETAIL
  https://phabricator.kde.org/D18043

AFFECTED FILES
  src/kpluginselector.cpp

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, pino, shubham, kde-frameworks-devel, michaelh, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

[David Faure]

dfaure added a comment.


  A unittest for this fix would have been even better ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18187

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R276:649157422e4e: [kitemviews] Change the search in Desktop 
Behavior/Activities to more in line… (authored by Krešimir Čohar 
, committed by GB_2).

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18046?vs=49041&id=49260

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18045: [kio] Add ellipsis to search label in Cookies section

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e4679f600075: [kio] Add ellipsis to search label in 
Cookies section (authored by Krešimir Čohar , committed 
by GB_2).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18045?vs=48875&id=49259

REVISION DETAIL
  https://phabricator.kde.org/D18045

AFFECTED FILES
  src/kcms/kio/kcookiespolicies.ui

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 11 Jan 2019 16:37:30 +
 Build duration:
7 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:28dacfe07375: [KNewFileMenu] Don't emit fileCreated 
when creating a directory (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18187?vs=49251&id=49254

REVISION DETAIL
  https://phabricator.kde.org/D18187

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Test still passes, creating new files and directories still works, 
conceptually makes sense, fixes 403100. Thanks for doing this @chinmoyr!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18187

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18187

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  BUG: 403100

TEST PLAN
  unit tests pass.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18187

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: chinmoyr, ngraham
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18158: Fix elapsed time check

[Chinmoy Ranjan Pradhan]

chinmoyr accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18158

To: davidedmundson, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell added inline comments.

INLINE COMMENTS

> fvogt wrote in su:28
> That won't work anywhere else and requires that the binary is installed when 
> running tests.

Not sure what you mean by won't work anywhere else, it'll work using the 
kdesu_stub which is built by the local compile.  It doens't need kdesu_stub to 
be installed.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked 3 inline comments as done.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked an inline comment as done.
jriddell added a comment.


  > Is it necessary to write the mock su/sudo in python? That introduces a big 
and mostly unnecessary dependency on python.
  
  Nope but that's what was easiest for me and I'm out of energy for this
  
  > By adding a new constructor to SuCommand which allows to specify the full 
path to su/sudo, testing would be much easier. It might be usable outside of 
the tests as well.
  
  I looked at that but I'd be scared of introducing binary incompatiblity.  
This approach covers the current needs.
  
  > The testcases would be simpler if it used QTESTDATA and rows for the 
su/sudo and correct/incorrect password cases
  
  Something else I need to learn about.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49244.
jriddell added a comment.


  - remove unused variable
  - remove unused include
  - use QStandardPaths::setTestModeEnabled
  - tidy up includes and defines
  - refactor out config setting to remove duplication

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49175&id=49244

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18164: Review KateGotoBar

[loh tar]

loh.tar updated this revision to Diff 49243.
loh.tar added a comment.


  - Use 120 as wheel-delta threshold
  - Use member instead of static local
  
  > If not do it right you can end up in partial value when it used 
finer-resolution wheels and mishmash.
  
  I have problems to see that hazard, na matter.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18164?vs=49185&id=49243

REVISION DETAIL
  https://phabricator.kde.org/D18164

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h

To: loh.tar, #ktexteditor
Cc: cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 21 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/21/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 11 Jan 2019 12:27:51 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kbookmarktest

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/4/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 11 Jan 2019 12:27:15 +
 Build duration:
3 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 15 lines...]Cloning repository git://anongit.kde.org/prison > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11 # timeout=10Checking out Revision 1c4a6198d690aef7010b23a5965dc0cbb669d47d (origin/master)Fetching upstream changes from git://anongit.kde.org/prison > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/prison +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/prison # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/prison # timeout=10Fetching upstream changes from git://anongit.kde.org/prison > git fetch --tags --progress git://anongit.kde.org/prison +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 1c4a6198d690aef7010b23a5965dc0cbb669d47dCommit message: "Fix clazy warning"[Pipeline] checkoutCloning the remote Git repository > git rev-list --no-walk c7305256a20dc1df4d6299f203055943569b9f1b # timeout=10Cloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/*Checking out Revision b35b63707f91ce03dc5be3abd4375c89be6df107 (origin/master)Commit message: "Fix errors with paths with a space."[Pipeline] checkoutCloning the remote Git repository > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f b35b63707f91ce03dc5be3abd4375c89be6df107Cloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision 39ad2a4a9bc543e186e6d63701cc775371d75121 (origin/master) > git rev-parse origin/master^{commit} # timeout=10Commit message: "releases made directly from master. this Plasma/5.4 branch is obsolete and does not compile"[Pipeline] checkoutCloning the remote Git repository > git config core.sparsecheckout # timeout=10 > git checkout -f 39ad2a4a9bc543e186e6d63701cc775371d75121Cloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision cae7bbe70a08669862eac8561524169f25a557e3 (origin/master)Commit message: "Add headings"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout

D17691: Add rows info to the plasma virtual desktop protocol

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> test_plasma_virtual_desktop.cpp:280
> +m_plasmaVirtualDesktopManagementInterface->setRows(3);
> +rowsChangedSpy.wait();
> +QCOMPARE(m_plasmaVirtualDesktopManagement->rows(), 3);

QVERIFY

> plasmavirtualdesktop.h:168
>  
> +void rowsChanged(quint32 rows);
> +

Missing documentation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17691

To: mart, #plasma, #kwin
Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

[Eike Hein]

hein added a comment.


  > The desktop cube shows everything flat, desktop grid is configurable (and 
hardcoded).
  
  The desktop grid effect uses the rows setting from the KCM for me.
  
  I don't think it's easy for users to understand that the KCM is configuring 
KWin only, instead of all of Plasma. Especially because the Pager can't escape 
KWin's spatial notions anyway: If you use the Pager to switch desktops, by 
default KWin does a slide animation that's directional based on the rows 
setting. If the Pager's layout differs from KWin's, the animation played won't 
fit what's visible on the Pager. Considering the Pager is all about providing a 
spatial overview into the system, this seems weird.
  
  Plus this protocol is meant to be a private one for use between KWin and 
plasmashell. I think it's OK for them to integrate tightly, it's not the same 
as exposing layout information to regular clients. I'd argue the entire 
PlasmaWindowManagement protocol already does so after all.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17691

To: mart, #plasma, #kwin
Cc: davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

[David Edmundson]

davidedmundson added a comment.


  I thought we had a whole conversation in the first set of reviews that views 
(layout) was independent of data.
  
  The desktop cube shows everything flat, desktop grid is configurable (and 
hardcoded).
  The pager is just another view, there's no need to sync with kwin's grid?

INLINE COMMENTS

> plasma-virtual-desktop.xml:56
>  
> +
> +

This needs to be in a version 2 and done at the end with appropriate bumps 
everywhere.

> plasmavirtualdesktop_interface.h:51
>   */
>  void setLayout(quint32 rows, quint32 columns);
>  

Is this even implemented?? I can't find it

If so it's technically safe to remove from the header, but it's a pretty 
rubbish situation to begin with.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17691

To: mart, #plasma, #kwin
Cc: davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18178: fix environment setup of klanguagename test

[Rik Mills]

rikmills accepted this revision.
rikmills added a comment.
This revision is now accepted and ready to land.


  Build and passes on Kubuntu CI now.
  
  
https://launchpadlibrarian.net/405807438/buildlog_ubuntu-disco-amd64.kconfigwidgets_5.54.0+p19.04+git20190111.1036-0_BUILDING.txt.gz

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18178

To: sitter, aacid, rikmills
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18178: fix environment setup of klanguagename test

[Harald Sitter]

sitter created this revision.
sitter added reviewers: aacid, rikmills.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  - use correct env vars LANG and LANGUAGE
  - as an additional safety-net explicitly set QLocale default to english
  
  (the latter kinda overrides the former, but better save than sorry since it
  has no adverse effects to do both)
  
  this should make tests pass regardless of potentially weird env states some
  CIs may have

TEST PLAN
  test passes on kubuntu ci. my theory is that QLocale picked the default 
before the env was set up and therefore used `C` instead of `en` thus bypassing 
the en=>en_US coercion

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18178

AFFECTED FILES
  autotests/klanguagenametest.cpp

To: sitter, aacid, rikmills
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Harald Sitter]

sitter added a comment.


  Oh actually. I have a theory. My environment vars were wrong. Try with 
s/LANG/LANGUAGE and s/LOCALE/LANG please.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: rikmills, vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, 
apol, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Harald Sitter]

sitter added a comment.


  You'll have to debug this for us. It passes on build.kde.org 😒

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: rikmills, vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, 
apol, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Rik Mills]

rikmills added a comment.


  Kubuntu CI builds
  
  2/4 Test #3: klanguagenametest ***Failed0.03 sec
  
  - Start testing of KLanguageNameTest *
  
  Config: Using QtTest library 5.11.3, Qt 5.11.3 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 8.2.0)
  PASS   : KLanguageNameTest::initTestCase()
  FAIL!  : KLanguageNameTest::testNameForCode() Compared values are not the same
  
Actual   (KLanguageName::nameForCode("en")): "English"
Expected ("US English"): US English
Loc: 
[/<>/kconfigwidgets-5.54.0+p19.04+git20190111.0330/autotests/klanguagenametest.cpp(46)]
  
  PASS   : KLanguageNameTest::testNameForCodeInLocale()
  PASS   : KLanguageNameTest::testNoTranslation()
  PASS   : KLanguageNameTest::testNoEntry()
  PASS   : KLanguageNameTest::testNoString()
  PASS   : KLanguageNameTest::cleanupTestCase()
  Totals: 6 passed, 1 failed, 0 skipped, 0 blacklisted, 6ms
  
  - Finished testing of KLanguageNameTest *

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: rikmills, vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, 
apol, michaelh, ngraham, bruns

D18038: Fix semantics for ghns_exclude

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D18038#390748 , @ngraham wrote:
  
  > What is the test tool? Can you help a total n00b like me learn how to test 
KNewStuff patches like these?
  
  
  The test tool is khotnewstuff_test in tests/. It's not installed, but once 
compiled it's in (build)/bin/khotnewstuff_test and can be run from there once 
the libraries are installed. For the most useful output, be sure to turn on all 
of the KNewStuff debug output, and then pass it a knsrc file. For example, what 
i use is
  
QT_LOGGING_RULES="org.kde.knewstuff.*=true" ./bin/khotnewstuff_test 
/etc/xdg/peruse.knsrc
  
  You then get a nice little UI which lets you run a couple of tests (engine 
test initialises the engine and lists the first page of content in the 
requested categories using the default sort order, and if you turn on the 
option underneath that, it will also attempt to download them). If you don't 
give it a knsrc file, it'll just use the static data found in tests/testdata.
  
  As you can tell, it's a super simple tool, and could of course be improved :) 
Haven't really had the need to do so, since the more advanced features seem 
better tested on live installs, and this one is more for testing out the very 
most basic functionality (which is just sort of expected to work in proper 
applications).
  
  > Also, the correct formatting is `CCBUG: 402888`. See 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
  
  Ah yes, quite, i've only been using those hooks for about a decade ;) You'd 
imagine i would be able to remember them at some point. Not that the bug hooks 
work for me, mind, but still :P

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18038

To: leinir, ronaldv, #kde_store, ngraham
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, 
alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck