Re: Power Management and Inhibition by Applications

[Kai Uwe Broulik]

Hi,


I had thought that would only inhibit the screensaver instead of automatic
sleep.


KScreenLocker (previously KSMServer) that owns the 
org.freedesktop.ScreenSaver interface tells PowerDevil to keep the 
screen on when screensaver is inhibited. It makes no sense to prevent 
the screen from locking (ie. keep the desktop visible) but then allow 
the screen to turn off, having the same effect: hiding the desktop.



I did a quick test and in case I inhibit through org.freedesktop.ScreenSaver
interface, the battery applet does not indicate any inhibit whereas through
org.freedesktop.PowerManagement.Inhibit indicates that an inhibition is valid.


It should and it does here. Note that PowerDevil only enforces 
inhibitions after five seconds to prevent short transient inhibitions 
(e.g. web browsers block suspend when playing audio which could also 
lead to short notification sounds prolonging the time until suspend)



I wonder if I should not instead make usage of the Inhibit mechanism from
logind coupled with powerdevil. I am not sure if this is desired.


It is and I would love that, I just haven't had the time to implement it.

Also I'm a bit tired of adding yet another inhibition interface (we 
already have like three or four of them) of the "but this time, I 
promise, it will be perfect!!" kind. Last time I checked logind didn't 
offer signals for when an inhibition was added/removed, so the "xyz is 
curently blocking PM" in Battery Monitor might not be possible anymore 
this way.


Cheers
Kai Uwe

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 82 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/82/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 23 Jan 2019 04:00:04 +
 Build duration:
5 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 81 - Aborted!

[CI System]

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:49372 failed. The channel is closing down or has closed down

D18380: KIO: make file dialog columns resizable again (and movable)

[Nathaniel Graham]

ngraham added a comment.


  The behavior is better now, thanks. I think it will be sufficient to fix the 
bug and not generate user complaints about anything!
  
  I'll let someone else do the code review. Maybe someone from #frameworks 
 or #dolphin 
? That said, one thing sticks out at 
me:

INLINE COMMENTS

> kdiroperatordetailview.cpp:296
> +
> +#include "kdiroperatordetailview.moc"

This is almost always wrong. Can you explain why you think it's required here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

[Nathaniel Graham]

ngraham added a comment.


  Better, though for the 32px version, the shreds feel too skinny. Maybe making 
them 2px wide might improve the look?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Dominik Haumann]

dhaumann added a comment.


  Is KateRenderer::setPrinterFriendly() only called in print preview mode? I 
think not.
  
  What is the bahavior currently when you print a page with another schema, and 
then print a page again? Does it always fallback to Printing without the patch, 
or does it remember the previous schema?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb set the repository for this revision to R241 KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb updated this revision to Diff 50084.
rjvbb added a comment.


  the change to the headerfile was now redundant.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18380?vs=50083=50084

REVISION DETAIL
  https://phabricator.kde.org/D18380

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb set the repository for this revision to R241 KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb updated this revision to Diff 50083.
rjvbb added a comment.


  Well, that was "interesting".
  
  It turns out that Qt has what looks like another path through which section 
sizes are calculated and through which they're shown, which apparently isn't 
used in file dialogs but which sometimes gets used when the detail view widget 
is used in a (Kate) side-bar. That path could give (much) smaller name column 
sizes than the designated minimum but also somewhat larger sizes. All this led 
to the "jarring effect" seen in Nate's video, which did not have anything to do 
with the font  being squeezed.
  
  I've been able to catch the smaller sizes by subclassing `QHeaderView` and 
overriding `sectionSizeFromContents()` and by calling 
`QTreeView::resizeColumnToContents(0)` when resizing; when a larger name column 
width is determine while in "narrow mode" that value now becomes the designated 
minimum so that the column doesn't "hesitate" between the 2 values (more than 
once).
  Calling `QTreeView::resizeColumnToContents` can reduce resizing reactivity 
noticeably so the call is omitted when the widget is used in a file dialog
  
  The font squeezing feature has been dropped.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18380?vs=50032=50083

REVISION DETAIL
  https://phabricator.kde.org/D18380

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Vlad Zagorodniy]

zzag added a comment.


  In D18167#398076 , @graesslin 
wrote:
  
  > The human error exists as long as clang-tidy is not used. What I fear is 
that someone does a hand porting - we have seen several attempts to do that in 
KWin from various developers. If devs don't know and now fix the warnings, they 
can bring in human error.
  
  
  If I understand this paragraph correctly, introduction of unrelated changes, 
which can break code, is a human error, is it correct?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, 
kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

[loh tar]

loh.tar updated this revision to Diff 50082.
loh.tar retitled this revision from "ViewPrivate: Make applyWordWrap() more 
comfortable" to "ViewPrivate: Make 'Apply Word Wrap' more comfortable".
loh.tar added a comment.


  - Use std::unique_ptr for the cursor
  - Oops!? Use 'if' instead of unneeded 'while' loop which also avoid 'goto'
  
  Regarding autotest point me to some blue print and I will try to do it.
  
  Should you love it as it is and intend to commit, I would update the summary 
section before and look at that "What this" hint.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17949?vs=48639=50082

REVISION DETAIL
  https://phabricator.kde.org/D17949

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[David Edmundson]

davidedmundson added a comment.


  Almost every project has already been gone over with clang-tidy.
  Including kwin which was then force-pushed back by you. This was back in June 
2017. 
  I've got little sympathy if we have a warning after explicitly reverting the 
fix to the warning.
  
  I don't particularly buy the arguments against:
  
  - It doesn't break git blame, as you need to know how to go quickly go 
through revisions to be able to use git blame in any real scenario anyway.
  - If you use the argument that the warning is useless then by definition an 
incorrect override is equally useless and therefore harmless.
  
  If kwin wants to do something special, (and given it does already for clang 
that seems like a non-issue, it would actually be removing code!), I disagree 
but won't stop it.
  
  I see no reason to revert this.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: davidedmundson, kossebau, graesslin, apol, vkrause, kde-frameworks-devel, 
kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/6/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 22 Jan 2019 18:30:19 +
 Build duration:
6 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3142/3844)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1171/1559)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18450: Add extractor for AppImage files

[Alexander Stippich]

astippich added a comment.


  Can you add a test please?
  
  In D18450#397920 , @kossebau wrote:
  
  > There seems to be some bug with the Comment field though, somehow in 
Dolphin the comment is not shown, where "dump" displays it as existing.
  
  
  That property "conflicts" with the xattr comment and is excluded in 
baloo-widgets because of that.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: astippich, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 22 Jan 2019 18:23:58 +
 Build duration:
6 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.exiv2extractortestFailed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)81%
(3126/3843)47%
(4578/9707)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)96%
(839/871)48%
(1806/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1168/1558)47%
(2223/4717)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/15/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 22 Jan 2019 18:26:05 +
 Build duration:
2 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3142/3844)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1171/1559)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 22 Jan 2019 18:25:58 +
 Build duration:
55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/14/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 22 Jan 2019 18:23:58 +
 Build duration:
2 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.exiv2extractortestFailed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)81%
(3126/3843)47%
(4578/9707)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)96%
(839/871)48%
(1806/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1168/1558)47%
(2223/4717)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18010: Fix failing test of exiv gps data

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:c3fbdea4f7f3: Fix failing test of exiv gps data (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18010?vs=49750=50079

REVISION DETAIL
  https://phabricator.kde.org/D18010

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 22 Jan 2019 18:23:58 +
 Build duration:
55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: projectroot.autotests.exiv2extractortest

D18205: Test empty and zero gps data

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:15d8c42d8ce0: Test empty and zero gps data (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18205?vs=49749=50078

REVISION DETAIL
  https://phabricator.kde.org/D18205

AFFECTED FILES
  autotests/exiv2extractortest.cpp
  autotests/exiv2extractortest.h
  autotests/samplefiles/test_no_gps.jpg
  autotests/samplefiles/test_zero_gps.jpg

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 50077.
kossebau added a comment.


  - skip getting the unlocalized description if there is a localized one

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18450?vs=50073=50077

BRANCH
  addappimageextractor

REVISION DETAIL
  https://phabricator.kde.org/D18450

AFFECTED FILES
  CMakeLists.txt
  src/extractors/CMakeLists.txt
  src/extractors/appimageextractor.cpp
  src/extractors/appimageextractor.h

To: kossebau, #baloo
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 50073.
kossebau added a comment.


  - switch and use any localized versions found matching the current system 
locale, should be more expected
  - also extract appdata  and expose as plain text, even though 
that can be quite some data, but that's the UI's task to handle that

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18450?vs=50050=50073

BRANCH
  addappimageextractor

REVISION DETAIL
  https://phabricator.kde.org/D18450

AFFECTED FILES
  CMakeLists.txt
  src/extractors/CMakeLists.txt
  src/extractors/appimageextractor.cpp
  src/extractors/appimageextractor.h

To: kossebau, #baloo
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18457: Add a preferences-desktop-effects icon

[TrickyRicky]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9ee939e4b914: Add a preferences-desktop-effects icon 
(authored by trickyricky26, committed by Krešimir Čohar 
kco...@gmail.com).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18457?vs=50071=50072

REVISION DETAIL
  https://phabricator.kde.org/D18457

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-effects.svg
  icons/preferences/32/preferences-desktop-effects.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

Re: Power Management and Inhibition by Applications

[Matthieu Gallien]

Hello,

On samedi 19 janvier 2019 12:19:10 CET Elvis Angelaccio wrote:
> On 16/01/19 22:07, Matthieu Gallien wrote:
> > Hello,
> > 
> > I am trying to work on a feature request to add the ability to suppress
> > laptop sleep when playing music.
> > 
> > Currently, Juk is doing it via dbus calls to
> > "org.kde.Solid.PowerManagement".
> > 
> > I also had a look to Solid frameworks and the power classes that add an
> > asynchronous way to do that.
> > Currently, the Solid framework only conditionally provides those features
> > and it seems distributions (at least Debian) do not always build it.
> > 
> > I am also unsure about the current recommended solution that would work
> > for
> > most desktop environments.
> > 
> > What would be the best way forward ?
> 
> Hi,
> the "official" way to achieve that should be a dbus call to the
> org.freedesktop.ScreenSaver interface (methods Inhibit and UnInhibit).

I had thought that would only inhibit the screensaver instead of automatic 
sleep.
I did a quick test and in case I inhibit through org.freedesktop.ScreenSaver 
interface, the battery applet does not indicate any inhibit whereas through 
org.freedesktop.PowerManagement.Inhibit indicates that an inhibition is valid.

I wonder if I should not instead make usage of the Inhibit mechanism from 
logind coupled with powerdevil. I am not sure if this is desired.

I would forward inhibit request to logind and checks existing inhibition 
before allowing powerdecil to suspend.

> > I can also see some other features that could make sense to provide in
> > libraries that music players could use (lyrics fetching, album art
> > fetching, ...). This could be in a dedicated framework to help build
> > media players.
> > 
> > Best regards
> > 
> > --
> > Matthieu Gallien
> 
> Cheers,
> Elvis

Best regards

D18457: Add a preferences-desktop-effects icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Love it! @trickyricky26 you might consider signing up for a developer account 
so you can land your own patches. See 
https://community.kde.org/Infrastructure/Get_a_Developer_Account

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-effects-preferences-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18457

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Martin Flöser]

graesslin added a comment.


  The human error exists as long as clang-tidy is not used. What I fear is that 
someone does a hand porting - we have seen several attempts to do that in KWin 
from various developers. If devs don't know and now fix the warnings, they can 
bring in human error.
  
  Thus I suggest that those who think this should be the default for all 
projects by KDE do the work to run clang-tidy over the complete KDE code base 
and afterwards enable this warning.
  
  I'm just not happy with the approach of breaking workflow without any 
discussion at all with the larger community. We have points in time where we 
can break things. E.g. the upcoming Qt 6. What I do not like is breaking in the 
middle of a release cycle without any coordination. Also I don't want to spend 
my very little spare time hunting behind what broke KWin build. I'm really not 
pleased about this from above attitude to break the compile of projects. It's 
one of the "dann macht euren Scheiss doch selbst" moments.
  
  Btw. of course KWin is fully maintained - also the old xcb code. It's just 
not possible to review 500+ line changes with someone adding override. 
Furthermore we have here virtuals which nobody touched for 15 years, but git 
blame on them is super important. And if you wonder: we have 1555 override in 
KWin. We use the new possibilities. We just don't adjust the old code base 
which nobody touches. I'm sure you all will be the first one to yell if KWin 
breaks and renders your desktop unusable. Yes we have very strict requirements 
on stability. A change for the sake of change is not done in KWin.
  
  So please revert this change and do a proper approach, talk to the community, 
ensure that this doesn't cause any new warnings and thus make it a useful new 
warning. In the current state it only causes work without any benefits for KWin.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: kossebau, graesslin, apol, vkrause, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D18457: Add a preferences-desktop-effects icon

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18457

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18457: Add a preferences-desktop-effects icon

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-effects-preferences-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18457

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-effects.svg
  icons/preferences/32/preferences-desktop-effects.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 50067.
trickyricky26 added a comment.


  - Use different, more recognizable pattern for the shredded part

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18439?vs=50026=50067

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 22 Jan 2019 14:23:08 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26487/31340)52%
(10516/20077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)97%
(12061/12371)49%
(6292/12853)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6264/7382)64%
(1801/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)86%
(7726/8956)65%
(2254/3456)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 22 Jan 2019 14:23:08 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/11/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 22 Jan 2019 14:23:08 +
 Build duration:
5 min 46 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26660/31344)53%
(10634/20077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12203/12372)50%
(6390/12853)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6270/7383)64%
(1802/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7751/8958)66%
(2273/3456)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

[loh tar]

loh.tar updated this revision to Diff 50061.
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - const QChar as value, not reference
  - Add , ; - + ^ ° § & just for completeness

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17693?vs=49452=50061

REVISION DETAIL
  https://phabricator.kde.org/D17693

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, dhaumann

D17691: Add rows info to the plasma virtual desktop protocol

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:d1e8b45d9310: Add rows info to the plasma virtual desktop 
protocol (authored by mart).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17691?vs=50046=50063

REVISION DETAIL
  https://phabricator.kde.org/D17691

AFFECTED FILES
  autotests/client/test_plasma_virtual_desktop.cpp
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/registry.cpp
  src/server/plasmavirtualdesktop_interface.cpp
  src/server/plasmavirtualdesktop_interface.h

To: mart, #plasma, #kwin, davidedmundson
Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18455: Port to new connect syntax

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Port some Q_PRIVATE_SLOTS in CopyJob and TransferJob to new syntax.

TEST PLAN
  Relevant unit test pass.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18455

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/job_p.h
  src/core/transferjob.cpp
  src/core/transferjob.h

To: chinmoyr, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb added a comment.


  > I'm still going to try to fix this
  
  Good thing I did (am doing), because what you call the jarring exists also 
without font stretching. It's something in Qt that somehow doesn't occur in 
file dialogs but only with applications of the widget like in Kate. It is 
caused by the name column being set to a sort of minimum size, for now beyond 
my control.
  
  I now have it to the point where the state only occurs transiently when you 
resize the Kate sidebar. That's still annoying so I'm looking into what can be 
done through a custom subclass of QHeaderView. There's only 1 virtual method I 
can override and have called by QTreeView but that may be exactly the one we 
need.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  phab/virtualdesktoprows

REVISION DETAIL
  https://phabricator.kde.org/D17691

To: mart, #plasma, #kwin, davidedmundson
Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18116: Don't show document load trouble twice

[Christoph Cullmann]

cullmann added a comment.


  I would not change that here, I would just ignore it in the application, as 
said in the other diff.

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18450: Add extractor for AppImage files

[Kai Uwe Broulik]

broulik added a comment.


  Cool!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Example screenshot: F6561839: Screenshot_20190122_102745.png 

  
  There seems to be some bug with the Comment field though, somehow in Dolphin 
the comment is not shown, where "dump" displays it as existing.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Only a few properties currently can be mapped more or less to the existing
  values of the "Property" enum, ideally for the future can be extended.

TEST PLAN
  "dump" test util and Dolphin both now show the extracted metadata for
  AppImage files.

REPOSITORY
  R286 KFileMetaData

BRANCH
  addappimageextractor

REVISION DETAIL
  https://phabricator.kde.org/D18450

AFFECTED FILES
  CMakeLists.txt
  src/extractors/CMakeLists.txt
  src/extractors/appimageextractor.cpp
  src/extractors/appimageextractor.h

To: kossebau, #baloo
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb added a comment.


  Yikes, and I can reproduce that. Did you notice this with previous versions 
that used font stretch? (Probably not if stretch had no effect for the font(s) 
you tried it with...)
  
  I'm still going to try to fix this; even if in the end it doesn't go in 
there's be a properly working version on record here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

[Marco Martin]

mart updated this revision to Diff 50046.
mart added a comment.


  - bump versions

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17691?vs=49994=50046

BRANCH
  phab/virtualdesktoprows

REVISION DETAIL
  https://phabricator.kde.org/D17691

AFFECTED FILES
  autotests/client/test_plasma_virtual_desktop.cpp
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/registry.cpp
  src/server/plasmavirtualdesktop_interface.cpp
  src/server/plasmavirtualdesktop_interface.h

To: mart, #plasma, #kwin
Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/10/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 22 Jan 2019 08:54:28 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26639/31323)53%
(10624/20063)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12184/12366)50%
(6379/12849)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6273/7376)65%
(1806/2791)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7746/8950)66%
(2270/3450)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 22 Jan 2019 08:54:29 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/4/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 22 Jan 2019 08:54:28 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26641/31320)53%
(10630/20063)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12195/12365)50%
(6390/12849)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6265/7374)65%
(1802/2791)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7745/8950)66%
(2269/3450)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D18440: [client] Wrap wl_shell_surface_set_{class,title}

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:0a2c807ad21e: [client] Wrap 
wl_shell_surface_set_{class,title} (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18440?vs=50030=50045

REVISION DETAIL
  https://phabricator.kde.org/D18440

AFFECTED FILES
  autotests/client/test_wayland_shell.cpp
  src/client/shell.cpp
  src/client/shell.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns