D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar added a comment. > the selection becomes wrapped in two ? - is that right? Yes > if we only want this for, say, markdown, then it should be a per-highlightfile list of chars that trigger this special behavior How that? > if I have foo + bar and I select the +

D18490: Add Virtual Desktops KCM icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:8fd382fc414e: Add Virtual Desktops KCM icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18490?vs=50159=50161 REVISION DETAIL

D18490: Add Virtual Desktops KCM icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Perfecto, shipit! REPOSITORY R266 Breeze Icons BRANCH preferences-virtual-desktop (branched from master) REVISION DETAIL https://phabricator.kde.org/D18490 To: ndavis, #vdg,

D18490: Add Virtual Desktops KCM icon

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18490 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18490: Add Virtual Desktops KCM icon

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18490 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18490: Add Virtual Desktops KCM icon

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-virtual-desktop (branched from master) REVISION DETAIL

D18483: Add icons for Touch Screen and Screen Edge KCMs

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9aec0d9cc43f: Add icons for Touch Screen and Screen Edge KCMs (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18483?vs=50156=50157

D18483: Add icons for Touch Screen and Screen Edge KCMs

ndavis updated this revision to Diff 50156. ndavis added a comment. Add change to breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18483?vs=50154=50156 BRANCH preferences-gestures (branched from master) REVISION DETAIL

D18483: Add icons for Touch Screen and Screen Edge KCMs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Love it. Shipit! REPOSITORY R266 Breeze Icons BRANCH preferences-gestures (branched from master) REVISION DETAIL https://phabricator.kde.org/D18483 To: ndavis, #vdg, ngraham Cc:

D18483: Add icons for Touch Screen and Screen Edge KCMs

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18483 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

ndavis updated this revision to Diff 50154. ndavis added a comment. Change style of screen edges icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18483?vs=50139=50154 BRANCH preferences-gestures (branched from master) REVISION DETAIL

D18487: Reparse background contrast settings when colors changed

ngraham added a comment. Nice, it works great for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18487 To: broulik, #plasma Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

This revision was automatically updated to reflect the committed changes. Closed by commit R266:39926c33c188: Fix file sharing preference related icon names (authored by ndavis). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18474?vs=50115=50149#toc REPOSITORY R266 Breeze Icons

D18474: Fix file sharing preference related icon names

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH preferences-share (branched from master) REVISION DETAIL https://phabricator.kde.org/D18474 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

ngraham added a comment. Cool. I think the issue here is that the hotcorner bit is simultaneously too small to be easily noticeable, but visible enough to subtly unbalance the icon. I might recommend experimenting with making the hotcorner highlight more visually prominent and then adding a

D18439: Add proper edit-delete-shred icons

ngraham added a comment. Still can't actually apply the patch to land it using Phab. Can you remove the symlink-related changes from this patch and then provide a list of them so I can do them manually? REPOSITORY R266 Breeze Icons BRANCH proper-shred-icons (branched from master)

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the summary of this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D11236: [KCrash] Establish socket to allow change of ptracer

croick added a comment. Ok, now I got it. After reading the YAMA doc again (more carefully) I realize that it really just is the parent that can be attached to the child by default and not the other way around. I still wonder why I seem to recall that there was a working backtrace for the

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham accepted this revision. ngraham added reviewers: Dolphin, apol. ngraham added a comment. This revision is now accepted and ready to land. In D18380#398301 , @rjvbb wrote: > > The behavior is better now, thanks. > > It's back to what

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

ngraham added a reviewer: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18479 To: wbauer, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18487: Reparse background contrast settings when colors changed

broulik added inline comments. INLINE COMMENTS > theme_p.cpp:754 > } > backgroundContrast = cg.readEntry("contrast", _contrast); > backgroundIntensity = cg.readEntry("intensity", _intensity); An alternative approach would be to store those values and then do the

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#398143 , @astippich wrote: > Can you add a test please? Done. The sample file sadly is some 2xx KB big, but the AppImage devs could not help to get it smaller without no longer being a real appimage,

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50146. kossebau added a comment. add unit test REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50077=50146 BRANCH addappimageextractor REVISION DETAIL https://phabricator.kde.org/D18450 AFFECTED

D18487: Reparse background contrast settings when colors changed

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When switching between light and dark system colors, the background contrast might

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

mwolff added a comment. can you say what this exactly does? from reading the code and the somewhat vague commit message, it makes me believe that when I have anything selected and then press e.g. `?` the selection becomes wrapped in two `?` - is that right? when would we ever want this?

Re: Power Management and Inhibition by Applications

Hello, On mercredi 23 janvier 2019 08:52:26 CET Kai Uwe Broulik wrote: > Hi, > > > I had thought that would only inhibit the screensaver instead of automatic > > sleep. > > KScreenLocker (previously KSMServer) that owns the > org.freedesktop.ScreenSaver interface tells PowerDevil to keep the >

D18483: Add icons for Touch Screen and Screen Edge KCMs

ndavis added a comment. In D18483#398753 , @ngraham wrote: > Maybe `preferences-desktop-gestures-screenedges` should have the cursor near to the hot corner to reinforce the concept? Otherwise it kind of feels like an icon for the cursors KCM.

D18483: Add icons for Touch Screen and Screen Edge KCMs

ngraham added a comment. Maybe `preferences-desktop-gestures-screenedges` should have the cursor near to the hot corner to reinforce the concept? Otherwise it kind of feels like an icon for the cursors KCM. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18483

D18483: Add icons for Touch Screen and Screen Edge KCMs

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18483 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer added a comment. In D18479#398655 , @wbauer wrote: > The existing check did work fine for me back in D13782 also for symlinks for some reason. > Maybe this broke because of some change in the kernel

D18483: Add icons for Touch Screen and Screen Edge KCMs

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-gestures (branched from master) REVISION DETAIL

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer added a comment. The existing check did work fine for me back in D13782 also for symlinks for some reason. Maybe this broke because of some change in the kernel or glibc? :-/ REPOSITORY R241 KIO REVISION DETAIL

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer created this revision. wbauer added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY A symlink to the mountpoint of an NTFS partition can have the type DT_LNK. So

D17806: Add Itinerary plugin

nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17806 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18473: Add monochrome symlinks for preferences-system

This revision was automatically updated to reflect the committed changes. Closed by commit R266:14bbb8f64ba2: Add monochrome symlinks for preferences-system (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18473?vs=50114=50127

D18475: Add AsciiDoc support

andreasgr created this revision. andreasgr added a reviewer: Framework: Syntax Highlighting. andreasgr added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. andreasgr requested review of this

D18474: Fix file sharing preference related icon names

ndavis added a comment. In D18474#398581 , @ngraham wrote: > Screenshots would be appreciated. :) Sorry, I had to deal with something. The only visual difference is with the samba share KCM. I also added

D18474: Fix file sharing preference related icon names

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18474 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

ngraham added a comment. Screenshots would be appreciated. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18474 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18473: Add monochrome symlinks for preferences-system

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH preferences-system-small (branched from master) REVISION DETAIL https://phabricator.kde.org/D18473 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham,

D18439: Add proper edit-delete-shred icons

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH proper-shred-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18439 To: trickyricky26, #vdg, ndavis, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I've checked the files and they all look good to me. REPOSITORY R266 Breeze Icons BRANCH proper-shred-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18439

D18473: Add monochrome symlinks for preferences-system

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18473 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

trickyricky26 updated this revision to Diff 50116. trickyricky26 added a comment. - Use a pattern with wider paper strips in the 32px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18439?vs=50067=50116 BRANCH proper-shred-icons (branched

D18439: Add proper edit-delete-shred icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18439 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18474: Fix file sharing preference related icon names

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Fixes the names of file sharing preference related icons so that they show up in system

D18473: Add monochrome symlinks for preferences-system

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This will improve visual compatibility with some 3rd party applications that use

D18439: Add proper edit-delete-shred icons

ngraham added a comment. In D18439#398526 , @trickyricky26 wrote: > Do you think these are better? > F6563857: edit-delete-shred-alt-pattern-32.svg.png I like this one! REPOSITORY R266 Breeze

D18439: Add proper edit-delete-shred icons

trickyricky26 added a comment. Do you think these are better? F6563857: edit-delete-shred-alt-pattern-32.svg.png This has smaller gaps, which are still large enough imo. F6563859: edit-delete-shred-alt-pattern2-32.svg.png

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50104. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Update 'What's This' hint to reflect new behaviour and to be more precise - Update 'What's This' hint of dyn

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

kossebau added a comment. In D18167#398360 , @aacid wrote: > In D18167#398343 , @kossebau wrote: > > > only 3(?) days between proposal and commit was also a very rushy > > > Check your dates

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. In D18167#398076 , @graesslin wrote: > The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers.

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. In D18167#398343 , @kossebau wrote: > only 3(?) days between proposal and commit was also a very rushy Check your dates better please, it's 9 days > Though then in this very case, my own take is to be pragmatic

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

kossebau added a comment. In D18167#398076 , @graesslin wrote: > The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a reviewer: Frameworks. rjvbb added a subscriber: kwrite-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham, #frameworks Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > The behavior is better now, thanks. It's back to what you liked before I started tinkering with font squeezing (plus a few fixes to the behaviour in side-bars). Do you know of other applications that use this widget/mode for/in a filebrowser side-bar thingy