D17932: Improvements to completion

mwolff added a comment. I'm in favor! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff Cc: dhaumann, apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, dems

D18163: Set the color scheme to Printing for Print Preview

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. yes, thanks! REPOSITORY R39 KTextEditor BRANCH print-preview-text-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktextedi

D18612: Cache the default KColorScheme configuration

mwolff added a comment. sure, but first let's get this in. @broulik or @dfaure care to give your +1? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D18612 To: mwolff, #kate, #kdevelop, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17734: Add Opus support for KIO AudioCD

This revision was automatically updated to reflect the committed changes. Closed by commit R342:ed3eb5a6a3e9: Add Opus support for KIO AudioCD (authored by yurchor). REPOSITORY R342 KIO AudioCD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17734?vs=48392&id=50906 REVISION DETAIL

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405368 , @ngraham wrote: > One thing I will not do in this patch is synthesize a fake button that has different behaviors from the standard button. If there's a problem with our buttons we need to fix it everywh

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. One thing I will not do in this patch is synthesize a fake button that has different behaviors from the standard button. If there's a problem with our buttons we need to fix it everywhere, not work around it here (and elsewhere). Here are our two options: F6

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

rizzitello added a comment. I think it looks better slightly off the edge of the item and I agree that if its on the item its looks much better with the shaded bar under it. To improve the contrast we could make the button our highlight color when hovered. REPOSITORY R296 KDeclarative RE

D16643: Correct the accept flag of the event object on DragMove

bruns added a comment. As fvogt already said, the current (old) code is wrong, the event should not be blindly ignored (line 97). The second change fvogt mentioned is IMHO handled quite strangely here - `!m_enabled || m_temporaryInhibition` is the inverse of `!m_enabled || m_temporaryIn

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. To me, having the buttons slightly escape the bounds of the thumbnail looks good with light buttons, but dark buttons look good when contained completely within the thumbnail. I can't quite put my finger on why it feels this way to me. REPOSITORY R296 KDeclarative

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

filipf added a comment. Round buttons looked nice, but the square buttons fit in a lot more with Breeze. As for the color, in a vacuum I think the dark buttons look better, but contextually they feel weird to me as well. We're used to everything following the color scheme. Inline v

D18739: Sync QML module padding to reflect system setting pages

davidedmundson edited the test plan for this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In systemsettings 6a9df821ecfaa008206a260b20f595136e254821

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. The dark inline buttons entirely within the thumbnail are growing on me. I'll sleep on it. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-framewo

D16643: Correct the accept flag of the event object on DragMove

ngraham added a comment. @bruns? Last call before we land this. :) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18738: Add ebook thumbnailer

broulik updated this revision to Diff 50896. broulik added a comment. - Resolve path to cover relative to OPF file - Search for `iTunesArtwork` as fallback - Search for any file `*cover*` as fallback REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D187

D17734: Add Opus support for KIO AudioCD

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. seems to work, did a quick glance at the code and didn't find anything terrible REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D17734 To: yurchor, #kde_applicat

D18738: Add ebook thumbnailer

abetts added a comment. +1 Awesome! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanue

D18738: Add ebook thumbnailer

ngraham added a comment. Works great for most of my ePubs. Here's an archive of some public-domain books in my collection that don't work.F6587654: ePubs that don't get thumbnails.tar.gz INLINE COMMENTS > ebookthumbnail.desktop:3 > +Type=Service > +Nam

D18638: Avoid using trimmed method

bruns added inline comments. INLINE COMMENTS > highlighter.cpp:311 > { > -if (text.trimmed().isEmpty() || !d->active || !d->spellCheckerFound) { > +if (!hasNotEmptyText(text) || !d->active || !d->spellCheckerFound) { > return; if (std::all_of(text.cbegin(), text.cend(), [

D18734: Update octave.xml to Octave 4.2.0

dhaumann added a comment. ...And there are also new Default Styles for kateversion="5.0", see: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ Maybe you could also use these for the itemData, like for Operator dsOperator, or for Builtin dsBui

D18734: Update octave.xml to Octave 4.2.0

dhaumann added a comment. Could you also switch to WordDetect for the trivial cases, and set kateversion="5.0" ? INLINE COMMENTS > octave.xml:2690-2711 > beginRegion="block" /> > endRegion="block" /> > beginRegion="block" /> > endRegion="block" /> >

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/13/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Feb 2019 21:37:47 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Feb 2019 21:37:46 + Build duration: 4 min 14 sec and counting BUILD ARTIFACTS abi-co

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Feb 2019 21:37:46 + Build duration: 3 min 52 sec and counting JUnit Tests Nam

D18604: Implement support for writing rating information for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:229 > +writeID3v2Tags(file.ID3v2Tag(), properties); > +} > file.save(); Is this the same as auto id3Tags = dynamic_cast(file.tag()); if (id3Tags) { ... } ? > taglibwriter.cpp:279 > +if (mp

D18630: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit R242:901ae4083442: Fix warning (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18630?vs=50602&id=50895 REVISION DETAIL https://ph

D18738: Add ebook thumbnailer

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, fir

D18601: Rewrite taglib writer to use property interface

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:70 > > -if (properties.contains(Property::Title)) { > -title = > QStringToTString(properties.value(Property::Title).toString()); > -tags->setTitle(title); > +void writeGenericProperties(TagLib::PropertyMap &old

D18738: Add ebook thumbnailer

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This can extract thumbnails from epub and fb2 ("fiction book", b

D18731: Replace KIconThemes dependency with equivalent QIcon usage

cfeck added a comment. Are application-specific icons now accessible with QIcon::fromTheme? Think Konqueror favicons in bookmark menu. Also, according to https://api.kde.org/frameworks/kbookmarks/html/kbookmarks-dependencies.html KBookmarks indirectly depends on KIconThemes via KTextWid

D18603: Implement more tags for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:134 > TagLib::MPEG::File file(&stream, > TagLib::ID3v2::FrameFactory::instance(), false); > -auto savedProperties = file.properties(); > -writeGenericProperties(savedProperties, properties); I think you hav

D17734: Add Opus support for KIO AudioCD

aacid added a comment. i'll test it later today REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D17734 To: yurchor, #kde_applications, #frameworks Cc: aacid, ngraham, cfeck

D18665: Cleanup taglib writer test

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH simplify_writing_test REVISION DETAIL https://phabricator.kde.org/D18665 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D17302: Add test for adding properties to result

bruns added inline comments. INLINE COMMENTS > resulttest.cpp:63 > +QCOMPARE(keywords->type(), QVariant::List); > +QCOMPARE(keywords->toList().count(), 2); > + This looks wrong to me ... How many items do you get when you append "keyword3" first and ["keyword1", "keyword2"] next

D18116: Add TODO KF6 note

dhaumann accepted this revision. REVISION DETAIL https://phabricator.kde.org/D18116 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405214 , @ngraham wrote: > I want to point out that the original problem was not that the buttons lacked contrast, but that the //icons// were illegible with a variety of thumbnail contents. This problem is 100%

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. I want to point out that the original problem was not that the buttons lacked contrast, but that the //icons// were illegible with a variety of thumbnail contents. This problem is 100% solved by using a real button with background that uses the system color scheme in

D17734: Add Opus support for KIO AudioCD

ngraham added a reviewer: Frameworks. ngraham added a comment. I can't test because I lack any CD reading hardware. :( Can anyone else test and review? REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D17734 To: yurchor, #kde_applications, #frameworks Cc: aaci

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#405210 , @abetts wrote: > In D18649#405209 , @GB_2 wrote: > > > In D18649#405200 , @ngraham wrote: > > > > > Here's how

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405209 , @GB_2 wrote: > In D18649#405200 , @ngraham wrote: > > > Here's how the buttons look when placed fully inline and with the color scheme inverted: > > >

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#405200 , @ngraham wrote: > Here's how the buttons look when placed fully inline and with the color scheme inverted: > > F6587345: Screenshot_20190204_130444.png > > I

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405200 , @ngraham wrote: > Here's how the buttons look when placed fully inline and with the color scheme inverted: > > F6587345: Screenshot_20190204_130444.png > >

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Here's how the buttons look when placed fully inline and with the color scheme inverted: F6587345: Screenshot_20190204_130444.png I have to admit, it ain't half bad. REPOSITORY R296 KDeclarative REVISION DETAIL ht

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405180 , @ngraham wrote: > In D18649#405179 , @abetts wrote: > > > I was thinking of dark buttons mostly. Something along these lines\ > > > > https://dribbble.co

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

broulik added a comment. Can we put the buttons at least fully inside the frame? With the boxes halfway outside it looks weird imho REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, G

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. In D18649#405179 , @abetts wrote: > I was thinking of dark buttons mostly. Something along these lines\ > > https://dribbble.com/shots/5204192-Buttons-Dark > > I think the breeze default color is just too close to

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405162 , @GB_2 wrote: > I think it looks good. I was thinking of dark buttons mostly. Something along these lines\ https://dribbble.com/shots/5204192-Buttons-Dark I think the breeze default color

D18734: Update octave.xml to Octave 4.2.0

sirgienko created this revision. sirgienko added a reviewer: Framework: Syntax Highlighting. sirgienko added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sirgienko requested review of this revision.

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. I think it looks good. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. I like this version because it feels slightly more conventional with the square-ish KDE-style buttons. A blend of old and new, so to speak. It says, "I may be modern and sleek, but I'm still a powerful KDE app, not some garbage mobile UI inappropriately applied to th

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405156 , @ngraham wrote: > Use square buttons and put them on the bottom right, not the top right The functionality seems great! We might need to do more padding with labels. Is there any way we can style

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham updated this revision to Diff 50879. ngraham added a comment. Use square buttons and put them on the bottom right, not the top right REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18649?vs=50869&id=50879 BRANCH improve-grid-view-kcm-inline-h

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#405153 , @ngraham wrote: > Nah, it's actually fine: > > F6587198: Screenshot_20190204_122428.png Oh, ok, then it's fine! REPOSITORY R296 KDeclarative REVISION

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Nah, it's actually fine: F6587198: Screenshot_20190204_122428.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. Now that I think about it though, the buttons overlap the label of the label text is long... REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-framewor

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#405146 , @ngraham wrote: > Like this? Or fully contained within the thumbnail? > > F6587190: Screenshot_20190204_122020.png This is good! REPOSITORY R296 KDecla

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added a comment. In D18698#404820 , @poboiko wrote: > Explained the race condition in summary, expanded test to check if watches were installed correctly. I am not sure if I understood your description correctly, but I am quite sure

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Like this? Or fully contained within the thumbnail? F6587190: Screenshot_20190204_122020.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavi

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kinotify.cpp:430 > +// HACK: For some reason, it.fileInfo() returns an > empty QFileInfo for `path` here > +// C

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#405137 , @ngraham wrote: > Not sure I catch your meaning, sorry. How big should the square buttons be? I kinda like them at that size TBH. Gwenview also has inline square hover buttons like this and it's fine.

D18116: Add TODO KF6 note

loh.tar updated this revision to Diff 50875. loh.tar added a comment. - Move to correct function Good catch :-) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18116?vs=50759&id=50875 REVISION DETAIL https://phabricator.kde.org/D18116 AFFECTED FILES src/include/ktexteditor/

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Not sure I catch your meaning, sorry. How big should the square buttons be? I kinda like them at that size TBH. Gwenview also has inline square hover buttons like this and it's fine. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649

T3689: Add abi compliance checker to CI

knauss added a comment. I'm not a expert in abi-complience-checker, so we need to find out together... In T3689#175022 , @danders wrote: > The ABI error started with build 4: https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#405094 , @ngraham wrote: > In D18649#405091 , @GB_2 wrote: > > > What if the buttons just looked normal and not so big and not as circles? > > > With regular-size

D18731: Replace KIconThemes dependency with equivalent QIcon usage

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D18731 To: vkrause, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18731: Replace KIconThemes dependency with equivalent QIcon usage

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D18731 AFFECTED FILES CMakeLists.txt src/

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. In D18649#405091 , @GB_2 wrote: > What if the buttons just looked normal and not so big and not as circles? With regular-sized square buttons: F6587075: Small square buttons.png

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. Just some variations on Nate's idea: https://dribbble.com/shots/4981650-Floating-Button-Micro-Interaction https://dribbble.com/shots/2619684-Expense-Floating-Button The floating buttons is a very Android-unique feature. Not sure we are copying that if we

D14927: KConfig: handle directory symlinks correctly.

dfaure added a comment. https://build.kde.org/job/Frameworks/view/Everything/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/ green !!! :-) Well, blue, because blue is the new green (!?). REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14927 To: dfaure, adridg, arichards

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. What if the buttons just looked normal and not so big and not as circles? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh,

D18730: Use breeze icons for search providers

ngraham added a comment. In D18730#405089 , @shubham wrote: > @ngraham I had a look at KuriFilter in frameworks, iconNameForPreferredSearchProvider() function is producing same icon name for all the entries. That's probably where we shou

D18730: Use breeze icons for search providers

shubham added a comment. @ngraham I had a look at KuriFilter in frameworks, iconNameForPreferredSearchProvider() function is producing same icon name for all the entries. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks,

D18730: Use breeze icons for search providers

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc: #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, crozbo, nda

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405082 , @ngraham wrote: > In D18649#405081 , @abetts wrote: > > > In D18649#405078 , @ngraham wrote: > > > > > Use ro

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. In D18649#405081 , @abetts wrote: > In D18649#405078 , @ngraham wrote: > > > Use round buttons in the corner rather than an inline toolbar > > > What does it look like

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405078 , @ngraham wrote: > Use round buttons in the corner rather than an inline toolbar What does it look like now? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 T

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham updated this revision to Diff 50869. ngraham added a comment. Use round buttons in the corner rather than an inline toolbar REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18649?vs=50662&id=50869 BRANCH improve-grid-view-kcm-inline-hover-butt

D18714: Add some Maxima constans and function

sirgienko closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18714 To: sirgienko, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, c

D18116: Add TODO KF6 note

dhaumann added inline comments. INLINE COMMENTS > document.h:394 > +// TODO KF6: Not needed anymore since we show load trouble as > KTextEditor::Message. > +// Remove all code which set m_openingErrorMessage > bool openingError() const; Hm, is it really that `bool openingError

D18714: Add some Maxima constans and function

dhaumann added a comment. In your branch, you should type: `arc land` This will merge your branch to master and commit/push your changes, and close this revision. This only works, if you have commit access. If not, we'll take care of this for now. REPOSITORY R216 Syntax Highlighting BRA

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter added a comment. BTw, am I missing something or shouldn't this entire kioslave lookup be made static? It only needs computing once but currently is run for every new slave that gets started (in fork-mode). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18725 To

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the kioslave harness is installed to LIBEXEC_KF5 which is '$libexec/' on win32 (technically $bindir) and '$libexec/kf5/'

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Feb 2019 12:42:40 + Build duration: 5 min 15 sec and counting JUnit Tests Name: project

D14927: KConfig: handle directory symlinks correctly.

dfaure closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14927 To: dfaure, adridg, arichardson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14927: KConfig: handle directory symlinks correctly.

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D14927 To: dfaure, adridg, arichardson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko updated this revision to Diff 50832. poboiko edited the summary of this revision. poboiko added a comment. Explained the race condition in summary, expanded test to check if watches were installed correctly. I've encountered some pretty weird issue: the watch for the moved folder

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM, thanks! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18680 To: elvisangelaccio, apol, smartins Cc: arojas, anthonyfieroni, kde-fr

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Feb 2019 08:24:51 + Build duration: 22 min and counting JUnit Tests Name: projectroot Fail

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fa6eaac55beb: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18653?vs=