D19108: [ExternalExtractor] Provide more helpful output when extractor fails

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  LGTM!. Annoyed me for a long time (and made hard to debug some issues).

INLINE COMMENTS

> externalextractor.cpp:120
>  extractorProcess.start(d->mainPath, QStringList(), QIODevice::ReadWrite);
> +bool started = extractorProcess.waitForStarted();
> +if (!started) {

Will this block anything?

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19108

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19020: [breeze-icons] Revamp system.svgz

[Noah Davis]

ndavis added a comment.


  In D19020#414317 , @rooty wrote:
  
  > In D19020#414300 , @abetts wrote:
  >
  > > Well, maybe it is time to call it and be done. I don't think we are going 
to please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.
  >
  >
  > You're right, and thanks for giving me the nudge I needed :D
  >
  > Okay so, I propose the icon remain the way it is right now:
  >  F6620691: image.png 
  > because
  >  (1) we can't use an I beam with or without dots (the label is too vague)
  >  (2) we could use a long bar, but it looks kind of like a progress bar
  >  (3) we could use a circle, but we technically don't need to - and this 
sort of stresses the fact that it's an entirely different login screen that 
it'll take you to
  
  
  That last little square in the username bothers me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/29/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 04:19:23 +
 Build duration:
8 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 195 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/195/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 18 Feb 2019 04:19:22 +
 Build duration:
7.5 sec and counting
   CONSOLE OUTPUT
  [...truncated 80 lines...]remote: Compressing objects:  51% (3248/6367)   remote: Compressing objects:  52% (3311/6367)   remote: Compressing objects:  53% (3375/6367)   remote: Compressing objects:  54% (3439/6367)   remote: Compressing objects:  55% (3502/6367)   remote: Compressing objects:  56% (3566/6367)   remote: Compressing objects:  57% (3630/6367)   remote: Compressing objects:  58% (3693/6367)   remote: Compressing objects:  59% (3757/6367)   remote: Compressing objects:  60% (3821/6367)   remote: Compressing objects:  61% (3884/6367)   remote: Compressing objects:  62% (3948/6367)   remote: Compressing objects:  63% (4012/6367)   remote: Compressing objects:  64% (4075/6367)   remote: Compressing objects:  65% (4139/6367)   remote: Compressing objects:  66% (4203/6367)   remote: Compressing objects:  67% (4266/6367)   remote: Compressing objects:  68% (4330/6367)   remote: Compressing objects:  69% (4394/6367)   remote: Compressing objects:  70% (4457/6367)   remote: Compressing objects:  71% (4521/6367)   remote: Compressing objects:  72% (4585/6367)   remote: Compressing objects:  73% (4648/6367)   remote: Compressing objects:  74% (4712/6367)   remote: Compressing objects:  75% (4776/6367)   remote: Compressing objects:  76% (4839/6367)   remote: Compressing objects:  77% (4903/6367)   remote: Compressing objects:  78% (4967/6367)   remote: Compressing objects:  79% (5030/6367)   remote: Compressing objects:  80% (5094/6367)   remote: Compressing objects:  81% (5158/6367)   remote: Compressing objects:  82% (5221/6367)   remote: Compressing objects:  83% (5285/6367)   remote: Compressing objects:  84% (5349/6367)   remote: Compressing objects:  85% (5412/6367)   remote: Compressing objects:  86% (5476/6367)   remote: Compressing objects:  87% (5540/6367)   remote: Compressing objects:  88% (5603/6367)   remote: Compressing objects:  89% (5667/6367)   remote: Compressing objects:  90% (5731/6367)   remote: Compressing objects:  91% (5794/6367)   remote: Compressing objects:  92% (5858/6367)   remote: Compressing objects:  93% (5922/6367)   remote: Compressing objects:  94% (5985/6367)   remote: Compressing objects:  95% (6049/6367)   remote: Compressing objects:  96% (6113/6367)   remote: Compressing objects:  97% (6176/6367)   remote: Compressing objects:  98% (6240/6367)   remote: Compressing objects:  99% (6304/6367)   remote: Compressing objects: 100% (6367/6367)   remote: Compressing objects: 100% (6367/6367), done.[2019-02-18T04:19:29.989Z] Receiving objects:   0% (1/39800)   fatal: write error: No space left on device[2019-02-18T04:19:29.989Z] fatal: index-pack failed[2019-02-18T04:19:29.989Z] [2019-02-18T04:19:29.989Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-02-18T04:19:29.989Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1905)[2019-02-18T04:19:29.989Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:81)[2019-02-18T04:19:29.989Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:488)[2019-02-18T04:19:29.989Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:712)[2019-02-18T04:19:29.989Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2019-02-18T04:19:29.989Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2019-02-18T04:19:29.989Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)[2019-02-18T04:19:29.989Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2019-02-18T04:19:29.989Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2019-02-18T04:19:29.989Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2019-02-18T04:19:29.989Z] 	at java.util.concurrent.FutureTask.run(Unknown Source)[2019-02-18T04:19:29.989Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)[2019-02-18T04:19:29.989Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)[2019-02-18T04:19:29.989Z] 	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)[20

D19111: Have ShareFileItemAction provide an output or an error if they are provided

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Dolphin, Frameworks, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  BUG: 397567

TEST PLAN
  Manual testing on dolphin

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19111

AFFECTED FILES
  src/fileitemactionplugin/CMakeLists.txt
  src/fileitemactionplugin/sharefileitemaction.cpp
  src/widgets/menu.cpp
  src/widgets/menu.h

To: apol, #dolphin, #frameworks, nicolasfella
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 51939.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.


  Update.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19080?vs=51876&id=51939

BRANCH
  safe-overwrite

REVISION DETAIL
  https://phabricator.kde.org/D19080

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19109: [Extractor] Add metadata to extractors

[Stefan Brüns]

bruns retitled this revision from "[Extractor] Add metadata to properties" to 
"[Extractor] Add metadata to extractors".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19109

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414300 , @abetts wrote:
  
  > Well, maybe it is time to call it and be done. I don't think we are going 
to please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.
  
  
  You're right, and thanks for giving me the nudge I needed :D
  
  Okay so, I propose the icon remain the way it is right now:
  F6620691: image.png 
  because
  (1) we can't use an I beam with or without dots (the label is too vague)
  (2) we could use a long bar, but it looks kind of like a progress bar
  (3) we could use a circle, but we technically don't need to - and this sort 
of stresses the fact that it's an entirely different login screen that it'll 
take you to

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51938.
rooty added a comment.


  Center user prompt icon vertically

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51920&id=51938

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19005: android: don't default to gcc anymore

[Aleix Pol Gonzalez]

apol added a comment.


  In D19005#412258 , @vkrause wrote:
  
  > Actually having tested this, "deprecated_value" looks wrong there, 
shouldn't this be "default_value"?
  
  
  no, the value is coming from the cache, so that's the one we're setting. What 
this patch tries to make sure is that we don't forward an empty value 
(resetting a proper variable to "").

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19005

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19110: Don't show the tooltip when the drop-down menu is shown

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, Frameworks.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  The menu itself should already offer enough information
  
  BUG: 404371

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19110

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, #frameworks
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19075: Fix FindEGL

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19109: [Extractor] Add metadata to properties

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19109

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19020: [breeze-icons] Revamp system.svgz

[Andres Betts]

abetts added a comment.


  Well, maybe it is time to call it and be done. I don't think we are going to 
please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414285 , @abetts wrote:
  
  > I think the icon is pretty much there. Maybe the label can help the meaning 
come across. What about:
  >
  > "Enter User"
  >  "Type User"
  >  "Change User"
  
  
  haha it was actually changed to Type User then to Other... because we 
couldn't settle on a name, and thr fact that Verb + User sounds worse 
(grammatically) than Verb + Username (and Username is too long)
  
  Change User also doesn't capture what the screen does
  
  I think the label that truly captures that button is "Use Prompt" but it 
looks so ... weird :D

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19109: [Extractor] Add metadata to properties

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  This adds extractor metadata in a backwards and forward compatible way.
  
  There are several use cases for this metadata:
  
  - Delayed loading of extractor plugins - currently, all extractors are loaded 
and and initialized when an ExtractorCollection is created.
  - Versioning information - e.g. Baloo would benefit from versioning 
information, to reindex affected files after an extractor has been updated.
  
  Although it would be possible to extend the extractor plugin interface
  with a method for each relevant property, it would require a bump of
  the plugin inteface version each time the interface is extended.

TEST PLAN
  ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  extractor_properties

REVISION DETAIL
  https://phabricator.kde.org/D19109

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/extractorcollectiontest.cpp
  src/extractor.cpp
  src/extractor.h
  src/extractor_p.h
  src/extractorcollection.cpp
  src/extractorcollection.h
  src/extractors/CMakeLists.txt
  src/extractors/epubextractor.h
  src/extractors/epubextractor.json
  src/extractors/exiv2extractor.h
  src/extractors/exiv2extractor.json.in
  src/extractors/ffmpegextractor.h
  src/extractors/ffmpegextractor.json
  src/extractors/mobiextractor.h
  src/extractors/mobiextractor.json
  src/extractors/odfextractor.h
  src/extractors/odfextractor.json
  src/extractors/office2007extractor.h
  src/extractors/office2007extractor.json
  src/extractors/officeextractor.h
  src/extractors/officeextractor.json
  src/extractors/plaintextextractor.h
  src/extractors/plaintextextractor.json
  src/extractors/poextractor.h
  src/extractors/poextractor.json
  src/extractors/popplerextractor.h
  src/extractors/popplerextractor.json
  src/extractors/postscriptdscextractor.h
  src/extractors/postscriptdscextractor.json
  src/extractors/taglibextractor.h
  src/extractors/taglibextractor.json
  src/extractors/xmlextractor.h
  src/extractors/xmlextractor.json

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19107: Write valid UTF8 characters without escaping.

[Viorel-Cătălin Răpițeanu]

rapiteanu added a comment.


  The commit fixes (as expected) the config write issue observed in 403557.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Andres Betts]

abetts added a comment.


  I think the icon is pretty much there. Maybe the label can help the meaning 
come across. What about:
  
  "Enter User"
  "Type User"
  "Change User"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19108: [ExternalExtractor] Provide more helpful output when extractor fails

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case the executable fails to start, no error was given at all.
  Show the pluginpath if no manifest.json is found.
  Show the extractor path and indexed file when the extractor fails at
  runtime.

TEST PLAN
  ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19108

AFFECTED FILES
  src/externalextractor.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Created https://github.com/AppImage/libappimage/pull/71 as one approach to 
get this solved on libappimage side.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18611

To: kossebau, broulik
Cc: sitter, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 51934.
kossebau added a comment.


  - update to latest master
  - remove unused name() method

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18450?vs=50535&id=51934

BRANCH
  addappimageextractor

REVISION DETAIL
  https://phabricator.kde.org/D18450

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/appimageextractortest.cpp
  autotests/appimageextractortest.h
  autotests/samplefiles/test.AppImage
  src/extractors/CMakeLists.txt
  src/extractors/appimageextractor.cpp
  src/extractors/appimageextractor.h

To: kossebau, #baloo, astippich
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D18450#402995 , @astippich 
wrote:
  
  > Just noticed, you never use the AppDataParser.name(). Is that intentional?
  
  
  Good catch, was left over from first code drafts, before I aligned the data 
mapping with what I have seen in other appimage code. Removing.
  
  > Otherwise looks good, but you may want to wait for someone more experienced 
than me.
  
  Thanks for review. I tried to poke some others, but seems no-one has 
something negative to point out. So I would go and push soon.
  Only blocker I added myself here is to have a released version of libappimage 
which has fixed version info in the cmake config, so we can reliable build 
against what is found.
  
  https://github.com/AppImage/libappimage/pull/71 is a recent proposal to get 
to that.

REPOSITORY
  R286 KFileMetaData

BRANCH
  addappimageextractor

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo, astippich
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D19107: Write valid UTF8 characters without escaping.

[Jos van den Oever]

vandenoever created this revision.
vandenoever added reviewers: dfaure, arichardson, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.

REVISION SUMMARY
  commit 6a18528 
 
introduced escaping of bytes >= 127 to ensure that
  KConfig files are valid UTF8.
  The simplistic approach with a cutoff results in many escaped bytes
  where it is not required. Especially non-western configuration files
  would have many escapes.
  
  This commit fixes that by only escaping bytes that are not valid UTF8.

TEST PLAN
  ninja && ninja test

REPOSITORY
  R237 KConfig

BRANCH
  utf8

REVISION DETAIL
  https://phabricator.kde.org/D19107

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigini.cpp

To: vandenoever, dfaure, arichardson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414231 , @trickyricky26 
wrote:
  
  > As they are now it's long, short, long (exact same length as rectangle 
number 1), shorter than height (which looks bad imo). There are no medium 
lengths and the same length is used twice. I would suggest giving every bar a 
different length.
  >
  > If you're going to remove the spaces, this won't be an issue, but I would 
not remove the spaces until we are certain that spaces are not allowed in the 
real thing.
  
  
  Oh I don't mind removing the spaces
  F6620461: image.png 
  But people have complained that the end result looks like a progress bar...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19103: Middle-elide very long filenames in error strings

[Nathaniel Graham]

ngraham updated this revision to Diff 51931.
ngraham added a comment.


  Make the length a variable

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19103?vs=51919&id=51931

BRANCH
  squeeze-very-long-filenames (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19103

AFFECTED FILES
  src/core/job_error.cpp

To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[TrickyRicky]

trickyricky26 added a comment.


  As they are now it's long, short, long (exact same length as rectangle number 
1), shorter than height (which looks bad imo). There are no medium lengths and 
the same length is used twice. I would suggest giving every bar a different 
length.
  
  If you're going to remove the spaces, this won't be an issue, but I would not 
remove the spaces until we are certain that spaces are not allowed in the real 
thing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18968: Word-wrap KMessageWidget text

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:cf2da56c5e76: Word-wrap KMessageWidget text (authored by 
ngraham).

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18968?vs=51554&id=51930

REVISION DETAIL
  https://phabricator.kde.org/D18968

AFFECTED FILES
  src/dolphinviewcontainer.cpp

To: ngraham, #dolphin, #frameworks, cfeck, elvisangelaccio
Cc: elvisangelaccio, cfeck, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414224 , @trickyricky26 
wrote:
  
  > I like it!
  >
  > I think the "Type User" Icon would look better if the bars acting as 
placeholder text were a bit less regular in width and would not be shorter than 
they are tall (which is the case for the rightmost rectangle).
  >  Also, can the usernames in the type user field contain spaces? If not, it 
might not be fitting to use multiple split rectangles to represent the 
username, as these gaps represent spaces.
  
  
  You're right about the spaces, I'll remove them
  But what do you mean by less regular in width?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[TrickyRicky]

trickyricky26 added a comment.


  I like it!
  
  I think the "Type User" Icon would look better if the bars acting as 
placeholder text were a bit less regular in width and would not be shorter than 
they are tall (which is the case for the rightmost rectangle).
  Also, can the usernames in the type user field contain spaces? If not, it 
might not be fitting to use multiple split rectangles to represent the 
username, as these gaps represent spaces.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19075: Fix FindEGL

[Simon Hausmann]

hausmann accepted this revision.
hausmann added a comment.
This revision is now accepted and ready to land.


  Thank you:)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Stefan Brüns]

bruns updated this revision to Diff 51928.
bruns marked an inline comment as done.
bruns added a comment.


  Add `double` test case
  Fix double conversion
  Fix nitpicks ('*')

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19087?vs=51886&id=51928

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D19087

AFFECTED FILES
  autotests/unit/file/CMakeLists.txt
  autotests/unit/file/propertyserializationtest.cpp
  src/file/CMakeLists.txt
  src/file/propertydata.cpp
  src/file/propertydata.h

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19102: Fix extraction of aspect ratio property

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ffmpegextractortest.cpp:53
>  QVERIFY(abs(result.properties().value(FrameRate).toDouble() - 23.976) < 
> 1e-4);
> +QVERIFY(abs(result.properties().value(AspectRatio).toDouble() - 1.8) 
> < 1e-4);
>  }

16.0/9

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19102

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ffmpegextractortest.cpp:52
>  QCOMPARE(result.properties().value(Height).toInt(), 720);
> +QVERIFY(abs(result.properties().value(FrameRate).toDouble() - 23.976) < 
> 1e-4);
>  }

You can probably use `(24.0/1001)` for the exact value.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18968: Word-wrap KMessageWidget text

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R318 Dolphin

BRANCH
  word-wrap-long-kmessagewidget-text (branched from Applications/18.12)

REVISION DETAIL
  https://phabricator.kde.org/D18968

To: ngraham, #dolphin, #frameworks, cfeck, elvisangelaccio
Cc: elvisangelaccio, cfeck, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D19103: Middle-elide very long filenames in error strings

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Please use a variable instead of hardcoding the length in multiple places.
  
  +1 otherwise.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19103

To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D19100: Cleanup ffmpeg extractor

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D19100

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19099: Add a test for ffmpeg extractor

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ffmpegextractortest.cpp:45
> +
> +QCOMPARE(result.properties().value(Title).toString(), 
> QStringLiteral("Title"));
> +QCOMPARE(result.properties().value(Copyright).toString(), 
> QStringLiteral("Copyright"));

I find it somewhat difficult to grasp `Title` is 
KFileMetaData::Property::Title. 
You can use something like:

  namespace KFMProp = KFileMetaData::Property;
  ...
  ... value(KFMProp::Title).toString()

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19099

To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51920.
rooty added a comment.


  Replace "Other..." icon with newer version

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51909&id=51920

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18968: Word-wrap KMessageWidget text

[Nathaniel Graham]

ngraham added a comment.


  Yep, that works great. Did it in D19103: Middle-elide very long filenames in 
error strings .
  
  We'll still need this because word-wrapping the message is also an 
improvement.

REPOSITORY
  R318 Dolphin

BRANCH
  word-wrap-long-kmessagewidget-text (branched from Applications/18.12)

REVISION DETAIL
  https://phabricator.kde.org/D18968

To: ngraham, #dolphin, #frameworks, cfeck
Cc: elvisangelaccio, cfeck, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D19101: Increase precision of frame rate property

[Alexander Stippich]

astippich added a dependency: D19100: Cleanup ffmpeg extractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

[Alexander Stippich]

astippich added a dependent revision: D19102: Fix extraction of aspect ratio 
property.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19103: Middle-elide very long filenames in error strings

[Nathaniel Graham]

ngraham added a comment.


  Question: is 80 characters too few? Should I increase it to something higher?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19103

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19102: Fix extraction of aspect ratio property

[Alexander Stippich]

astippich added a dependency: D19101: Increase precision of frame rate property.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19102

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19100: Cleanup ffmpeg extractor

[Alexander Stippich]

astippich added a dependent revision: D19101: Increase precision of frame rate 
property.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19100

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19103: Middle-elide very long filenames in error strings

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Middle-elide very long filenames used in error strings to prevent broken 
layouts.
  
  See the fixed bug for one such example.
  
  BUG: 404232
  FIXED-IN: 5.56

TEST PLAN
  In Dolphin, create a new file named 
  
"aaa"
  
  F6620295: Elided 

REPOSITORY
  R241 KIO

BRANCH
  squeeze-very-long-filenames (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19103

AFFECTED FILES
  src/core/job_error.cpp

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19100: Cleanup ffmpeg extractor

[Alexander Stippich]

astippich added a dependency: D19099: Add a test for ffmpeg extractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19100

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19099: Add a test for ffmpeg extractor

[Alexander Stippich]

astippich added a dependent revision: D19100: Cleanup ffmpeg extractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19099

To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19102: Fix extraction of aspect ratio property

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  The extraction of the aspect ratio was broken
  for multiple reasons. Using the function
  provided by ffmpeg fixes this.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_aspectratio

REVISION DETAIL
  https://phabricator.kde.org/D19102

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/propertyinfotest.cpp
  src/extractors/ffmpegextractor.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Some video files have frame rates
  of 23.976 or similar, requiring the representation
  as double. The data will be displayed 
  with two digit precision, as done by 
  kdenlive for example.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_framerate

REVISION DETAIL
  https://phabricator.kde.org/D19101

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/propertyinfotest.cpp
  src/extractors/ffmpegextractor.cpp
  src/formatstrings.cpp
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19100: Cleanup ffmpeg extractor

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D19100

AFFECTED FILES
  src/extractors/ffmpegextractor.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19099: Add a test for ffmpeg extractor

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Test the ffmpegextractor using
  a test file. The file contains 1 second
  of blackness.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D19099

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  autotests/samplefiles/test.webm

To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19097: Add a test and document PropertyMap/VariantMap conversion

[Alexander Stippich]

astippich added a dependent revision: D19098: Add PropertyMap to QVariantMap 
conversion function using names.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19097

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19098: Add PropertyMap to QVariantMap conversion function using names

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Add a conversion function from a
  PropertyMap to a VariantMap using the property name.
  Will be used by baloo-widgets. 
  Depends on D19097 

REPOSITORY
  R286 KFileMetaData

BRANCH
  named_map_conversion

REVISION DETAIL
  https://phabricator.kde.org/D19098

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.h

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19097: Add a test and document PropertyMap/VariantMap conversion

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Add a roundtrip test and document the
  conversion function.

REPOSITORY
  R286 KFileMetaData

BRANCH
  map_conversion

REVISION DETAIL
  https://phabricator.kde.org/D19097

AFFECTED FILES
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h
  src/properties.h

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise added a comment.


  My vacancies ended and I'm making the annual planning for my classes, so I 
will be busy for at least two weeks, but I plan to work on the subjob bug as 
soon my schedule allows it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich added a comment.


  ping. I know this is quite a large diff, but it fixes a potential crash

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17816: Support for xattrs on kio copy/move

[Nathaniel Graham]

ngraham added a comment.


  Where are we with this? Would be really nice to finally get this bug fixed 
for our users. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

[Nathaniel Graham]

ngraham added a comment.


  @Pino, can you help fix us the root cause then? The reason why we've resorted 
to these workarounds is because nobody's been able to adequately understand the 
root cause or implement a risk-free fix.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18798

To: anemeth, #frameworks, kde-frameworks-devel, ngraham, davidedmundson
Cc: pino, elvisangelaccio, ngraham, kde-frameworks-devel, michaelh, bruns

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Alexander Stippich]

astippich added a comment.


  I was wondering if using QDataStream would be simpler, but the data size was 
over twice the amount compared to the size using JSON during my testing. But 
this would solve a lot of the limitations which JSON imposes, like handling int 
and doubles, qdatetime objects, and there would be no need for 
merging/unmerging items after fixing KFileMetaData.

INLINE COMMENTS

> propertyserializationtest.cpp:2
> +/*
> +   This file is part of the KDE Baloo project.
> + * Copyright (C) 2019  Stefan Brüns 

very minor nitpick: missing * 
also below

> propertyserializationtest.cpp:102
> +QCOMPARE(res, properties);
> +}
> +

A test with stringlists and single strings would be nice. Also doubles should 
be checked.

> propertydata.cpp:80
> +propertyMap.insertMulti(prop, val.toString());
> +}
> +

This means that multiple entries with the same key get stored as single entries 
in the property map, right? 
This breaks the current behavior in dolphin and baloo-widgets. Merging (or more 
specific D19088 ) must then wait until we 
convert all those data to output stringlists. But I think this code will also 
split up data of stringlists, doesn't it?
Also, if there are multiple extractors for the same mime type (which I know 
there aren not currently) , which will add e.g. two releaseYear properties, 
these will be converted to a string.

> propertydata.cpp:83
> +} else if (it.value().isDouble()) {
> +propertyMap.insertMulti(prop, it.value().toInt());
> +} else {

I think that will break all properties containing doubles, of which there are a 
few.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19094: Use KCM name in KCM header

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, that's the right fix.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19094

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  @abetts
  
  F6620144: image.png 
  
  This is what I came up for the login/password field idea. What do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/26/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 17 Feb 2019 17:25:08 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.filewatchtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5405/9501)41%
(2141/5238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)90%
(816/905)51%
(270/530)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)39%
(652/1666)37%
(388/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
 

D19090: Hardcoding the Remaining Time Update Interval

[Nathaniel Graham]

ngraham added a comment.


  Arc uses the commit message in the web UI, not your local one. If you change 
the local commit message, you need to then send it up to the web UI with `arc 
diff --edit --verbatim`
  
  See 
https://community.kde.org/Infrastructure/Phabricator#Updating_the_summary_of_the_Differential_from_the_local_Git_commit_message
  
  Kinda convoluted and unintuitive, I know. :/

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19090

To: narvaez, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/19/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 17 Feb 2019 17:25:08 +
 Build duration:
3 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 2 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5383/9501)41%
(2126/5238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)88%
(794/905)48%
(256/530)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)39%
(652/1666)37%
(387/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3

D19090: Hardcoding the Remaining Time Update Interval

[David Narváez]

narvaez added a comment.


  In D19090#413998 , @bruns wrote:
  
  > Nitpick - "Hardcoding ..." -> "Hardcode"  or better "Use a fixed interval 
for updating the Remaining Time"
  
  
  Huh, I updated my local commit to use that recommendation but arc still 
landed the old commit message, sorry about that

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19090

To: narvaez, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19090: Hardcoding the Remaining Time Update Interval

[David Narváez]

narvaez closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19090

To: narvaez, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51910.
rooty added a comment.


  Implement the newer versions of all three icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51889&id=51910

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51909.
rooty added a comment.


  Add new switch user icons

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51821&id=51909

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19094: Use KCM name in KCM header

[Björn Feber]

GB_2 edited the summary of this revision.
GB_2 edited the test plan for this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D19094

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19090: Hardcoding the Remaining Time Update Interval

[Stefan Brüns]

bruns added a comment.


  Nitpick - "Hardcoding ..." -> "Hardcode"  or better "Use a fixed interval for 
updating the Remaining Time"

REPOSITORY
  R293 Baloo

BRANCH
  monitor_hardcoded_interval

REVISION DETAIL
  https://phabricator.kde.org/D19090

To: narvaez, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19090: Hardcoding the Remaining Time Update Interval

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  monitor_hardcoded_interval

REVISION DETAIL
  https://phabricator.kde.org/D19090

To: narvaez, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19094: Use KCM name in KCM header

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Change it for KCMs not opened through the system settings too, similar to 
D19006 .

TEST PLAN
  Open a Qt Widgets KCM like "Widget Style".

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19094

AFFECTED FILES
  src/kcmultidialog.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

[David Faure]

dfaure added a comment.


  Ah I see, we copy to .part only when the destination actually exists. I had 
missed that in my earlier comment. Makes sense, actually.

INLINE COMMENTS

> file_unix.cpp:289
> +::unlink(_dest_backup.data());
> +orig_delete_attempted = true;
> +continue;

I think the naming of that bool could be improved (orig sounds like origin 
sounds like source, but this is about the dest).

How about

  existing_dest_delete_attempted

?

> file_unix.cpp:322
> +if (!_dest_backup.isEmpty() && !orig_delete_attempted) {
> +::unlink(_dest_backup.data());
> +orig_delete_attempted = true;

.constData()  [everywhere you used .data()]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19080

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

[David Faure]

dfaure added a comment.


  kio_thumbnail is a separate process (like all kioslaves) so a crash doesn't 
bring down the user-visible application.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D19092: Add bison minimum version of 2.4.1 due to %code

[Kurt Hindenburg]

hindenburg created this revision.
Herald added a project: Frameworks.
hindenburg requested review of this revision.

REVISION SUMMARY
  Some Mac OS versions have bison 2.3 even though it is very old.
  %code is first handled in bison version 2.4; gnu site has 2.4.1 as
  the earliest 2.4.x version.

TEST PLAN
  Verified build fails in cmake phase when using bison 2.3 and builds
  correctly using bison 2.4.1+.

REPOSITORY
  R309 KService

BRANCH
  bison_min_version (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19092

AFFECTED FILES
  CMakeLists.txt

To: hindenburg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19090: Hardcoding the Remaining Time Update Interval

[David Narváez]

narvaez added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19090

To: narvaez, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19090: Hardcoding the Remaining Time Update Interval

[David Narváez]

narvaez created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
narvaez requested review of this revision.

REVISION SUMMARY
  There is no relation between this number and the batch size of the
  scheduler.

REPOSITORY
  R293 Baloo

BRANCH
  monitor_hardcoded_interval

REVISION DETAIL
  https://phabricator.kde.org/D19090

AFFECTED FILES
  src/qml/experimental/monitor.cpp

To: narvaez
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

[David Narváez]

narvaez abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18997: Add functions returning all definitions for a mimetype or file name

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I would propose:
  
  Use the m_sortedDefs as base for the searching.
  Return the vector after the bestCandidate did the sort.
  
  That would yield in my eyes the most useful sorting: all things with the same 
priority that match have the original sort as in definitions() and you get best 
candidates first.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18997

To: davschul, vkrause, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18968: Word-wrap KMessageWidget text

[Elvis Angelaccio]

elvisangelaccio added a comment.


  That could also work, yes. @ngraham wanna give it a try?

REPOSITORY
  R318 Dolphin

BRANCH
  word-wrap-long-kmessagewidget-text (branched from Applications/18.12)

REVISION DETAIL
  https://phabricator.kde.org/D18968

To: ngraham, #dolphin, #frameworks, cfeck
Cc: elvisangelaccio, cfeck, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

[Pino Toscano]

pino added a comment.


  In D18798#413803 , @ngraham wrote:
  
  > The workaround isn't required everywhere, just in a small number of places.
  
  
  It still is a workaround, and the fact that the places where this is "needed" 
are not many still does not justify it IMHO.
  
  > prior patches were accepted by Plasma developers, so it would be a shame 
not to land this last one.
  
  The real shame was to accept such workarounds in other places, instead of 
fixing breeze (or qt).
  
  Again, -1 for workarounds in important places like KIO, where they will stay 
for years because people forget about them...

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18798

To: anemeth, #frameworks, kde-frameworks-devel, ngraham, davidedmundson
Cc: pino, elvisangelaccio, ngraham, kde-frameworks-devel, michaelh, bruns