D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. bonghyunkim requested review of this revision. REVISION SUMMARY This commit adds syntax definition for Elm language to syntax-highlighting. REPOSITORY R216

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

vkrause added inline comments. INLINE COMMENTS > kossebau wrote in textcreator.cpp:169 > @vkrause Can you help here and tell what one is intended to use? I think default background color here refers to what your palette gives you. The background color defined by highlighting is typically only u

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 01 Mar 2019 06:23:36 + Build duration: 2 min 10 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Mar 2019 06:23:36 + Build duration: 2 min 11 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 01 Mar 2019 06:23:36 + Build duration: 57 sec and counting JUnit Tests Name: projectroot

D19437: [knewstuff] Remove qt5.13 deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method TEST PLAN autotest ok REPOSITORY R304 KNewStuff BRA

D19436: [kservice] compile without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R309 KServ

D19422: Fix upper/lower case rename on case insensitive fs

ngraham added reviewers: Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/32/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Mar 2019 04:56:50 + Build duration: 5 min 29 sec and counting BUILD ARTIFACTS abi-c

D19422: Fix upper/lower case rename on case insensitive fs

ngraham added reviewers: dfaure, chinmoyr. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/24/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 01 Mar 2019 04:56:50 + Build duration: 5 min 15 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/36/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 01 Mar 2019 04:56:50 + Build duration: 2 min 43 sec and counting JUnit Tests Nam

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 01 Mar 2019 00:22:22 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compatibility-resu

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/30/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Mar 2019 00:22:22 + Build duration: 7 min 16 sec and counting BUILD ARTIFACTS abi-compatibility

D12336: Replace several Q_ASSERTs with proper checks

This revision was automatically updated to reflect the committed changes. Closed by commit R293:75db0004ad02: Replace several Q_ASSERTs with proper checks (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12336?vs=33171&id=52870 REVISION DETAI

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a subscriber: vkrause. kossebau added inline comments. INLINE COMMENTS > kossebau wrote in textcreator.cpp:169 > Good idea. Hm, > `highlightingTheme.backgroundColor(KSyntaxHighlighting::Theme::Normal)` > returns black for me, and there is a comment for > `Theme::backgroundColor(

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. In D19420#422043 , @apol wrote: > With a unit test it would be much easier to accept the patch ;) ... and to identify a remaining bug. The header is now read again after re-initialization. REVISION DETAIL https

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick updated this revision to Diff 52868. croick added a comment. add unit test, reset bNeedHeader CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19420?vs=52825&id=52868 REVISION DETAIL https://phabricator.kde.org/D19420 AFFECTED FILES autotests/data/noop_big.gz autotests/d

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added inline comments. INLINE COMMENTS > cfeck wrote in textcreator.cpp:169 > KSyntaxHighlighting::Theme also provides a background color. Can that be used > instead of the hardcoded 245? I cannot remember reason why I disabled (or > never enabled) the QPalette code; I suggest to remov

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. > That is a good observation: @cullmann Could you give this partial revert a try? I'll try to do that too, tomorrow. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann, dhaumann Cc: rjvbb, loh.tar, thomassc, kwrite-de

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

cfeck added inline comments. INLINE COMMENTS > textcreator.cpp:169 > + > syntaxHighlighter.setDefinition(m_highlightingRepository.definitionForFileName(path)); > + > syntaxHighlighter.setTheme(m_highlightingRepository.defaultTheme(KSyntaxHighlighting::Repository::LightThem

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a comment. Before: F6645792: Screenshot_20190301_000252.png After: F6645790: Screenshot_20190301_03.png There is surely room for more improvements with this thumbnailer, but the syntax

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau created this revision. kossebau added a reviewer: broulik. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Makes previews of text files a bit easier to recognize, both due

D18601: Rewrite taglib writer to use property interface

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibwriter.cpp:70 > That will then require to load and write the property map twice when > properties only specific to some tagging formats need to be written, see e.g. > Ape and Vorbis tags in D18604

D18604: Implement support for writing rating information for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:80 > +if (newProperties.contains(Property::Rating)) { > +int rating = newProperties.value(Property::Rating).toInt(); > +id3Tags->removeFrames("POPM"); This requires a range check here - and then you can use a pla

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/31/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Feb 2019 22:02:09 + Build duration: 7 min 3 sec and counting BUILD ARTIFACTS abi-co

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 22:02:08 + Build duration: 6 min 33 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/35/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 28 Feb 2019 22:02:08 + Build duration: 4 min 50 sec and counting JUnit Tests Nam

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/40/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 28 Feb 2019 22:00:58 + Build duration: 4 min 30 sec and counting CONSOLE OUTPUT [.

D19317: compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R287:f1c6c15b061b: compile without foreach (authored by mlaurent). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19317?vs=52700&id=52863 REVISION DETAIL https:

D19418: Make it compiles without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9fc663d9f0ed: Make it compiles without deprecated method (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19418?vs=52818&id

D19431: [kitemviews] make it compile without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated methods TEST PLAN autotest ok REPOSITORY R276 KIte

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile QT_NO_CAST_FROM_ASCII TEST PLAN autotests ok REPOSITORY R298 KDesigne

D19416: Restore the search wrapped message to its former type and position.

loh.tar added a comment. >> @loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed? > > You don't mean the widget through which you enter the pattern to search on I hope?

D15013: balootctl: fix 396535

bruns abandoned this revision. bruns added a comment. This has been fixed with D18829 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 To: bruns, jausmus Cc: bruns, mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, domson

D15013: balootctl: fix 396535

bruns commandeered this revision. bruns edited reviewers, added: jausmus; removed: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 To: bruns, jausmus Cc: bruns, mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. > The summary of this diff reads a bit as if it doesn't noticeably improve behaviour The line height change (a part of this commit) does noticeably improve behavior for the font that is used on my system. REPOSITORY R39 KTextEditor REVISION DETAIL https://

D19416: Restore the search wrapped message to its former type and position.

rjvbb added a comment. > @loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed? You don't mean the widget through which you enter the pattern to search on I hope? REPOSITORY

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. > Next Frameworks Tag is on Saturday, 2nd, i.e. in 2 days. Revert, or give it a try? TBH I didn't notice any issues with the before code and am pretty certain I couldn't do better. FWIW I noticed that Scribus (1.5.5) filters out pure emoji fonts, from what I und

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

dhaumann added a comment. That is a good observation: @cullmann Could you give this partial revert a try? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann, dhaumann Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, micha

D12336: Replace several Q_ASSERTs with proper checks

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I am very much in favour of this change. In fact, we had this discussion already a long time ago on the mailing list, namely that baloo has (had?) zero error handling and simply ass

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. > We trade one bug for another. Which one is worse? Without having had a detailed look, it seems to me like the problem reported by @rjvbb might be caused by the removal of the workaround with the second drawing passes in this commit (the changes in src/view/kat

D19416: Restore the search wrapped message to its former type and position.

dhaumann added subscribers: neundorf, dhaumann. dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. @neundorf With this we are back to where we came from. Interesting to see how history repeats, and repeats, and repeats... Accepting this

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

dhaumann added a comment. We trade one bug for another. Which one is worse? Next Frameworks Tag is on Saturday, 2nd, i.e. in 2 days. Revert, or give it a try? PS: This is never going to be fixed, since some lines (in this case with emojis, but could also be bidi text or arabic lette

D19427: ViInputMode: Remove unsupported text attributes from the status bar

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. TEST PLAN F6645655: pic.png REPOSITORY

Re: kconf_update lost its update.log in 2014

El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va escriure: > ...and I don't understand why > > Hi! > > this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0` > and thus disabling the update.log writing, replacing it with logging > to stderr instead. Why it doe

Re: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Failure!

Hi Laurent, Please see below - your changes broke the build on Windows. Cheers, Ben On Fri, Mar 1, 2019 at 1:18 AM CI System wrote: > *BUILD FAILURE* > Build URL > https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/39/ > Project: kf5-qt5 WindowsMSVCQt5.11 > Date o

Re: kconf_update lost its update.log in 2014

On Thu, Feb 28, 2019 at 12:43 PM Harald Sitter wrote: > > ...and I don't understand why > > Hi! > > this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0` > and thus disabling the update.log writing, replacing it with logging > to stderr instead. Why it does that eludes me though.

D19416: Restore the search wrapped message to its former type and position.

loh.tar added a comment. I quote myself from D19367 TEST PLAN Potential TODOs: > There is a status (KSqueezedTextLabel) set in indicateMatch, but I have never seen this hint. Tinker the UI file make it visible. Not so bad. Do anyone knows why this is

D19418: Make it compiles without deprecated method

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH remove_deprecated_methods (branched from master) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

apol added a comment. With a unit test it would be much easier to accept the patch ;) REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19425: DocumentPrivate: Support to set dictionary on block selection

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY That may rarely needed but in case of tables for sure useful

D19388: improve documentation on global config cascading

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D19388 To: sitter, kde-frameworks-devel, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19383: remove kpackage_install_package deprecation warning

apol added a comment. In D19383#422019 , @apol wrote: > I'd like to see this documented somewhere. My bad, thanks @sitter :) REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19383 To: sitter, mart Cc: apol, kde-

D19383: remove kpackage_install_package deprecation warning

apol added a comment. I'd like to see this documented somewhere. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19383 To: sitter, mart Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19385: use KPackage::fileUrl to support rcc KCMs packages

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, it would make sense to see if we can come up with a check for such things. I wonder if filePath should be deprecated actually as it's better dealt by the host application. REPOSIT

D19317: compile without foreach

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > imagedump.cpp:75 > out << "File formats:\n"; > -foreach (const QByteArray &fmt, > QImageReader::supportedImageFormats()) { > +const QList lstSuppor

D19422: Fix upper/lower case rename on case insensitive fs

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Fixes wrong temp file creation (missing '/' at relative root of mounted fs). TEST PLAN Mount a CIFS s

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/34/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 28 Feb 2019 14:59:56 + Build duration: 58 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/30/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Feb 2019 14:59:56 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 14:59:56 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compati

D19421: [Icon Item] Block next animation also based on window visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b6a6bb8e175b: [Icon Item] Block next animation also based on window visibility (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19421?vs=52830&id=52832#toc REPOSITORY R2

D19421: [Icon Item] Block next animation also based on window visibility

broulik retitled this revision from "WIP: [Icon Item] Block next animation also based on window visibility" to "[Icon Item] Block next animation also based on window visibility". broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https

D19421: WIP: [Icon Item] Block next animation also based on window visibility

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19421 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19421: WIP: [Icon Item] Block next animation also based on window visibility

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Plasma `Dialog` used to change the item's visiblity but this is no longer the case, s

D19416: Restore the search wrapped message to its former type and position.

ngraham added a comment. I'm in favor of this. Ever since the message was moved to the middle of the screen, it's annoyed me by covering up the search result itself. If the bottom-right corner is considered too hidden, maybe it should be horizontally centered, and moved up 50 pixels or so fr

D18996: Fix building with namespaced Qt

cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:68 > set_property(TARGET SyntaxHighlightingData PROPERTY > POSITION_INDEPENDENT_CODE 1) > +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core) This is causing a build issue (at least) with CMake 3.10: > CMake Erro

D19324: Add code-oss icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:54a20776ffb4: Add code-oss icon (authored by axionl, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52826&id=52827 REVISION DET

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

broulik added a comment. Works fine here, thanks, but I don't feel qualified enough to comment on this patch, I added Frameworks reviewers. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ng

D19324: Add code-oss icon

axionl updated this revision to Diff 52826. axionl added a comment. - Setting my username to pass the automated audit. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52786&id=52826 BRANCH code-oss (branched from master) REVISION DETAIL h

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

broulik added a reviewer: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick created this revision. croick added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. croick requested review of this revision. REVISION SUMMARY - return KFilterBase::End if KGzipFilter::uncompress_noop() finished reading - reset r

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/33/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 28 Feb 2019 12:28:30 + Build duration: 45 min and counting JUnit Tests Name: pro

D19418: Make it compiles without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN all autotest ok REPOSITORY R242 P

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. Causes https://bugs.kde.org/show_bug.cgi?id=404907 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann, dhaumann Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cu

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 12:28:30 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compati

D19416: Restore the search wrapped message to its former type and position.

rjvbb created this revision. rjvbb added a reviewer: KTextEditor. rjvbb added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added a subscriber: kwrite-devel. rjvbb requested review of this revision. REVISION SUMMARY This fixes issue 398731 by restoring the "search wrapp

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/29/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Feb 2019 12:28:30 + Build duration: 5 min 11 sec and counting BUILD ARTIFACTS abi-c

D19326: [Kconfig] Compile without foreach

mlaurent edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19326 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

mlaurent updated this revision to Diff 52808. mlaurent added a comment. Fixed code as requested by David REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19326?vs=52579&id=52808 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 28 Feb 2019 12:09:35 + Build duration: 8 min 48 sec and counting CONSOLE OUTPUT [.

D19396: [kxmlgui] remove deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R263:8069268ceda6: [kxmlgui] remove deprecated method (authored by mlaurent). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19396?vs=52794&id=52802 REVISION DETAIL h

D19395: [KJobWidget] remove deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R288:07d140f5a206: [KJobWidget] remove deprecated method (authored by mlaurent). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19395?vs=52793&id=52801 REVISION DET

kconf_update lost its update.log in 2014

...and I don't understand why Hi! this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0` and thus disabling the update.log writing, replacing it with logging to stderr instead. Why it does that eludes me though. It seems entirely unrelated to the rest of the commit. Should the up

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

davschul added a comment. cool thanks :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19286 To: dhaumann, cullmann, davschul, vkrause Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19395: [KJobWidget] remove deprecated method

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH remove_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19395 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19396: [kxmlgui] remove deprecated method

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH remove_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19396 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

knauss added a subtask: T10504: Abi compliance checker flaky/not working. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19410: create-abi-dump: Do not break for library, that don't have a SONAME.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blaz

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 08:58:04 + Build duration: 7 min 26 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/15/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Feb 2019 08:58:04 + Build duration: 5 min 32 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 28 Feb 2019 08:58:04 + Build duration: 4 min 19 sec and counting JUnit Tests Name: pr