D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
bonghyunkim requested review of this revision.

REVISION SUMMARY
  This commit adds syntax definition for Elm language to syntax-highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

AFFECTED FILES
  data/syntax/elm.xml

To: bonghyunkim
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> kossebau wrote in textcreator.cpp:169
> @vkrause Can you help here and tell what one is intended to use?

I think default background color here refers to what your palette gives you. 
The background color defined by highlighting is typically only used for small 
text blocks like for alerts ("TODO", "HACK", etc).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 01 Mar 2019 06:23:36 +
 Build duration:
2 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.56.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/10/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Mar 2019 06:23:36 +
 Build duration:
2 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.56.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 01 Mar 2019 06:23:36 +
 Build duration:
57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D19437: [knewstuff] Remove qt5.13 deprecated method

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  remove deprecated method

TEST PLAN
  autotest ok

REPOSITORY
  R304 KNewStuff

BRANCH
  remove_deprecated_qt5.13 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19437

AFFECTED FILES
  CMakeLists.txt
  src/core/installation.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19436: [kservice] compile without deprecated method

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without deprecated method

TEST PLAN
  autotest ok

REPOSITORY
  R309 KService

BRANCH
  compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19436

AFFECTED FILES
  CMakeLists.txt
  autotests/kmimeassociationstest.cpp
  autotests/ksycocathreadtest.cpp
  src/services/kservicetypeprofile.cpp
  src/sycoca/kbuildservicefactory.cpp
  src/sycoca/kbuildsycoca.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19422: Fix upper/lower case rename on case insensitive fs

[Nathaniel Graham]

ngraham added reviewers: Frameworks, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/32/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Mar 2019 04:56:50 +
 Build duration:
5 min 29 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D19422: Fix upper/lower case rename on case insensitive fs

[Nathaniel Graham]

ngraham added reviewers: dfaure, chinmoyr.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/24/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 01 Mar 2019 04:56:50 +
 Build duration:
5 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/36/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 01 Mar 2019 04:56:50 +
 Build duration:
2 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/23/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 01 Mar 2019 00:22:22 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.56.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5721/9530)43%
(2239/5260)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(865/908)52%
(275/530)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1739/2147)60%
(695/1159)src.file63%
(24/38)63%
(24/38)51%
(867/1688)42%
(446/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/30/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Mar 2019 00:22:22 +
 Build duration:
7 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.56.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5743/9530)43%
(2254/5260)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)98%
(887/908)55%
(289/530)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1739/2147)60%
(695/1159)src.file63%
(24/38)63%
(24/38)51%
(867/1688)42%
(447/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
   

D12336: Replace several Q_ASSERTs with proper checks

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:75db0004ad02: Replace several Q_ASSERTs with proper 
checks (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12336?vs=33171=52870

REVISION DETAIL
  https://phabricator.kde.org/D12336

AFFECTED FILES
  src/engine/documenturldb.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, dhaumann
Cc: dhaumann, ngraham, apol, sitter, kde-frameworks-devel, broulik, 
#frameworks, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added a subscriber: vkrause.
kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in textcreator.cpp:169
> Good idea. Hm, 
> `highlightingTheme.backgroundColor(KSyntaxHighlighting::Theme::Normal)` 
> returns black for me, and there is a comment for 
> `Theme::backgroundColor(TextStyle) const` saying
> "0 is returned for styles that do not specify a background color, use the 
> default background color in that case. "
> No clue yet what is meant by "default background color". Not sure I want to 
> use the `Theme::editorColor(EditorColorRole role) const` with 
> `BackgroundColor`?

@vkrause Can you help here and tell what one is intended to use?

> cfeck wrote in textcreator.cpp:169
> KSyntaxHighlighting::Theme also provides a background color. Can that be used 
> instead of the hardcoded 245? I cannot remember reason why I disabled (or 
> never enabled) the QPalette code; I suggest to remove it.

@cfeck: I would do the remove of the qpalette in a separate commit then later.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick added a comment.


  In D19420#422043 , @apol wrote:
  
  > With a unit test it would be much easier to accept the patch ;)
  
  
  ... and to identify a remaining bug.
  The header is now read again after re-initialization.

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick updated this revision to Diff 52868.
croick added a comment.


  add unit test, reset bNeedHeader

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19420?vs=52825=52868

REVISION DETAIL
  https://phabricator.kde.org/D19420

AFFECTED FILES
  autotests/data/noop_big.gz
  autotests/data/noop_small.gz
  autotests/kfiltertest.cpp
  autotests/kfiltertest.h
  src/kcompressiondevice.cpp
  src/kgzipfilter.cpp

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> cfeck wrote in textcreator.cpp:169
> KSyntaxHighlighting::Theme also provides a background color. Can that be used 
> instead of the hardcoded 245? I cannot remember reason why I disabled (or 
> never enabled) the QPalette code; I suggest to remove it.

Good idea. Hm, 
`highlightingTheme.backgroundColor(KSyntaxHighlighting::Theme::Normal)` returns 
black for me, and there is a comment for `Theme::backgroundColor(TextStyle) 
const` saying
"0 is returned for styles that do not specify a background color, use the 
default background color in that case. "
No clue yet what is meant by "default background color". Not sure I want to use 
the `Theme::editorColor(EditorColorRole role) const` with `BackgroundColor`?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  >   That is a good observation: @cullmann Could you give this partial revert 
a try?
  
  I'll try to do that too, tomorrow.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> textcreator.cpp:169
> +
> syntaxHighlighter.setDefinition(m_highlightingRepository.definitionForFileName(path));
> +
> syntaxHighlighter.setTheme(m_highlightingRepository.defaultTheme(KSyntaxHighlighting::Repository::LightTheme));
> +

KSyntaxHighlighting::Theme also provides a background color. Can that be used 
instead of the hardcoded 245? I cannot remember reason why I disabled (or never 
enabled) the QPalette code; I suggest to remove it.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Before:
  F6645792: Screenshot_20190301_000252.png 

  After:
  F6645790: Screenshot_20190301_03.png 

  
  There is surely room for more improvements with this thumbnailer, but the 
syntax highlighting already adds a lot for me (though I only use it with the 
tooltip myself, not actual thumbnails).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: broulik.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Makes previews of text files a bit easier to recognize, both due to the
  highlighting helping with reading as well as color pattern adding to
  recognizability of files by their preview.

TEST PLAN
  Renders fine for any kind of text/plain MIME types and sub formats.

REPOSITORY
  R320 KIO Extras

BRANCH
  addsyntaxhighlighttotextpreview

REVISION DETAIL
  https://phabricator.kde.org/D19432

AFFECTED FILES
  CMakeLists.txt
  thumbnail/CMakeLists.txt
  thumbnail/textcreator.cpp
  thumbnail/textcreator.h

To: kossebau, broulik
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18601: Rewrite taglib writer to use property interface

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwriter.cpp:70
> That will then require to load and write the property map twice when 
> properties only specific to some tagging formats need to be written, see e.g. 
> Ape and Vorbis tags in D18604 . I would 
> like to avoid this.

So **iff** the rating is updated at the same time as another property, taglib 
has to adjust some in-memory structure twice. Obviously, for most formats this 
poses no problem, but for Ape/Vorbis it does?

Also, this no longer applies when you use the specific tag types for Ape/Ogg.

Writing to disk only happens when calling `file->save()`...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:80
> +if (newProperties.contains(Property::Rating)) {
> +int rating = newProperties.value(Property::Rating).toInt();
> +id3Tags->removeFrames("POPM");

This requires a range check here - and then you can use a plain array for 
lookup.

> taglibwriter.cpp:89
> +
> +void writeVorbisAndApeTags(TagLib::PropertyMap , const 
> PropertyMap )
> +{

I think this should be split in
`writeApeTags(Taglib::APE::Tag *tags, PropertyMap) { ...; tags->setItem(...) }`
and
`writeXiphTags(Taglib::Ogg::XiphComment *tags, PropertyMap) {...; 
tags->addField(..., replace) }`

Thats much more in line with the other calls.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/31/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 28 Feb 2019 22:02:09 +
 Build duration:
7 min 3 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/23/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 28 Feb 2019 22:02:08 +
 Build duration:
6 min 33 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/35/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 28 Feb 2019 22:02:08 +
 Build duration:
4 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/40/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 28 Feb 2019 22:00:58 +
 Build duration:
4 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 340 lines...][2019-02-28T22:05:15.668Z]  * KF5WindowSystem (required version >= 5.55.0)[2019-02-28T22:05:15.668Z]  * KF5GlobalAccel (required version >= 5.55.0)[2019-02-28T22:05:15.668Z]  * Doxygen (required version >= 1.8.13)[2019-02-28T22:05:15.668Z]Needed for API dox QCH file generation[2019-02-28T22:05:15.668Z]  * QHelpGenerator, Part of Qt5 tools[2019-02-28T22:05:15.668Z]Needed for API dox QCH file generation[2019-02-28T22:05:15.668Z]  * Qt5Xml[2019-02-28T22:05:15.668Z]  * Qt5Test[2019-02-28T22:05:15.668Z]  * Qt5 (required version >= 5.10.0)[2019-02-28T22:05:15.668Z] [2019-02-28T22:05:15.668Z] -- Configuring done[2019-02-28T22:05:17.576Z] -- Generating done[2019-02-28T22:05:17.576Z] -- Build files have been written to: C:/CI/workspace/Frameworks/kxmlgui/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-02-28T22:05:18.675Z] [2019-02-28T22:05:18.675Z] C:\CI\workspace\Frameworks\kxmlgui\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat" [2019-02-28T22:05:18.675Z] **[2019-02-28T22:05:18.675Z] ** Visual Studio 2017 Developer Command Prompt v15.7.3[2019-02-28T22:05:18.675Z] ** Copyright (c) 2017 Microsoft Corporation[2019-02-28T22:05:18.675Z] **[2019-02-28T22:05:20.588Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-02-28T22:05:22.592Z] [2019-02-28T22:05:22.592Z] jom 1.1.2 - empower your cores[2019-02-28T22:05:22.592Z] [2019-02-28T22:05:22.592Z] jom: parallel job execution disabled for Makefile[2019-02-28T22:05:22.592Z] Scanning dependencies of target KF5XmlGui_autogen[2019-02-28T22:05:22.592Z] Scanning dependencies of target ksendbugmail_autogen[2019-02-28T22:05:22.592Z] Scanning dependencies of target KF5XmlGui_QCH[2019-02-28T22:05:22.592Z] [  2%] Automatic MOC for target KF5XmlGui[2019-02-28T22:05:22.869Z] [  1%] Automatic MOC for target ksendbugmail[2019-02-28T22:05:22.869Z] [  3%] Built target ksendbugmail_autogen[2019-02-28T22:05:24.262Z] Scanning dependencies of target ksendbugmail[2019-02-28T22:05:24.842Z] [  6%] Built target KF5XmlGui_autogen[2019-02-28T22:05:24.842Z] [  3%] Generating src/KF5XmlGui.qch, src/KF5XmlGui.tags[2019-02-28T22:05:24.842Z] [  5%] Building CXX object src/ksendbugmail/CMakeFiles/ksendbugmail.dir/main.cpp.obj[2019-02-28T22:05:24.842Z] [  5%] Building CXX object src/ksendbugmail/CMakeFiles/ksendbugmail.dir/smtp.cpp.obj[2019-02-28T22:05:24.842Z] main.cpp[2019-02-28T22:05:24.842Z] [  6%] Building CXX object src/ksendbugmail/CMakeFiles/ksendbugmail.dir/ksendbugmail_autogen/mocs_compilation.cpp.obj[2019-02-28T22:05:25.803Z] [  8%] Built target KF5XmlGui_QCH[2019-02-28T22:05:25.803Z] [  7%] Generating qrc_kxmlgui.cpp[2019-02-28T22:05:25.803Z] [  8%] Generating ui_kshortcutsdialog.h[2019-02-28T22:05:25.803Z] [  8%] Generating ui_kshortcutwidget.h[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(66): error C2450: switch _expression_ of type 'QOperatingSystemVersion' is illegal[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(66): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): error C2131: _expression_ did not evaluate to a constant[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note: failure was caused by non-constant arguments or reference to a non-constant symbol[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note: see usage of 'Windows7'[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error C2131: _expression_ did not evaluate to a constant[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): note: failure was caused by non-constant arguments or reference to a non-constant symbol[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): note: see usage of 'Windows8'[2019-02-28T22:05:26.063Z] 

D19317: compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R287:f1c6c15b061b: compile without foreach (authored by 
mlaurent).

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19317?vs=52700=52863

REVISION DETAIL
  https://phabricator.kde.org/D19317

AFFECTED FILES
  CMakeLists.txt
  autotests/readtest.cpp
  autotests/writetest.cpp
  src/imageformats/pic.cpp
  tests/imageconverter.cpp
  tests/imagedump.cpp

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19418: Make it compiles without deprecated method

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9fc663d9f0ed: Make it compiles without deprecated method 
(authored by mlaurent).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19418?vs=52818=52862

REVISION DETAIL
  https://phabricator.kde.org/D19418

AFFECTED FILES
  CMakeLists.txt
  autotests/dialognativetest.cpp
  autotests/framesvgtest.cpp
  autotests/modeltest.cpp
  autotests/plasmoidpackagetest.cpp
  autotests/storagetest.cpp
  src/declarativeimports/calendar/calendar.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/private/storagethread.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/svg.cpp
  src/plasma/theme.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19431: [kitemviews] make it compile without deprecated method

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without deprecated methods

TEST PLAN
  autotest ok

REPOSITORY
  R276 KItemViews

BRANCH
  make_it_compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19431

AFFECTED FILES
  CMakeLists.txt
  src/kcategorizedview.cpp
  tests/kwidgetitemdelegatetest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile QT_NO_CAST_FROM_ASCII

TEST PLAN
  autotests ok

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  compile_with_QT_NO_CAST_FROM_ASCII (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19430

AFFECTED FILES
  CMakeLists.txt
  src/kde.widgets
  src/kgendesignerplugin.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19416: Restore the search wrapped message to its former type and position.

[loh tar]

loh.tar added a comment.


  >>   @loh.tar The line edit in the search bar was once used before the 
floating message widgets in the view even existed. I guess it's legacy and 
possibly can be removed?
  > 
  > You don't mean the widget through which you enter the pattern to search on 
I hope?
  
  That quote reads a little strange. There is a label right from the line edit, 
now always hidden.
  
  I had talked with Christoph and Dominik elsewhere to modify this wrap message 
in a way to only be shown when the start position is wrapped, but not 
top/bottom of the document. 
  That will reduce the times this message can be annoying and for my taste is a 
much more useful hint.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19416

To: rjvbb, #ktexteditor, dhaumann
Cc: dhaumann, neundorf, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, head7, cullmann, kfunk, sars

D15013: balootctl: fix 396535

[Stefan Brüns]

bruns abandoned this revision.
bruns added a comment.


  This has been fixed with D18829 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15013

To: bruns, jausmus
Cc: bruns, mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15013: balootctl: fix 396535

[Stefan Brüns]

bruns commandeered this revision.
bruns edited reviewers, added: jausmus; removed: bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15013

To: bruns, jausmus
Cc: bruns, mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Thomas Schöps]

thomassc added a comment.


  > The summary of this diff reads a bit as if it doesn't noticeably improve 
behaviour
  
  The line height change (a part of this commit) does noticeably improve 
behavior for the font that is used on my system.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19416: Restore the search wrapped message to its former type and position.

[René J . V . Bertin]

rjvbb added a comment.


  >   @loh.tar The line edit in the search bar was once used before the 
floating message widgets in the view even existed. I guess it's legacy and 
possibly can be removed?
  
  You don't mean the widget through which you enter the pattern to search on I 
hope?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19416

To: rjvbb, #ktexteditor, dhaumann
Cc: dhaumann, neundorf, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, head7, cullmann, kfunk, sars

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  >   Next Frameworks Tag is on Saturday, 2nd, i.e. in 2 days. Revert, or give 
it a try?
  
  TBH I didn't notice any issues with the before code and am pretty certain I 
couldn't do better. FWIW I noticed that Scribus (1.5.5) filters out pure emoji 
fonts, from what I understand because they lack information needed for proper 
scaling. That probably explains why lines holding these glyphs are lower 
despite the fact that the glyphs are taller than the text.
  
  The summary of this diff reads a bit as if it doesn't noticeably improve 
behaviour so my vote would be on reverting.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Dominik Haumann]

dhaumann added a comment.


  That is a good observation: @cullmann Could you give this partial revert a 
try?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12336: Replace several Q_ASSERTs with proper checks

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I am very much in favour of this change.
  
  In fact, we had this discussion already a long time ago on the mailing list, 
namely that baloo has (had?) zero error handling and simply assuming that 
everything works by adding some Q_ASSERTS.
  
  @bruns You are working on this code for quite a time now. I trust you know 
very much what you are doing much more than possibly anyone else. I know that 
you would like to get a better review, but having a review open for 5+ months 
clearly shows we have an issue elsewhere.
  
  Please proceed and commit - I am taking the liberty to give a +2: If there 
are other issues, the these can still be fixed in followup commits.

REPOSITORY
  R293 Baloo

BRANCH
  db_robustness2

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, #frameworks, ngraham, poboiko, dhaumann
Cc: dhaumann, ngraham, apol, sitter, kde-frameworks-devel, broulik, 
#frameworks, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Thomas Schöps]

thomassc added a comment.


  > We trade one bug for another. Which one is worse?
  
  Without having had a detailed look, it seems to me like the problem reported 
by @rjvbb might be caused by the removal of the workaround with the second 
drawing passes in this commit (the changes in src/view/kateviewinternal.cpp), 
which probably results in more issues with oversized characters. This is 
independent from the other change (in src/render/katerenderer.cpp), which 
adapts the line height and fixes the bug with the bottom of lines being cut 
off. So, one might try to revert the removal of the second drawing passes, but 
keep the change to the line heights.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19416: Restore the search wrapped message to its former type and position.

[Dominik Haumann]

dhaumann added subscribers: neundorf, dhaumann.
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  @neundorf With this we are back to where we came from. Interesting to see how 
history repeats, and repeats, and repeats... Accepting this change means a 
wont-fix to your wish to move it to the center.
  
  @loh.tar The line edit in the search bar was once used before the floating 
message widgets in the view even existed. I guess it's legacy and possibly can 
be removed?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19416

To: rjvbb, #ktexteditor, dhaumann
Cc: dhaumann, neundorf, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, head7, cullmann, kfunk, sars

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Dominik Haumann]

dhaumann added a comment.


  We trade one bug for another. Which one is worse?
  
  Next Frameworks Tag is on Saturday, 2nd, i.e. in 2 days. Revert, or give it a 
try?
  
  PS: This is never going to be fixed, since some lines (in this case with 
emojis, but could also be bidi text or arabic letters) , suddenly need another 
height. Call it "broken by design", but we are struggling with this at least 
5++ years.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19427: ViInputMode: Remove unsupported text attributes from the status bar

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

TEST PLAN
  F6645655: pic.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19427

AFFECTED FILES
  src/inputmode/kateviinputmode.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: kconf_update lost its update.log in 2014

[Albert Astals Cid]

El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va escriure:
> ...and I don't understand why
> 
> Hi!
> 
> this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0`
> and thus disabling the update.log writing, replacing it with logging
> to stderr instead. Why it does that eludes me though. It seems
> entirely unrelated to the rest of the commit.

Yep, maybe he was testing on windows, that code had issues on windows, disabled 
it for the moment and then forgot to reenable?

Sound we try CC'ing Alex Richardson in case he remembers? Or you did and it got 
lost because he's on the list?

> Should the update.log writing happen? I expect this won't be super
> reliable because I think these days the application itself forks
> kconf_update. 

I don't understand what you mean with this. kconf_update has always been its 
own application as far as i know. 

Cheers,
  Albert

> If so, we should just drop the if block and update
> documentation accordingly I guess (e.g. see [2])
> 
> [1] 
> https://cgit.kde.org/kconfig.git/commit/?id=94419b6f0cd469dc7cb0184a6fb48c1fe304c4d8
> [2] https://bugs.kde.org/show_bug.cgi?id=404904
> 

Re: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Failure!

[Ben Cooksley]

Hi Laurent,

Please see below - your changes broke the build on Windows.

Cheers,
Ben

On Fri, Mar 1, 2019 at 1:18 AM CI System  wrote:

> *BUILD FAILURE*
> Build URL
> https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/39/
> Project: kf5-qt5 WindowsMSVCQt5.11
> Date of build: Thu, 28 Feb 2019 12:09:35 +
> Build duration: 8 min 48 sec and counting
> * CONSOLE OUTPUT *
> [...truncated 395 lines...]
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note:
> failure was caused by non-constant arguments or reference to a non-constant
> symbol
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note: see
> usage of 'WV_XP'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error
> C2039: 'WV_2003': is not a member of 'QSysInfo'
> [2019-02-28T12:18:14.482Z]
> c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70):
> note: see declaration of 'QSysInfo'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error
> C2065: 'WV_2003': undeclared identifier
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error
> C2131: expression did not evaluate to a constant
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): note:
> failure was caused by non-constant arguments or reference to a non-constant
> symbol
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): note: see
> usage of 'WV_2003'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): error
> C2039: 'WV_VISTA': is not a member of 'QSysInfo'
> [2019-02-28T12:18:14.482Z]
> c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70):
> note: see declaration of 'QSysInfo'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): error
> C2065: 'WV_VISTA': undeclared identifier
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): error
> C2131: expression did not evaluate to a constant
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): note:
> failure was caused by non-constant arguments or reference to a non-constant
> symbol
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): note: see
> usage of 'WV_VISTA'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): error
> C2039: 'WV_WINDOWS7': is not a member of 'QSysInfo'
> [2019-02-28T12:18:14.482Z]
> c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70):
> note: see declaration of 'QSysInfo'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): error
> C2065: 'WV_WINDOWS7': undeclared identifier
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): error
> C2131: expression did not evaluate to a constant
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): note:
> failure was caused by non-constant arguments or reference to a non-constant
> symbol
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): note: see
> usage of 'WV_WINDOWS7'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(71): error
> C2039: 'WV_WINDOWS8': is not a member of 'QSysInfo'
> [2019-02-28T12:18:14.482Z]
> c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70):
> note: see declaration of 'QSysInfo'
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(71): error
> C2065: 'WV_WINDOWS8': undeclared identifier
> [2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
> windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(71): error
> C2131: expression did not evaluate to a constant
> 

Re: kconf_update lost its update.log in 2014

[Aleix Pol]

On Thu, Feb 28, 2019 at 12:43 PM Harald Sitter  wrote:
>
> ...and I don't understand why
>
> Hi!
>
> this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0`
> and thus disabling the update.log writing, replacing it with logging
> to stderr instead. Why it does that eludes me though. It seems
> entirely unrelated to the rest of the commit.

Sounds like he didn't go through review.

> Should the update.log writing happen? I expect this won't be super
> reliable because I think these days the application itself forks
> kconf_update. If so, we should just drop the if block and update
> documentation accordingly I guess (e.g. see [2])

If anything, instead of going directly to stderr it should be using
QDebug and go through journald (or whatever the system uses), no?

> [1] 
> https://cgit.kde.org/kconfig.git/commit/?id=94419b6f0cd469dc7cb0184a6fb48c1fe304c4d8
> [2] https://bugs.kde.org/show_bug.cgi?id=404904

D19416: Restore the search wrapped message to its former type and position.

[loh tar]

loh.tar added a comment.


  I quote myself from D19367  TEST PLAN 
Potential TODOs:
  
  > There is a status (KSqueezedTextLabel) set in indicateMatch, but I have 
never seen this hint. Tinker the UI file make it visible. Not so bad. Do anyone 
knows why this is still there? May that be better to use instead of the fancy 
in-view-hint which is sometimes annoying because it hides the text? ... PowerUi 
would need such label too.
  
  No, do not want so say that this label is better, just for info.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19416

To: rjvbb, #ktexteditor
Cc: loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D19418: Make it compiles without deprecated method

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove_deprecated_methods (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19418

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Aleix Pol Gonzalez]

apol added a comment.


  With a unit test it would be much easier to accept the patch ;)

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19425: DocumentPrivate: Support to set dictionary on block selection

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  That may rarely needed but in case of tables for sure useful
  
  - Removed unused trivial function 
KTextEditor::DocumentPrivate::revertToDefaultDictionary
  
  F6645454: pic.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19425

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/document/katedocument.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19388: improve documentation on global config cascading

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19388

To: sitter, kde-frameworks-devel, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19383: remove kpackage_install_package deprecation warning

[Aleix Pol Gonzalez]

apol added a comment.


  In D19383#422019 , @apol wrote:
  
  > I'd like to see this documented somewhere.
  
  
  My bad, thanks @sitter :)

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D19383

To: sitter, mart
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19383: remove kpackage_install_package deprecation warning

[Aleix Pol Gonzalez]

apol added a comment.


  I'd like to see this documented somewhere.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D19383

To: sitter, mart
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19385: use KPackage::fileUrl to support rcc KCMs packages

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense, it would make sense to see if we can come up with a check for 
such things. I wonder if filePath should be deprecated actually as it's better 
dealt by the host application.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19385

To: sitter, mart, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19317: compile without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> imagedump.cpp:75
>  out << "File formats:\n";
> -foreach (const QByteArray , 
> QImageReader::supportedImageFormats()) {
> +const QList lstSupportedFormats = 
> QImageReader::supportedImageFormats();
> +for (const QByteArray  : lstSupportedFormats) {

auto too?

REPOSITORY
  R287 KImageFormats

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19317

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19422: Fix upper/lower case rename on case insensitive fs

[Robert Hoffmann]

hoffmannrobert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Fixes wrong temp file creation (missing '/' at
  relative root of mounted fs).

TEST PLAN
  Mount a CIFS share e.g. at /mnt/share with option
  'nocase'. In dolphin, go there and create a file
  'foo' (i.e. /mnt/share/foo).
  Try to rename it to 'Foo': Without this patch a
  dialog pops up telling you about overwriting the file.
  With this patch applied it will correctly be renamed.
  
  Create a directory 'subdir' below /mnt/share.
  In dolphin, change there and create a file 'foo'
  (i.e. /mnt/share/subdir/foo).
  Try to rename it to 'Foo': no problem with and without
  this patch.

REPOSITORY
  R241 KIO

BRANCH
  fix_case_rename

REVISION DETAIL
  https://phabricator.kde.org/D19422

AFFECTED FILES
  src/core/copyjob.cpp

To: hoffmannrobert
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/34/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 28 Feb 2019 14:59:56 +
 Build duration:
58 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/30/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 28 Feb 2019 14:59:56 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13338)18%
(1818/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2261)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/22/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 28 Feb 2019 14:59:56 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13338)18%
(1818/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2261)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
  

D19421: [Icon Item] Block next animation also based on window visibility

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b6a6bb8e175b: [Icon Item] Block next animation also based 
on window visibility (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19421?vs=52830=52832#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19421?vs=52830=52832

REVISION DETAIL
  https://phabricator.kde.org/D19421

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19421: [Icon Item] Block next animation also based on window visibility

[Kai Uwe Broulik]

broulik retitled this revision from "WIP: [Icon Item] Block next animation also 
based on window visibility" to "[Icon Item] Block next animation also based on 
window visibility".
broulik edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19421

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19421: WIP: [Icon Item] Block next animation also based on window visibility

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19421

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19421: WIP: [Icon Item] Block next animation also based on window visibility

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Plasma `Dialog` used to change the item's visiblity but this is no longer the 
case, so it would animate when a window is shown and the source has changed in 
the meantime.

TEST PLAN
  Changed volume, waited for OSD to disappear, changed brightness, OSD would no 
longer show while animating from the old pixmap.
  Changed volume, and changed brightness right away, OSD would still animate
  
  WIP because the first animation for each icon item isn't animated as the item 
is usually assigned a window which then becomes visible as such blocking the 
animation :/

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19421

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19416: Restore the search wrapped message to its former type and position.

[Nathaniel Graham]

ngraham added a comment.


  I'm in favor of this. Ever since the message was moved to the middle of the 
screen, it's annoyed me by covering up the search result itself. If the 
bottom-right corner is considered too hidden, maybe it should be horizontally 
centered, and moved up 50 pixels or so from the bottom of the view? But 
anything's better than covering up the found matches. :)
  
  Also +1 for using the "Information" style rather than "Positive". That seems 
semantically correct to me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19416

To: rjvbb, #ktexteditor
Cc: ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D18996: Fix building with namespaced Qt

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:68
>  set_property(TARGET SyntaxHighlightingData PROPERTY 
> POSITION_INDEPENDENT_CODE 1)
> +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core)

This is causing a build issue (at least) with CMake 3.10:

> CMake Error at data/CMakeLists.txt:68 (target_link_libraries):
> 
>   Object library target "SyntaxHighlightingData" may not link to anything.

OBJECT targets must not link to anything [1]

>   An object library compiles source files but does not archive or link their 
> object files into a library.

The CMake doc < 3.11 also mentions "Object libraries cannot be linked."

[1] https://cmake.org/cmake/help/v3.14/command/add_library.html#object-libraries

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18996

To: davschul, vkrause
Cc: cgiboudeaux, cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D19324: Add code-oss icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:54a20776ffb4: Add code-oss icon (authored by axionl, 
committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52826=52827

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg, ndavis
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Kai Uwe Broulik]

broulik added a comment.


  Works fine here, thanks, but I don't feel qualified enough to comment on this 
patch, I added Frameworks reviewers.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19324: Add code-oss icon

[Ariel AxionL]

axionl updated this revision to Diff 52826.
axionl added a comment.


  - Setting my username to pass the automated audit.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19324?vs=52786=52826

BRANCH
  code-oss (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19324

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg

To: axionl, #vdg, ndavis
Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Kai Uwe Broulik]

broulik added a reviewer: Frameworks.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick created this revision.
croick added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
croick requested review of this revision.

REVISION SUMMARY
  - return KFilterBase::End if KGzipFilter::uncompress_noop() finished reading
  - reset result to KFilterBase::Ok if there is data remaining
  - fixes 96083005e90e 


TEST PLAN
  - load gzipped files (size < and > than BUFFER_SIZE = 8192 bytes) using kate 
and labplot
  - load unzipped files with .gz suffix (size < and > than 8192 bytes) using 
kate and labplot
  - load bzipped files with kate

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

AFFECTED FILES
  src/kcompressiondevice.cpp
  src/kgzipfilter.cpp

To: croick, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/33/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 28 Feb 2019 12:28:30 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D19418: Make it compiles without deprecated method

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without deprecated method

TEST PLAN
  all autotest ok

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove_deprecated_methods (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19418

AFFECTED FILES
  CMakeLists.txt
  autotests/dialognativetest.cpp
  autotests/framesvgtest.cpp
  autotests/modeltest.cpp
  autotests/plasmoidpackagetest.cpp
  autotests/storagetest.cpp
  src/declarativeimports/calendar/calendar.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/private/storagethread.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/svg.cpp
  src/plasma/theme.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  Causes https://bugs.kde.org/show_bug.cgi?id=404907

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/21/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 28 Feb 2019 12:28:30 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
  

D19416: Restore the search wrapped message to its former type and position.

[René J . V . Bertin]

rjvbb created this revision.
rjvbb added a reviewer: KTextEditor.
rjvbb added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added a subscriber: kwrite-devel.
rjvbb requested review of this revision.

REVISION SUMMARY
  This fixes issue 398731 by restoring the "search wrapped" info message to its 
former type and position.
  
  BUG: 398731

TEST PLAN
  works as intended (= as before #cc8b2208)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19416

AFFECTED FILES
  src/search/katesearchbar.cpp

To: rjvbb, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/29/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 28 Feb 2019 12:28:30 +
 Build duration:
5 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%

D19326: [Kconfig] Compile without foreach

[Laurent Montel]

mlaurent edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19326

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 52808.
mlaurent added a comment.


  Fixed code as requested by David

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19326?vs=52579=52808

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19326

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigtest.cpp
  src/core/kauthorized.cpp
  src/core/kconfig.cpp
  src/core/kconfiggroup.h
  src/core/kconfigini.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kdesktopfile.cpp
  src/core/ksharedconfig.cpp
  src/gui/kconfigloader.cpp
  src/kconf_update/kconf_update.cpp
  src/kconf_update/kconfigutils.cpp
  src/kconfig_compiler/kconfig_compiler.cpp
  src/kreadconfig/kreadconfig.cpp
  src/kreadconfig/kwriteconfig.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/39/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 28 Feb 2019 12:09:35 +
 Build duration:
8 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 395 lines...][2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note: failure was caused by non-constant arguments or reference to a non-constant symbol[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note: see usage of 'WV_XP'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error C2039: 'WV_2003': is not a member of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70): note: see declaration of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error C2065: 'WV_2003': undeclared identifier[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error C2131: _expression_ did not evaluate to a constant[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): note: failure was caused by non-constant arguments or reference to a non-constant symbol[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): note: see usage of 'WV_2003'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): error C2039: 'WV_VISTA': is not a member of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70): note: see declaration of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): error C2065: 'WV_VISTA': undeclared identifier[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): error C2131: _expression_ did not evaluate to a constant[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): note: failure was caused by non-constant arguments or reference to a non-constant symbol[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(69): note: see usage of 'WV_VISTA'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): error C2039: 'WV_WINDOWS7': is not a member of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70): note: see declaration of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): error C2065: 'WV_WINDOWS7': undeclared identifier[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): error C2131: _expression_ did not evaluate to a constant[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): note: failure was caused by non-constant arguments or reference to a non-constant symbol[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(70): note: see usage of 'WV_WINDOWS7'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(71): error C2039: 'WV_WINDOWS8': is not a member of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\craft\ci-qt511\windows-msvc2017_64-cl-debug\include\qt5\qtcore\qsysinfo.h(70): note: see declaration of 'QSysInfo'[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(71): error C2065: 'WV_WINDOWS8': undeclared identifier[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(71): error C2131: _expression_ did not evaluate to a constant[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(71): note: failure was caused by non-constant arguments or reference to a non-constant symbol[2019-02-28T12:18:14.482Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5 

D19396: [kxmlgui] remove deprecated method

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:8069268ceda6: [kxmlgui] remove deprecated method 
(authored by mlaurent).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19396?vs=52794=52802

REVISION DETAIL
  https://phabricator.kde.org/D19396

AFFECTED FILES
  CMakeLists.txt
  autotests/kmainwindow_unittest.cpp
  autotests/ktoolbar_unittest.cpp
  autotests/kxmlgui_unittest.cpp
  src/ktoolbar.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19395: [KJobWidget] remove deprecated method

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R288:07d140f5a206: [KJobWidget] remove deprecated method 
(authored by mlaurent).

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19395?vs=52793=52801

REVISION DETAIL
  https://phabricator.kde.org/D19395

AFFECTED FILES
  CMakeLists.txt
  src/kstatusbarjobtracker.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

kconf_update lost its update.log in 2014

[Harald Sitter]

...and I don't understand why

Hi!

this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0`
and thus disabling the update.log writing, replacing it with logging
to stderr instead. Why it does that eludes me though. It seems
entirely unrelated to the rest of the commit.

Should the update.log writing happen? I expect this won't be super
reliable because I think these days the application itself forks
kconf_update. If so, we should just drop the if block and update
documentation accordingly I guess (e.g. see [2])

[1] 
https://cgit.kde.org/kconfig.git/commit/?id=94419b6f0cd469dc7cb0184a6fb48c1fe304c4d8
[2] https://bugs.kde.org/show_bug.cgi?id=404904

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

[David Schulz]

davschul added a comment.


  cool thanks :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19286

To: dhaumann, cullmann, davschul, vkrause
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19395: [KJobWidget] remove deprecated method

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R288 KJobWidgets

BRANCH
  remove_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19395

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19396: [kxmlgui] remove deprecated method

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  remove_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19396

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a subtask: T10504: Abi compliance checker flaky/not working.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19410: create-abi-dump: Do not break for library, 
that don't have a SONAME..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/11/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 28 Feb 2019 08:58:04 +
 Build duration:
7 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.56.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6417/8535)44%
(10444/23958)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5925/12151)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/15/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 28 Feb 2019 08:58:04 +
 Build duration:
5 min 32 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.56.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6417/8535)44%
(10444/23958)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5925/12151)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/17/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 28 Feb 2019 08:58:04 +
 Build duration:
4 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest