D19170: Fix crash while moving files

hallas marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19170 To: hallas, #frameworks, elvisangelaccio, dfaure Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

hallas updated this revision to Diff 53032. hallas added a comment. Set job to nullptr before stopping job running in parallel REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19170?vs=52643&id=53032 BRANCH fix_crash_while_moving_files (branched from master)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/35/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 03 Mar 2019 04:34:20 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Mar 2019 04:34:20 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Mar 2019 04:34:20 + Build duration: 10 min and counting JUnit Tests Name: pro

T10554: KDiff3 to join Applications

mreeves removed a project: KDE Applications. TASK DETAIL https://phabricator.kde.org/T10554 To: mreeves Cc: kde-frameworks-devel, mreeves, alexeymin, genaxxx

T10554: KDiff3 to join Applications

mreeves created this task. mreeves triaged this task as "Normal" priority. mreeves added a project: KDE Applications. TASK DESCRIPTION KDiff3 is preparing to join Applications from Extragear. I have been advised to have some check over the changes made for the kf5/qt5 port. TASK DETAIL https

D15408: Don't assert deleting the temporary file

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15408 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The warning needs to be removed then. We can't really warn at the time of using a variable. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D1

D17737: [CopyJob] Create clones in btrf/xfs mount

dfaure added a comment. No objection from me, but I don't know those clone APIs, so I can't really review/approve it. Maybe Thiago or Oswald, if nobody else does. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, davidedmundson, #framework

D19422: Fix upper/lower case rename on case insensitive fs

dfaure requested changes to this revision. dfaure added a comment. Indeed, "just" a missing slash. Porting error in my commit bbf6181f4de7bc315c7c64e7528a3150788eea09 7 years ago (!) I removed KUrl::AppendTrail

D18699: [KIO/RenameDialog] Add new apply behaviour

rooty added a comment. I propose that "Apply to" be taken out of the checkbox/combobox, hence Apply to: "combobox" And I propose the labels: "This File Only" "Every File" (or Every File in Transit) "Destination, if Older Than Arrival" "Destination, if More Recent Than Arrival"

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

dfaure added a comment. Wow, it's nice that this is fixable, I thought it wasn't. I can't really review the code itself though, too clueless about utf8 details. Thiago might be able to review this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18161 To: cfeck, #f

D18263: [CopyJob] Provide more descriptive notification header

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:344 > +const QString destStr = > KStringHandler::csqueeze(m_dest.toDisplayString(QUrl::PreferLocalFile), 100); > +m_description =

D18699: [KIO/RenameDialog] Add new apply behaviour

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Yeah that naming needs improvement. At the very least, using a short form like "Dest" doesn't seem like a good idea in a user-facing GUI. REPOSITORY R241 KIO REVISION DETAIL

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. @ngraham I'm not convinced. Warning users that an operation can't be undone makes sense, but canceling in the middle of the operation is not usually something to warn about. It's nice to ha

D19298: Make it compile without foreach

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Polkit1Backend.cpp:203 > { > -Q_FOREACH (const QString &action, m_cachedResults.keys()) { > +const auto listKeys = m_cachedResults.keys(); > +for (const QSt

D19299: Make it compile without foreach

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I can't review tests/faceicontest.cpp, phabricator thinks it's a binary file. INLINE COMMENTS > ktexttohtmltest.cpp:163 > +for (const QString &schema : qAsConst(schemas)) { >

D19319: make it compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R291 KPty BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19319 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19455: [knotification] compile without deprecated methods

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraha

D19170: Fix crash while moving files

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for testing the fix - and indeed the reverse case is useful to have too. INLINE COMMENTS > hallas wrote in filecopyjob.cpp:495 > Should we also set d->m_chmodJob to nullpt

D19336: [kguiaddons] make it compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R273 KGuiAddons BRANCH make_it_compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19336 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bru

D19318: compile without foreach

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kidletime.cpp:253 > > if (associations.values().contains(msec)) { > +const auto listKeys = associations.keys(msec); Urgh, how horrible and slow. But pre-

D19431: [kitemviews] make it compile without deprecated method

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwidgetitemdelegatetest.cpp:254 > +#else > +int widthUninstall = > QApplication::style()->sizeFromContents(QStyle::CT_ToolButton, > &toolButtonOpt,

D19326: [Kconfig] Compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19326 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18479 To: wbauer, #frameworks, #dolphin, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. On, with the partially reverted patch: CoreText font engine: F6650185: Screen Shot 2019-03-02 at 22.51.09.png FontConfig font engine (= identical to the one on Linux; FreeType & FontConfig have the Infinality patches):

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. > But now the state is just like it was before: If you have a font that does fallbacks for some glyphs It's the fontengine that handles this of course ;) Note that on Unix the fallback mechanism is actually provided by/through fontconfig, so there might be thin

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18479 To: wbauer, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 29 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/29/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 01 Mar 2019 12:59:21 + Build duration: 1 day 7 hr and counting JUnit Tests Name: p

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 18:56:17 + Build duration: 1 hr 21 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/42/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 17:32:17 + Build duration: 2 hr 43 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 16:14:55 + Build duration: 3 hr 39 min and counting JUnit Tests Name: projectro

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 16:05:21 + Build duration: 3 hr 42 min and counting JUnit Tests Name

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 15:55:31 + Build duration: 3 hr 45 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/36/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Mar 2019 19:30:38 + Build duration: 6 min 8 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 15:47:45 + Build duration: 3 hr 46 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 19:30:38 + Build duration: 2 min 0 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/35/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Mar 2019 19:26:41 + Build duration: 2 min 18 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 19:22:32 + Build duration: 6 min 47 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/34/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Mar 2019 19:20:23 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 19:20:23 + Build duration: 2 min 8 sec and counting BUILD ARTIFACTS abi-compa

D19102: Fix extraction of aspect ratio property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1082b1e009bc: Fix extraction of aspect ratio property (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=52114&id=53021 REVISIO

D19101: Increase precision of frame rate property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2ab37ed086d8: Increase precision of frame rate property (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19101?vs=52109&id=53020 REVIS

D19436: [kservice] compile without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R309:45337a4c28c3: [kservice] compile without deprecated method (authored by mlaurent). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19436?vs=53011&id=53018 REVISION

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann added a comment. If somebody provides a patch that allows artifact free line height modification, I will happily merge it. The same for any improvement to the line height computation. It is only fixed for all lines to make it easy (and fast). If somebody fixes that all, I am more

KDE CI: Frameworks » kemoticons » kf5-qt5 WindowsMSVCQt5.11 - Build # 28 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20WindowsMSVCQt5.11/28/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 02 Mar 2019 14:53:52 + Build duration: 3 hr 29 min and counting JUnit Tests Na

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

rjvbb added a comment. > I would rather keep the current behavior and let people use sane fonts if the want unicode. That's not current acceptable IMHO, not with the cumbersome way of selecting the font. If proper document display depends on "user picking a sane font", they should

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 15:17:47 + Build duration: 2 hr 32 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 15:13:10 + Build duration: 2 hr 31 min and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 15:08:52 + Build duration: 2 hr 32 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 14:56:34 + Build duration: 2 hr 35 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 16:19:51 + Build duration: 1 hr 9 min and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 16:12:34 + Build duration: 1 hr 16 min and counting BUILD ARTIFACTS abi-compatibil

D18455: Port to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R241:53bba36a78c4: Port to new connect syntax (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18455?vs=53013&id=53014 REVISION DETAIL https://phabr

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 16:29:13 + Build duration: 52 min and counting BUILD ARTIFACTS abi-compatibility-res

D18455: Port to new connect syntax

chinmoyr updated this revision to Diff 53013. chinmoyr added a comment. Restore sourceStated in CopyJob. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18455?vs=50058&id=53013 BRANCH arcpatch-D18455 REVISION DETAIL https://phabricator.kde.org/D18455 AFFE

D19436: [kservice] compile without deprecated method

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19436 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bru

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 16:05:54 + Build duration: 1 hr 4 min and counting BUILD ARTIFACTS abi-compati

D19436: [kservice] compile without deprecated method

mlaurent updated this revision to Diff 53011. mlaurent added a comment. Use toSecsSinceEpoch REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19436?vs=52878&id=53011 BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL https:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 15:47:21 + Build duration: 1 hr 9 min and counting BUILD ARTIFACTS abi-compatibilit

D19422: Fix upper/lower case rename on case insensitive fs

chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:1909 > const QString srcDir = QFileInfo(_src).absolutePath(); > -QTemporaryFile tmpFile(srcDir + QLatin1String

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 14:02:09 + Build duration: 2 hr 44 min and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/28/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 15:32:57 + Build duration: 1 hr 13 min and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 14:00:16 + Build duration: 2 hr 44 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 15:25:04 + Build duration: 1 hr 18 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:52:09 + Build duration: 2 hr 43 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 13:31:42 + Build duration: 2 hr 57 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 13:31:30 + Build duration: 2 hr 48 min and counting BUILD ARTIFACTS abi-co

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:32:02 + Build duration: 2 hr 42 min and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 13:30:30 + Build duration: 2 hr 42 min and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 13:30:45 + Build duration: 2 hr 35 min and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/37/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:31:28 + Build duration: 2 hr 33 min and counting JUnit Tests Name

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:30:45 + Build duration: 2 hr 24 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 45 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/45/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 02 Mar 2019 13:28:50 + Build duration: 2 hr 23 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:30:30 + Build duration: 2 hr 17 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 13:29:01 + Build duration: 2 hr 18 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 13:26:43 + Build duration: 2 hr 6 min and counting BUILD ARTIFACTS abi-compat

D19461: Logcat: fix dsError color with underline="0"

cullmann added a comment. Is that btw. this good old bug? https://bugs.kde.org/show_bug.cgi?id=143399 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19461 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-dev

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Mar 2019 13:25:28 + Build duration: 1 hr 59 min and counting BUILD ARTIFACTS abi-compati

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann closed this revision. cullmann added a comment. Actually, if you use a "proper" font, it all works fine with this patch, too. Here screenshots using DejaVu with current KTextEditor master. F6649178: arab.png F6649180: smileys.png

D19476: Hopefully fix flaky remote access test

davidedmundson updated this revision to Diff 52992. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19476?vs=52990&id=52992 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19476 AFFECTED FILES autot

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Mar 2019 14:23:23 + Build duration: 55 min and counting BUILD ARTIFACTS abi-compatibility-r

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:29:54 + Build duration: 1 hr 47 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:29:29 + Build duration: 1 hr 43 min and counting JUnit Tests Name: projectroot

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. I guess the previous situation is still more practical, since by temporarily adding a newline there below the oversized line, it is at least possible to edit that line. With the line cut off, it is impossible to edit. Also, in cases where a line is only slightly ove

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/34/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Mar 2019 14:26:58 + Build duration: 44 min and counting BUILD ARTIFACTS abi-compati

Re: Flaky test in kwayland: RemoteAccessTest

Done (hopefully!). https://phabricator.kde.org/D19476 David

D19476: Hopefully fix flaky remote access test

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We have 4 events: buffer1 created buffer2 created buffer1

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:29:01 + Build duration: 1 hr 39 min and counting JUnit Tests Name: projec

D19407: ModeBase::goToPos: Ensure jump target is valid

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. In any case, I think it is OK to make this function save for invalid cursors. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktextedito

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Mar 2019 14:19:56 + Build duration: 45 min and counting BUILD ARTIFACTS abi-compatibili

D19407: ModeBase::goToPos: Ensure jump target is valid

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a272e86f07e7: ModeBase::goToPos: Ensure jump target is valid (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19407?vs

D19427: ViInputMode: Remove unsupported text attributes from the status bar

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c7737fb33ef1: ViInputMode: Remove unsupported text attributes from the status bar (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabrica

D19427: ViInputMode: Remove unsupported text attributes from the status bar

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, good catch, buttons don't like rich-text and I don't think that is really needed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19427 To: loh.tar, #k

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann reopened this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann, dhaumann Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking

D18125: KateStatusBar: Add dictionary button

This revision was automatically updated to reflect the committed changes. Closed by commit R39:08d1d681ff8b: KateStatusBar: Add dictionary button (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18125?vs=52307&id=

D18125: KateStatusBar: Add dictionary button

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for taking care of the overhead by adding the new internal signal. I think this can now go in. I still would like to have the button configurable, but that is no reason to den

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Mar 2019 13:27:50 + Build duration: 1 hr 28 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/12/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Mar 2019 14:08:08 + Build duration: 42 min and counting BUILD ARTIFACTS abi-compatibility-r

  1   2   >