D19170: Fix crash while moving files

[David Hallas]

hallas marked 4 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

[David Hallas]

hallas updated this revision to Diff 53032.
hallas added a comment.


  Set job to nullptr before stopping job running in parallel

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19170?vs=52643=53032

BRANCH
  fix_crash_while_moving_files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19170

AFFECTED FILES
  src/core/filecopyjob.cpp

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/35/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 03 Mar 2019 04:34:20 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3607/13344)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(299/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/27/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 03 Mar 2019 04:34:20 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/39/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 03 Mar 2019 04:34:20 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

T10554: KDiff3 to join Applications

[Michael Reeves]

mreeves removed a project: KDE Applications.

TASK DETAIL
  https://phabricator.kde.org/T10554

To: mreeves
Cc: kde-frameworks-devel, mreeves, alexeymin, genaxxx

T10554: KDiff3 to join Applications

[Michael Reeves]

mreeves created this task.
mreeves triaged this task as "Normal" priority.
mreeves added a project: KDE Applications.

TASK DESCRIPTION
  KDiff3 is preparing to join Applications from Extragear. I have been advised 
to have some check over the changes made for the kf5/qt5 port.

TASK DETAIL
  https://phabricator.kde.org/T10554

To: mreeves
Cc: kde-frameworks-devel, mreeves, alexeymin, genaxxx

D15408: Don't assert deleting the temporary file

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15408

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  The warning needs to be removed then. We can't really warn at the time of 
using a variable.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

To: dinoh, apol, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17737: [CopyJob] Create clones in btrf/xfs mount

[David Faure]

dfaure added a comment.


  No objection from me, but I don't know those clone APIs, so I can't really 
review/approve it.
  
  Maybe Thiago or Oswald, if nobody else does.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, davidedmundson, #frameworks
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D19422: Fix upper/lower case rename on case insensitive fs

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.


  Indeed, "just" a missing slash.
  
  Porting error in my commit bbf6181f4de7bc315c7c64e7528a3150788eea09 
 7 
years ago (!)
  I removed KUrl::AppendTrailingSlash and didn't actually a '/'  :(

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

[Krešimir Čohar]

rooty added a comment.


  I propose that "Apply to" be taken out of the checkbox/combobox, hence Apply 
to: "combobox"
  
  And I propose the labels:
  "This File Only"
  "Every File" (or Every File in Transit)
  "Destination, if Older Than Arrival"
  "Destination, if More Recent Than Arrival"
  
  Otherwise, nice patch! +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18699

To: chinmoyr, dfaure, ngraham, #vdg
Cc: rooty, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

[David Faure]

dfaure added a comment.


  Wow, it's nice that this is fixable, I thought it wasn't.
  
  I can't really review the code itself though, too clueless about utf8 
details. Thiago might be able to review this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18161

To: cfeck, #frameworks, #dolphin, dfaure
Cc: nerdopolist, ngraham, kde-frameworks-devel, michaelh, bruns

D18263: [CopyJob] Provide more descriptive notification header

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> copyjob.cpp:344
> +const QString destStr = 
> KStringHandler::csqueeze(m_dest.toDisplayString(QUrl::PreferLocalFile), 100);
> +m_description = i18n("%1 %2 to %3", modeStr, itemStr, destStr);
> +}

translators won't know what to do with this word puzzle. Better do

  const QString str = m_mode == CopyJob::Copy ? i18n("Copying %1 to %2") : 
i18n("Moving %1 to %2");

> job.cpp:123
> +static const QString s_defaultTitle = i18nc("@title job", "Moving");
> +static const QString s_title = jobTitle(job, s_defaultTitle);
>  static const QString s_source = i18nc("The source of a file operation", 
> "Source");

You can't make this static, otherwise the very first job will determine what 
all subsequent jobs will get in s_title.

And then remove the s_ prefix, of course.

(*3)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18263

To: chinmoyr, dfaure, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Yeah that naming needs improvement. At the very least, using a short form 
like "Dest" doesn't seem like a good idea in a user-facing GUI.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18699

To: chinmoyr, dfaure, ngraham, #vdg
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  @ngraham I'm not convinced. Warning users that an operation can't be undone 
makes sense, but canceling in the middle of the operation is not usually 
something to warn about. It's nice to handle it better, but I wouldn't bother 
the user with "you know, if you cancel, you'll be in trouble". Well, yes, I'm 
OVERWRITING a file. If I'm too slow to cancel, I'll have the same trouble too.
  
  Anyhow, that's for the GUI side of things, this commit seems fine in itself.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D10663

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19298: Make it compile without foreach

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> Polkit1Backend.cpp:203
>  {
> -Q_FOREACH (const QString , m_cachedResults.keys()) {
> +const auto listKeys = m_cachedResults.keys();
> +for (const QString  : listKeys) {

(pre-existing) bad, very slow, creates a temp container just to iterate.

  for (auto it = m_cachedResults.begin(); it != m_cachedResults.end(); ++it) {
  const QString action = it.key();
  if (it.value() != ) {
  *it = ;
   ...
  }
  }

REPOSITORY
  R283 KAuth

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19298

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19299: Make it compile without foreach

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I can't review tests/faceicontest.cpp, phabricator thinks it's a binary file.

INLINE COMMENTS

> ktexttohtmltest.cpp:163
> +for (const QString  : qAsConst(schemas)) {
> +for (QString url : qAsConst(urls)) {   //krazy:exclude=foreach
>  // by definition: if the URL is enclosed in brackets, the URL 
> itself is not allowed

I wonder if the krazy comment needs to be updated, but I don't know, feel free 
to leave it as is if you don't know either.

> kpluginloader.cpp:296
>  QPluginLoader loader;
> -foreach (const KPluginMetaData , findPlugins(directory, 
> filter)) {
> +QVector listMetaData = findPlugins(directory, filter);
> +for (const KPluginMetaData  : listMetaData) {

const missing

> kpluginmetadata.cpp:233
>  } else if (people.isArray()) {
> -foreach (const QJsonValue , people.toArray()) {
> +for (const QJsonValue  : people.toArray()) {
>  if (val.isObject()) {

needs a const local var, no?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D19299

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19319: make it compile without foreach

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R291 KPty

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19319

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19455: [knotification] compile without deprecated methods

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19455

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks for testing the fix - and indeed the reverse case is useful to have 
too.

INLINE COMMENTS

> hallas wrote in filecopyjob.cpp:495
> Should we also set d->m_chmodJob to nullptr here, just like the m_putJob 
> handling branch?

Right, probably a good idea, just in case.

> hallas wrote in filecopyjob.cpp:500
> Should we also set d->m_delJob to nullptr here, just like the m_putJob 
> handling branch?

same

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19336: [kguiaddons] make it compile without foreach

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R273 KGuiAddons

BRANCH
  make_it_compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19336

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kidletime.cpp:253
>  
>  if (associations.values().contains(msec)) {
> +const auto listKeys = associations.keys(msec);

Urgh, how horrible and slow. But pre-existing, unrelated to your change.

REPOSITORY
  R274 KIdleTime

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19318

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19431: [kitemviews] make it compile without deprecated method

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwidgetitemdelegatetest.cpp:254
> +#else
> +int widthUninstall = 
> QApplication::style()->sizeFromContents(QStyle::CT_ToolButton, 
> , 
> QSize(option.fontMetrics.horizontalAdvance(QStringLiteral("Uninstall")) + 
> HARDCODED_BORDER * 3, option.fontMetrics.height()), toolButton).width();
> +#endif

I think the whole point of the name horizontalAdvance() is that characters can 
actually be drawn outside of that width. I guess boundingRect().width() is a 
better port for width() in general.

Heh actually I just read the documentation for width and it agrees with that.

So yes this is a "same behaviour" port, but the whole point of the renaming is 
to make us realize these things. Sometimes horizontalAdvance is correct (like 
in kwordwrap.cpp, where they get added together), sometimes boundingRect is 
what we need, like here when it's to resize something and make sure all the 
pixels fit.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D19431

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19326

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18479

To: wbauer, #frameworks, #dolphin, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  On, with the partially reverted patch:
  
  CoreText font engine:
  F6650185: Screen Shot 2019-03-02 at 22.51.09.png 

  
  FontConfig font engine (= identical to the one on Linux; FreeType & 
FontConfig have the Infinality patches):
  F6650191: Screen Shot 2019-03-02 at 22.52.24.png 

  
  Font: Ubuntu Mono 12pt.
  
  I find neither particularly troublesome; the latin characters remain readable.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  >   But now the state is just like it was before: If you have a font that 
does fallbacks for some glyphs
  
  It's the fontengine that handles this of course ;)
  Note that on Unix the fallback mechanism is actually provided by/through 
fontconfig, so there might be things to configure at that level.
  
  >   and therefore doesn't take their "real" height into account, we mess up.
  
  Actually, if that's really what happens (= information provided the font is 
ignored instead of absent as is apparently the case with the emoji fonts) then 
that c/should be considered a Qt bug.
  
  To be certain: does KTE obtain its lineheight information from a Qt method 
that takes an entire line, or could it?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

[Wolfgang Bauer]

wbauer added a comment.


  Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18479

To: wbauer, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 29 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/29/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 01 Mar 2019 12:59:21 +
 Build duration:
1 day 7 hr and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kcrashtest

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/13/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 18:56:17 +
 Build duration:
1 hr 21 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/42/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 17:32:17 +
 Build duration:
2 hr 43 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/15/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 16:14:55 +
 Build duration:
3 hr 39 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/38/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 16:05:21 +
 Build duration:
3 hr 42 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 15:55:31 +
 Build duration:
3 hr 45 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/36/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Mar 2019 19:30:38 +
 Build duration:
6 min 8 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3453/4131)47%
(5067/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(994/1022)49%
(2189/4513)src76%
(19/25)76%
(19/25)80%
(1167/1455)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1234/1569)47%
(2321/4909)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/28/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 15:47:45 +
 Build duration:
3 hr 46 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/31/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 19:30:38 +
 Build duration:
2 min 0 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3453/4131)47%
(5067/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(994/1022)49%
(2189/4513)src76%
(19/25)76%
(19/25)80%
(1167/1455)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1234/1569)47%
(2321/4909)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/35/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Mar 2019 19:26:41 +
 Build duration:
2 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3453/4131)47%
(5067/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(994/1022)49%
(2189/4513)src76%
(19/25)76%
(19/25)80%
(1167/1455)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1234/1569)47%
(2321/4909)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/30/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 19:22:32 +
 Build duration:
6 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3453/4131)47%
(5067/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(994/1022)49%
(2189/4513)src76%
(19/25)76%
(19/25)80%
(1167/1455)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1234/1569)47%
(2321/4909)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/34/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Mar 2019 19:20:23 +
 Build duration:
6 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3441/4120)47%
(5053/10679)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(991/1019)48%
(2179/4493)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1228/1564)47%
(2317/4905)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/29/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 19:20:23 +
 Build duration:
2 min 8 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3441/4120)47%
(5053/10679)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(991/1019)48%
(2179/4493)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1228/1564)47%
(2317/4905)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D19102: Fix extraction of aspect ratio property

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1082b1e009bc: Fix extraction of aspect ratio property 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19102?vs=52114=53021

REVISION DETAIL
  https://phabricator.kde.org/D19102

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/propertyinfotest.cpp
  src/extractors/ffmpegextractor.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2ab37ed086d8: Increase precision of frame rate property 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19101?vs=52109=53020

REVISION DETAIL
  https://phabricator.kde.org/D19101

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/propertyinfotest.cpp
  src/extractors/ffmpegextractor.cpp
  src/formatstrings.cpp
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19436: [kservice] compile without deprecated method

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:45337a4c28c3: [kservice] compile without deprecated 
method (authored by mlaurent).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19436?vs=53011=53018

REVISION DETAIL
  https://phabricator.kde.org/D19436

AFFECTED FILES
  CMakeLists.txt
  autotests/kmimeassociationstest.cpp
  autotests/ksycocathreadtest.cpp
  src/services/kservicetypeprofile.cpp
  src/sycoca/kbuildservicefactory.cpp
  src/sycoca/kbuildsycoca.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann added a comment.


  If somebody provides a patch that allows artifact free line height 
modification, I will happily merge it.
  The same for any improvement to the line height computation. It is only fixed 
for all lines to make it easy (and fast). If somebody fixes that all, I am more 
than happy.
  But now the state is just like it was before: If you have a font that does 
fallbacks for some glyphs and therefore doesn't take their "real" height into 
account, we mess up.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kemoticons » kf5-qt5 WindowsMSVCQt5.11 - Build # 28 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20WindowsMSVCQt5.11/28/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 02 Mar 2019 14:53:52 +
 Build duration:
3 hr 29 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kemoticons_ktexttohtmlplugintest

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  >   I would rather keep the current behavior and let people use sane fonts if 
the want unicode.
  
  That's not current acceptable IMHO, not with the cumbersome way of selecting 
the font.
  
  If proper document display depends on "user picking a sane font", they should 
have a drop-down list where they can pick one quickly, and with a clear and 
easy way to make this a temporary or a document-specific choice.
  
  Also, while it's clear that you cannot expect everything to work properly 
with any font, accepting that the user just has to pick the right font to avoid 
lineheight issues is a slippery slope that I'd fear could easily lead to 
hardwiring a limited selection of typefaces just to avoid bug reports. That 
would be fine (AFAIAC) for Kate, but not for the framework that provides the 
editor component for more complex applications like KDevelop.
  
  Rather, an effort should be made to implement support for variable 
lineheights (GSoC? junior job?)
  
  > how should the user set it to the "right value" if it can differ per line?
  
  The same way they can pick a "sane font"? FWIW, I'm using Ubuntu Mono, that's 
supposed to be pretty complete and should be sane too.
  
  The "right value" here would be a value that works for all lines = the 
tallest lineheight that gives proper line separation everywhere. My guess would 
be that you will already catch most situations with a choice of 1.5x and 2x .
  
  > And I don't see a benefit in supporting that at all
  
  There are situations where I would welcome the possibility to increase line 
spacing on the fly, for improved readability - I'm certain I'm not the only one.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 15:17:47 +
 Build duration:
2 hr 32 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 15:13:10 +
 Build duration:
2 hr 31 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 15:08:52 +
 Build duration:
2 hr 32 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/41/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 14:56:34 +
 Build duration:
2 hr 35 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 16:19:51 +
 Build duration:
1 hr 9 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/17/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 16:12:34 +
 Build duration:
1 hr 16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.56.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeatFailed: projectroot.autotests.client.kwayland_testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(239/260)92%
(239/260)82%
(25865/31437)51%
(10278/20169)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)93%
(11513/12391)47%
(6050/12883)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)84%
(6203/7385)64%
(1795/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)85%
(7695/9008)64%
(2256/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

D18455: Port to new connect syntax

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:53bba36a78c4: Port to new connect syntax (authored by 
chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18455?vs=53013=53014

REVISION DETAIL
  https://phabricator.kde.org/D18455

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/job_p.h
  src/core/transferjob.cpp
  src/core/transferjob.h

To: chinmoyr, davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 16:29:13 +
 Build duration:
52 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.56.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(454/2220)18%
(199/1126)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(150/155)58%
(61/106)src100%
(8/8)100%
(8/8)67%
(220/327)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%

D18455: Port to new connect syntax

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53013.
chinmoyr added a comment.


  Restore sourceStated in CopyJob.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18455?vs=50058=53013

BRANCH
  arcpatch-D18455

REVISION DETAIL
  https://phabricator.kde.org/D18455

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/job_p.h
  src/core/transferjob.cpp
  src/core/transferjob.h

To: chinmoyr, davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19436: [kservice] compile without deprecated method

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19436

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 16:05:54 +
 Build duration:
1 hr 4 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WindowSystem-5.56.0.xmlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7178/9546)55%
(3542/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3044/3136)53%
(1290/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3340/4662)61%
(1947/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D19436: [kservice] compile without deprecated method

[Laurent Montel]

mlaurent updated this revision to Diff 53011.
mlaurent added a comment.


  Use toSecsSinceEpoch

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19436?vs=52878=53011

BRANCH
  compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19436

AFFECTED FILES
  CMakeLists.txt
  autotests/kmimeassociationstest.cpp
  autotests/ksycocathreadtest.cpp
  src/services/kservicetypeprofile.cpp
  src/sycoca/kbuildservicefactory.cpp
  src/sycoca/kbuildsycoca.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/9/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 15:47:21 +
 Build duration:
1 hr 9 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.56.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

D19422: Fix upper/lower case rename on case insensitive fs

[Chinmoy Ranjan Pradhan]

chinmoyr requested changes to this revision.
chinmoyr added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> copyjob.cpp:1909
>  const QString srcDir = QFileInfo(_src).absolutePath();
> -QTemporaryFile tmpFile(srcDir + QLatin1String("kio_XX"));
> +QTemporaryFile 
> tmpFile(QDir(srcDir).filePath(QLatin1String("kio_XX")));
>  const bool openOk = tmpFile.open();

IMO QDir isn't required here. QLatin1String("/kio_xx") is sufficient.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 14:02:09 +
 Build duration:
2 hr 44 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/28/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 15:32:57 +
 Build duration:
1 hr 13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3438/4117)47%
(5043/10659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(989/1017)48%
(2170/4475)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1227/1563)47%
(2316/4903)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 14:00:16 +
 Build duration:
2 hr 44 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/13/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 15:25:04 +
 Build duration:
1 hr 18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.56.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6417/8535)44%
(10444/23958)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5925/12151)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:52:09 +
 Build duration:
2 hr 43 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 11 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/11/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 13:31:42 +
 Build duration:
2 hr 57 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.56.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(450/2220)17%
(195/1126)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(146/155)54%
(57/106)src100%
(8/8)100%
(8/8)67%
(220/327)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 13:31:30 +
 Build duration:
2 hr 48 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
 

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/14/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:32:02 +
 Build duration:
2 hr 42 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/16/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 13:30:30 +
 Build duration:
2 hr 42 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.56.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModelFailed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(238/260)92%
(238/260)82%
(25839/31413)51%
(10248/20169)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)94%
(11673/12389)47%
(6111/12883)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client97%
(72/74)97%
(72/74)81%
(5972/7372)59%
(1660/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)86%
(7740/8999)66%
(2300/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 13:30:45 +
 Build duration:
2 hr 35 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WindowSystem-5.56.0.xmlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7186/9546)56%
(3555/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3046/3136)53%
(1293/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(788/1391)45%
(304/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3345/4662)61%
(1955/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/37/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:31:28 +
 Build duration:
2 hr 33 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:30:45 +
 Build duration:
2 hr 24 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 45 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/45/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 02 Mar 2019 13:28:50 +
 Build duration:
2 hr 23 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/27/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:30:30 +
 Build duration:
2 hr 17 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/8/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 13:29:01 +
 Build duration:
2 hr 18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.56.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/27/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 13:26:43 +
 Build duration:
2 hr 6 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3438/4117)47%
(5043/10659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(989/1017)48%
(2170/4475)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1227/1563)47%
(2316/4903)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D19461: Logcat: fix dsError color with underline="0"

[Christoph Cullmann]

cullmann added a comment.


  Is that btw. this good old bug? https://bugs.kde.org/show_bug.cgi?id=143399

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19461

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Mar 2019 13:25:28 +
 Build duration:
1 hr 59 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.56.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6417/8535)44%
(10444/23958)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5925/12151)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Actually, if you use a "proper" font, it all works fine with this patch, too.
  
  Here screenshots using DejaVu with current KTextEditor master.
  
  F6649178: arab.png 
  F6649180: smileys.png 
  
  The overpainting on the other side leads to ugly effects that even selections 
cut out parts of the line below.
  
  I would rather keep the current behavior and let people use sane fonts if the 
want unicode.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19476: Hopefully fix flaky remote access test

[David Edmundson]

davidedmundson updated this revision to Diff 52992.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19476?vs=52990=52992

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19476

AFFECTED FILES
  autotests/client/test_remote_access.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/23/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Mar 2019 14:23:23 +
 Build duration:
55 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.56.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26863/31461)53%
(10770/20169)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12307/12394)50%
(6469/12883)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6288/7396)65%
(1814/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7814/9018)66%
(2310/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:29:54 +
 Build duration:
1 hr 47 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:29:29 +
 Build duration:
1 hr 43 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Thomas Schöps]

thomassc added a comment.


  I guess the previous situation is still more practical, since by temporarily 
adding a newline there below the oversized line, it is at least possible to 
edit that line. With the line cut off, it is impossible to edit. Also, in cases 
where a line is only slightly oversized (as with the emoji example), with the 
overpainting it might look just fine, whereas with the cutoff it won't look 
fine.
  
  FYI, below is a screenshot of how the new example looks on my system 
((K)ubuntu 14.04, Monospace font, normal style, size 9, which I believe is the 
default), after applying the line height fix: it looks perfectly fine.
  
  F6649169: bug_404713_monospace_ubuntu.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/34/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Mar 2019 14:26:58 +
 Build duration:
44 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3607/13344)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(299/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

Re: Flaky test in kwayland: RemoteAccessTest

[David Edmundson]

Done (hopefully!).
https://phabricator.kde.org/D19476

David

D19476: Hopefully fix flaky remote access test

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We have 4 events:
  
  buffer1 created
  buffer2 created
  buffer1 paramters sent
  buffer2 paramters sent
  
  Some are batched
  
  We should connect to buffer 1's parameters being sent after the first
  buffer is recieved, not in the potential event loop waiting for buffer
  2.

TEST PLAN
  Passes locally
  Haven't tested on build.k.o

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19476

AFFECTED FILES
  autotests/client/test_remote_access.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:29:01 +
 Build duration:
1 hr 39 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D19407: ModeBase::goToPos: Ensure jump target is valid

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  In any case, I think it is OK to make this function save for invalid cursors.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19407

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Mar 2019 14:19:56 +
 Build duration:
45 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WindowSystem-5.56.0.xmlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7194/9546)56%
(3557/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3056/3136)53%
(1296/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(303/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3345/4662)61%
(1955/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D19407: ModeBase::goToPos: Ensure jump target is valid

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:a272e86f07e7: ModeBase::goToPos: Ensure jump target is 
valid (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19407?vs=52790=52989

REVISION DETAIL
  https://phabricator.kde.org/D19407

AFFECTED FILES
  src/vimode/modes/modebase.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D19427: ViInputMode: Remove unsupported text attributes from the status bar

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c7737fb33ef1: ViInputMode: Remove unsupported text 
attributes from the status bar (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19427?vs=52850=52988

REVISION DETAIL
  https://phabricator.kde.org/D19427

AFFECTED FILES
  src/inputmode/kateviinputmode.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19427: ViInputMode: Remove unsupported text attributes from the status bar

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, good catch, buttons don't like rich-text and I don't think that is really 
needed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19427

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18125: KateStatusBar: Add dictionary button

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:08d1d681ff8b: KateStatusBar: Add dictionary button 
(authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18125?vs=52307=52987

REVISION DETAIL
  https://phabricator.kde.org/D18125

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, sars

D18125: KateStatusBar: Add dictionary button

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for taking care of the overhead by adding the new internal signal.
  I think this can now go in.
  I still would like to have the button configurable, but that is no reason to 
deny it.

REVISION DETAIL
  https://phabricator.kde.org/D18125

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, sars

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/40/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Mar 2019 13:27:50 +
 Build duration:
1 hr 28 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/12/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Mar 2019 14:08:08 +
 Build duration:
42 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.56.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)