D19913: [plasma-desktop] make it compiles without foreach

broulik added inline comments. INLINE COMMENTS > coronatest.cpp:150 > +const auto containments = m_corona->containments(); > +for (auto cont : containments) { > switch (cont->id()) { Please always annotate `auto` with e.g. asterisk or ampersand depending on type > coronatest.cp

D19913: [plasma-desktop] make it compiles without foreach

mlaurent updated this revision to Diff 55796. mlaurent added a comment. Rename some variables REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=54920&id=55796 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#445829 , @dfaure wrote: > Is the makeURL function still used, or should it be removed now? Yep, it is still used in a bunch of other places. INLINE COMMENTS > dfaure wrote in urlinfo.h:39 > const QString

Re: New framework: KContacts

On Sat, Apr 6, 2019 at 6:02 PM Volker Krause wrote: > > Hi, > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > KContacts is essentially an implementation of the vCard standard, covering the > data model as well as parsing and creating of vCard files. As the recent CI > i

D20042: Show the plasmoid context menu on long tap

apol abandoned this revision. apol added a comment. We discussed it and decided long tap is not the way to go, will have to find alternative ways to access the options on the context menu on a case-by-case basis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabric

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/61/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Apr 2019 21:04:26 + Build duration: 19 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/55/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Apr 2019 21:04:26 + Build duration: 18 min and counting BUILD ARTIFACTS acc/KF5Plas

D20042: Show the plasmoid context menu on long tap

GB_2 added a comment. Ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20042 To: apol, #plasma, #frameworks, mart Cc: GB_2, mart, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/65/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 08 Apr 2019 21:04:26 + Build duration: 3 min 3 sec and counting JUnit Tests Name

D20392: Use more appropriate "Alternatives" icon and text

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7687ffa3dab0: Use more appropriate "Alternatives" icon and text (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20392?vs=55

D20392: Use more appropriate "Alternatives" icon and text

filipf accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH use-new-alternatives-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20392 To: ngraham, #vdg, #plasma, GB_2, filipf Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20342: Update KDE logo to be closer to original

abetts added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH update-kde-logo-to-be-closer-to-original (branched from master) REVISION DETAIL https://phabricator.kde.org/D20342 To: GB_2, #vdg, #kde_promo, filipf Cc: abetts, ndavis, filipf, ngraham, #kde_promo, kde-frameworks-devel, #

D20392: Use more appropriate "Alternatives" icon and text

GB_2 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH use-new-alternatives-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20392 To: ngraham, #vdg, #plasma, GB_2 Cc: kde-frameworks-devel, mi

D20367: Add alternatives icon

ngraham added a comment. Sweet, now let's use it: D20392 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg, ngraham Cc: abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20392: Use more appropriate "Alternatives" icon and text

ngraham retitled this revision from "Use new "Alternatives" icon" to "Use more appropriate "Alternatives" icon and text". ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20392 To: ngraham, #vdg, #plasma Cc:

D20392: Use new "Alternatives" icon

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This was just added in D20367 . The current i

D20342: Update KDE logo to be closer to original

filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R266 Breeze Icons BRANCH update-kde-logo-to-be-closer-to-original (branched from master) REVISION DETAIL https://phabricator.kde.org/D20342 T

D20342: Update KDE logo to be closer to original

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20342 To: GB_2, #vdg, #kde_promo Cc: abetts, ndavis, filipf, ngraham, #kde_promo, kde-frameworks-devel, #vdg, michaelh, bruns

D20342: Update KDE logo to be closer to original

GB_2 updated this revision to Diff 55772. GB_2 added a comment. Make gradient more obvious REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20342?vs=55648&id=55772 BRANCH update-kde-logo-to-be-closer-to-original (branched from master) REVISION DETAIL

D20367: Add alternatives icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6449fe92654b: Add alternatives icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20367?vs=55764&id=55771 REVISION DETAIL https://phabri

D20367: Add alternatives icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! REPOSITORY R266 Breeze Icons BRANCH add-alternatives-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg, ngraham Cc: abetts, ngr

D20342: Update KDE logo to be closer to original

GB_2 added a comment. In D20342#446160 , @filipf wrote: > So what I'm seeing is that the gradient has been toned down, which also results in a slight color change in general. FWIW I like the older version more because the new one seems flat(ter)

Re: New framework: KCalCore

On Sunday, 7 April 2019 18:54:19 CEST Albert Astals Cid wrote: > El diumenge, 7 d’abril de 2019, a les 14:45:09 CEST, Volker Krause va escriure: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > Does exceptions.h need a d-pointer? Looks like it, I'll fix t

D20367: Add alternatives icon

GB_2 updated this revision to Diff 55764. GB_2 added a comment. Rename icon to "widget-alternatives" REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20367?vs=55755&id=55764 BRANCH add-alternatives-icon (branched from master) REVISION DETAIL https:

D20342: Update KDE logo to be closer to original

filipf added a comment. So what I'm seeing is that the gradient has been toned down, which also results in a slight color change in general. FWIW I like the older version more because the new one seems flat(ter) in comparison. Not to long ago someone in VDG actually remarked that the officia

D20342: Update KDE logo to be closer to original

ngraham added subscribers: filipf, ndavis, abetts. ngraham added a comment. lol I still can't tell. :) I'll let someone with an eye for these little details (@ndavis, @filipf , @abetts?) do the review. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20342 To: G

D20342: Update KDE logo to be closer to original

GB_2 added a comment. In D20342#446140 , @ngraham wrote: > I'm not sure I can tell the difference for these icons, even after testing the patch myself. Any chance you could do a before-and-after for each icon? Such a shame Phab doesn't provide t

Re: New framework: KContacts

Thanks for having a look at this Albert! On Sunday, 7 April 2019 18:46:46 CEST Albert Astals Cid wrote: > El dissabte, 6 d’abril de 2019, a les 18:01:09 CEST, Volker Krause va escriure: > > Hi, > > > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > ## QUESTION 1 ## >

D15318: Automatically re-upload saved files located on remote locations instead of asking first

ngraham added a comment. Thanks for the poke, I'll try to revive this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: maverick74, elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

D20367: Add alternatives icon

GB_2 added a comment. In D20367#446144 , @ngraham wrote: > I like it! But since this is specifically about widgets, maybe the filename should reflect that and be be `widget-alternatives` or something? Sure. REPOSITORY R266 Breeze Icons

D20367: Add alternatives icon

ngraham added a comment. I like it! But since this is specifically about widgets, maybe the filename should reflect that and be be `widget-alternatives` or something? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg Cc: abetts, ngraham, kde-

D20342: Update KDE logo to be closer to original

ngraham added a comment. I'm not sure I can tell the difference for these icons, even after testing the patch myself. Any chance you could do a before-and-after for each icon? Such a shame Phab doesn't provide this feature automatically like Gitlab does... REPOSITORY R266 Breeze Icons REV

D20358: Force en locale for propertyinfotest

astippich added a comment. There already was a bug report some time ago https://bugreports.qt.io/browse/QTBUG-15488 looks like it regressed. The given test in the bug report also does not work here. I will open a new one. REPOSITORY R286 KFileMetaData REVISION DETAIL https://ph

D20358: Force en locale for propertyinfotest

astippich updated this revision to Diff 55760. astippich added a comment. - use enum REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=55684&id=55760 BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 AFFECTED FILES auto

D15872: Fix Oxygen background gradient for QML modules

ngraham closed this revision. ngraham added a comment. 5.57 is now tagged, so I've landed this. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D15872 To: hwti, mart, #vdg, #plasma, davidedmundson Cc: ngraham, davidedmundson, filipf, kde-frameworks-devel, michaelh, b

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 144 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/144/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 08 Apr 2019 12:04:12 + Build duration: 5 hr 7 min and counting CONSOLE OUTPUT

D20342: Update KDE logo to be closer to original

GB_2 added a reviewer: KDE Promo. GB_2 added a subscriber: KDE Promo. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20342 To: GB_2, #vdg, #kde_promo Cc: #kde_promo, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20367: Add alternatives icon

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg Cc: abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

GB_2 updated this revision to Diff 55755. GB_2 added a comment. Improve icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20367?vs=55713&id=55755 BRANCH add-alternatives-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D15318: Automatically re-upload saved files located on remote locations instead of asking first

maverick74 added a comment. @ngraham What's the state of this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: maverick74, elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/64/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 08 Apr 2019 13:15:05 + Build duration: 1 hr 5 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/54/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Apr 2019 13:15:05 + Build duration: 1 hr 5 min and counting BUILD ARTIFACTS acc/KF5

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/60/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Apr 2019 13:15:05 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 56 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/56/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 08 Apr 2019 09:37:35 + Build duration: 3 hr 49 min and counting JUnit Tests

D20202: FrameSvgItem: add "mask" property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f20722fbe1d0: FrameSvgItem: add "mask" property (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20202?vs=55274&id=55738 R

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/63/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 08 Apr 2019 11:33:34 + Build duration: 1 hr 3 min and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 143 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/143/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 07 Apr 2019 16:15:44 + Build duration: 19 hr and counting CONSOLE OUTPUT [.

D20376: [ktextwidget] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R310:b87f924aadf0: [ktextwidget] compile without foreach (authored by mlaurent). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20376?vs=55733&id=55734 REVISION DE

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/41/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 07 Apr 2019 15:35:13 + Build duration: 20 hr and counting JUnit Tests Name: project

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/53/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Apr 2019 11:33:34 + Build duration: 21 min and counting BUILD ARTIFACTS acc/KF5Plas

D20376: [ktextwidget] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20376 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20376: [ktextwidget] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R310 KTextWidgets B

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/59/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Apr 2019 11:33:35 + Build duration: 4 min 42 sec and counting BUILD ARTIFACTS abi-c

D20202: FrameSvgItem: add "mask" property

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvgitemaddmaskproperty REVISION DETAIL https://phabricator.kde.org/D20202 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

t-ask added a comment. As I'm quite busy right now I will upload my current SVG version. I did add a very simple more Breeze styled icon (which I think is not the best fit to identify it as a NUM button). F6759017: image.png Maybe someone else

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 19 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/19/ Project: kf5-qt5 AndroidQt5.12 Date of build: Mon, 08 Apr 2019 09:55:15 + Build duration: 2 min 55 sec and counting CONSOLE OUTPUT [..

D20196: Add Notify capability to KConfigXT

broulik updated this revision to Diff 55730. broulik retitled this revision from "RFC: Add Notify capability to KConfigXT" to "Add Notify capability to KConfigXT". broulik edited the test plan for this revision. broulik added a comment. - Move stuff into `KConfigSkeletonItem` REPOSITORY R23

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 33 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/33/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 07 Apr 2019 07:17:41 + Build duration: 1 day 2 hr and counting JUnit Tests Name: p

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 55 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/55/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 07 Apr 2019 10:03:21 + Build duration: 23 hr and counting JUnit Tests Name:

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/18/ Project: kf5-qt5 AndroidQt5.12 Date of build: Mon, 08 Apr 2019 09:28:05 + Build duration: 6 min 12 sec and counting CONSOLE OUTPUT [..

D20374: [KNotifications] Update when flags, urls, or urgency change

This revision was automatically updated to reflect the committed changes. Closed by commit R289:c0b14c032746: [KNotifications] Update when flags, urls, or urgency change (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20374?vs=5572

D20374: [KNotifications] Update when flags, urls, or urgency change

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20374 To: broulik, #plasma, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20374: [KNotifications] Update when flags, urls, or urgency change

broulik created this revision. broulik added reviewers: Plasma, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It was forgotten to schedule an update when they changed. TEST PLAN Updatin

D20158: Allow to set urgency for notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R289:39c6e0ea805c: Allow to set urgency for notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20158?vs=55173&id=55726#toc REPOSITORY R289 KNotifications CHANGES

D20158: Allow to set urgency for notifications

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Is the makeURL function still used, or should it be removed now? INLINE COMMENTS > urlinfo.h:39 > + */ > +UrlInfo(QString path) > +: line(0), column(0) const QStr

D20158: Allow to set urgency for notifications

broulik added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns