D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55967. meven added a comment. Fix switch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55850&id=55967 BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES src/ioslaves/fi

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > urlinfo.h:76 > + * - make relative paths absolute using the current working > directory > + * - prefer local file, if in doubt! > + */ remo

D20417: Add invokable public API for emitting contextualActionsAboutToShow

GB_2 added a dependent revision: D17410: Add alternatives button to applet configuration in panel edit mode. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20417 To: davidedmundson, #plasma, broulik Cc: GB_2, broulik, kde-frameworks-

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor, dhaumann Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor,

D20169: Add profile support interface for TerminalInterface

hindenburg added a comment. Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed. https://community.kde.org/Schedules/Frameworks REPOSITORY R306 KP

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6ba329f8d451: KateIconBorder: Ensure Dyn Wrap Marker are shown (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20431?vs=55893&id=55957 REVI

D20425: KateIconBorder: Code cosmetic

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6906368aa6b3: KateIconBorder: Code cosmetic (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20425?vs=55877&id=55956 REVISION DETAIL https

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

nhiga added a comment. I've just updated my KDE Identity account - my full name and email address can now be found by searching the username "nhiga" on KDE Identity - People . I'm sorry for the inconvenience caused. REPOSITORY R241 KIO R

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

loh.tar updated this revision to Diff 55955. loh.tar edited the summary of this revision. loh.tar added a comment. - Use unicode code point QChar constructor - Due to comment by @cfeck remove fallback/config hint and... - Init in header as const - Add hint about different char sizes CHAN

D20458: [balooctl] Use more understandable names for size in status output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f8c51b237965: [balooctl] Use more understandable names for size in status output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20458?vs=55949&id

D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ceb9b3756106: [balooctl] clear command: Remove bogus check for documentData, cleanup (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20457?vs=5594

D20456: [kio_search] Fix warning, add UDSEntry for "." in listDir

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b3fac5a25041: [kio_search] Fix warning, add UDSEntry for "." in listDir (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20456?vs=55947&id=55952

D20460: [balooctl] Cleanup handling of different positional arguments

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Remove the temporary Url list, and remove the d

D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20457 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, mich

D20459: [balooctl] Extend options help text, improve error checking

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The "-i" option requires a valid deviceId from

D20456: [kio_search] Fix warning, add UDSEntry for "." in listDir

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20456 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, mich

D20458: [balooctl] Use more understandable names for size in status output

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Agreed. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20458 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel

D20458: [balooctl] Use more understandable names for size in status output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Actual and expected size are somewhat hard to u

D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case only BasicIndexing is enabled, or when

D20456: [kio_search] Fix warning, add UDSEntry for "." in listDir

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Every KIO listDir implementation requires a UDS

D13266: Set RTL supported by default on QtQuick KCMs

davidedmundson abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D13266 To: davidedmundson, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added inline comments. INLINE COMMENTS > file.cpp:890 > +break; > +default: // case 0: > +// filename, access, type, size, linkdest This is wrong in case someone uses details > 3, should be `case 0: reserve(5)`, `case 3: default: reserve(15)` . all checks below do e.g

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think to not agonize MSVC it would be better to use the unicode code point for the QChar constructor. After that is altered I think, too, this should go in, nice! REPOSITO

D17500: Get mobipocket extractor up-to-date, but keep disabled

aacid added a comment. In D17500#447620 , @astippich wrote: > In D17500#447049 , @aacid wrote: > > > In D17500#446937 , @astippich wrote: > > > > > The

D20422: KZip: fix Heap-use-after-free in broken files

This revision was automatically updated to reflect the committed changes. Closed by commit R243:125291306243: KZip: fix Heap-use-after-free in broken files (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20422?vs=55868&id=55940 REVISION D

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 19:37:46 + Build duration: 1 hr 44 min and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/81/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 19:37:40 + Build duration: 1 hr 35 min and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/65/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 19:37:39 + Build duration: 1 hr 34 min and counting BUILD ARTIFACTS abi-co

D20435: Add go-up/down/next/previous-skip

This revision was automatically updated to reflect the committed changes. Closed by commit R266:aaa6451d308e: Add go-up/down/next/previous-skip (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20435?vs=55938&id=55939 REVISION DETAIL

D20435: Add go-up/down/next/previous-skip

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH more-go (branched from master) REVISION DETAIL https://phabricator.kde.org/D20435 To: ndavis, #vdg, #atelier, ngraham Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

ndavis updated this revision to Diff 55938. ndavis edited the summary of this revision. ndavis added a comment. - Turn window-keep-* into symlinks to go-up/down-skip REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20435?vs=55899&id=55938 BRANCH more-

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. As I understand, one can still disable the indicator if not wanted, right? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20431 To: loh.tar, cullmann, dhau

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Let's give this a try. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor, dhaumann Cc: dhaumann, cfeck, ngraham, kwr

D20425: KateIconBorder: Code cosmetic

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20425 To: loh.tar, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, szutmael, gennad, domson, michaelh, ngraham,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 83 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/83/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 19:37:18 + Build duration: 56 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 34 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/34/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 19:37:16 + Build duration: 53 min and counting BUILD ARTIFACTS abi-compatibilit

D20426: Improve "widget-alternatives" icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

GB_2 updated this revision to Diff 55933. GB_2 added a comment. Redesign icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55902&id=55933 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES icons-dark/act

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

cfeck added a comment. The proposed character is in Unicode since version 1.1 (1993). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor Cc: cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, m

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20358: Force en locale for propertyinfotest

bruns added a comment. otherwise, good to go. INLINE COMMENTS > propertyinfotest.cpp:94 > QTest::addColumn("value"); > QTest::addColumn("expected"); > QTest::addColumn("maybeLocalized"); Can you add a comment for "expected", telling the expected value uses the English/UnitedS

D20433: Use mount point returned from DBus instead of using property value

bruns added a comment. This approach is completely wrong. The right approach is to wait for the information in a PropertiesChanged signal, and only when the mountpoint has been set in the property propage the signal. This whole "our information is inconsistent, lets query for it exp

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Apr 2019 18:10:43 + Build duration: 15 min and counting BUILD ARTIFACTS acc/KF5WindowS

D20417: Add invokable public API for emitting contextualActionsAboutToShow

GB_2 added a comment. Yeah, thanks a lot! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20417 To: davidedmundson, #plasma, broulik Cc: GB_2, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 10 Apr 2019 18:10:44 + Build duration: 3 min 47 sec and counting JUnit Tests Name:

D20417: Add invokable public API for emitting contextualActionsAboutToShow

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for taking care of this REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20417 To: davidedmundson, #plasma, broulik Cc:

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela Cc: svuorela, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19445: Handle variant list in formatting functions

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 55926. astippich added a comment. - remove unrequired parenthesis REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=55326&id=55926 BRANCH generic_display_list REVISION DETAIL https://phabricator.kde.

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. In D17500#447049 , @aacid wrote: > In D17500#446937 , @astippich wrote: > > > The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and re

D20358: Force en locale for propertyinfotest

astippich added a comment. It is a documentation bug. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20424 To: nhiga, kde-frameworks-devel, ngraham Cc: ngraham, michaelh, bruns

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks very much, this is perfect. Lovely, easy-to-follow Test Plan, too. Can you please provide your full name and email address so we can land your patch with correct authorship inf

D20042: Show the plasmoid context menu on long tap

ngraham added a comment. In D20042#446976 , @apol wrote: > In D20042#446770 , @ngraham wrote: > > > That seems... quite sub-optimal to me. > > > > Is all of this to preserve press-and-hold for mo

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In D20096#446742 , @ngraham wrote: > So are we ready to land this, or is there anything left to do? Are there some more feedback ? I would appreciate a second accept. REPOSITORY R241 KIO BRANCH arcpatch-D2

D20443: Move to runtime the decision to use x11 or not

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of deciding at build time which backend to use, see which is used upon construction. This will make it possible to

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol updated this revision to Diff 55913. apol added a comment. Include keystates client side REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20191?vs=55247&id=55913 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20191 AFFECTED FILES sr

D20435: Add go-up/down/next/previous-skip

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-go (branched from master) REVISION DETAIL https://phabricator.kde.org/D20435 To: ndavis, #vdg, #atelier, ngraham Cc: abetts, ngraham, laysrodrigues, kde-frameworks-dev

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

ngraham added a comment. +1, this seems appropriate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor Cc: ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, bruns, demsking, cullmann, sars

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. Hi all, Can you check if here is anything else that needs to be changed? Thanks. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham, kde-frameworks-devel,

D19812: Add a web page to view and compare icons of different sizes

guoyunhe marked 5 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

laysrodrigues added a comment. Yes, the names are awesome! great work @ndavis ! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20435 To: ndavis, #vdg, #atelier Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20426: Improve "widget-alternatives" icon

GB_2 updated this revision to Diff 55902. GB_2 added a comment. Add 22px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55891&id=55902 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES icons-dark/

D20435: Add go-up/down/next/previous-skip

ndavis added a comment. Now I'll need to turn `window-keep-above` and `window-keep-below` into symlinks to `go-up-skip` and `go-down-skip`. `arc patch` hates it when files or symlinks are converted to each other, so I'll hold off doing that until this gets accepted. REPOSITORY R266 Breeze

D20433: Use mount point returned from DBus instead of using property value

broulik added inline comments. INLINE COMMENTS > udisksstorageaccess.cpp:35 > StorageAccess::StorageAccess(Device *device) > -: DeviceInterface(device), m_setupInProgress(false), > m_teardownInProgress(false), m_passphraseRequested(false) > +: DeviceInterface(device), m_setupInProgress(

D20435: Add go-up/down/next/previous-skip

ngraham added a reviewer: Atelier. ngraham added a comment. @laysrodrigues are these what you wanted, and are the names good? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20435 To: ndavis, #vdg, #atelier Cc: ngraham, laysrodrigues, kde-frameworks-devel, micha

D20433: Use mount point returned from DBus instead of using property value

broulik added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20435 To: ndavis, #vdg Cc: laysrodrigues, kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. ndavis added a subscriber: laysrodrigues. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20435 To: ndavis, #vdg Cc: laysrodrigues, kde-frameworks-devel, michaelh, ngraham, br

D20433: Use mount point returned from DBus instead of using property value

nicolasfella reopened this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:3ed42e887066: Use mount point returned from DBus instead of using property value (authored by nicolasfella). REPOSITOR

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

loh.tar added a comment. Diff on top of D20425 /D20431 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktex

D20435: Add go-up/down/next/previous-skip

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These are meant to be used when moving by the normal amount (go-up/down/next/previous) is t

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

loh.tar created this revision. loh.tar added reviewers: cullmann, KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The old special created pixmap is once working fine bu

D20433: Use mount point returned from DBus instead of using property value

nicolasfella created this revision. nicolasfella added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY There is a slight time frame (~2ms) where mount has returned but the

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

loh.tar added a comment. Diff on top of D20425 , not sure if depend on REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20431 To: loh.tar, cullmann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh,

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

loh.tar created this revision. loh.tar added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. TEST PLAN - Ensure you have Dnamic Word Wrap *disabled* on KWrite start-up but *Alw

D20426: Improve "widget-alternatives" icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

GB_2 updated this revision to Diff 55891. GB_2 added a comment. Use old style, better recognizable at small sizes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55889&id=55891 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20

D20426: Improve "widget-alternatives" icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Apr 2019 11:54:09 + Build duration: 15 min and counting BUILD ARTIFACTS acc/KF5Plas

D20426: Improve "widget-alternatives" icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

GB_2 updated this revision to Diff 55889. GB_2 added a comment. Improve icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55878&id=55889 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES icons-dark/acti

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/64/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 11:54:09 + Build duration: 6 min 18 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/68/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 10 Apr 2019 11:54:09 + Build duration: 2 min 19 sec and counting JUnit Tests Nam

D20428: separe mobile text selection to avoid recursive imports

This revision was automatically updated to reflect the committed changes. Closed by commit R242:58dd4c5c0f12: separe mobile text selection to avoid recursive imports (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20428?vs=55885&id=55888#toc REPOSITORY R242 Plasma Fr

D20428: separe mobile text selection to avoid recursive imports

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Works here now, thx! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20428 To: mart, #plasma, hein Cc: hein, kde-frameworks-devel,

D20428: separe mobile text selection to avoid recursive imports

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY the mobile text selection toolbar uses toolbuttons, which in turn use the private import. Th

D20233: Add syntax highlighting for fish shell

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then we keep that license and push this as is. Thanks for the contribution, btw.! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20233 To

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added inline comments. INLINE COMMENTS > pino wrote in file.cpp:850-870 > No, he means using a const& for the argument, e.g: > > inline static uint16_t stat_mode(struct statx &buf) { return buf.stx_mode; } > @pino > No, he means using a const& for the argument, e.g: I think he meant