D20417: Add invokable public API for emitting contextualActionsAboutToShow

[Björn Feber]

GB_2 added a dependent revision: D17410: Add alternatives button to applet 
configuration in panel edit mode.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20417

To: davidedmundson, #plasma, broulik
Cc: GB_2, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks

REVISION DETAIL
  https://phabricator.kde.org/D20434

To: loh.tar, cullmann, #ktexteditor, dhaumann
Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, cullmann, sars

D20169: Add profile support interface for TerminalInterface

[Kurt Hindenburg]

hindenburg added a comment.


  Can someone from the frameworks group clarify if this can be committed for 
the next release 5.58 next month?  I know years ago, we had a 
TerminalInterfaceV2 because the interface was changed.
  
  https://community.kde.org/Schedules/Frameworks

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks
Cc: michaelh, ngraham, bruns

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6ba329f8d451: KateIconBorder: Ensure Dyn Wrap Marker are 
shown (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20431?vs=55893=55957

REVISION DETAIL
  https://phabricator.kde.org/D20431

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20425: KateIconBorder: Code cosmetic

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6906368aa6b3: KateIconBorder: Code cosmetic (authored by 
loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20425?vs=55877=55956

REVISION DETAIL
  https://phabricator.kde.org/D20425

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, szutmael, gennad, domson, 
michaelh, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[N. Higa]

nhiga added a comment.


  I've just updated my KDE Identity account - my full name and email address 
can now be found by searching the username "nhiga" on KDE Identity - People 
. I'm sorry for the 
inconvenience caused.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20424

To: nhiga, kde-frameworks-devel, ngraham
Cc: ngraham, michaelh, bruns

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[loh tar]

loh.tar updated this revision to Diff 55955.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Use unicode code point QChar constructor
  - Due to comment by @cfeck remove fallback/config hint and...
  - Init in header as const
  - Add hint about different char sizes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20434?vs=55896=55955

REVISION DETAIL
  https://phabricator.kde.org/D20434

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, cullmann, #ktexteditor, dhaumann
Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, cullmann, sars

D20458: [balooctl] Use more understandable names for size in status output

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f8c51b237965: [balooctl] Use more understandable names 
for size in status output (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20458?vs=55949=55954

REVISION DETAIL
  https://phabricator.kde.org/D20458

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ceb9b3756106: [balooctl] clear command: Remove bogus 
check for documentData, cleanup (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20457?vs=55948=55953

REVISION DETAIL
  https://phabricator.kde.org/D20457

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20456: [kio_search] Fix warning, add UDSEntry for "." in listDir

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b3fac5a25041: [kio_search] Fix warning, add UDSEntry for 
.  in listDir (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20456?vs=55947=55952

REVISION DETAIL
  https://phabricator.kde.org/D20456

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20460: [balooctl] Cleanup handling of different positional arguments

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Remove the temporary Url list, and remove the disambiguities:
  
  1. An existing files named "file:..." or "inode:..." was handled as 
documentID/inode in the loop.
  2. An inode number matching an existing file name was interpreted as file 
name, even when the "-i" option was specified.
  
  Also, parsing errors of inode/documentId numbers where ignored, stating
  "No index information found" instead.
  
  Add the currently processed Url to the error messages, to make it
  more obvious which one the error refers to.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20460

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20457

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20459: [balooctl] Extend options help text, improve error checking

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The "-i" option requires a valid deviceId from the "-d" option. Error
  out early if it is missing. Also mention the fact in the help text.
  
  Extend help text for the positional arguments, the files can be specified
  as Urls, document IDs or inodes (with -i).
  
  Move parsing of the -d and -i options out of the loops.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20459

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20456: [kio_search] Fix warning, add UDSEntry for "." in listDir

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20456

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20458: [balooctl] Use more understandable names for size in status output

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Agreed.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20458

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20458: [balooctl] Use more understandable names for size in status output

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Actual and expected size are somewhat hard to understand, while
  "File Size" and "Used" are hopefully much clearer.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20458

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case only BasicIndexing is enabled, or when the content indexing
  is suspended due to "onBattery" mode, no data is added to the document.
  
  There is no reason to disallow clearing a file which has no data.
  
  Also remove an unused Indexer instance.

TEST PLAN
  create a file with contentIndexing disabled
  try to remove it from the index with `balooctl clear `

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20457

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20456: [kio_search] Fix warning, add UDSEntry for "." in listDir

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Every KIO listDir implementation requires a UDS entry for ".",
  see D20100 .

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20456

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D13266: Set RTL supported by default on QtQuick KCMs

[David Edmundson]

davidedmundson abandoned this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D13266

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> file.cpp:890
> +break;
> +default: // case 0:
> +// filename, access, type, size, linkdest

This is wrong in case someone uses details > 3, should be `case 0: reserve(5)`, 
`case 3: default: reserve(15)` .
all checks below do e.g `if (details > 2)`, so handle 5 the same as 3.

> file.cpp:939
> +#endif
> +auto bufferSize = qBound(lowerBound, size +1, higherBound);
>  QByteArray linkTargetBuffer;

missing space, `size + 1`

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think to not agonize MSVC it would be better to use the unicode code point 
for the QChar constructor.
  After that is altered I think, too, this should go in, nice!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

To: loh.tar, cullmann, #ktexteditor, dhaumann
Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, cullmann, sars

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Albert Astals Cid]

aacid added a comment.


  In D17500#447620 , @astippich 
wrote:
  
  > In D17500#447049 , @aacid wrote:
  >
  > > In D17500#446937 , @astippich 
wrote:
  > >
  > > > The plan I was about to propose is to move the thumbnailer to 
kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting 
the KIO dependency of QMobipocket. I think a KIO dependency for such a library 
is inconvenient.
  > >
  > >
  > > qmobipocket only depends on Qt::Core and Qt::Gui.
  >
  >
  > To be more precise, the thumbnailer packaged alongside qmobipocket requires 
kio
  
  
  Correct, why is that a problem?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20422: KZip: fix Heap-use-after-free in broken files

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:125291306243: KZip: fix Heap-use-after-free in broken 
files (authored by aacid).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20422?vs=55868=55940

REVISION DETAIL
  https://phabricator.kde.org/D20422

AFFECTED FILES
  src/kzip.cpp

To: aacid, apol
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/20/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Apr 2019 19:37:46 +
 Build duration:
1 hr 44 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.57.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1615/)51%
(1020/2012)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)48%
(210/434)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(561/758)63%
(532/845)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/531)34%
(177/522)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/81/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Apr 2019 19:37:40 +
 Build duration:
1 hr 35 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.propertyinfotest_enFailed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3654/4306)48%
(5083/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1263/1293)49%
(2548/5219)src79%
(22/28)79%
(22/28)79%
(1221/1543)43%
(482/1128)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/65/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Apr 2019 19:37:39 +
 Build duration:
1 hr 34 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
 

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:aaa6451d308e: Add go-up/down/next/previous-skip (authored 
by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20435?vs=55938=55939

REVISION DETAIL
  https://phabricator.kde.org/D20435

AFFECTED FILES
  icons-dark/actions/16/go-down-skip.svg
  icons-dark/actions/16/go-next-skip.svg
  icons-dark/actions/16/go-previous-skip.svg
  icons-dark/actions/16/go-up-skip.svg
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/22/go-down-skip.svg
  icons-dark/actions/22/go-next-skip.svg
  icons-dark/actions/22/go-previous-skip.svg
  icons-dark/actions/22/go-up-skip.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/32/go-down-skip.svg
  icons-dark/actions/32/go-next-skip.svg
  icons-dark/actions/32/go-previous-skip.svg
  icons-dark/actions/32/go-up-skip.svg
  icons/actions/16/go-down-skip.svg
  icons/actions/16/go-next-skip.svg
  icons/actions/16/go-previous-skip.svg
  icons/actions/16/go-up-skip.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/22/go-down-skip.svg
  icons/actions/22/go-next-skip.svg
  icons/actions/22/go-previous-skip.svg
  icons/actions/22/go-up-skip.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/32/go-down-skip.svg
  icons/actions/32/go-next-skip.svg
  icons/actions/32/go-previous-skip.svg
  icons/actions/32/go-up-skip.svg

To: ndavis, #vdg, #atelier, ngraham
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-go (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg, #atelier, ngraham
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis updated this revision to Diff 55938.
ndavis edited the summary of this revision.
ndavis added a comment.


  - Turn window-keep-* into symlinks to go-up/down-skip

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20435?vs=55899=55938

BRANCH
  more-go (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20435

AFFECTED FILES
  icons-dark/actions/16/go-down-skip.svg
  icons-dark/actions/16/go-next-skip.svg
  icons-dark/actions/16/go-previous-skip.svg
  icons-dark/actions/16/go-up-skip.svg
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/22/go-down-skip.svg
  icons-dark/actions/22/go-next-skip.svg
  icons-dark/actions/22/go-previous-skip.svg
  icons-dark/actions/22/go-up-skip.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/32/go-down-skip.svg
  icons-dark/actions/32/go-next-skip.svg
  icons-dark/actions/32/go-previous-skip.svg
  icons-dark/actions/32/go-up-skip.svg
  icons/actions/16/go-down-skip.svg
  icons/actions/16/go-next-skip.svg
  icons/actions/16/go-previous-skip.svg
  icons/actions/16/go-up-skip.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/22/go-down-skip.svg
  icons/actions/22/go-next-skip.svg
  icons/actions/22/go-previous-skip.svg
  icons/actions/22/go-up-skip.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/32/go-down-skip.svg
  icons/actions/32/go-next-skip.svg
  icons/actions/32/go-previous-skip.svg
  icons/actions/32/go-up-skip.svg

To: ndavis, #vdg, #atelier, ngraham
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  As I understand, one can still disable the indicator if not wanted, right?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20431

To: loh.tar, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Let's give this a try.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

To: loh.tar, cullmann, #ktexteditor, dhaumann
Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, cullmann, sars

D20425: KateIconBorder: Code cosmetic

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20425

To: loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, szutmael, gennad, domson, 
michaelh, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 83 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/83/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Apr 2019 19:37:18 +
 Build duration:
56 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32973/60623)39%
(17143/44478)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9315/9772)48%
(4364/9111)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8461/14443)51%
(4768/9355)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4346/8049)40%
(1920/4821)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 34 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/34/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Apr 2019 19:37:16 +
 Build duration:
53 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)84%
(69/82)84%
(69/82)75%
(6392/8539)43%
(10209/23626)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2706/2795)48%
(5825/12025)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io73%
(8/11)73%
(8/11)66%
(839/1266)35%
(956/2711)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(426/835)47%
(1017/2169)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 updated this revision to Diff 55933.
GB_2 added a comment.


  Redesign icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20426?vs=55902=55933

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20426

AFFECTED FILES
  icons-dark/actions/16/widget-alternatives.svg
  icons-dark/actions/22/widget-alternatives.svg
  icons/actions/16/widget-alternatives.svg
  icons/actions/22/widget-alternatives.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[Christoph Feck]

cfeck added a comment.


  The proposed character is in Unicode since version 1.1 (1993).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

To: loh.tar, cullmann, #ktexteditor
Cc: cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, 
domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20358: Force en locale for propertyinfotest

[Stefan Brüns]

bruns added a comment.


  otherwise, good to go.

INLINE COMMENTS

> propertyinfotest.cpp:94
>  QTest::addColumn("value");
>  QTest::addColumn("expected");
>  QTest::addColumn("maybeLocalized");

Can you add a comment for "expected", telling the expected value uses the 
English/UnitedState locale?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20358

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20433: Use mount point returned from DBus instead of using property value

[Stefan Brüns]

bruns added a comment.


  This approach is completely wrong.
  
  The right approach is to wait for the information in a PropertiesChanged 
signal, and only when the mountpoint has been set in the property propage the 
signal.
  
  This whole "our information is inconsistent, lets query for it explicitly" 
dance is a mess.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20433

To: nicolasfella, broulik, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/17/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 10 Apr 2019 18:10:43 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.57.0.xmllogs/KF5WindowSystem/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7177/9550)55%
(3538/6399)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3046/3138)53%
(1292/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3337/4664)60%
(1941/3219)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D20417: Add invokable public API for emitting contextualActionsAboutToShow

[Björn Feber]

GB_2 added a comment.


  Yeah, thanks a lot!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20417

To: davidedmundson, #plasma, broulik
Cc: GB_2, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/18/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 10 Apr 2019 18:10:44 +
 Build duration:
3 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

D20417: Add invokable public API for emitting contextualActionsAboutToShow

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks for taking care of this

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20417

To: davidedmundson, #plasma, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

[Ahmed Bilal]

ahmedbilal abandoned this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20312

To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela
Cc: svuorela, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich updated this revision to Diff 55926.
astippich added a comment.


  - remove unrequired parenthesis

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19445?vs=55326=55926

BRANCH
  generic_display_list

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  In D17500#447049 , @aacid wrote:
  
  > In D17500#446937 , @astippich 
wrote:
  >
  > > The plan I was about to propose is to move the thumbnailer to 
kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting 
the KIO dependency of QMobipocket. I think a KIO dependency for such a library 
is inconvenient.
  >
  >
  > qmobipocket only depends on Qt::Core and Qt::Gui.
  
  
  To be more precise, the thumbnailer packaged alongside qmobipocket requires 
kio

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

[Alexander Stippich]

astippich added a comment.


  It is a documentation bug.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20358

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20424

To: nhiga, kde-frameworks-devel, ngraham
Cc: ngraham, michaelh, bruns

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks very much, this is perfect. Lovely, easy-to-follow Test Plan, too.
  
  Can you please provide your full name and email address so we can land your 
patch with correct authorship information?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20424

To: nhiga, kde-frameworks-devel, ngraham
Cc: ngraham, michaelh, bruns

D20042: Show the plasmoid context menu on long tap

[Nathaniel Graham]

ngraham added a comment.


  In D20042#446976 , @apol wrote:
  
  > In D20042#446770 , @ngraham 
wrote:
  >
  > > That seems... quite sub-optimal to me.
  > >
  > > Is all of this to preserve press-and-hold for moving widgets? Is there a 
centralized place for this discussion? If not I can create a Phab task for it.
  >
  >
  > no, there isn't. If you can coordinate it through a phabricator task, I 
would really appreciate it.
  
  
  Done, see T10783: Right-click on touch .

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20042

To: apol, #plasma, #frameworks, mart
Cc: GB_2, mart, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven added a comment.


  In D20096#446742 , @ngraham wrote:
  
  > So are we ready to land this, or is there anything left to do?
  
  
  Are there some more feedback ?
  
  I would appreciate a second accept.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20443: Move to runtime the decision to use x11 or not

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of deciding at build time which backend to use, see which is
  used upon construction.
  This will make it possible to have an alternative wayland
  implementation.

TEST PLAN
  See D20442 

REPOSITORY
  R273 KGuiAddons

BRANCH
  wayland_keystate

REVISION DETAIL
  https://phabricator.kde.org/D20443

AFFECTED FILES
  src/CMakeLists.txt
  src/util/kmodifierkeyinfo.cpp
  src/util/kmodifierkeyinfoprovider.cpp
  src/util/kmodifierkeyinfoprovider_dummy.cpp
  src/util/kmodifierkeyinfoprovider_p.h
  src/util/kmodifierkeyinfoprovider_x11.cpp
  src/util/kmodifierkeyinfoprovider_xcb.cpp
  src/util/kmodifierkeyinfoprovider_xcb.h

To: apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

[Aleix Pol Gonzalez]

apol updated this revision to Diff 55913.
apol added a comment.


  Include keystates client side

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20191?vs=55247=55913

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20191

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/client/keystate.h
  src/client/protocols/keystate.xml
  src/client/registry.cpp
  src/client/registry.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/keystate_interface.cpp
  src/server/keystate_interface.h

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-go (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg, #atelier, ngraham
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[Nathaniel Graham]

ngraham added a comment.


  +1, this seems appropriate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

To: loh.tar, cullmann, #ktexteditor
Cc: ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars, dhaumann

D19812: Add a web page to view and compare icons of different sizes

[Yunhe Guo]

guoyunhe added a comment.


  Hi all,
  
  Can you check if here is anything else that needs to be changed? Thanks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

[Yunhe Guo]

guoyunhe marked 5 inline comments as done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

[Lays Rodrigues]

laysrodrigues added a comment.


  Yes, the names are awesome!
  great work @ndavis !

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg, #atelier
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 updated this revision to Diff 55902.
GB_2 added a comment.


  Add 22px version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20426?vs=55891=55902

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20426

AFFECTED FILES
  icons-dark/actions/16/widget-alternatives.svg
  icons-dark/actions/22/widget-alternatives.svg
  icons/actions/16/widget-alternatives.svg
  icons/actions/22/widget-alternatives.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis added a comment.


  Now I'll need to turn `window-keep-above` and `window-keep-below` into 
symlinks to `go-up-skip` and `go-down-skip`. `arc patch` hates it when files or 
symlinks are converted to each other, so I'll hold off doing that until this 
gets accepted.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg, #atelier
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20433: Use mount point returned from DBus instead of using property value

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> udisksstorageaccess.cpp:35
>  StorageAccess::StorageAccess(Device *device)
> -: DeviceInterface(device), m_setupInProgress(false), 
> m_teardownInProgress(false), m_passphraseRequested(false)
> +: DeviceInterface(device), m_setupInProgress(false), 
> m_teardownInProgress(false), m_passphraseRequested(false), m_mountPoint()
>  {

Initialization not needed for complex types

> udisksstorageaccess.cpp:82
>  {
> -QByteArrayList mntPoints;
> -
> -if (isLuksDevice()) {  // encrypted (and unlocked) device
> -const QString path = clearTextPath();
> -if (path.isEmpty() || path == "/") {
> -return QString();
> -}
> -Device holderDevice(path);
> -mntPoints = 
> qdbus_cast(holderDevice.prop("MountPoints"));
> +if (m_mountPoint.isEmpty()) {
> +QByteArrayList mntPoints = 
> qdbus_cast(m_device->prop("MountPoints"));

Won't this bypass the luks stuff when it is not mounted or something?
On mount you do this `holderDevice` dance but otherwise you just go straight to 
`MountPoints`

> udisksstorageaccess.cpp:151
> +if (isLuksDevice()) {
> +if(!isAccessible()) { // unlocked device, now mount it
> +mount();

Coding style: `if (!...) {`

> udisksstorageaccess.cpp:200
>  m_teardownInProgress = false;
>  m_device->invalidateCache();
>  m_device->broadcastActionDone("teardown");

Don't you need to clear the `m_mountPoint` after unmount?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20433

To: nicolasfella, broulik, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Nathaniel Graham]

ngraham added a reviewer: Atelier.
ngraham added a comment.


  @laysrodrigues are these what you wanted, and are the names good?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg, #atelier
Cc: ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20433: Use mount point returned from DBus instead of using property value

[Kai Uwe Broulik]

broulik added a reviewer: bruns.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20433

To: nicolasfella, broulik, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg
Cc: laysrodrigues, kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.
ndavis added a subscriber: laysrodrigues.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg
Cc: laysrodrigues, kde-frameworks-devel, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

[Nicolas Fella]

nicolasfella reopened this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20433

To: nicolasfella, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

[Nicolas Fella]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:3ed42e887066: Use mount point returned from DBus instead 
of using property value (authored by nicolasfella).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20433?vs=55898=55900

REVISION DETAIL
  https://phabricator.kde.org/D20433

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp
  src/solid/devices/backends/udisks2/udisksstorageaccess.h

To: nicolasfella, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[loh tar]

loh.tar added a comment.


  Diff on top of D20425 /D20431 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  These are meant to be used when moving by the normal amount 
(go-up/down/next/previous) is too slow, but skipping all the way to the end of 
something is too far (go-top/bottom/first/last).

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-go (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20435

AFFECTED FILES
  icons-dark/actions/16/go-down-skip.svg
  icons-dark/actions/16/go-next-skip.svg
  icons-dark/actions/16/go-previous-skip.svg
  icons-dark/actions/16/go-up-skip.svg
  icons-dark/actions/22/go-down-skip.svg
  icons-dark/actions/22/go-next-skip.svg
  icons-dark/actions/22/go-previous-skip.svg
  icons-dark/actions/22/go-up-skip.svg
  icons-dark/actions/32/go-down-skip.svg
  icons-dark/actions/32/go-next-skip.svg
  icons-dark/actions/32/go-previous-skip.svg
  icons-dark/actions/32/go-up-skip.svg
  icons/actions/16/go-down-skip.svg
  icons/actions/16/go-next-skip.svg
  icons/actions/16/go-previous-skip.svg
  icons/actions/16/go-up-skip.svg
  icons/actions/22/go-down-skip.svg
  icons/actions/22/go-next-skip.svg
  icons/actions/22/go-previous-skip.svg
  icons/actions/22/go-up-skip.svg
  icons/actions/32/go-down-skip.svg
  icons/actions/32/go-next-skip.svg
  icons/actions/32/go-previous-skip.svg
  icons/actions/32/go-up-skip.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: cullmann, KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  The old special created pixmap is once working fine but not so easy to 
maintain. The look however special too.
  
  The new code looks much more simpler but has the potential to fail when there 
is no such char in the desired font available.

TEST PLAN
  New look, the old you will know
  F6764371: 1554904220.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20433: Use mount point returned from DBus instead of using property value

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  There is a slight time frame (~2ms) where mount has returned but the 
MountPoints property is not updated. When the mounpoint is queried during that 
time it will be empty and opening a plugged in USB device in Dolphin will fail.
  To avoid this use the mountpoint information returned by the mount() call

REPOSITORY
  R245 Solid

BRANCH
  limux_master

REVISION DETAIL
  https://phabricator.kde.org/D20433

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp
  src/solid/devices/backends/udisks2/udisksstorageaccess.h

To: nicolasfella, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

[loh tar]

loh.tar added a comment.


  Diff on top of D20425 , not sure if 
depend on

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20431

To: loh.tar, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

TEST PLAN
  - Ensure you have Dnamic Word Wrap *disabled* on KWrite start-up but *Always 
ON* to show wrap indicators; Config->Appearance->General
  - Start KWrite, enter long enough lines
  - Hit F10 to enable Dnamic Word Wrap
  - Lines should now be wrapped and wrap indicators shown, at least with this 
patch

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20431

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 updated this revision to Diff 55891.
GB_2 added a comment.


  Use old style, better recognizable at small sizes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20426?vs=55889=55891

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20426

AFFECTED FILES
  icons-dark/actions/16/widget-alternatives.svg
  icons/actions/16/widget-alternatives.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/58/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 10 Apr 2019 11:54:09 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13367)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/1022)tests.dpi0%
   

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 updated this revision to Diff 55889.
GB_2 added a comment.


  Improve icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20426?vs=55878=55889

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20426

AFFECTED FILES
  icons-dark/actions/16/widget-alternatives.svg
  icons/actions/16/widget-alternatives.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/64/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 10 Apr 2019 11:54:09 +
 Build duration:
6 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/68/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 10 Apr 2019 11:54:09 +
 Build duration:
2 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20428: separe mobile text selection to avoid recursive imports

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:58dd4c5c0f12: separe mobile text selection to avoid 
recursive imports (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20428?vs=55885=55888#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20428?vs=55885=55888

REVISION DETAIL
  https://phabricator.kde.org/D20428

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/mobiletextselection/MobileCursor.qml
  
src/declarativeimports/plasmacomponents3/mobiletextselection/MobileTextActionsToolBar.qml
  src/declarativeimports/plasmacomponents3/mobiletextselection/qmldir
  src/declarativeimports/plasmacomponents3/private/MobileCursor.qml
  src/declarativeimports/plasmacomponents3/private/MobileTextActionsToolBar.qml
  src/declarativeimports/plasmacomponents3/private/qmldir

To: mart, #plasma, hein
Cc: hein, kde-frameworks-devel, michaelh, ngraham, bruns

D20428: separe mobile text selection to avoid recursive imports

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Works here now, thx!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20428

To: mart, #plasma, hein
Cc: hein, kde-frameworks-devel, michaelh, ngraham, bruns

D20428: separe mobile text selection to avoid recursive imports

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  the mobile text selection toolbar uses toolbuttons, which in turn use the 
  private import. This will make the components loading stuck in dependency 
  resolution

TEST PLAN
  all loads correctly now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20428

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/mobiletextselection/MobileCursor.qml
  
src/declarativeimports/plasmacomponents3/mobiletextselection/MobileTextActionsToolBar.qml
  src/declarativeimports/plasmacomponents3/mobiletextselection/qmldir
  src/declarativeimports/plasmacomponents3/private/MobileCursor.qml
  src/declarativeimports/plasmacomponents3/private/MobileTextActionsToolBar.qml
  src/declarativeimports/plasmacomponents3/private/qmldir

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20233: Add syntax highlighting for fish shell

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, then we keep that license and push this as is.
  
  Thanks for the contribution, btw.!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D20233

To: adiestelhorst, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> pino wrote in file.cpp:850-870
> No, he means using a const& for the argument, e.g:
> 
>   inline static uint16_t stat_mode(struct statx ) { return buf.stx_mode; }

> @pino 
>  No, he means using a const& for the argument, e.g:

I think he meant both.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added inline comments.

INLINE COMMENTS

> dfaure wrote in urlinfo.h:77
> But then you can't do `kde-open5 www.google.fr` anymore, right?
> 
> I see what you mean with typo handling, but there is no perfect solution. 
> Either we treat typos as URLs (but it means we also treat actual URLs as 
> such), or we treat everything non-existing as a local file (breaking any use 
> of short URLs). The latter is OK for kwrite, but not for the more general 
> purpose kioclient / kde-open5.

> But then you can't do kde-open5 www.google.fr anymore, right?

Ah, right. Ok, then.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd updated this revision to Diff 55879.
arrowd marked 5 inline comments as done.
arrowd added a comment.


  Address comments.

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18296?vs=54774=55879

BRANCH
  cursor

REVISION DETAIL
  https://phabricator.kde.org/D18296

AFFECTED FILES
  kioclient/kioclient.cpp
  kioclient/kioclient.h
  kioclient/urlinfo.h

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20367: Add alternatives icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20367

To: GB_2, #vdg, ngraham
Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20367

To: GB_2, #vdg, ngraham
Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20367

To: GB_2, #vdg, ngraham
Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

[Björn Feber]

GB_2 added a comment.


  I made a revision to improve it here: D20426 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20367

To: GB_2, #vdg, ngraham
Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

TEST PLAN
  Open Cuttlefish and search for `widget-alternatives`.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20426

AFFECTED FILES
  icons-dark/actions/16/widget-alternatives.svg
  icons/actions/16/widget-alternatives.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns