D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

shubham edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20691 To: shubham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

shubham created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY BUG: 405554 REPOSITORY R245 Solid BRANCH error REVISION DETAIL https://phabricator.kde.org/D20691 AFFECTED FIL

D20672: Add an icon for Thunderbolt KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R266:a6a153629ecc: Add an icon for Thunderbolt KCM (authored by yurchor). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20672?vs=56598&id=56599 REVISION DETAIL

D13358: Add new class that is a model of numbers between two values

vkrause added a comment. ping? this is needed for scratch/davidedmundson/kirigami-addons REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D13358 To: davidedmundson, vkrause Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns

D20672: Add an icon for Thunderbolt KCM

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg, ndavis, ngraham Cc: abetts, ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

yurchor added a comment. In D20672#453068 , @abetts wrote: > Sorry for coming this late into the conversation. I was wondering if the spear in the bolt can be changed to be horizontal? It would be more visually consistent with the angle that the

D20672: Add an icon for Thunderbolt KCM

abetts added a comment. Sorry for coming this late into the conversation. I was wondering if the spear in the bolt can be changed to be horizontal? It would be more visually consistent with the angle that the lightning bold is. The back of the arrow |>, that needs to be horizontal. REPOSITO

D20672: Add an icon for Thunderbolt KCM

yurchor updated this revision to Diff 56598. yurchor added a comment. Use plain SVG REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20672?vs=56590&id=56598 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 AFFECTED FILES icons-da

D20672: Add an icon for Thunderbolt KCM

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Actually, one last thing. Can you save it as a plain SVG so that it isn't filled with Inkscape metadata? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.

D20672: Add an icon for Thunderbolt KCM

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I like the new top color. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg, ndavis, ngraham Cc: ndavis, GB_2, filipf,

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

ngraham added a comment. I've been told that @bruns can review this sometime next week. :) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

ngraham accepted this revision as: ngraham. ngraham added a comment. Wow, that's quite beautiful. Thumbs up from me now! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg, ndavis, ngraham Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-de

D20672: Add an icon for Thunderbolt KCM

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg, ndavis Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

yurchor updated this revision to Diff 56590. yurchor added a comment. 1. Fix diameter. 2. Add copy for dark. 3. Use non-transparent gradient. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20672?vs=56576&id=56590 BRANCH master REVISION DETAIL

D20606: Add action to toggle folding of child ranges

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given we have no actions and some more proper documentation, I am in favor of this. I would remove the two asserts here: Q_ASSERT(startLine >= 0); Q_ASSERT(startLine < l

D20565: Ensure not to fold the end marker

cullmann accepted this revision. cullmann added a comment. You can submit that, perhaps with the discussed checks, thanks And happy Easter ;=) REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel, kde-frameworks-devel,

D20672: Add an icon for Thunderbolt KCM

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. A few problems: 1. That circle has a diameter of 27.9px instead of 28px 2. There is no copy of the icon in `icons-dark/preferences/32/` 3. The top of the gradient is transp

D20626: Refactor and cleanup

pino added a comment. Also, please explicitly mention what are the changes done. "refactor and cleanup" is very vague, while saying that, for example, QSysInfo is used on all the OSes is better. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure

D20626: Refactor and cleanup

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Refactor and cleanup

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven added a comment. See comments in https://bugs.kde.org/show_bug.cgi?id=406242 for whole context REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven added a comment. Friendly ping REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns