D20938: Add Mounts Backend

hallas added a comment. I have tried to modify the fstab backend to also show fuse mounts and a //very// simple prototype is this: diff --git a/src/solid/devices/backends/fstab/fstabhandling.cpp b/src/solid/devices/backends/fstab/fstabhandling.cpp index 63130c6..3632b52 100644

D20983: Exclude .gcode and .vdi files from indexing consideration

ngraham created this revision. ngraham added reviewers: bruns, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY gcode files are the CNC machine/3D printer equivalent of build files and c

D20963: Code cosmetic

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d572d3276358: Code cosmetic (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20963?vs=57380&id=57428 REVISION DETAIL https://phabricator.kd

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH same-button-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D20977 To: filipf, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngra

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: VDG, ngraham, Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20977 To: filipf, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel, michae

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY Because the shortcut button has text inside it, its height is increased, which leaves the clear button shorter. We want t

D20959: Allow to change the Mode, after changing the Highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sounds reasonable. REPOSITORY R39 KTextEditor BRANCH fix-mode-highlight-menu REVISION DETAIL https://phabricator.kde.org/D20959 To: nibags, #ktexteditor, #kate, cullmann Cc: cul

D20958: New menu of syntax highlighting in the status bar

cullmann added a comment. As first feedback: much better than current state :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg Cc: cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns,

D20963: Code cosmetic

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20963 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktextedit

D20958: New menu of syntax highlighting in the status bar

ngraham added a comment. In D20958#459676 , @loh.tar wrote: > - The blue frame (in dark theme) looks compared to the other plain menus slightly strange, any possibility to remove this? This's a generic issue with the selection border bein

D20735: [KPropertiesDialog] Add octal permissions

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. The permission changes to ktelnetservice5.desktop are unrelated, please revert them. Mostly important, the value shown in the advanced permissions dialog is not taking into accou

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added inline comments. INLINE COMMENTS > apol wrote in kfilewidget.cpp:745 > Isn't it a bit weird to do this in setMimeFilter? I did it in `setMimeFilter` since that's where it's determined whether or not there's a limited assortment of mimetypes, which is what controls what the string

D17302: Add test for adding properties to result

astippich added a comment. ping REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20958: New menu of syntax highlighting in the status bar

loh.tar added a comment. > When the menu is opened, clear any text in the search field left over from a prior search For my taste would that the usability only worsen, this way may not be usual but works charming. Perhaps may a change to select the field in that case a possibility

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added inline comments. INLINE COMMENTS > kfilewidget.cpp:745 > + > +if (d->operationMode == Saving) { > +d->filterLabel->setText(i18n("&File type:")); Isn't it a bit weird to do this in setMimeFilter? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20964

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

leinir added inline comments. INLINE COMMENTS > ngraham wrote in GridDelegate.qml:147 > This was a deliberate choice, to make sure that the delegate got selected > when one of its buttons got clicked. But yeah selected may not necessarily > require clicked, so maybe it wasn't the best way of do

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/92/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 May 2019 18:29:48 + Build duration: 6 min 53 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 02 May 2019 18:29:48 + Build duration: 2 min 38 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/91/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 02 May 2019 18:29:48 + Build duration: 1 min 31 sec and counting JUnit Tests Name:

D20942: Reorder includes

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7be7da0ee6f9: Reorder includes (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20942?vs=57337&id=57391 REVISION DETAIL https://phabr

D20967: [UserMetaData] Add method to query which attributes are set

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Many files have no UserMetaData attributes set at all, o

D20958: New menu of syntax highlighting in the status bar

ngraham added a comment. OMG so much better! Adding a search field is a godsend. I have a few UI comments: - When the menu is opened, clear any text in the search field left over from a prior search - Single-clicking on an item in the list should select it and close the menu; doub

D20938: Add Mounts Backend

hallas added a comment. In D20938#459628 , @bruns wrote: > In D20938#459627 , @hallas wrote: > > > In D20938#459218 , @bruns wrote: > > > > > Solid alre

D20938: Add Mounts Backend

bruns added a comment. In D20938#459627 , @hallas wrote: > In D20938#459218 , @bruns wrote: > > > Solid already has a working implementation for reading from /proc/mounts, the fstab backend. > >

D20938: Add Mounts Backend

hallas added a comment. In D20938#459218 , @bruns wrote: > Solid already has a working implementation for reading from /proc/mounts, the fstab backend. > > Contrary to this code, the fstab backend does not poll every second using a timer, bu

D20938: Add Mounts Backend

hallas added a comment. In D20938#459149 , @ivan wrote: > I'm torn between two approaches: > > - doing what you have done, maybe with a customization point - `fusermount -u` by default, something else for specific mount types; > - disabling

D20958: New menu of syntax highlighting in the status bar

ngraham added a reviewer: VDG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg Cc: loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20955: use actually existing breeze icon for the new file Program.desktop

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D20955 To: sitter, #vdg, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added inline comments. INLINE COMMENTS > leinir wrote in GridDelegate.qml:147 > Just came across having both a function called on clicking the thumbnail > (using the onClicked handler) and on actions being triggered, and both now > get triggered at the same time. Was this a deliberate c

D20958: New menu of syntax highlighting in the status bar

loh.tar added a comment. Wow, look very nice :-) The only thing I would like to have is an auto generated "most often used" list. That was also suggested somewhere. This way you could quickly change between preferred styles instead to search for them. Your code looks lovely and well do

D20934: Rename file dialog "Filter" label text to "Type"

ngraham added a comment. Submitted a patch that does that: D20964 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20934 To: GB_2, #frameworks, #plasma, #vdg, elvisangelaccio Cc: ngraham, elvisangelaccio, #vdg, #plasma, kde-frameworks-

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham abandoned this revision. ngraham added a comment. Superseded by D20964 , which is the correct change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, abetts Cc: kde-frame

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham created this revision. ngraham added reviewers: VDG, elvisangelaccio, GB_2. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The Filter combobox currently always has the label "Filter:" This i

D20963: Code cosmetic

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Sort and group lines in the hope it's cause no hassle but looks

D20924: ViewConfig: Use new generic config interface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:743cbe13fda0: ViewConfig: Use new generic config interface (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57354&id=57378 REVISION

D20961: [KJS] Allow calling function from KJSObject by adding a call function to its api

ahmadosama edited the summary of this revision. ahmadosama added a subscriber: aacid. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D20961 To: ahmadosama Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20961: [KJS] Allow calling function from KJSObject by adding a call function to its api

ahmadosama updated this revision to Diff 57376. ahmadosama added a comment. - Passing default empty paramters to the call function REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20961?vs=57375&id=57376 BRANCH add_call_to_kjobject_api (branched from master)

D20961: [KJS] Allow calling function from KJSObject by adding a call function to its api

ahmadosama added a comment. @apol I updated the the description of the patch now, sorry about that. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D20961 To: ahmadosama Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20961: [KJS] Allow calling function from KJSObject by adding a call function to its api

ahmadosama retitled this revision from "[KJS] Allow calling function from KJObject by adding a call function to its api" to "[KJS] Allow calling function from KJSObject by adding a call function to its api". ahmadosama edited the summary of this revision. REPOSITORY R314 KJs REVISION DETAIL

D20961: [KJS] Allow calling function from KJObject by adding a call function to its api

apol added a comment. What are you using KJs for that needs such changes? INLINE COMMENTS > kjsobject.cpp:225 > + > +KJS::List args = List(); > +foreach(KJSObject arg, arguments) Just `KJS::List args;` > kjsobject.h:149 > + */ > + KJSObject call(KJSContext *ctx, const QList

D20961: [KJS] Allow calling function from KJObject by adding a call function to its api

ahmadosama retitled this revision from "Allow calling function from KJObject by adding a call function to its api" to "[KJS] Allow calling function from KJObject by adding a call function to its api". REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D20961 To: ahmadosama Cc:

D20961: Allow calling function from KJObject by adding a call function to its api

ahmadosama created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadosama requested review of this revision. REPOSITORY R314 KJs BRANCH add_call_to_kjobject_api (branched from master) REVISION DETAIL https://phabricator.kde.org/D20961

D20959: Allow to change the Mode, after changing the Highlighting

nibags created this revision. nibags added reviewers: KTextEditor, Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Currently, when selecting a language in the "Highlighting" me

D20958: New menu of syntax highlighting in the status bar

nibags edited the summary of this revision. nibags added reviewers: KTextEditor, Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann,

D20924: ViewConfig: Use new generic config interface

cullmann accepted this revision. cullmann added a comment. I think this look OK. Can't verify every replacement is correct, but let's have that in now. Thanks for that massive amount of work ;=) REVISION DETAIL https://phabricator.kde.org/D20924 To: loh.tar, #ktexteditor, dhaumann, cull

D20958: New menu of syntax highlighting in the status bar

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL https://phabricator.kde.org/D20958 AFFECTED FILES

D20955: use actually existing breeze icon for the new file Program.desktop

sitter edited the summary of this revision. sitter added reviewers: VDG, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20955 To: sitter, #vdg, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20940: [baloo_file] Wait for extractor process to start

bruns added a comment. You better had fixed the commit message ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20940 To: nicolasfella, #baloo, bruns Cc: bruns, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abraha

D20940: [baloo_file] Wait for extractor process to start

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1841ea1d311: [baloo_file] Wait for extractor process to start (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20940?vs=57365&id=57367 REV

D20955: use actually existing breeze icon for the new file Program.desktop

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Icon entry in there was a legacy name that no longer exists. this resulted in the default new program having no/brok

D20940: [baloo_file] Wait for extractor process to start

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH waitForStart REVISION DETAIL https://phabricator.kde.org/D20940 To: nicolasfella, #baloo, bruns Cc: bruns, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, asti

D20940: [baloo_file] Wait for extractor process to start

nicolasfella updated this revision to Diff 57365. nicolasfella added a comment. - Remove assert REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20940?vs=57324&id=57365 BRANCH waitForStart REVISION DETAIL https://phabricator.kde.org/D20940 AFFECTED FILES

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kwayland.git/commit/?id=3ef09f3e0c4d20cd9da482107bb3402c40e47c6a REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20628 To: broulik, #kwin, zzag Cc: zzag, davidedmundson, kde-frameworks-deve

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

leinir added inline comments. INLINE COMMENTS > GridDelegate.qml:147 > +onClicked: { > +delegate.clicked() > +modelData.trigger() Just came across having both a function called on clicking the thumbnail (

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/91/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 May 2019 08:16:32 + Build duration: 15 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 02 May 2019 08:13:48 + Build duration: 14 min and counting BUILD ARTIFACTS acc/KF5Wayland-5.58

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 02 May 2019 08:13:47 + Build duration: 12 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/94/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 02 May 2019 08:16:33 + Build duration: 8 min 13 sec and counting JUnit Tests Nam

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 02 May 2019 08:16:33 + Build duration: 3 min 32 sec and counting BUILD ARTIFACTS acc/K

D20630: [Dialog] Add CriticalNotification type

This revision was automatically updated to reflect the committed changes. Closed by commit R242:91024027b09b: [Dialog] Add CriticalNotification type (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20630?vs=56425&id=5736

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 02 May 2019 08:08:58 + Build duration: 6 min 30 sec and counting BUILD ARTIFACTS acc/KF5W

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 02 May 2019 08:12:58 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 02 May 2019 08:08:58 + Build duration: 3 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 May 2019 08:08:58 + Build duration: 3 min 15 sec and counting BUILD ARTIFACTS acc/KF5Wi

D20627: Introduce CriticalNotificationType

This revision was automatically updated to reflect the committed changes. Closed by commit R278:dff8842bfaac: Introduce CriticalNotificationType (authored by broulik). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20627?vs=56418&id=57359 REVISION DETAI